121933 2013-09-25 18:07:59 -0700 Do not reenter Document from its destructor 2013-09-25 20:06:12 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin commit-queue esprehn+autocc glenn kangil.han macpherson menard oldest_to_newest 933297 0 benjamin 2013-09-25 18:07:59 -0700 Do not reenter Document from its destructor 933300 1 212648 benjamin 2013-09-25 18:15:07 -0700 Created attachment 212648 Patch 933314 2 212648 darin 2013-09-25 18:56:37 -0700 Comment on attachment 212648 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=212648&action=review No regression test? > Source/WebCore/css/CSSStyleSheet.h:114 > + void detachFromDocument() { m_ownerNode = 0; } nullptr > Source/WebCore/dom/DocumentStyleSheetCollection.cpp:505 > } > > + > +void DocumentStyleSheetCollection::detachFromDocument() Looks like there is an extra blank line here. 933332 3 benjamin 2013-09-25 20:06:12 -0700 Committed r156444: <http://trac.webkit.org/changeset/156444> 212648 2013-09-25 18:15:07 -0700 2013-09-25 18:56:37 -0700 Patch bug-121933-20130925181507.patch text/plain 5773 benjamin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1NjQ0MCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDM1IEBACisyMDEzLTA5LTI1ICBCZW5qYW1p biBQb3VsYWluICA8YmVuamFtaW5Ad2Via2l0Lm9yZz4KKworICAgICAgICBEbyBub3QgcmVlbnRl ciBEb2N1bWVudCBmcm9tIGl0cyBkZXN0cnVjdG9yCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjE5MzMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBGb2xsb3dpbmcgcjE1NjQyMiwgdGhlcmUgYXJlIGNhc2Vz IHdoZXJlIHdlIHdvdWxkIHJlZW50ZXIgRG9jdW1lbnQKKyAgICAgICAgZHVyaW5nIGl0cyBkZXN0 cnVjdGlvbi4KKworICAgICAgICBUaGUgZmxvdyB3YXMgdGhlIGZvbGxvd2luZzoKKyAgICAgICAg LURvY3VtZW50J3MgZGVzdHJ1Y3RvciBpcyBleGVjdXRlZC4KKyAgICAgICAgLURvY3VtZW50U3R5 bGVTaGVldENvbGxlY3Rpb24gYmVpbmcgcGFydCBvZiBEb2N1bWVudCwgaXRzIGRlc3RydWN0b3IK KyAgICAgICAgIGlzIGV4ZWN1dGVkLgorICAgICAgICAtRG9jdW1lbnRTdHlsZVNoZWV0Q29sbGVj dGlvbidzIGRlc3RydWN0b3IgZGV0YWNoIHRoZSBvd25lciBub2RlIG9mIGFsbAorICAgICAgICAg aXRzIHN0eWxlc2hlZXRzIGF2b2lkIGtlZXBpbmcgc3RhbGUgcmVmZXJlbmNlcyB0byBhIGRlYWQg RG9jdW1lbnQuCisgICAgICAgIC1DU1NTdHlsZVNoZWV0OjpjbGVhck93bmVyTm9kZSgpIHdvdWxk IGZldGNoIHRoZSBkeWluZyBkb2N1bWVudAorICAgICAgICAgYW5kIGludm9rZSBEb2N1bWVudDo6 c3R5bGVSZXNvbHZlckNoYW5nZWQoKS4KKyAgICAgICAgVGhpcyB3b3VsZCBub3QgZmFpbCBiZWNh dXNlIHRoZSBkb2N1bWVudCBpcyBkZXRhY2hlZCBhbmQgRG9jdW1lbnQ6OnN0eWxlUmVzb2x2ZXJD aGFuZ2VkKCkKKyAgICAgICAgd291bGQgZmFpbCBlYXJseS4gVGhpcyBpcyBjb21wbGljYXRlZCBh bmQgZXJyb3IgcHJvbmUgc28gdGhpcyBwYXRjaCBhdHRlbXB0IHRvIGNsZWFyCisgICAgICAgIHRo ZSBwcm9jZXNzIGEgYml0LgorCisgICAgICAgIFdpdGggdGhlIHBhdGNoLCBEb2N1bWVudCBkZXRh Y2ggYWxsIHRoZSBzdHlsZXNoZWV0cyBlYXJseSBpbiB0aGUgZGVzdHJ1Y3Rpb24uCisgICAgICAg IENsZWFyaW5nIHRoZSBzdHlsZXNoZWV0IGlzIGFsc28gY2hhbmdlZCB0byBhdm9pZCByZS1lbnRl cmluZyB0aGUgZG9jdW1lbnQuCisKKyAgICAgICAgKiBjc3MvQ1NTU3R5bGVTaGVldC5oOgorICAg ICAgICAqIGRvbS9Eb2N1bWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpEb2N1bWVudDo6fkRv Y3VtZW50KToKKyAgICAgICAgKiBkb20vRG9jdW1lbnRTdHlsZVNoZWV0Q29sbGVjdGlvbi5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpEb2N1bWVudFN0eWxlU2hlZXRDb2xsZWN0aW9uOjpkZXRhY2hG cm9tRG9jdW1lbnQpOgorICAgICAgICAqIGRvbS9Eb2N1bWVudFN0eWxlU2hlZXRDb2xsZWN0aW9u Lmg6CisKIDIwMTMtMDktMjUgIENvbW1pdCBRdWV1ZSAgPGNvbW1pdC1xdWV1ZUB3ZWJraXQub3Jn PgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIxNTY0MzIuCkluZGV4OiBTb3Vy Y2UvV2ViQ29yZS9jc3MvQ1NTU3R5bGVTaGVldC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJD b3JlL2Nzcy9DU1NTdHlsZVNoZWV0LmgJKHJldmlzaW9uIDE1NjQzNSkKKysrIFNvdXJjZS9XZWJD b3JlL2Nzcy9DU1NTdHlsZVNoZWV0LmgJKHdvcmtpbmcgY29weSkKQEAgLTExMSw2ICsxMTEsOCBA QCBwdWJsaWM6CiAKICAgICBTdHlsZVNoZWV0Q29udGVudHMqIGNvbnRlbnRzKCkgY29uc3QgeyBy ZXR1cm4gbV9jb250ZW50cy5nZXQoKTsgfQogCisgICAgdm9pZCBkZXRhY2hGcm9tRG9jdW1lbnQo KSB7IG1fb3duZXJOb2RlID0gMDsgfQorCiBwcml2YXRlOgogICAgIENTU1N0eWxlU2hlZXQoUGFz c1JlZlB0cjxTdHlsZVNoZWV0Q29udGVudHM+LCBDU1NJbXBvcnRSdWxlKiBvd25lclJ1bGUpOwog ICAgIENTU1N0eWxlU2hlZXQoUGFzc1JlZlB0cjxTdHlsZVNoZWV0Q29udGVudHM+LCBOb2RlKiBv d25lck5vZGUsIGJvb2wgaXNJbmxpbmVTdHlsZXNoZWV0KTsKSW5kZXg6IFNvdXJjZS9XZWJDb3Jl L2RvbS9Eb2N1bWVudC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvZG9tL0RvY3Vt ZW50LmNwcAkocmV2aXNpb24gMTU2NDM1KQorKysgU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50 LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNjAzLDcgKzYwMyw4IEBAIERvY3VtZW50Ojp+RG9jdW1l bnQoKQogICAgICAgICBtX3N0eWxlU2hlZXRMaXN0LT5kZXRhY2hGcm9tRG9jdW1lbnQoKTsKIAog ICAgIGlmIChtX2VsZW1lbnRTaGVldCkKLSAgICAgICAgbV9lbGVtZW50U2hlZXQtPmNsZWFyT3du ZXJOb2RlKCk7CisgICAgICAgIG1fZWxlbWVudFNoZWV0LT5kZXRhY2hGcm9tRG9jdW1lbnQoKTsK KyAgICBtX3N0eWxlU2hlZXRDb2xsZWN0aW9uLmRldGFjaEZyb21Eb2N1bWVudCgpOwogCiAgICAg Y2xlYXJTdHlsZVJlc29sdmVyKCk7IC8vIFdlIG5lZWQgdG8gZGVzdHJveSBDU1NGb250U2VsZWN0 b3IgYmVmb3JlIGRlc3Ryb3lpbmcgbV9jYWNoZWRSZXNvdXJjZUxvYWRlci4KIApJbmRleDogU291 cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50U3R5bGVTaGVldENvbGxlY3Rpb24uY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudFN0eWxlU2hlZXRDb2xsZWN0aW9uLmNw cAkocmV2aXNpb24gMTU2NDM1KQorKysgU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50U3R5bGVT aGVldENvbGxlY3Rpb24uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC02OCwyMCArNjgsNiBAQCBEb2N1 bWVudFN0eWxlU2hlZXRDb2xsZWN0aW9uOjpEb2N1bWVudFN0CiB7CiB9CiAKLURvY3VtZW50U3R5 bGVTaGVldENvbGxlY3Rpb246On5Eb2N1bWVudFN0eWxlU2hlZXRDb2xsZWN0aW9uKCkKLXsKLSAg ICBpZiAobV9wYWdlVXNlclNoZWV0KQotICAgICAgICBtX3BhZ2VVc2VyU2hlZXQtPmNsZWFyT3du ZXJOb2RlKCk7Ci0gICAgZm9yICh1bnNpZ25lZCBpID0gMDsgaSA8IG1faW5qZWN0ZWRVc2VyU3R5 bGVTaGVldHMuc2l6ZSgpOyArK2kpCi0gICAgICAgIG1faW5qZWN0ZWRVc2VyU3R5bGVTaGVldHNb aV0tPmNsZWFyT3duZXJOb2RlKCk7Ci0gICAgZm9yICh1bnNpZ25lZCBpID0gMDsgaSA8IG1faW5q ZWN0ZWRBdXRob3JTdHlsZVNoZWV0cy5zaXplKCk7ICsraSkKLSAgICAgICAgbV9pbmplY3RlZEF1 dGhvclN0eWxlU2hlZXRzW2ldLT5jbGVhck93bmVyTm9kZSgpOwotICAgIGZvciAodW5zaWduZWQg aSA9IDA7IGkgPCBtX3VzZXJTdHlsZVNoZWV0cy5zaXplKCk7ICsraSkKLSAgICAgICAgbV91c2Vy U3R5bGVTaGVldHNbaV0tPmNsZWFyT3duZXJOb2RlKCk7Ci0gICAgZm9yICh1bnNpZ25lZCBpID0g MDsgaSA8IG1fYXV0aG9yU3R5bGVTaGVldHMuc2l6ZSgpOyArK2kpCi0gICAgICAgIG1fYXV0aG9y U3R5bGVTaGVldHNbaV0tPmNsZWFyT3duZXJOb2RlKCk7Ci19Ci0KIHZvaWQgRG9jdW1lbnRTdHls ZVNoZWV0Q29sbGVjdGlvbjo6Y29tYmluZUNTU0ZlYXR1cmVGbGFncygpCiB7CiAgICAgLy8gRGVs YXkgcmVzZXR0aW5nIHRoZSBmbGFncyB1bnRpbCBhZnRlciBuZXh0IHN0eWxlIHJlY2FsYyBzaW5j ZSB1bmFwcGx5aW5nIHRoZSBzdHlsZSBtYXkgbm90IHdvcmsgd2l0aG91dCB0aGVzZSBzZXQgKHRo aXMgaXMgdHJ1ZSBhdCBsZWFzdCB3aXRoIGJlZm9yZS9hZnRlcikuCkBAIC01MTUsNCArNTAxLDE5 IEBAIGJvb2wgRG9jdW1lbnRTdHlsZVNoZWV0Q29sbGVjdGlvbjo6YWN0aXYKICAgICByZXR1cm4g bV93ZWFrQ29weU9mQWN0aXZlU3R5bGVTaGVldExpc3RGb3JGYXN0TG9va3VwLT5jb250YWlucyhz aGVldCk7CiB9CiAKKwordm9pZCBEb2N1bWVudFN0eWxlU2hlZXRDb2xsZWN0aW9uOjpkZXRhY2hG cm9tRG9jdW1lbnQoKQoreworICAgIGlmIChtX3BhZ2VVc2VyU2hlZXQpCisgICAgICAgIG1fcGFn ZVVzZXJTaGVldC0+ZGV0YWNoRnJvbURvY3VtZW50KCk7CisgICAgZm9yICh1bnNpZ25lZCBpID0g MDsgaSA8IG1faW5qZWN0ZWRVc2VyU3R5bGVTaGVldHMuc2l6ZSgpOyArK2kpCisgICAgICAgIG1f aW5qZWN0ZWRVc2VyU3R5bGVTaGVldHNbaV0tPmRldGFjaEZyb21Eb2N1bWVudCgpOworICAgIGZv ciAodW5zaWduZWQgaSA9IDA7IGkgPCBtX2luamVjdGVkQXV0aG9yU3R5bGVTaGVldHMuc2l6ZSgp OyArK2kpCisgICAgICAgIG1faW5qZWN0ZWRBdXRob3JTdHlsZVNoZWV0c1tpXS0+ZGV0YWNoRnJv bURvY3VtZW50KCk7CisgICAgZm9yICh1bnNpZ25lZCBpID0gMDsgaSA8IG1fdXNlclN0eWxlU2hl ZXRzLnNpemUoKTsgKytpKQorICAgICAgICBtX3VzZXJTdHlsZVNoZWV0c1tpXS0+ZGV0YWNoRnJv bURvY3VtZW50KCk7CisgICAgZm9yICh1bnNpZ25lZCBpID0gMDsgaSA8IG1fYXV0aG9yU3R5bGVT aGVldHMuc2l6ZSgpOyArK2kpCisgICAgICAgIG1fYXV0aG9yU3R5bGVTaGVldHNbaV0tPmRldGFj aEZyb21Eb2N1bWVudCgpOworfQorCiB9CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1l bnRTdHlsZVNoZWV0Q29sbGVjdGlvbi5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2Rv bS9Eb2N1bWVudFN0eWxlU2hlZXRDb2xsZWN0aW9uLmgJKHJldmlzaW9uIDE1NjQzNSkKKysrIFNv dXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudFN0eWxlU2hlZXRDb2xsZWN0aW9uLmgJKHdvcmtpbmcg Y29weSkKQEAgLTQ4LDggKzQ4LDYgQEAgY2xhc3MgRG9jdW1lbnRTdHlsZVNoZWV0Q29sbGVjdGlv biB7CiBwdWJsaWM6CiAgICAgZXhwbGljaXQgRG9jdW1lbnRTdHlsZVNoZWV0Q29sbGVjdGlvbihE b2N1bWVudCYpOwogCi0gICAgfkRvY3VtZW50U3R5bGVTaGVldENvbGxlY3Rpb24oKTsKLQogICAg IGNvbnN0IFZlY3RvcjxSZWZQdHI8U3R5bGVTaGVldD4+JiBzdHlsZVNoZWV0c0ZvclN0eWxlU2hl ZXRMaXN0KCkgY29uc3QgeyByZXR1cm4gbV9zdHlsZVNoZWV0c0ZvclN0eWxlU2hlZXRMaXN0OyB9 CiAKICAgICBjb25zdCBWZWN0b3I8UmVmUHRyPENTU1N0eWxlU2hlZXQ+PiYgYWN0aXZlQXV0aG9y U3R5bGVTaGVldHMoKSBjb25zdCB7IHJldHVybiBtX2FjdGl2ZUF1dGhvclN0eWxlU2hlZXRzOyB9 CkBAIC0xMTcsNiArMTE1LDggQEAgcHVibGljOgogCiAgICAgYm9vbCBhY3RpdmVTdHlsZVNoZWV0 c0NvbnRhaW5zKGNvbnN0IENTU1N0eWxlU2hlZXQqKSBjb25zdDsKIAorICAgIHZvaWQgZGV0YWNo RnJvbURvY3VtZW50KCk7CisKIHByaXZhdGU6CiAgICAgdm9pZCBjb2xsZWN0QWN0aXZlU3R5bGVT aGVldHMoVmVjdG9yPFJlZlB0cjxTdHlsZVNoZWV0PiA+Jik7CiAgICAgZW51bSBTdHlsZVJlc29s dmVyVXBkYXRlVHlwZSB7Cg==