<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>121910</bug_id>
          
          <creation_ts>2013-09-25 09:02:44 -0700</creation_ts>
          <short_desc>[WK2] Crash at at com.apple.WebKit2: WebKit::VoidCallback::invalidate + 46</short_desc>
          <delta_ts>2013-09-26 11:12:22 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Jer Noble">jer.noble</reporter>
          <assigned_to name="Jer Noble">jer.noble</assigned_to>
          <cc>buildbot</cc>
    
    <cc>darin</cc>
    
    <cc>rniwa</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>933033</commentid>
    <comment_count>0</comment_count>
    <who name="Jer Noble">jer.noble</who>
    <bug_when>2013-09-25 09:02:44 -0700</bug_when>
    <thetext>[WK2] Crash at at com.apple.WebKit2: WebKit::VoidCallback::invalidate + 46</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>933035</commentid>
    <comment_count>1</comment_count>
      <attachid>212585</attachid>
    <who name="Jer Noble">jer.noble</who>
    <bug_when>2013-09-25 09:07:45 -0700</bug_when>
    <thetext>Created attachment 212585
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>933036</commentid>
    <comment_count>2</comment_count>
    <who name="Jer Noble">jer.noble</who>
    <bug_when>2013-09-25 09:08:20 -0700</bug_when>
    <thetext>&lt;rdar://problem/13389393&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>933040</commentid>
    <comment_count>3</comment_count>
      <attachid>212585</attachid>
    <who name="Build Bot">buildbot</who>
    <bug_when>2013-09-25 09:25:08 -0700</bug_when>
    <thetext>Comment on attachment 212585
Patch

Attachment 212585 did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/2181004</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>933053</commentid>
    <comment_count>4</comment_count>
      <attachid>212585</attachid>
    <who name="Build Bot">buildbot</who>
    <bug_when>2013-09-25 09:47:13 -0700</bug_when>
    <thetext>Comment on attachment 212585
Patch

Attachment 212585 did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/2166250</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>933075</commentid>
    <comment_count>5</comment_count>
      <attachid>212599</attachid>
    <who name="Jer Noble">jer.noble</who>
    <bug_when>2013-09-25 10:38:19 -0700</bug_when>
    <thetext>Created attachment 212599
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>933100</commentid>
    <comment_count>6</comment_count>
      <attachid>212599</attachid>
    <who name="Build Bot">buildbot</who>
    <bug_when>2013-09-25 11:04:11 -0700</bug_when>
    <thetext>Comment on attachment 212599
Patch

Attachment 212599 did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/2266057</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>933123</commentid>
    <comment_count>7</comment_count>
      <attachid>212599</attachid>
    <who name="Build Bot">buildbot</who>
    <bug_when>2013-09-25 11:22:37 -0700</bug_when>
    <thetext>Comment on attachment 212599
Patch

Attachment 212599 did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/2281054</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>933246</commentid>
    <comment_count>8</comment_count>
      <attachid>212635</attachid>
    <who name="Jer Noble">jer.noble</who>
    <bug_when>2013-09-25 16:22:40 -0700</bug_when>
    <thetext>Created attachment 212635
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>933313</commentid>
    <comment_count>9</comment_count>
      <attachid>212635</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2013-09-25 18:53:27 -0700</bug_when>
    <thetext>Comment on attachment 212635
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=212635&amp;action=review

I would say review+ except for the confusing assertions.

&gt; Source/WebKit2/ChangeLog:10
&gt; +        Store a copy of the VoidCallback passed to WKPage, and cancel the callback
&gt; +        during dealloc by changing it&apos;s context to 0. This requires a small change
&gt; +        to CallbackBase to add the ability to change the context post-creation.

You changed the patch to use invalidate, so the comment about CallbackBase is no longer correct.

&gt; Source/WebKit2/ChangeLog:13
&gt; +        * UIProcess/GenericCallback.h:
&gt; +        (WebKit::CallbackBase::setContext): Added; simple setter.

This change is not in the patch.

&gt; Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm:115
&gt; +    ASSERT(!_repaintCallback);

This is really confusing. How does calling invalidate on the callback cause it to become a nullptr?

&gt; Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm:409
&gt; +    ASSERT(!_repaintCallback);

This is really confusing. How does calling invalidate on the callback cause it to become a nullptr?

&gt; Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm:416
&gt; +    _repaintCallback = 0;

We like nullptr for this in newer code.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>933358</commentid>
    <comment_count>10</comment_count>
    <who name="Jer Noble">jer.noble</who>
    <bug_when>2013-09-25 21:57:09 -0700</bug_when>
    <thetext>(In reply to comment #9)
&gt; (From update of attachment 212635 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=212635&amp;action=review
&gt; 
&gt; I would say review+ except for the confusing assertions.
&gt; 
&gt; &gt; Source/WebKit2/ChangeLog:10
&gt; &gt; +        Store a copy of the VoidCallback passed to WKPage, and cancel the callback
&gt; &gt; +        during dealloc by changing it&apos;s context to 0. This requires a small change
&gt; &gt; +        to CallbackBase to add the ability to change the context post-creation.
&gt; 
&gt; You changed the patch to use invalidate, so the comment about CallbackBase is no longer correct.

Whoops; i&apos;ll update the ChangeLog.

&gt; &gt; Source/WebKit2/ChangeLog:13
&gt; &gt; +        * UIProcess/GenericCallback.h:
&gt; &gt; +        (WebKit::CallbackBase::setContext): Added; simple setter.
&gt; 
&gt; This change is not in the patch.

And here as well.

&gt; &gt; Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm:115
&gt; &gt; +    ASSERT(!_repaintCallback);
&gt; 
&gt; This is really confusing. How does calling invalidate on the callback cause it to become a nullptr?

When you call VoidCallback::invalidate(), it immediately calls the callback method with an error parameter.  The callback method will clear the _repaintCallback.

&gt; &gt; Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm:409
&gt; &gt; +    ASSERT(!_repaintCallback);
&gt; 
&gt; This is really confusing. How does calling invalidate on the callback cause it to become a nullptr?

Ditto.

&gt; &gt; Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm:416
&gt; &gt; +    _repaintCallback = 0;
&gt; 
&gt; We like nullptr for this in newer code.

Will change.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>933368</commentid>
    <comment_count>11</comment_count>
      <attachid>212667</attachid>
    <who name="Jer Noble">jer.noble</who>
    <bug_when>2013-09-25 22:28:03 -0700</bug_when>
    <thetext>Created attachment 212667
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>933604</commentid>
    <comment_count>12</comment_count>
    <who name="Jer Noble">jer.noble</who>
    <bug_when>2013-09-26 11:12:22 -0700</bug_when>
    <thetext>Committed r156479: &lt;http://trac.webkit.org/changeset/156479&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>212585</attachid>
            <date>2013-09-25 09:07:45 -0700</date>
            <delta_ts>2013-09-25 10:38:17 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-121910-20130925090744.patch</filename>
            <type>text/plain</type>
            <size>4082</size>
            <attacher name="Jer Noble">jer.noble</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTU2MDUyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNjJiZDQ2MWJhOTlmZDgw
ZmZjZmE5ZmVlZTI2MjQ5OWY1MjJhMjQ3Mi4uYWYyZjBmNGE0NGRkMjk4NTZlZGU0N2YzODZhMDVj
MGQ0MmRhZGM3YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEzLTA5LTI1ICBKZXIg
Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCisgICAgICAgIFtXSzJdIENyYXNoIGF0IGF0
IGNvbS5hcHBsZS5XZWJLaXQyOiBXZWJLaXQ6OlZvaWRDYWxsYmFjazo6aW52YWxpZGF0ZSArIDQ2
CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjE5MTAK
KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTdG9yZSBh
IGNvcHkgb2YgdGhlIFZvaWRDYWxsYmFjayBwYXNzZWQgdG8gV0tQYWdlLCBhbmQgY2FuY2VsIHRo
ZSBjYWxsYmFjaworICAgICAgICBkdXJpbmcgZGVhbGxvYyBieSBjaGFuZ2luZyBpdCdzIGNvbnRl
eHQgdG8gMC4gVGhpcyByZXF1aXJlcyBhIHNtYWxsIGNoYW5nZQorICAgICAgICB0byBDYWxsYmFj
a0Jhc2UgdG8gYWRkIHRoZSBhYmlsaXR5IHRvIGNoYW5nZSB0aGUgY29udGV4dCBwb3N0LWNyZWF0
aW9uLgorCisgICAgICAgICogVUlQcm9jZXNzL0dlbmVyaWNDYWxsYmFjay5oOgorICAgICAgICAo
V2ViS2l0OjpDYWxsYmFja0Jhc2U6OnNldENvbnRleHQpOiBBZGRlZDsgc2ltcGxlIHNldHRlci4K
KyAgICAgICAgKiBVSVByb2Nlc3MvbWFjL1dLRnVsbFNjcmVlbldpbmRvd0NvbnRyb2xsZXIuaDoK
KyAgICAgICAgKiBVSVByb2Nlc3MvbWFjL1dLRnVsbFNjcmVlbldpbmRvd0NvbnRyb2xsZXIubW06
CisgICAgICAgICgtW1dLRnVsbFNjcmVlbldpbmRvd0NvbnRyb2xsZXIgZGVhbGxvY10pOiBDbGVh
ciB0aGUgY2FsbGJhY2tzIGNvbnRleHQsIGlmIHByZXNlbnQuCisgICAgICAgICgtW1dLRnVsbFNj
cmVlbldpbmRvd0NvbnRyb2xsZXIgZmluaXNoZWRFeGl0RnVsbFNjcmVlbkFuaW1hdGlvbjpdKTog
RGl0dG8uIENyZWF0ZSBhIG5ldyBjYWxsYmFjay4KKyAgICAgICAgKC1bV0tGdWxsU2NyZWVuV2lu
ZG93Q29udHJvbGxlciBjb21wbGV0ZUZpbmlzaEV4aXRGdWxsU2NyZWVuQW5pbWF0aW9uQWZ0ZXJS
ZXBhaW50XSk6IENsZWFyIHRoZSBjYWxsYmFjay4KKwogMjAxMy0wOS0wNiAgSmVyIE5vYmxlICA8
amVyLm5vYmxlQGFwcGxlLmNvbT4KIAogICAgICAgICBbTWFjXSBJbXBsZW1lbnQgdGhlIG1lZGlh
IGNvbnRyb2xzIGluIEphdmFTY3JpcHQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVBy
b2Nlc3MvR2VuZXJpY0NhbGxiYWNrLmggYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvR2VuZXJp
Y0NhbGxiYWNrLmgKaW5kZXggY2RhMDIwZmQwMTIxY2EyMGRkNTRlZWU3NGI4MDU1YjM5NjFiNGJk
NC4uY2NhYzJmMWI3MmViMTQxM2UwZGI4YjI5YWExMmU3Zjc5YmQxNDViZSAxMDA2NDQKLS0tIGEv
U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0dlbmVyaWNDYWxsYmFjay5oCisrKyBiL1NvdXJjZS9X
ZWJLaXQyL1VJUHJvY2Vzcy9HZW5lcmljQ2FsbGJhY2suaApAQCAtNTAsNiArNTAsNyBAQCBwcm90
ZWN0ZWQ6CiAgICAgewogICAgIH0KIAorICAgIHZvaWQgc2V0Q29udGV4dCh2b2lkKiBjb250ZXh0
KSB7IG1fY29udGV4dCA9IGNvbnRleHQ7IH0KICAgICB2b2lkKiBjb250ZXh0KCkgY29uc3QgeyBy
ZXR1cm4gbV9jb250ZXh0OyB9CiAKIHByaXZhdGU6CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0
Mi9VSVByb2Nlc3MvbWFjL1dLRnVsbFNjcmVlbldpbmRvd0NvbnRyb2xsZXIuaCBiL1NvdXJjZS9X
ZWJLaXQyL1VJUHJvY2Vzcy9tYWMvV0tGdWxsU2NyZWVuV2luZG93Q29udHJvbGxlci5oCmluZGV4
IGM4Yjg2ZDRlZjdiODAwMjMzY2MyZTFlMmM5NWJkYWExNTk2MDQ2YzcuLjRmZmI3ZThhZDk4MGY1
MTA4NGQ4Y2Y5M2Y1M2ZkY2Q1OTc3ODQ1MWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJ
UHJvY2Vzcy9tYWMvV0tGdWxsU2NyZWVuV2luZG93Q29udHJvbGxlci5oCisrKyBiL1NvdXJjZS9X
ZWJLaXQyL1VJUHJvY2Vzcy9tYWMvV0tGdWxsU2NyZWVuV2luZG93Q29udHJvbGxlci5oCkBAIC0z
MCw2ICszMCw3IEBACiAKIG5hbWVzcGFjZSBXZWJLaXQgeyAKIGNsYXNzIExheWVyVHJlZUNvbnRl
eHQ7CitjbGFzcyBWb2lkQ2FsbGJhY2s7CiB9CiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKQEAgLTU4
LDYgKzU5LDcgQEAgdHlwZWRlZiBlbnVtIEZ1bGxTY3JlZW5TdGF0ZSA6IE5TSW50ZWdlciBGdWxs
U2NyZWVuU3RhdGU7CiAgICAgRnVsbFNjcmVlblN0YXRlIF9mdWxsU2NyZWVuU3RhdGU7CiAKICAg
ICBkb3VibGUgX3NhdmVkU2NhbGU7CisgICAgUmVmUHRyPFZvaWRDYWxsYmFjaz4gX3JlcGFpbnRD
YWxsYmFjazsKIH0KIAogLSAoaWQpaW5pdFdpdGhXaW5kb3c6KE5TV2luZG93ICopd2luZG93IHdl
YlZpZXc6KFdLVmlldyAqKXdlYlZpZXc7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVBy
b2Nlc3MvbWFjL1dLRnVsbFNjcmVlbldpbmRvd0NvbnRyb2xsZXIubW0gYi9Tb3VyY2UvV2ViS2l0
Mi9VSVByb2Nlc3MvbWFjL1dLRnVsbFNjcmVlbldpbmRvd0NvbnRyb2xsZXIubW0KaW5kZXggZTRl
NzBjOTdjMjk4ZjgxZjkxMjJiODRjMWUwMWU2Y2IxOTFhOGRiMS4uY2U5YTIxMjA2Y2EwYTA4NmM2
OGE0NGRhMzgxOWY3YzkxYjU1Yjc3YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9j
ZXNzL21hYy9XS0Z1bGxTY3JlZW5XaW5kb3dDb250cm9sbGVyLm1tCisrKyBiL1NvdXJjZS9XZWJL
aXQyL1VJUHJvY2Vzcy9tYWMvV0tGdWxsU2NyZWVuV2luZG93Q29udHJvbGxlci5tbQpAQCAtMTA5
LDYgKzEwOSwxMCBAQCBzdGF0aWMgTlNSZWN0IGNvbnZlcnRSZWN0VG9TY3JlZW4oTlNXaW5kb3cg
KndpbmRvdywgTlNSZWN0IHJlY3QpCiAgICAgW05TT2JqZWN0IGNhbmNlbFByZXZpb3VzUGVyZm9y
bVJlcXVlc3RzV2l0aFRhcmdldDpzZWxmXTsKICAgICAKICAgICBbW05TTm90aWZpY2F0aW9uQ2Vu
dGVyIGRlZmF1bHRDZW50ZXJdIHJlbW92ZU9ic2VydmVyOnNlbGZdOworCisgICAgaWYgKF9yZXBh
aW50Q2FsbGJhY2spCisgICAgICAgIF9yZXBhaW50Q2FsbGJhY2stPnNldENvbnRleHQoMCk7CisK
ICAgICBbc3VwZXIgZGVhbGxvY107CiB9CiAKQEAgLTM5OCwxMSArNDAyLDE2IEBAIHN0YXRpYyB2
b2lkIGNvbXBsZXRlRmluaXNoRXhpdEZ1bGxTY3JlZW5BbmltYXRpb25BZnRlclJlcGFpbnQoV0tF
cnJvclJlZiwgdm9pZCopCiAgICAgW3NlbGYgX21hbmFnZXJdLT5zZXRBbmltYXRpbmdGdWxsU2Ny
ZWVuKGZhbHNlKTsKICAgICBbc2VsZiBfcGFnZV0tPnNjYWxlUGFnZShfc2F2ZWRTY2FsZSwgSW50
UG9pbnQoKSk7CiAgICAgW3NlbGYgX21hbmFnZXJdLT5yZXN0b3JlU2Nyb2xsUG9zaXRpb24oKTsK
LSAgICBbc2VsZiBfcGFnZV0tPmZvcmNlUmVwYWludChWb2lkQ2FsbGJhY2s6OmNyZWF0ZShzZWxm
LCBjb21wbGV0ZUZpbmlzaEV4aXRGdWxsU2NyZWVuQW5pbWF0aW9uQWZ0ZXJSZXBhaW50KSk7CisK
KyAgICBpZiAoX3JlcGFpbnRDYWxsYmFjaykKKyAgICAgICAgX3JlcGFpbnRDYWxsYmFjay0+c2V0
Q29udGV4dCgwKTsKKyAgICBfcmVwYWludENhbGxiYWNrID0gVm9pZENhbGxiYWNrOjpjcmVhdGUo
c2VsZiwgY29tcGxldGVGaW5pc2hFeGl0RnVsbFNjcmVlbkFuaW1hdGlvbkFmdGVyUmVwYWludCk7
CisgICAgW3NlbGYgX3BhZ2VdLT5mb3JjZVJlcGFpbnQoX3JlcGFpbnRDYWxsYmFjayk7CiB9CiAK
IC0gKHZvaWQpY29tcGxldGVGaW5pc2hFeGl0RnVsbFNjcmVlbkFuaW1hdGlvbkFmdGVyUmVwYWlu
dAogeworICAgIF9yZXBhaW50Q2FsbGJhY2sgPSAwOwogICAgIFtbX3dlYlZpZXcgd2luZG93XSBz
ZXRBdXRvZGlzcGxheTpZRVNdOwogICAgIFtbX3dlYlZpZXcgd2luZG93XSBkaXNwbGF5SWZOZWVk
ZWRdOwogICAgIE5TRW5hYmxlU2NyZWVuVXBkYXRlcygpOwo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>212599</attachid>
            <date>2013-09-25 10:38:19 -0700</date>
            <delta_ts>2013-09-25 16:22:38 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-121910-20130925103817.patch</filename>
            <type>text/plain</type>
            <size>4090</size>
            <attacher name="Jer Noble">jer.noble</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTU2MDUyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNjJiZDQ2MWJhOTlmZDgw
ZmZjZmE5ZmVlZTI2MjQ5OWY1MjJhMjQ3Mi4uYWYyZjBmNGE0NGRkMjk4NTZlZGU0N2YzODZhMDVj
MGQ0MmRhZGM3YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEzLTA5LTI1ICBKZXIg
Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCisgICAgICAgIFtXSzJdIENyYXNoIGF0IGF0
IGNvbS5hcHBsZS5XZWJLaXQyOiBXZWJLaXQ6OlZvaWRDYWxsYmFjazo6aW52YWxpZGF0ZSArIDQ2
CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjE5MTAK
KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTdG9yZSBh
IGNvcHkgb2YgdGhlIFZvaWRDYWxsYmFjayBwYXNzZWQgdG8gV0tQYWdlLCBhbmQgY2FuY2VsIHRo
ZSBjYWxsYmFjaworICAgICAgICBkdXJpbmcgZGVhbGxvYyBieSBjaGFuZ2luZyBpdCdzIGNvbnRl
eHQgdG8gMC4gVGhpcyByZXF1aXJlcyBhIHNtYWxsIGNoYW5nZQorICAgICAgICB0byBDYWxsYmFj
a0Jhc2UgdG8gYWRkIHRoZSBhYmlsaXR5IHRvIGNoYW5nZSB0aGUgY29udGV4dCBwb3N0LWNyZWF0
aW9uLgorCisgICAgICAgICogVUlQcm9jZXNzL0dlbmVyaWNDYWxsYmFjay5oOgorICAgICAgICAo
V2ViS2l0OjpDYWxsYmFja0Jhc2U6OnNldENvbnRleHQpOiBBZGRlZDsgc2ltcGxlIHNldHRlci4K
KyAgICAgICAgKiBVSVByb2Nlc3MvbWFjL1dLRnVsbFNjcmVlbldpbmRvd0NvbnRyb2xsZXIuaDoK
KyAgICAgICAgKiBVSVByb2Nlc3MvbWFjL1dLRnVsbFNjcmVlbldpbmRvd0NvbnRyb2xsZXIubW06
CisgICAgICAgICgtW1dLRnVsbFNjcmVlbldpbmRvd0NvbnRyb2xsZXIgZGVhbGxvY10pOiBDbGVh
ciB0aGUgY2FsbGJhY2tzIGNvbnRleHQsIGlmIHByZXNlbnQuCisgICAgICAgICgtW1dLRnVsbFNj
cmVlbldpbmRvd0NvbnRyb2xsZXIgZmluaXNoZWRFeGl0RnVsbFNjcmVlbkFuaW1hdGlvbjpdKTog
RGl0dG8uIENyZWF0ZSBhIG5ldyBjYWxsYmFjay4KKyAgICAgICAgKC1bV0tGdWxsU2NyZWVuV2lu
ZG93Q29udHJvbGxlciBjb21wbGV0ZUZpbmlzaEV4aXRGdWxsU2NyZWVuQW5pbWF0aW9uQWZ0ZXJS
ZXBhaW50XSk6IENsZWFyIHRoZSBjYWxsYmFjay4KKwogMjAxMy0wOS0wNiAgSmVyIE5vYmxlICA8
amVyLm5vYmxlQGFwcGxlLmNvbT4KIAogICAgICAgICBbTWFjXSBJbXBsZW1lbnQgdGhlIG1lZGlh
IGNvbnRyb2xzIGluIEphdmFTY3JpcHQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVBy
b2Nlc3MvR2VuZXJpY0NhbGxiYWNrLmggYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvR2VuZXJp
Y0NhbGxiYWNrLmgKaW5kZXggY2RhMDIwZmQwMTIxY2EyMGRkNTRlZWU3NGI4MDU1YjM5NjFiNGJk
NC4uY2NhYzJmMWI3MmViMTQxM2UwZGI4YjI5YWExMmU3Zjc5YmQxNDViZSAxMDA2NDQKLS0tIGEv
U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0dlbmVyaWNDYWxsYmFjay5oCisrKyBiL1NvdXJjZS9X
ZWJLaXQyL1VJUHJvY2Vzcy9HZW5lcmljQ2FsbGJhY2suaApAQCAtNTAsNiArNTAsNyBAQCBwcm90
ZWN0ZWQ6CiAgICAgewogICAgIH0KIAorICAgIHZvaWQgc2V0Q29udGV4dCh2b2lkKiBjb250ZXh0
KSB7IG1fY29udGV4dCA9IGNvbnRleHQ7IH0KICAgICB2b2lkKiBjb250ZXh0KCkgY29uc3QgeyBy
ZXR1cm4gbV9jb250ZXh0OyB9CiAKIHByaXZhdGU6CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0
Mi9VSVByb2Nlc3MvbWFjL1dLRnVsbFNjcmVlbldpbmRvd0NvbnRyb2xsZXIuaCBiL1NvdXJjZS9X
ZWJLaXQyL1VJUHJvY2Vzcy9tYWMvV0tGdWxsU2NyZWVuV2luZG93Q29udHJvbGxlci5oCmluZGV4
IGM4Yjg2ZDRlZjdiODAwMjMzY2MyZTFlMmM5NWJkYWExNTk2MDQ2YzcuLmYyMzExYzFkM2NhODll
MzcyZWViNzEwNjkyZjM2ZjgxM2Q4ZWY3YWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJ
UHJvY2Vzcy9tYWMvV0tGdWxsU2NyZWVuV2luZG93Q29udHJvbGxlci5oCisrKyBiL1NvdXJjZS9X
ZWJLaXQyL1VJUHJvY2Vzcy9tYWMvV0tGdWxsU2NyZWVuV2luZG93Q29udHJvbGxlci5oCkBAIC0z
MCw2ICszMCw3IEBACiAKIG5hbWVzcGFjZSBXZWJLaXQgeyAKIGNsYXNzIExheWVyVHJlZUNvbnRl
eHQ7CitjbGFzcyBWb2lkQ2FsbGJhY2s7CiB9CiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKQEAgLTU4
LDYgKzU5LDcgQEAgdHlwZWRlZiBlbnVtIEZ1bGxTY3JlZW5TdGF0ZSA6IE5TSW50ZWdlciBGdWxs
U2NyZWVuU3RhdGU7CiAgICAgRnVsbFNjcmVlblN0YXRlIF9mdWxsU2NyZWVuU3RhdGU7CiAKICAg
ICBkb3VibGUgX3NhdmVkU2NhbGU7CisgICAgUmVmUHRyPFdlYktpdDo6Vm9pZENhbGxiYWNrPiBf
cmVwYWludENhbGxiYWNrOwogfQogCiAtIChpZClpbml0V2l0aFdpbmRvdzooTlNXaW5kb3cgKil3
aW5kb3cgd2ViVmlldzooV0tWaWV3ICopd2ViVmlldzsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL
aXQyL1VJUHJvY2Vzcy9tYWMvV0tGdWxsU2NyZWVuV2luZG93Q29udHJvbGxlci5tbSBiL1NvdXJj
ZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvV0tGdWxsU2NyZWVuV2luZG93Q29udHJvbGxlci5tbQpp
bmRleCBlNGU3MGM5N2MyOThmODFmOTEyMmI4NGMxZTAxZTZjYjE5MWE4ZGIxLi5jZTlhMjEyMDZj
YTBhMDg2YzY4YTQ0ZGEzODE5ZjdjOTFiNTViNzdiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0
Mi9VSVByb2Nlc3MvbWFjL1dLRnVsbFNjcmVlbldpbmRvd0NvbnRyb2xsZXIubW0KKysrIGIvU291
cmNlL1dlYktpdDIvVUlQcm9jZXNzL21hYy9XS0Z1bGxTY3JlZW5XaW5kb3dDb250cm9sbGVyLm1t
CkBAIC0xMDksNiArMTA5LDEwIEBAIHN0YXRpYyBOU1JlY3QgY29udmVydFJlY3RUb1NjcmVlbihO
U1dpbmRvdyAqd2luZG93LCBOU1JlY3QgcmVjdCkKICAgICBbTlNPYmplY3QgY2FuY2VsUHJldmlv
dXNQZXJmb3JtUmVxdWVzdHNXaXRoVGFyZ2V0OnNlbGZdOwogICAgIAogICAgIFtbTlNOb3RpZmlj
YXRpb25DZW50ZXIgZGVmYXVsdENlbnRlcl0gcmVtb3ZlT2JzZXJ2ZXI6c2VsZl07CisKKyAgICBp
ZiAoX3JlcGFpbnRDYWxsYmFjaykKKyAgICAgICAgX3JlcGFpbnRDYWxsYmFjay0+c2V0Q29udGV4
dCgwKTsKKwogICAgIFtzdXBlciBkZWFsbG9jXTsKIH0KIApAQCAtMzk4LDExICs0MDIsMTYgQEAg
c3RhdGljIHZvaWQgY29tcGxldGVGaW5pc2hFeGl0RnVsbFNjcmVlbkFuaW1hdGlvbkFmdGVyUmVw
YWludChXS0Vycm9yUmVmLCB2b2lkKikKICAgICBbc2VsZiBfbWFuYWdlcl0tPnNldEFuaW1hdGlu
Z0Z1bGxTY3JlZW4oZmFsc2UpOwogICAgIFtzZWxmIF9wYWdlXS0+c2NhbGVQYWdlKF9zYXZlZFNj
YWxlLCBJbnRQb2ludCgpKTsKICAgICBbc2VsZiBfbWFuYWdlcl0tPnJlc3RvcmVTY3JvbGxQb3Np
dGlvbigpOwotICAgIFtzZWxmIF9wYWdlXS0+Zm9yY2VSZXBhaW50KFZvaWRDYWxsYmFjazo6Y3Jl
YXRlKHNlbGYsIGNvbXBsZXRlRmluaXNoRXhpdEZ1bGxTY3JlZW5BbmltYXRpb25BZnRlclJlcGFp
bnQpKTsKKworICAgIGlmIChfcmVwYWludENhbGxiYWNrKQorICAgICAgICBfcmVwYWludENhbGxi
YWNrLT5zZXRDb250ZXh0KDApOworICAgIF9yZXBhaW50Q2FsbGJhY2sgPSBWb2lkQ2FsbGJhY2s6
OmNyZWF0ZShzZWxmLCBjb21wbGV0ZUZpbmlzaEV4aXRGdWxsU2NyZWVuQW5pbWF0aW9uQWZ0ZXJS
ZXBhaW50KTsKKyAgICBbc2VsZiBfcGFnZV0tPmZvcmNlUmVwYWludChfcmVwYWludENhbGxiYWNr
KTsKIH0KIAogLSAodm9pZCljb21wbGV0ZUZpbmlzaEV4aXRGdWxsU2NyZWVuQW5pbWF0aW9uQWZ0
ZXJSZXBhaW50CiB7CisgICAgX3JlcGFpbnRDYWxsYmFjayA9IDA7CiAgICAgW1tfd2ViVmlldyB3
aW5kb3ddIHNldEF1dG9kaXNwbGF5OllFU107CiAgICAgW1tfd2ViVmlldyB3aW5kb3ddIGRpc3Bs
YXlJZk5lZWRlZF07CiAgICAgTlNFbmFibGVTY3JlZW5VcGRhdGVzKCk7Cg==
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>212635</attachid>
            <date>2013-09-25 16:22:40 -0700</date>
            <delta_ts>2013-09-25 22:28:00 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-121910-20130925162239.patch</filename>
            <type>text/plain</type>
            <size>3690</size>
            <attacher name="Jer Noble">jer.noble</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTU2NDIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYjQ1YTBiNGMwZTJjN2Jj
ZmUzNjA4ODU3ZTJmNWNlOTUxOTUxZTU5OC4uOGFmMjY0ZmRjNWU5NWY2YzRjMjJjMTNhOTk5NTEy
NTkyZWMyYjNjNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEzLTA5LTI1ICBKZXIg
Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCisgICAgICAgIFtXSzJdIENyYXNoIGF0IGF0
IGNvbS5hcHBsZS5XZWJLaXQyOiBXZWJLaXQ6OlZvaWRDYWxsYmFjazo6aW52YWxpZGF0ZSArIDQ2
CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjE5MTAK
KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTdG9yZSBh
IGNvcHkgb2YgdGhlIFZvaWRDYWxsYmFjayBwYXNzZWQgdG8gV0tQYWdlLCBhbmQgY2FuY2VsIHRo
ZSBjYWxsYmFjaworICAgICAgICBkdXJpbmcgZGVhbGxvYyBieSBjaGFuZ2luZyBpdCdzIGNvbnRl
eHQgdG8gMC4gVGhpcyByZXF1aXJlcyBhIHNtYWxsIGNoYW5nZQorICAgICAgICB0byBDYWxsYmFj
a0Jhc2UgdG8gYWRkIHRoZSBhYmlsaXR5IHRvIGNoYW5nZSB0aGUgY29udGV4dCBwb3N0LWNyZWF0
aW9uLgorCisgICAgICAgICogVUlQcm9jZXNzL0dlbmVyaWNDYWxsYmFjay5oOgorICAgICAgICAo
V2ViS2l0OjpDYWxsYmFja0Jhc2U6OnNldENvbnRleHQpOiBBZGRlZDsgc2ltcGxlIHNldHRlci4K
KyAgICAgICAgKiBVSVByb2Nlc3MvbWFjL1dLRnVsbFNjcmVlbldpbmRvd0NvbnRyb2xsZXIuaDoK
KyAgICAgICAgKiBVSVByb2Nlc3MvbWFjL1dLRnVsbFNjcmVlbldpbmRvd0NvbnRyb2xsZXIubW06
CisgICAgICAgICgtW1dLRnVsbFNjcmVlbldpbmRvd0NvbnRyb2xsZXIgZGVhbGxvY10pOiBDbGVh
ciB0aGUgY2FsbGJhY2tzIGNvbnRleHQsIGlmIHByZXNlbnQuCisgICAgICAgICgtW1dLRnVsbFNj
cmVlbldpbmRvd0NvbnRyb2xsZXIgZmluaXNoZWRFeGl0RnVsbFNjcmVlbkFuaW1hdGlvbjpdKTog
RGl0dG8uIENyZWF0ZSBhIG5ldyBjYWxsYmFjay4KKyAgICAgICAgKC1bV0tGdWxsU2NyZWVuV2lu
ZG93Q29udHJvbGxlciBjb21wbGV0ZUZpbmlzaEV4aXRGdWxsU2NyZWVuQW5pbWF0aW9uQWZ0ZXJS
ZXBhaW50XSk6IENsZWFyIHRoZSBjYWxsYmFjay4KKwogMjAxMy0wOS0wNiAgSmVyIE5vYmxlICA8
amVyLm5vYmxlQGFwcGxlLmNvbT4KIAogICAgICAgICBbTWFjXSBJbXBsZW1lbnQgdGhlIG1lZGlh
IGNvbnRyb2xzIGluIEphdmFTY3JpcHQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVBy
b2Nlc3MvbWFjL1dLRnVsbFNjcmVlbldpbmRvd0NvbnRyb2xsZXIuaCBiL1NvdXJjZS9XZWJLaXQy
L1VJUHJvY2Vzcy9tYWMvV0tGdWxsU2NyZWVuV2luZG93Q29udHJvbGxlci5oCmluZGV4IGM4Yjg2
ZDRlZjdiODAwMjMzY2MyZTFlMmM5NWJkYWExNTk2MDQ2YzcuLmYyMzExYzFkM2NhODllMzcyZWVi
NzEwNjkyZjM2ZjgxM2Q4ZWY3YWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz
cy9tYWMvV0tGdWxsU2NyZWVuV2luZG93Q29udHJvbGxlci5oCisrKyBiL1NvdXJjZS9XZWJLaXQy
L1VJUHJvY2Vzcy9tYWMvV0tGdWxsU2NyZWVuV2luZG93Q29udHJvbGxlci5oCkBAIC0zMCw2ICsz
MCw3IEBACiAKIG5hbWVzcGFjZSBXZWJLaXQgeyAKIGNsYXNzIExheWVyVHJlZUNvbnRleHQ7Citj
bGFzcyBWb2lkQ2FsbGJhY2s7CiB9CiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKQEAgLTU4LDYgKzU5
LDcgQEAgdHlwZWRlZiBlbnVtIEZ1bGxTY3JlZW5TdGF0ZSA6IE5TSW50ZWdlciBGdWxsU2NyZWVu
U3RhdGU7CiAgICAgRnVsbFNjcmVlblN0YXRlIF9mdWxsU2NyZWVuU3RhdGU7CiAKICAgICBkb3Vi
bGUgX3NhdmVkU2NhbGU7CisgICAgUmVmUHRyPFdlYktpdDo6Vm9pZENhbGxiYWNrPiBfcmVwYWlu
dENhbGxiYWNrOwogfQogCiAtIChpZClpbml0V2l0aFdpbmRvdzooTlNXaW5kb3cgKil3aW5kb3cg
d2ViVmlldzooV0tWaWV3ICopd2ViVmlldzsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJ
UHJvY2Vzcy9tYWMvV0tGdWxsU2NyZWVuV2luZG93Q29udHJvbGxlci5tbSBiL1NvdXJjZS9XZWJL
aXQyL1VJUHJvY2Vzcy9tYWMvV0tGdWxsU2NyZWVuV2luZG93Q29udHJvbGxlci5tbQppbmRleCBl
NGU3MGM5N2MyOThmODFmOTEyMmI4NGMxZTAxZTZjYjE5MWE4ZGIxLi4wYzM0Yjk3M2QyNjY1NzU0
MzFmN2E5YzVkODQ2NzIwYWFmNzdkNmExIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVBy
b2Nlc3MvbWFjL1dLRnVsbFNjcmVlbldpbmRvd0NvbnRyb2xsZXIubW0KKysrIGIvU291cmNlL1dl
YktpdDIvVUlQcm9jZXNzL21hYy9XS0Z1bGxTY3JlZW5XaW5kb3dDb250cm9sbGVyLm1tCkBAIC0x
MDksNiArMTA5LDExIEBAIHN0YXRpYyBOU1JlY3QgY29udmVydFJlY3RUb1NjcmVlbihOU1dpbmRv
dyAqd2luZG93LCBOU1JlY3QgcmVjdCkKICAgICBbTlNPYmplY3QgY2FuY2VsUHJldmlvdXNQZXJm
b3JtUmVxdWVzdHNXaXRoVGFyZ2V0OnNlbGZdOwogICAgIAogICAgIFtbTlNOb3RpZmljYXRpb25D
ZW50ZXIgZGVmYXVsdENlbnRlcl0gcmVtb3ZlT2JzZXJ2ZXI6c2VsZl07CisKKyAgICBpZiAoX3Jl
cGFpbnRDYWxsYmFjaykKKyAgICAgICAgX3JlcGFpbnRDYWxsYmFjay0+aW52YWxpZGF0ZSgpOwor
ICAgIEFTU0VSVCghX3JlcGFpbnRDYWxsYmFjayk7CisKICAgICBbc3VwZXIgZGVhbGxvY107CiB9
CiAKQEAgLTM5OCwxMSArNDAzLDE3IEBAIHN0YXRpYyB2b2lkIGNvbXBsZXRlRmluaXNoRXhpdEZ1
bGxTY3JlZW5BbmltYXRpb25BZnRlclJlcGFpbnQoV0tFcnJvclJlZiwgdm9pZCopCiAgICAgW3Nl
bGYgX21hbmFnZXJdLT5zZXRBbmltYXRpbmdGdWxsU2NyZWVuKGZhbHNlKTsKICAgICBbc2VsZiBf
cGFnZV0tPnNjYWxlUGFnZShfc2F2ZWRTY2FsZSwgSW50UG9pbnQoKSk7CiAgICAgW3NlbGYgX21h
bmFnZXJdLT5yZXN0b3JlU2Nyb2xsUG9zaXRpb24oKTsKLSAgICBbc2VsZiBfcGFnZV0tPmZvcmNl
UmVwYWludChWb2lkQ2FsbGJhY2s6OmNyZWF0ZShzZWxmLCBjb21wbGV0ZUZpbmlzaEV4aXRGdWxs
U2NyZWVuQW5pbWF0aW9uQWZ0ZXJSZXBhaW50KSk7CisKKyAgICBpZiAoX3JlcGFpbnRDYWxsYmFj
aykKKyAgICAgICAgX3JlcGFpbnRDYWxsYmFjay0+aW52YWxpZGF0ZSgpOworICAgIEFTU0VSVCgh
X3JlcGFpbnRDYWxsYmFjayk7CisgICAgX3JlcGFpbnRDYWxsYmFjayA9IFZvaWRDYWxsYmFjazo6
Y3JlYXRlKHNlbGYsIGNvbXBsZXRlRmluaXNoRXhpdEZ1bGxTY3JlZW5BbmltYXRpb25BZnRlclJl
cGFpbnQpOworICAgIFtzZWxmIF9wYWdlXS0+Zm9yY2VSZXBhaW50KF9yZXBhaW50Q2FsbGJhY2sp
OwogfQogCiAtICh2b2lkKWNvbXBsZXRlRmluaXNoRXhpdEZ1bGxTY3JlZW5BbmltYXRpb25BZnRl
clJlcGFpbnQKIHsKKyAgICBfcmVwYWludENhbGxiYWNrID0gMDsKICAgICBbW193ZWJWaWV3IHdp
bmRvd10gc2V0QXV0b2Rpc3BsYXk6WUVTXTsKICAgICBbW193ZWJWaWV3IHdpbmRvd10gZGlzcGxh
eUlmTmVlZGVkXTsKICAgICBOU0VuYWJsZVNjcmVlblVwZGF0ZXMoKTsK
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>212667</attachid>
            <date>2013-09-25 22:28:03 -0700</date>
            <delta_ts>2013-09-26 09:22:47 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-121910-20130925222802.patch</filename>
            <type>text/plain</type>
            <size>4771</size>
            <attacher name="Jer Noble">jer.noble</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTU2NDM0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZTRmN2YxZWQ2M2JiOTI1
ZTA0ZTQzZWY3NDUxMzNmOWExMWZiNzY3NC4uZTE2ZDUyNTdiZTg0NGU0MTEwMjZhNTgwMjc5NTk0
OTNlMzA5ZWE5OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEzLTA5LTI1ICBKZXIg
Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCisgICAgICAgIFtXSzJdIENyYXNoIGF0IGF0
IGNvbS5hcHBsZS5XZWJLaXQyOiBXZWJLaXQ6OlZvaWRDYWxsYmFjazo6aW52YWxpZGF0ZSArIDQ2
CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjE5MTAK
KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTdG9yZSBh
IGNvcHkgb2YgdGhlIFZvaWRDYWxsYmFjayBwYXNzZWQgdG8gV0tQYWdlLCBhbmQgaW52YWxpZGF0
ZSB0aGUgY2FsbGJhY2sKKyAgICAgICAgZHVyaW5nIGRlYWxsb2MuIFRoZSBWb2lkQ2FsbGJhY2sg
Y2xhc3MgYXNzdW1lcyB0aGF0IGl0IHdpbGwgb25seSBldmVyIGJlCisgICAgICAgIGludmFsaWRh
dGVkIG9yIGludm9rZWQgb25jZSwgc28gY2hhbmdlIHRoZSBBU1NFUlRzIGludG8gYW4gZWFybHkg
cmV0dXJuLgorCisgICAgICAgICogVUlQcm9jZXNzL0dlbmVyaWNDYWxsYmFjay5oOgorICAgICAg
ICAoV2ViS2l0OjpWb2lkQ2FsbGJhY2s6OnBlcmZvcm1DYWxsYmFjayk6IEV4aXQgZWFybHkgaWYg
cHJldmlvdXNseSBpbnZhbGlkYXRlZC4KKyAgICAgICAgKFdlYktpdDo6Vm9pZENhbGxiYWNrOjpp
bnZhbGlkYXRlKTogRGl0dG8uCisgICAgICAgICogVUlQcm9jZXNzL21hYy9XS0Z1bGxTY3JlZW5X
aW5kb3dDb250cm9sbGVyLmg6CisgICAgICAgICogVUlQcm9jZXNzL21hYy9XS0Z1bGxTY3JlZW5X
aW5kb3dDb250cm9sbGVyLm1tOgorICAgICAgICAoLVtXS0Z1bGxTY3JlZW5XaW5kb3dDb250cm9s
bGVyIGRlYWxsb2NdKTogSW52YWxpZGF0ZSB0aGUgcmVwYWludCBjYWxsYmFjayBpZiBwcmVzZW50
LgorICAgICAgICAoLVtXS0Z1bGxTY3JlZW5XaW5kb3dDb250cm9sbGVyIGZpbmlzaGVkRXhpdEZ1
bGxTY3JlZW5BbmltYXRpb246XSk6IERpdHRvICYgY3JlYXRlIGEgbmV3IGNhbGxiYWNrLgorICAg
ICAgICAoLVtXS0Z1bGxTY3JlZW5XaW5kb3dDb250cm9sbGVyIGNvbXBsZXRlRmluaXNoRXhpdEZ1
bGxTY3JlZW5BbmltYXRpb25BZnRlclJlcGFpbnRdKTogQ2xlYXIgdGhlIGNhbGxiYWNrLgorCiAy
MDEzLTA5LTA2ICBKZXIgTm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgogCiAgICAgICAgIFtN
YWNdIEltcGxlbWVudCB0aGUgbWVkaWEgY29udHJvbHMgaW4gSmF2YVNjcmlwdC4KZGlmZiAtLWdp
dCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9HZW5lcmljQ2FsbGJhY2suaCBiL1NvdXJjZS9X
ZWJLaXQyL1VJUHJvY2Vzcy9HZW5lcmljQ2FsbGJhY2suaAppbmRleCBjZGEwMjBmZDAxMjFjYTIw
ZGQ1NGVlZTc0YjgwNTViMzk2MWI0YmQ0Li4wY2MyY2U1YmQ5OGE1ZGE2ZGNkNDFhNjg0OGQwMTE4
OTM0MmFiYTI3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvR2VuZXJpY0Nh
bGxiYWNrLmgKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0dlbmVyaWNDYWxsYmFjay5o
CkBAIC03OSw3ICs3OSw4IEBAIHB1YmxpYzoKIAogICAgIHZvaWQgcGVyZm9ybUNhbGxiYWNrKCkK
ICAgICB7Ci0gICAgICAgIEFTU0VSVChtX2NhbGxiYWNrKTsKKyAgICAgICAgaWYgKCFtX2NhbGxi
YWNrKQorICAgICAgICAgICAgcmV0dXJuOwogCiAgICAgICAgIG1fY2FsbGJhY2soMCwgY29udGV4
dCgpKTsKIApAQCAtODgsNyArODksOCBAQCBwdWJsaWM6CiAgICAgCiAgICAgdm9pZCBpbnZhbGlk
YXRlKCkKICAgICB7Ci0gICAgICAgIEFTU0VSVChtX2NhbGxiYWNrKTsKKyAgICAgICAgaWYgKCFt
X2NhbGxiYWNrKQorICAgICAgICAgICAgcmV0dXJuOwogCiAgICAgICAgIFJlZlB0cjxXZWJFcnJv
cj4gZXJyb3IgPSBXZWJFcnJvcjo6Y3JlYXRlKCk7CiAgICAgICAgIG1fY2FsbGJhY2sodG9BUEko
ZXJyb3IuZ2V0KCkpLCBjb250ZXh0KCkpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQ
cm9jZXNzL21hYy9XS0Z1bGxTY3JlZW5XaW5kb3dDb250cm9sbGVyLmggYi9Tb3VyY2UvV2ViS2l0
Mi9VSVByb2Nlc3MvbWFjL1dLRnVsbFNjcmVlbldpbmRvd0NvbnRyb2xsZXIuaAppbmRleCBjOGI4
NmQ0ZWY3YjgwMDIzM2NjMmUxZTJjOTViZGFhMTU5NjA0NmM3Li5mMjMxMWMxZDNjYTg5ZTM3MmVl
YjcxMDY5MmYzNmY4MTNkOGVmN2FlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl
c3MvbWFjL1dLRnVsbFNjcmVlbldpbmRvd0NvbnRyb2xsZXIuaAorKysgYi9Tb3VyY2UvV2ViS2l0
Mi9VSVByb2Nlc3MvbWFjL1dLRnVsbFNjcmVlbldpbmRvd0NvbnRyb2xsZXIuaApAQCAtMzAsNiAr
MzAsNyBAQAogCiBuYW1lc3BhY2UgV2ViS2l0IHsgCiBjbGFzcyBMYXllclRyZWVDb250ZXh0Owor
Y2xhc3MgVm9pZENhbGxiYWNrOwogfQogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CkBAIC01OCw2ICs1
OSw3IEBAIHR5cGVkZWYgZW51bSBGdWxsU2NyZWVuU3RhdGUgOiBOU0ludGVnZXIgRnVsbFNjcmVl
blN0YXRlOwogICAgIEZ1bGxTY3JlZW5TdGF0ZSBfZnVsbFNjcmVlblN0YXRlOwogCiAgICAgZG91
YmxlIF9zYXZlZFNjYWxlOworICAgIFJlZlB0cjxXZWJLaXQ6OlZvaWRDYWxsYmFjaz4gX3JlcGFp
bnRDYWxsYmFjazsKIH0KIAogLSAoaWQpaW5pdFdpdGhXaW5kb3c6KE5TV2luZG93ICopd2luZG93
IHdlYlZpZXc6KFdLVmlldyAqKXdlYlZpZXc7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9V
SVByb2Nlc3MvbWFjL1dLRnVsbFNjcmVlbldpbmRvd0NvbnRyb2xsZXIubW0gYi9Tb3VyY2UvV2Vi
S2l0Mi9VSVByb2Nlc3MvbWFjL1dLRnVsbFNjcmVlbldpbmRvd0NvbnRyb2xsZXIubW0KaW5kZXgg
ZTRlNzBjOTdjMjk4ZjgxZjkxMjJiODRjMWUwMWU2Y2IxOTFhOGRiMS4uM2Y4MWExM2QwZGVjMGE0
M2ZkMGQ0MDI2M2NiZmRlYjlkOTgyMThlYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQ
cm9jZXNzL21hYy9XS0Z1bGxTY3JlZW5XaW5kb3dDb250cm9sbGVyLm1tCisrKyBiL1NvdXJjZS9X
ZWJLaXQyL1VJUHJvY2Vzcy9tYWMvV0tGdWxsU2NyZWVuV2luZG93Q29udHJvbGxlci5tbQpAQCAt
MTA5LDYgKzEwOSwxNCBAQCBzdGF0aWMgTlNSZWN0IGNvbnZlcnRSZWN0VG9TY3JlZW4oTlNXaW5k
b3cgKndpbmRvdywgTlNSZWN0IHJlY3QpCiAgICAgW05TT2JqZWN0IGNhbmNlbFByZXZpb3VzUGVy
Zm9ybVJlcXVlc3RzV2l0aFRhcmdldDpzZWxmXTsKICAgICAKICAgICBbW05TTm90aWZpY2F0aW9u
Q2VudGVyIGRlZmF1bHRDZW50ZXJdIHJlbW92ZU9ic2VydmVyOnNlbGZdOworCisgICAgaWYgKF9y
ZXBhaW50Q2FsbGJhY2spIHsKKyAgICAgICAgX3JlcGFpbnRDYWxsYmFjay0+aW52YWxpZGF0ZSgp
OworICAgICAgICAvLyBpbnZhbGlkYXRlKCkgY2FsbHMgY29tcGxldGVGaW5pc2hFeGl0RnVsbFNj
cmVlbkFuaW1hdGlvbkFmdGVyUmVwYWludCwgd2hpY2gKKyAgICAgICAgLy8gY2xlYXJzIF9yZXBh
aW50Q2FsbGJhY2suCisgICAgICAgIEFTU0VSVCghX3JlcGFpbnRDYWxsYmFjayk7CisgICAgfQor
CiAgICAgW3N1cGVyIGRlYWxsb2NdOwogfQogCkBAIC0zOTgsMTEgKzQwNiwyMCBAQCBzdGF0aWMg
dm9pZCBjb21wbGV0ZUZpbmlzaEV4aXRGdWxsU2NyZWVuQW5pbWF0aW9uQWZ0ZXJSZXBhaW50KFdL
RXJyb3JSZWYsIHZvaWQqKQogICAgIFtzZWxmIF9tYW5hZ2VyXS0+c2V0QW5pbWF0aW5nRnVsbFNj
cmVlbihmYWxzZSk7CiAgICAgW3NlbGYgX3BhZ2VdLT5zY2FsZVBhZ2UoX3NhdmVkU2NhbGUsIElu
dFBvaW50KCkpOwogICAgIFtzZWxmIF9tYW5hZ2VyXS0+cmVzdG9yZVNjcm9sbFBvc2l0aW9uKCk7
Ci0gICAgW3NlbGYgX3BhZ2VdLT5mb3JjZVJlcGFpbnQoVm9pZENhbGxiYWNrOjpjcmVhdGUoc2Vs
ZiwgY29tcGxldGVGaW5pc2hFeGl0RnVsbFNjcmVlbkFuaW1hdGlvbkFmdGVyUmVwYWludCkpOwor
CisgICAgaWYgKF9yZXBhaW50Q2FsbGJhY2spIHsKKyAgICAgICAgX3JlcGFpbnRDYWxsYmFjay0+
aW52YWxpZGF0ZSgpOworICAgICAgICAvLyBpbnZhbGlkYXRlKCkgY2FsbHMgY29tcGxldGVGaW5p
c2hFeGl0RnVsbFNjcmVlbkFuaW1hdGlvbkFmdGVyUmVwYWludCwgd2hpY2gKKyAgICAgICAgLy8g
Y2xlYXJzIF9yZXBhaW50Q2FsbGJhY2suCisgICAgICAgIEFTU0VSVCghX3JlcGFpbnRDYWxsYmFj
ayk7CisgICAgfQorICAgIF9yZXBhaW50Q2FsbGJhY2sgPSBWb2lkQ2FsbGJhY2s6OmNyZWF0ZShz
ZWxmLCBjb21wbGV0ZUZpbmlzaEV4aXRGdWxsU2NyZWVuQW5pbWF0aW9uQWZ0ZXJSZXBhaW50KTsK
KyAgICBbc2VsZiBfcGFnZV0tPmZvcmNlUmVwYWludChfcmVwYWludENhbGxiYWNrKTsKIH0KIAog
LSAodm9pZCljb21wbGV0ZUZpbmlzaEV4aXRGdWxsU2NyZWVuQW5pbWF0aW9uQWZ0ZXJSZXBhaW50
CiB7CisgICAgX3JlcGFpbnRDYWxsYmFjayA9IG51bGxwdHI7CiAgICAgW1tfd2ViVmlldyB3aW5k
b3ddIHNldEF1dG9kaXNwbGF5OllFU107CiAgICAgW1tfd2ViVmlldyB3aW5kb3ddIGRpc3BsYXlJ
Zk5lZWRlZF07CiAgICAgTlNFbmFibGVTY3JlZW5VcGRhdGVzKCk7Cg==
</data>
<flag name="review"
          id="234914"
          type_id="1"
          status="+"
          setter="darin"
    />
          </attachment>
      

    </bug>

</bugzilla>