121904 2013-09-25 06:20:15 -0700 REGRESSION (r156355) Links / interactive elements inside nested tables are unclickable 2013-09-26 10:51:58 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 0 phiw2 webkit-unassigned commit-queue dykstrad esprehn+autocc glenn koivisto kondapallykalyan svetloslav oldest_to_newest 932961 0 212565 phiw2 2013-09-25 06:20:15 -0700 Created attachment 212565 test case Possibly from http://trac.webkit.org/changeset/156355 Sample URL: on bugzilla.mozilla.org https://bugzilla.mozilla.org/show_bug.cgi?id=468568 Try to click on an attachment link. In the attached test case: links inside the cyan block (parent table) are unclickable. If I remove the ‘box-shadow’ on the inner table (left column), magically the link start to work. I don’t think that is the only trigger. Margin: auto is (possibly) needed, more? This page: http://www.atimes.com also exhibits the issue (try the article links or the navigation column, light blue on the left), but individual pages work correctly. 932966 1 koivisto 2013-09-25 06:25:55 -0700 Looks like I lost a ! here: - if (child->isBox() && !toRenderBox(child)->hasSelfPaintingLayer()) { - LayoutPoint childPoint = flipForWritingModeForChild(toRenderBox(child), adjustedLocation); - if (child->nodeAtPoint(request, result, locationInContainer, childPoint, action)) { + if (row->hasSelfPaintingLayer()) { I think this might be it. 933074 2 212598 koivisto 2013-09-25 10:35:01 -0700 Created attachment 212598 patch 933080 3 koivisto 2013-09-25 10:46:01 -0700 https://trac.webkit.org/r156404 Thanks for the quick test case Philippe. It was very helpful. 933126 4 koivisto 2013-09-25 11:27:21 -0700 *** Bug 121912 has been marked as a duplicate of this bug. *** 933273 5 phiw2 2013-09-25 17:31:52 -0700 r156422 works perfectly fine. Thanks for the quick fix. 933324 6 koivisto 2013-09-25 19:13:53 -0700 <rdar://problem/15081686> 933590 7 ap 2013-09-26 10:51:58 -0700 *** Bug 121911 has been marked as a duplicate of this bug. *** 212565 2013-09-25 06:20:15 -0700 2013-09-25 06:21:06 -0700 test case wbk-tb-l.html text/html 923 phiw2 PCFkb2N0eXBlIGh0bWw+CjxodG1sIGxhbmc9ImVuIj4KPGhlYWQ+CjxtZXRhIGNoYXJzZXQ9InV0 Zi04Ij4KPHRpdGxlPnRlc3Q6IHNvbWV0aGluZzwvdGl0bGU+CjxzdHlsZSB0eXBlPSJ0ZXh0L2Nz cyI+CnRhYmxlIHsgYmFja2dyb3VuZDogY3lhbjsgbWFyZ2luOiA1MHB4IGF1dG87IGJvcmRlci1z cGFjaW5nOiAwOyB9CgouYXR0YWNobWVudF90YWJsZSB7CmJhY2tncm91bmQ6ICAjZmZmOwpib3Jk ZXI6IG5vbmU7CmJvcmRlci1jb2xsYXBzZTogY29sbGFwc2U7Ci8qYm9yZGVyLWJvdHRvbTogMXB4 IHNvbGlkICByZ2JhKDAsIDAsIDAsIDAuMik7Ki8KYm94LXNoYWRvdzogMCAxcHggMXB4IHJnYmEo MCwgMCwgMCwgMC4xKTsKLyptYXJnaW4tYm90dG9tOiA0MHB4OyovCn0KCnRhYmxlIHRhYmxlIHsg YmFja2dyb3VuZDogcmVkIH0KCgo8L3N0eWxlPgoKCgo8L2hlYWQ+Cgo8Ym9keT4KPHRhYmxlPjx0 cj48dGQ+Cjx0YWJsZSBjbGFzcz0iYXR0YWNobWVudF90YWJsZSI+Cjx0Ym9keT4KCTx0cj4KCQk8 dGQgdmFsaWduPSJ0b3AiPiA8YSBocmVmPSIvIj48Yj5saW5rIHRleHQ8L2I+PC9hPjwvdGQ+Cgk8 L3RyPgo8L3Rib2R5Pgo8L3RhYmxlPgo8L3RkPgoKPHRkPgo8dGFibGU+Cjx0Ym9keT4KCTx0cj4K CQk8dGQgdmFsaWduPSJ0b3AiPiA8YSBocmVmPSIvIj5saW5rIHRleHQ8L2E+PC90ZD4KCTwvdHI+ Cgk8dHI+CgkJPHRkPiA8YSBocmVmPSIvIj5saW5rIHRleHQ8L2E+PC90ZD4KCTwvdHI+CjwvdGJv ZHk+CjwvdGFibGU+Cgo8L3RkPgoKPC90cj48L3RhYmxlPgoKPHRhYmxlIGNsYXNzPSJhdHRhY2ht ZW50X3RhYmxlIj4KPHRib2R5PgoJPHRyPgoJCTx0ZCB2YWxpZ249InRvcCI+IDxhIGhyZWY9Ii8i PjxiPmxpbmsgdGV4dDwvYj48L2E+PC90ZD4KCTwvdHI+CjwvdGJvZHk+CjwvdGFibGU+Cgo8L2Jv ZHk+CjwvaHRtbD4= 212598 2013-09-25 10:35:01 -0700 2013-09-25 10:37:40 -0700 patch table-self-painting-regresion.patch text/plain 5807 koivisto SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1NjQwMikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI1IEBACisyMDEzLTA5LTI1ICBBbnR0aSBL b2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OIChyMTU2MzU1 KSBMaW5rcyAvIGludGVyYWN0aXZlIGVsZW1lbnRzIGluc2lkZSBuZXN0ZWQgdGFibGVzIGFyZSB1 bmNsaWNrYWJsZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTIxOTA0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgVGVzdDogZmFzdC90YWJsZS9oaXR0ZXN0LXNlbGYtcGFpbnRpbmcuaHRtbAorICAgICAgICAK KyAgICAgICAgT3JpZ2luYWwgcmVkdWN0aW9uIGJ5IFBoaWxpcHBlIFdpdHRlbmJlcmdoLgorCisg ICAgICAgICogcmVuZGVyaW5nL1JlbmRlclRhYmxlUm93LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OlJlbmRlclRhYmxlUm93OjpzdHlsZURpZENoYW5nZSk6CisgICAgICAgIAorICAgICAgICAgICAg VGlnaHRlbiBhIGJpdC4KKworICAgICAgICAoV2ViQ29yZTo6UmVuZGVyVGFibGVSb3c6Om5vZGVB dFBvaW50KToKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyVGFibGVTZWN0aW9uLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OlJlbmRlclRhYmxlU2VjdGlvbjo6bm9kZUF0UG9pbnQpOgorICAgICAg ICAKKyAgICAgICAgICAgIFRoZXNlIGZsaXBwZWQgYWNjaWRlbnRhbGx5IGluIHIxNTYzNTUuCisK IDIwMTMtMDktMjUgIEFsYmVydG8gR2FyY2lhICA8YmVydG9AaWdhbGlhLmNvbT4KIAogICAgICAg ICBGaXggd2FybmluZyBpbiBtYWtlcHJvcC5wbApJbmRleDogU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL1JlbmRlclRhYmxlUm93LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9yZW5k ZXJpbmcvUmVuZGVyVGFibGVSb3cuY3BwCShyZXZpc2lvbiAxNTYzNzYpCisrKyBTb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyVGFibGVSb3cuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC04MSwx MSArODEsOCBAQCB2b2lkIFJlbmRlclRhYmxlUm93OjpzdHlsZURpZENoYW5nZShTdHlsCiAgICAg ICAgICAgICAvLyBJZiB0aGUgYm9yZGVyIHdpZHRoIGNoYW5nZXMgb24gYSByb3csIHdlIG5lZWQg dG8gbWFrZSBzdXJlIHRoZSBjZWxscyBpbiB0aGUgcm93IGtub3cgdG8gbGF5IG91dCBhZ2Fpbi4K ICAgICAgICAgICAgIC8vIFRoaXMgb25seSBoYXBwZW5zIHdoZW4gYm9yZGVycyBhcmUgY29sbGFw c2VkLCBzaW5jZSB0aGV5IGVuZCB1cCBhZmZlY3RpbmcgdGhlIGJvcmRlciBzaWRlcyBvZiB0aGUg Y2VsbAogICAgICAgICAgICAgLy8gaXRzZWxmLgotICAgICAgICAgICAgZm9yIChSZW5kZXJCb3gq IGNoaWxkQm94ID0gZmlyc3RDaGlsZEJveCgpOyBjaGlsZEJveDsgY2hpbGRCb3ggPSBjaGlsZEJv eC0+bmV4dFNpYmxpbmdCb3goKSkgewotICAgICAgICAgICAgICAgIGlmICghY2hpbGRCb3gtPmlz VGFibGVDZWxsKCkpCi0gICAgICAgICAgICAgICAgICAgIGNvbnRpbnVlOwotICAgICAgICAgICAg ICAgIGNoaWxkQm94LT5zZXRDaGlsZE5lZWRzTGF5b3V0KHRydWUsIE1hcmtPbmx5VGhpcyk7Ci0g ICAgICAgICAgICB9CisgICAgICAgICAgICBmb3IgKFJlbmRlclRhYmxlQ2VsbCogY2VsbCA9IGZp cnN0Q2VsbCgpOyBjZWxsOyBjZWxsID0gY2VsbC0+bmV4dENlbGwoKSkKKyAgICAgICAgICAgICAg ICBjZWxsLT5zZXRDaGlsZE5lZWRzTGF5b3V0KHRydWUsIE1hcmtPbmx5VGhpcyk7CiAgICAgICAg IH0KICAgICB9CiB9CkBAIC0yMTYsNyArMjEzLDcgQEAgYm9vbCBSZW5kZXJUYWJsZVJvdzo6bm9k ZUF0UG9pbnQoY29uc3QgSAogICAgICAgICAvLyBhdCB0aGUgbW9tZW50IChhIGRlbW90ZWQgaW5s aW5lIDxmb3JtPiBmb3IgZXhhbXBsZSkuIElmIHdlIGV2ZXIgaW1wbGVtZW50IGEKICAgICAgICAg Ly8gdGFibGUtc3BlY2lmaWMgaGl0LXRlc3QgbWV0aG9kICh3aGljaCB3ZSBzaG91bGQgZG8gZm9y IHBlcmZvcm1hbmNlIHJlYXNvbnMgYW55d2F5KSwKICAgICAgICAgLy8gdGhlbiB3ZSBjYW4gcmVt b3ZlIHRoaXMgY2hlY2suCi0gICAgICAgIGlmIChjZWxsLT5oYXNTZWxmUGFpbnRpbmdMYXllcigp KSB7CisgICAgICAgIGlmICghY2VsbC0+aGFzU2VsZlBhaW50aW5nTGF5ZXIoKSkgewogICAgICAg ICAgICAgTGF5b3V0UG9pbnQgY2VsbFBvaW50ID0gZmxpcEZvcldyaXRpbmdNb2RlRm9yQ2hpbGQo Y2VsbCwgYWNjdW11bGF0ZWRPZmZzZXQpOwogICAgICAgICAgICAgaWYgKGNlbGwtPm5vZGVBdFBv aW50KHJlcXVlc3QsIHJlc3VsdCwgbG9jYXRpb25JbkNvbnRhaW5lciwgY2VsbFBvaW50LCBhY3Rp b24pKSB7CiAgICAgICAgICAgICAgICAgdXBkYXRlSGl0VGVzdFJlc3VsdChyZXN1bHQsIGxvY2F0 aW9uSW5Db250YWluZXIucG9pbnQoKSAtIHRvTGF5b3V0U2l6ZShjZWxsUG9pbnQpKTsKSW5kZXg6 IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUYWJsZVNlY3Rpb24uY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUYWJsZVNlY3Rpb24uY3BwCShy ZXZpc2lvbiAxNTYzNzYpCisrKyBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGFibGVT ZWN0aW9uLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTM1Miw3ICsxMzUyLDcgQEAgYm9vbCBSZW5k ZXJUYWJsZVNlY3Rpb246Om5vZGVBdFBvaW50KGNvbgogICAgICAgICAgICAgLy8gYXQgdGhlIG1v bWVudCAoYSBkZW1vdGVkIGlubGluZSA8Zm9ybT4gZm9yIGV4YW1wbGUpLiBJZiB3ZSBldmVyIGlt cGxlbWVudCBhCiAgICAgICAgICAgICAvLyB0YWJsZS1zcGVjaWZpYyBoaXQtdGVzdCBtZXRob2Qg KHdoaWNoIHdlIHNob3VsZCBkbyBmb3IgcGVyZm9ybWFuY2UgcmVhc29ucyBhbnl3YXkpLAogICAg ICAgICAgICAgLy8gdGhlbiB3ZSBjYW4gcmVtb3ZlIHRoaXMgY2hlY2suCi0gICAgICAgICAgICBp ZiAocm93LT5oYXNTZWxmUGFpbnRpbmdMYXllcigpKSB7CisgICAgICAgICAgICBpZiAoIXJvdy0+ aGFzU2VsZlBhaW50aW5nTGF5ZXIoKSkgewogICAgICAgICAgICAgICAgIExheW91dFBvaW50IGNo aWxkUG9pbnQgPSBmbGlwRm9yV3JpdGluZ01vZGVGb3JDaGlsZChyb3csIGFkanVzdGVkTG9jYXRp b24pOwogICAgICAgICAgICAgICAgIGlmIChyb3ctPm5vZGVBdFBvaW50KHJlcXVlc3QsIHJlc3Vs dCwgbG9jYXRpb25JbkNvbnRhaW5lciwgY2hpbGRQb2ludCwgYWN0aW9uKSkgewogICAgICAgICAg ICAgICAgICAgICB1cGRhdGVIaXRUZXN0UmVzdWx0KHJlc3VsdCwgdG9MYXlvdXRQb2ludChsb2Nh dGlvbkluQ29udGFpbmVyLnBvaW50KCkgLSBjaGlsZFBvaW50KSk7CkluZGV4OiBMYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lv biAxNTY0MDIpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEs MyArMSwxMyBAQAorMjAxMy0wOS0yNSAgQW50dGkgS29pdmlzdG8gIDxhbnR0aUBhcHBsZS5jb20+ CisKKyAgICAgICAgUkVHUkVTU0lPTiAocjE1NjM1NSkgTGlua3MgLyBpbnRlcmFjdGl2ZSBlbGVt ZW50cyBpbnNpZGUgbmVzdGVkIHRhYmxlcyBhcmUgdW5jbGlja2FibGUKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMTkwNAorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZmFzdC90YWJsZS9oaXR0ZXN0LXNl bGYtcGFpbnRpbmctZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L3RhYmxlL2hp dHRlc3Qtc2VsZi1wYWludGluZy5odG1sOiBBZGRlZC4KKwogMjAxMy0wOS0yNSAgU2FuZ2h5dXAg TGVlICA8c2g1My5sZWVAc2Ftc3VuZy5jb20+CiAKICAgICAgICAgW0VGTF0gVW5yZXZpZXdlZCBn YXJkZW5pbmcuIFVuc2tpcCBwYXNzaW5nIGZhc3QvdGV4dC9mb250LWtlcm5pbmcuaHRtbCAKSW5k ZXg6IExheW91dFRlc3RzL2Zhc3QvdGFibGUvaGl0dGVzdC1zZWxmLXBhaW50aW5nLWV4cGVjdGVk LnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L3RhYmxlL2hpdHRlc3Qtc2VsZi1w YWludGluZy1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L3Rh YmxlL2hpdHRlc3Qtc2VsZi1wYWludGluZy1leHBlY3RlZC50eHQJKHdvcmtpbmcgY29weSkKQEAg LTAsMCArMSwxMCBAQAorVGVzdCB0aGF0IGV2ZW50cyBnZXQgdGhyb3VnaCBzZWxmLXBhaW50aW5n IGxheWVycyBpbiB0YWJsZXMuCisKK09uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNlcmllcyBv ZiAiUEFTUyIgbWVzc2FnZXMsIGZvbGxvd2VkIGJ5ICJURVNUIENPTVBMRVRFIi4KKworCitQQVNT IGNsaWNrIGV2ZW50IHJlY2VpdmVkCitQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCisK K1RFU1QgQ09NUExFVEUKKwpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC90YWJsZS9oaXR0ZXN0LXNl bGYtcGFpbnRpbmcuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L3RhYmxlL2hp dHRlc3Qtc2VsZi1wYWludGluZy5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFz dC90YWJsZS9oaXR0ZXN0LXNlbGYtcGFpbnRpbmcuaHRtbAkod29ya2luZyBjb3B5KQpAQCAtMCww ICsxLDIzIEBACis8aHRtbD4KKzxzY3JpcHQgc3JjPSIuLi8uLi9yZXNvdXJjZXMvanMtdGVzdC1w cmUuanMiPjwvc2NyaXB0PgorPGhlYWQ+Cis8c3R5bGU+CisjdGVzdCB7IGJhY2tncm91bmQtY29s b3I6IHJlZDsgYm94LXNoYWRvdzogMCAxcHggMXB4IHJnYmEoMCwgMCwgMCwgMC4xKTsgaGVpZ2h0 OjIwMHB4OyB3aWR0aDoyMDBweCB9CisjdGVzdDpob3ZlciB7IGJhY2tncm91bmQtY29sb3I6IGdy ZWVuOyB9Cis8L3N0eWxlPgorPC9oZWFkPgorPGJvZHk+Cis8dGFibGU+PHRyPjx0ZD4KKzxkaXYg aWQ9dGVzdCBvbmNsaWNrPSJ0ZXN0UGFzc2VkKCdjbGljayBldmVudCByZWNlaXZlZCcpIj4KKzwv ZGl2PgorPC90ZD48L3RkPgorPC90YWJsZT4KKzxzY3JpcHQ+CisgICAgZGVzY3JpcHRpb24oIlRl c3QgdGhhdCBldmVudHMgZ2V0IHRocm91Z2ggc2VsZi1wYWludGluZyBsYXllcnMgaW4gdGFibGVz LiIpOworICAgIGlmICh3aW5kb3cuZXZlbnRTZW5kZXIpIHsKKyAgICAgICAgZXZlbnRTZW5kZXIu bW91c2VNb3ZlVG8oMTAwLCAxMDApOworICAgICAgICBldmVudFNlbmRlci5tb3VzZURvd24oKTsK KyAgICAgICAgZXZlbnRTZW5kZXIubW91c2VVcCgpOworICAgIH0KKzwvc2NyaXB0PgorPHNjcmlw dCBzcmM9Ii4uLy4uL3Jlc291cmNlcy9qcy10ZXN0LXBvc3QuanMiPjwvc2NyaXB0Pgo=