121903 2013-09-25 06:17:32 -0700 htmlediting.cpp: unnecessary local variable cleanup 2013-09-25 18:59:52 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Minor --- 0 santosh.ma webkit-unassigned commit-queue oldest_to_newest 932960 0 santosh.ma 2013-09-25 06:17:32 -0700 Node* lowestRoot = 0 is not used any where in function so removing it. 932963 1 212566 santosh.ma 2013-09-25 06:23:52 -0700 Created attachment 212566 Patch 933303 2 212566 darin 2013-09-25 18:36:29 -0700 Comment on attachment 212566 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=212566&action=review > Source/WebCore/editing/htmlediting.cpp:145 > + return 0; Should be nullptr rather than 0 in new code. 933317 3 212566 commit-queue 2013-09-25 18:59:50 -0700 Comment on attachment 212566 Patch Clearing flags on attachment: 212566 Committed r156442: <http://trac.webkit.org/changeset/156442> 933318 4 commit-queue 2013-09-25 18:59:52 -0700 All reviewed patches have been landed. Closing bug. 212566 2013-09-25 06:23:52 -0700 2013-09-25 18:59:50 -0700 Patch bug-121903-20130925185804.patch text/plain 1451 santosh.ma U3VidmVyc2lvbiBSZXZpc2lvbjogMTU1ODMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzJkM2YzN2Q3ODAyYzJl NzIzZTM4NTE4MWI5MjcxMmNiMzc2YjI0NS4uN2YzYjMxYjc4Y2FjN2Q4YjVlNzE0NWM1OTk1Njg4 MTA1MDg4YmEyMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTA5LTI1ICBTYW50 b3NoIE1haHRvICA8c2FudG9zaC5tYUBzYW1zdW5nLmNvbT4KKworICAgICAgICBodG1sZWRpdGlu Zy5jcHA6IHVubmVjZXNzYXJ5IGxvY2FsIHZhcmlhYmxlIGNsZWFudXAKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMTkwMworCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENvZGUgY2xlYW51cC4KKworICAgICAg ICAqIGVkaXRpbmcvaHRtbGVkaXRpbmcuY3BwOgorICAgICAgICAoV2ViQ29yZTo6bG93ZXN0RWRp dGFibGVBbmNlc3Rvcik6CisKIDIwMTMtMDktMTUgIEd1c3Rhdm8gTm9yb25oYSBTaWx2YSAgPGdu c0Bnbm9tZS5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCBtYWtlIGRpc3RjaGVjayBmaXguCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL2h0bWxlZGl0aW5nLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL2VkaXRpbmcvaHRtbGVkaXRpbmcuY3BwCmluZGV4IGRkYWYyNDQxOTc3YjFmZWIz ZTkwNjI4YmI1ZDA1NjZhMDhkNGI4MzguLjk4NzYxY2U2ZTFkMjkyMDVkNDg4NzQ2Nzg4ODI0MzE5 M2JkY2I0ZGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvaHRtbGVkaXRpbmcu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvaHRtbGVkaXRpbmcuY3BwCkBAIC0xMzQs NyArMTM0LDYgQEAgTm9kZSogbG93ZXN0RWRpdGFibGVBbmNlc3RvcihOb2RlKiBub2RlKQogICAg IGlmICghbm9kZSkKICAgICAgICAgcmV0dXJuIDA7CiAgICAgCi0gICAgTm9kZSogbG93ZXN0Um9v dCA9IDA7CiAgICAgd2hpbGUgKG5vZGUpIHsKICAgICAgICAgaWYgKG5vZGUtPnJlbmRlcmVySXNF ZGl0YWJsZSgpKQogICAgICAgICAgICAgcmV0dXJuIG5vZGUtPnJvb3RFZGl0YWJsZUVsZW1lbnQo KTsKQEAgLTE0Myw3ICsxNDIsNyBAQCBOb2RlKiBsb3dlc3RFZGl0YWJsZUFuY2VzdG9yKE5vZGUq IG5vZGUpCiAgICAgICAgIG5vZGUgPSBub2RlLT5wYXJlbnROb2RlKCk7CiAgICAgfQogICAgIAot ICAgIHJldHVybiBsb3dlc3RSb290OworICAgIHJldHVybiAwOwogfQogCiBib29sIGlzRWRpdGFi bGVQb3NpdGlvbihjb25zdCBQb3NpdGlvbiYgcCwgRWRpdGFibGVUeXBlIGVkaXRhYmxlVHlwZSwg RVVwZGF0ZVN0eWxlIHVwZGF0ZVN0eWxlKQo=