121895 2013-09-24 22:26:37 -0700 Remove the Windows-specific rules from WebKit2's DerivedSources.make, Windows is not supported anymore 2013-09-24 22:35:49 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 sam sam oldest_to_newest 932891 0 sam 2013-09-24 22:26:37 -0700 Remove the Windows-specific rules from WebKit2's DerivedSources.make, Windows is not supported anymore 932892 1 212540 sam 2013-09-24 22:27:01 -0700 Created attachment 212540 Patch 932893 2 212540 ap 2013-09-24 22:31:46 -0700 Comment on attachment 212540 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=212540&action=review > Source/WebKit2/DerivedSources.make:1 > -# Copyright (C) 2010, 2011, 2012 Apple Inc. All rights reserved. > +# Copyright (C) 2010, 2011, 2012, 2013 Apple Inc. All rights reserved. Did we change this file this year? I don't think that removing code gives you copyright. > Source/WebKit2/DerivedSources.make:-139 > -# Mac-specific rules > - > -ifeq ($(PLATFORM_NAME),macosx) These changes are not mentioned in ChangeLog, and surprised me. Looks like this file is only used on Mac. 932895 3 sam 2013-09-24 22:34:46 -0700 (In reply to comment #2) > (From update of attachment 212540 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=212540&action=review > > > Source/WebKit2/DerivedSources.make:1 > > -# Copyright (C) 2010, 2011, 2012 Apple Inc. All rights reserved. > > +# Copyright (C) 2010, 2011, 2012, 2013 Apple Inc. All rights reserved. > > Did we change this file this year? I don't think that removing code gives you copyright. > We did. r142518 for instance. > > Source/WebKit2/DerivedSources.make:-139 > > -# Mac-specific rules > > - > > -ifeq ($(PLATFORM_NAME),macosx) > > These changes are not mentioned in ChangeLog, and surprised me. > > Looks like this file is only used on Mac. Right, I think DerivedSources.make is only used by Mac and Windows. And without Windows, it only leaves Mac :). I'll fix the ChangeLog. 932896 4 sam 2013-09-24 22:35:49 -0700 Committed r156384: <http://trac.webkit.org/changeset/156384> 212540 2013-09-24 22:27:01 -0700 2013-09-24 22:31:46 -0700 Patch bug-121895-20130924222701.patch text/plain 2395 sam SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1NjM4MykKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEzLTA5LTI0ICBTYW0gV2Vp bmlnICA8c2FtQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmVtb3ZlIHRoZSBXaW5kb3dzLXNwZWNp ZmljIHJ1bGVzIGZyb20gV2ViS2l0MidzIERlcml2ZWRTb3VyY2VzLm1ha2UsIFdpbmRvd3MgaXMg bm90IHN1cHBvcnRlZCBhbnltb3JlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMjE4OTUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIERlcml2ZWRTb3VyY2VzLm1ha2U6CisgICAgICAgIFJlbW92ZSBXaW5k b3dzLXNwZWNpZmljIHJ1bGVzLgorCiAyMDEzLTA5LTI0ICBBbmRlcnMgQ2FybHNzb24gIDxhbmRl cnNjYUBhcHBsZS5jb20+CiAKICAgICAgICAgT25seSBhbGxvdyBydmFsdWVzIHRvIGJlIHBhc3Nl ZCBhcyBzeW5jaHJvbm91cyBtZXNzYWdlIHJlcGxpZXMKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL0Rl cml2ZWRTb3VyY2VzLm1ha2UKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvRGVyaXZlZFNv dXJjZXMubWFrZQkocmV2aXNpb24gMTU2MzgyKQorKysgU291cmNlL1dlYktpdDIvRGVyaXZlZFNv dXJjZXMubWFrZQkod29ya2luZyBjb3B5KQpAQCAtMSw0ICsxLDQgQEAKLSMgQ29weXJpZ2h0IChD KSAyMDEwLCAyMDExLCAyMDEyIEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyMgQ29w eXJpZ2h0IChDKSAyMDEwLCAyMDExLCAyMDEyLCAyMDEzIEFwcGxlIEluYy4gQWxsIHJpZ2h0cyBy ZXNlcnZlZC4KICMKICMgUmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFy eSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CiAjIG1vZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBw cm92aWRlZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9ucwpAQCAtMTM0LDkgKzEzNCw2IEBA IGFsbCA6IFwKIAlAZWNobyBHZW5lcmF0aW5nIG1lc3NhZ2UgcmVjZWl2ZXIgZm9yICQqLi4uCiAJ QHB5dGhvbiAkKFdlYktpdDIpL1NjcmlwdHMvZ2VuZXJhdGUtbWVzc2FnZXMtaGVhZGVyLnB5ICQ8 ID4gJEAKIAotIyBNYWMtc3BlY2lmaWMgcnVsZXMKLQotaWZlcSAoJChQTEFURk9STV9OQU1FKSxt YWNvc3gpCiAKIEZSQU1FV09SS19GTEFHUyA9ICQoc2hlbGwgZWNobyAkKEJVSUxUX1BST0RVQ1RT X0RJUikgJChGUkFNRVdPUktfU0VBUkNIX1BBVEhTKSB8IHBlcmwgLWUgJ3ByaW50ICItRiAiIC4g am9pbigiIC1GICIsIHNwbGl0KCIgIiwgPD4pKTsnKQogSEVBREVSX0ZMQUdTID0gJChzaGVsbCBl Y2hvICQoQlVJTFRfUFJPRFVDVFNfRElSKSAkKEhFQURFUl9TRUFSQ0hfUEFUSFMpIHwgcGVybCAt ZSAncHJpbnQgIi1JIiAuIGpvaW4oIiAtSSIsIHNwbGl0KCIgIiwgPD4pKTsnKQpAQCAtMTY0LDE4 ICsxNjEsMyBAQCBhbGw6ICQoU0FOREJPWF9QUk9GSUxFUykKIAlAZWNobyBQcmUtcHJvY2Vzc2lu ZyAkKiBzYW5kYm94IHByb2ZpbGUuLi4KIAkkKENDKSAkKFNES19GTEFHUykgJChURVhUX1BSRVBS T0NFU1NPUl9GTEFHUykgJChGUkFNRVdPUktfRkxBR1MpICQoSEVBREVSX0ZMQUdTKSAtaW5jbHVk ZSAid3RmL1BsYXRmb3JtLmgiICQ8ID4gJEAKIAotZW5kaWYgIyBtYWNvc3gKLQotIyAtLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0KLQotIyBXaW5kb3dzLXNwZWNpZmljIHJ1bGVzCi0KLWlmZXEgKCQo T1MpLFdpbmRvd3NfTlQpCi0KLWFsbCA6IEhlYWRlckRldGVjdGlvbi5oCi0KLUhlYWRlckRldGVj dGlvbi5oIDogRGVyaXZlZFNvdXJjZXMubWFrZQotCWlmIFsgLWYgIiQoV0VCS0lUTElCUkFSSUVT RElSKS9pbmNsdWRlL1dlYktpdFF1YXJ0ekNvcmVBZGRpdGlvbnMvV2ViS2l0UXVhcnR6Q29yZUFk ZGl0aW9uc0Jhc2UuaCIgXSAmJiBbICEgLWYgIiQoV0VCS0lUTElCUkFSSUVTRElSKS9pbmNsdWRl L2NhaXJvL2NhaXJvLmgiIF07IHRoZW4gZWNobyAiI2RlZmluZSBIQVZFX1dLUUNBIDEiID4gJEA7 IGVsc2UgZWNobyA+ICRAOyBmaQotCWlmIFsgLWYgIiQoV0VCS0lUTElCUkFSSUVTRElSKS9pbmNs dWRlL0FWRm91bmRhdGlvbkNGL0FWQ0ZCYXNlLmgiIF07IHRoZW4gZWNobyAiI2RlZmluZSBIQVZF X0FWQ0YgMSIgPj4gJEA7IGVsc2UgZWNobyA+PiAkQDsgZmkKLQotZW5kaWYgIyBXaW5kb3dzX05U Cg==