121870 2013-09-24 15:09:54 -0700 Only allow rvalues to be passed as synchronous message replies 2013-09-24 18:02:58 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca commit-queue oldest_to_newest 932738 0 andersca 2013-09-24 15:09:54 -0700 Only allow rvalues to be passed as synchronous message replies 932741 1 212509 andersca 2013-09-24 15:12:25 -0700 Created attachment 212509 Patch 932742 2 commit-queue 2013-09-24 15:13:48 -0700 Attachment 212509 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Platform/CoreIPC/Connection.h', u'Source/WebKit2/Platform/CoreIPC/MessageSender.h', u'Source/WebKit2/Shared/ChildProcessProxy.h']" exit_code: 1 Source/WebKit2/Shared/ChildProcessProxy.h:51: Missing spaces around && [whitespace/operators] [3] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 932831 3 andersca 2013-09-24 18:02:58 -0700 Committed r156378: <http://trac.webkit.org/changeset/156378> 212509 2013-09-24 15:12:25 -0700 2013-09-24 15:31:08 -0700 Patch bug-121870-20130924151224.patch text/plain 6422 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTU2MzYwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZjhiNGMzNzExNTQwMjNi OWVmYzAxZTBlODNiNmY4OWE1NmYwNjQ2OS4uMWJmMmNhNDVkYWFkODk0MTI3OTU1MjA3YWQ5YzU4 N2M0NTVjNWFhZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIyIEBACiAyMDEzLTA5LTI0ICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKKyAgICAgICAgT25seSBhbGxvdyBy dmFsdWVzIHRvIGJlIHBhc3NlZCBhcyBzeW5jaHJvbm91cyBtZXNzYWdlIHJlcGxpZXMKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMTg3MAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgbGV0cyB1cyBn ZXQgcmlkIG9mIGEgbmFzdHkgY29uc3QgY2FzdCBhbmQgaXMgbW9yZSBsb2dpY2FsLgorCisgICAg ICAgICogUGxhdGZvcm0vQ29yZUlQQy9Db25uZWN0aW9uLmg6CisgICAgICAgIChDb3JlSVBDOjpD b25uZWN0aW9uOjpzZW5kU3luYyk6CisgICAgICAgICogUGxhdGZvcm0vQ29yZUlQQy9NZXNzYWdl U2VuZGVyLmg6CisgICAgICAgIChDb3JlSVBDOjpNZXNzYWdlU2VuZGVyOjpzZW5kKToKKyAgICAg ICAgKENvcmVJUEM6Ok1lc3NhZ2VTZW5kZXI6OnNlbmRTeW5jKToKKyAgICAgICAgKiBTaGFyZWQv Q2hpbGRQcm9jZXNzUHJveHkuaDoKKyAgICAgICAgKFdlYktpdDo6Q2hpbGRQcm9jZXNzUHJveHk6 OnNlbmRTeW5jKToKKworMjAxMy0wOS0yNCAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBw bGUuY29tPgorCiAgICAgICAgIFVzZSBzdGQ6OnVuaXF1ZV9wdHIgZm9yIGRlY29kZXJzIGFzIHdl bGwKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMTg2 OAogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9Db3JlSVBDL0Nvbm5lY3Rp b24uaCBiL1NvdXJjZS9XZWJLaXQyL1BsYXRmb3JtL0NvcmVJUEMvQ29ubmVjdGlvbi5oCmluZGV4 IGNhNTg3MmIwZjhhYmQ0ODAxMDRkNzkxZTkxZDYzZGMxMjk2ZjEyMmMuLmQyZTA3MjRkYjdkODg5 NzI3YjdjMWJhMjAzYjIzMTkyM2EyNmU4MmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1Bs YXRmb3JtL0NvcmVJUEMvQ29ubmVjdGlvbi5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1BsYXRmb3Jt L0NvcmVJUEMvQ29ubmVjdGlvbi5oCkBAIC0xNzAsNyArMTcwLDcgQEAgcHVibGljOgogICAgIHN0 YXRpYyBjb25zdCBpbnQgTm9UaW1lb3V0ID0gLTE7CiAKICAgICB0ZW1wbGF0ZTx0eXBlbmFtZSBU PiBib29sIHNlbmQoY29uc3QgVCYgbWVzc2FnZSwgdWludDY0X3QgZGVzdGluYXRpb25JRCwgdW5z aWduZWQgbWVzc2FnZVNlbmRGbGFncyA9IDApOwotICAgIHRlbXBsYXRlPHR5cGVuYW1lIFQ+IGJv b2wgc2VuZFN5bmMoY29uc3QgVCYgbWVzc2FnZSwgY29uc3QgdHlwZW5hbWUgVDo6UmVwbHkmIHJl cGx5LCB1aW50NjRfdCBkZXN0aW5hdGlvbklELCBkb3VibGUgdGltZW91dCA9IE5vVGltZW91dCwg dW5zaWduZWQgc3luY1NlbmRGbGFncyA9IDApOworICAgIHRlbXBsYXRlPHR5cGVuYW1lIFQ+IGJv b2wgc2VuZFN5bmMoY29uc3QgVCYgbWVzc2FnZSwgdHlwZW5hbWUgVDo6UmVwbHkmJiByZXBseSwg dWludDY0X3QgZGVzdGluYXRpb25JRCwgZG91YmxlIHRpbWVvdXQgPSBOb1RpbWVvdXQsIHVuc2ln bmVkIHN5bmNTZW5kRmxhZ3MgPSAwKTsKICAgICB0ZW1wbGF0ZTx0eXBlbmFtZSBUPiBib29sIHdh aXRGb3JBbmREaXNwYXRjaEltbWVkaWF0ZWx5KHVpbnQ2NF90IGRlc3RpbmF0aW9uSUQsIGRvdWJs ZSB0aW1lb3V0KTsKIAogICAgIHN0ZDo6dW5pcXVlX3B0cjxNZXNzYWdlRW5jb2Rlcj4gY3JlYXRl U3luY01lc3NhZ2VFbmNvZGVyKFN0cmluZ1JlZmVyZW5jZSBtZXNzYWdlUmVjZWl2ZXJOYW1lLCBT dHJpbmdSZWZlcmVuY2UgbWVzc2FnZU5hbWUsIHVpbnQ2NF90IGRlc3RpbmF0aW9uSUQsIHVpbnQ2 NF90JiBzeW5jUmVxdWVzdElEKTsKQEAgLTM1NSw3ICszNTUsNyBAQCB0ZW1wbGF0ZTx0eXBlbmFt ZSBUPiBib29sIENvbm5lY3Rpb246OnNlbmQoY29uc3QgVCYgbWVzc2FnZSwgdWludDY0X3QgZGVz dGluYXRpbwogICAgIHJldHVybiBzZW5kTWVzc2FnZShzdGQ6Om1vdmUoZW5jb2RlciksIG1lc3Nh Z2VTZW5kRmxhZ3MpOwogfQogCi10ZW1wbGF0ZTx0eXBlbmFtZSBUPiBib29sIENvbm5lY3Rpb246 OnNlbmRTeW5jKGNvbnN0IFQmIG1lc3NhZ2UsIGNvbnN0IHR5cGVuYW1lIFQ6OlJlcGx5JiByZXBs eSwgdWludDY0X3QgZGVzdGluYXRpb25JRCwgZG91YmxlIHRpbWVvdXQsIHVuc2lnbmVkIHN5bmNT ZW5kRmxhZ3MpCit0ZW1wbGF0ZTx0eXBlbmFtZSBUPiBib29sIENvbm5lY3Rpb246OnNlbmRTeW5j KGNvbnN0IFQmIG1lc3NhZ2UsIHR5cGVuYW1lIFQ6OlJlcGx5JiYgcmVwbHksIHVpbnQ2NF90IGRl c3RpbmF0aW9uSUQsIGRvdWJsZSB0aW1lb3V0LCB1bnNpZ25lZCBzeW5jU2VuZEZsYWdzKQogewog ICAgIENPTVBJTEVfQVNTRVJUKFQ6OmlzU3luYywgU3luY01lc3NhZ2VFeHBlY3RlZCk7CiAKQEAg LTM3MSw3ICszNzEsNyBAQCB0ZW1wbGF0ZTx0eXBlbmFtZSBUPiBib29sIENvbm5lY3Rpb246OnNl bmRTeW5jKGNvbnN0IFQmIG1lc3NhZ2UsIGNvbnN0IHR5cGVuYW1lCiAgICAgICAgIHJldHVybiBm YWxzZTsKIAogICAgIC8vIERlY29kZSB0aGUgcmVwbHkuCi0gICAgcmV0dXJuIHJlcGx5RGVjb2Rl ci0+ZGVjb2RlKGNvbnN0X2Nhc3Q8dHlwZW5hbWUgVDo6UmVwbHkmPihyZXBseSkpOworICAgIHJl dHVybiByZXBseURlY29kZXItPmRlY29kZShyZXBseSk7CiB9CiAKIHRlbXBsYXRlPHR5cGVuYW1l IFQ+IGJvb2wgQ29ubmVjdGlvbjo6d2FpdEZvckFuZERpc3BhdGNoSW1tZWRpYXRlbHkodWludDY0 X3QgZGVzdGluYXRpb25JRCwgZG91YmxlIHRpbWVvdXQpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0Mi9QbGF0Zm9ybS9Db3JlSVBDL01lc3NhZ2VTZW5kZXIuaCBiL1NvdXJjZS9XZWJLaXQyL1Bs YXRmb3JtL0NvcmVJUEMvTWVzc2FnZVNlbmRlci5oCmluZGV4IDQ4NzgzMGRiNzA1NzE4MzYxNGY1 MzM1MjIwMzA2NjBkMjEyZDc5YTYuLjA0ODUyNzhlNWIwMjUzNThmMWMwZmNlYmRiOGRkYTYyNWE4 ODUxZTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1BsYXRmb3JtL0NvcmVJUEMvTWVzc2Fn ZVNlbmRlci5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1BsYXRmb3JtL0NvcmVJUEMvTWVzc2FnZVNl bmRlci5oCkBAIC00MiwyNCArNDIsMjYgQEAgcHVibGljOgogCiAgICAgdGVtcGxhdGU8dHlwZW5h bWUgVT4gYm9vbCBzZW5kKGNvbnN0IFUmIG1lc3NhZ2UsIHVpbnQ2NF90IGRlc3RpbmF0aW9uSUQp CiAgICAgewotICAgICAgICBDT01QSUxFX0FTU0VSVCghVTo6aXNTeW5jLCBBc3luY01lc3NhZ2VF eHBlY3RlZCk7CisgICAgICAgIHN0YXRpY19hc3NlcnQoIVU6OmlzU3luYywgIk1lc3NhZ2UgaXMg c3luYyEiKTsKKwogICAgICAgICBhdXRvIGVuY29kZXIgPSBzdGQ6Om1ha2VfdW5pcXVlPE1lc3Nh Z2VFbmNvZGVyPihVOjpyZWNlaXZlck5hbWUoKSwgVTo6bmFtZSgpLCBkZXN0aW5hdGlvbklEKTsK ICAgICAgICAgZW5jb2Rlci0+ZW5jb2RlKG1lc3NhZ2UpOwogICAgICAgICAKICAgICAgICAgcmV0 dXJuIHNlbmRNZXNzYWdlKHN0ZDo6bW92ZShlbmNvZGVyKSk7CiAgICAgfQogCi0gICAgdGVtcGxh dGU8dHlwZW5hbWUgVT4gYm9vbCBzZW5kU3luYyhjb25zdCBVJiBtZXNzYWdlLCBjb25zdCB0eXBl bmFtZSBVOjpSZXBseSYgcmVwbHksIGRvdWJsZSB0aW1lb3V0ID0gQ29ubmVjdGlvbjo6Tm9UaW1l b3V0KQorICAgIHRlbXBsYXRlPHR5cGVuYW1lIFU+IGJvb2wgc2VuZFN5bmMoY29uc3QgVSYgbWVz c2FnZSwgdHlwZW5hbWUgVTo6UmVwbHkmJiByZXBseSwgZG91YmxlIHRpbWVvdXQgPSBDb25uZWN0 aW9uOjpOb1RpbWVvdXQpCiAgICAgewotICAgICAgICBDT01QSUxFX0FTU0VSVChVOjppc1N5bmMs IFN5bmNNZXNzYWdlRXhwZWN0ZWQpOwotICAgICAgICByZXR1cm4gc2VuZFN5bmMobWVzc2FnZSwg cmVwbHksIG1lc3NhZ2VTZW5kZXJEZXN0aW5hdGlvbklEKCksIHRpbWVvdXQpOworICAgICAgICBz dGF0aWNfYXNzZXJ0KFU6OmlzU3luYywgIk1lc3NhZ2UgaXMgbm90IHN5bmMhIik7CisKKyAgICAg ICAgcmV0dXJuIHNlbmRTeW5jKG1lc3NhZ2UsIHN0ZDo6bW92ZShyZXBseSksIG1lc3NhZ2VTZW5k ZXJEZXN0aW5hdGlvbklEKCksIHRpbWVvdXQpOwogICAgIH0KIAotICAgIHRlbXBsYXRlPHR5cGVu YW1lIFU+IGJvb2wgc2VuZFN5bmMoY29uc3QgVSYgbWVzc2FnZSwgY29uc3QgdHlwZW5hbWUgVTo6 UmVwbHkmIHJlcGx5LCB1aW50NjRfdCBkZXN0aW5hdGlvbklELCBkb3VibGUgdGltZW91dCA9IENv bm5lY3Rpb246Ok5vVGltZW91dCkKKyAgICB0ZW1wbGF0ZTx0eXBlbmFtZSBVPiBib29sIHNlbmRT eW5jKGNvbnN0IFUmIG1lc3NhZ2UsIHR5cGVuYW1lIFU6OlJlcGx5JiYgcmVwbHksIHVpbnQ2NF90 IGRlc3RpbmF0aW9uSUQsIGRvdWJsZSB0aW1lb3V0ID0gQ29ubmVjdGlvbjo6Tm9UaW1lb3V0KQog ICAgIHsKICAgICAgICAgQVNTRVJUKG1lc3NhZ2VTZW5kZXJDb25uZWN0aW9uKCkpOwogCi0gICAg ICAgIHJldHVybiBtZXNzYWdlU2VuZGVyQ29ubmVjdGlvbigpLT5zZW5kU3luYyhtZXNzYWdlLCBy ZXBseSwgZGVzdGluYXRpb25JRCwgdGltZW91dCk7CisgICAgICAgIHJldHVybiBtZXNzYWdlU2Vu ZGVyQ29ubmVjdGlvbigpLT5zZW5kU3luYyhtZXNzYWdlLCBzdGQ6Om1vdmUocmVwbHkpLCBkZXN0 aW5hdGlvbklELCB0aW1lb3V0KTsKICAgICB9CiAKICAgICBib29sIHNlbmRNZXNzYWdlKHN0ZDo6 dW5pcXVlX3B0cjxNZXNzYWdlRW5jb2Rlcj4pOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIv U2hhcmVkL0NoaWxkUHJvY2Vzc1Byb3h5LmggYi9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvQ2hpbGRQ cm9jZXNzUHJveHkuaAppbmRleCBkMDA0NzQ5MTVjMjg4OGM3Y2I5YTEzZDlkZTQ3NWIwMTI1MDky M2YwLi45ODEwNGQxMWFkNDNjNzY0ZGUzYWM2NGEzZGU2M2EyYTAzZjkyNTlmIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvQ2hpbGRQcm9jZXNzUHJveHkuaAorKysgYi9Tb3VyY2Uv V2ViS2l0Mi9TaGFyZWQvQ2hpbGRQcm9jZXNzUHJveHkuaApAQCAtNDgsNyArNDgsNyBAQCBwdWJs aWM6CiAgICAgdm9pZCB0ZXJtaW5hdGUoKTsKIAogICAgIHRlbXBsYXRlPHR5cGVuYW1lIFQ+IGJv b2wgc2VuZChjb25zdCBUJiBtZXNzYWdlLCB1aW50NjRfdCBkZXN0aW5hdGlvbklELCB1bnNpZ25l ZCBtZXNzYWdlU2VuZEZsYWdzID0gMCk7Ci0gICAgdGVtcGxhdGU8dHlwZW5hbWUgVT4gYm9vbCBz ZW5kU3luYyhjb25zdCBVJiBtZXNzYWdlLCBjb25zdCB0eXBlbmFtZSBVOjpSZXBseSYsIHVpbnQ2 NF90IGRlc3RpbmF0aW9uSUQsIGRvdWJsZSB0aW1lb3V0ID0gMSk7CisgICAgdGVtcGxhdGU8dHlw ZW5hbWUgVT4gYm9vbCBzZW5kU3luYyhjb25zdCBVJiBtZXNzYWdlLCB0eXBlbmFtZSBVOjpSZXBs eSYmLCB1aW50NjRfdCBkZXN0aW5hdGlvbklELCBkb3VibGUgdGltZW91dCA9IDEpOwogICAgIAog ICAgIENvcmVJUEM6OkNvbm5lY3Rpb24qIGNvbm5lY3Rpb24oKSBjb25zdAogICAgIHsKQEAgLTEw MSwxNCArMTAxLDE0IEBAIGJvb2wgQ2hpbGRQcm9jZXNzUHJveHk6OnNlbmQoY29uc3QgVCYgbWVz c2FnZSwgdWludDY0X3QgZGVzdGluYXRpb25JRCwgdW5zaWduZWQKIH0KIAogdGVtcGxhdGU8dHlw ZW5hbWUgVT4gCi1ib29sIENoaWxkUHJvY2Vzc1Byb3h5OjpzZW5kU3luYyhjb25zdCBVJiBtZXNz YWdlLCBjb25zdCB0eXBlbmFtZSBVOjpSZXBseSYgcmVwbHksIHVpbnQ2NF90IGRlc3RpbmF0aW9u SUQsIGRvdWJsZSB0aW1lb3V0KQorYm9vbCBDaGlsZFByb2Nlc3NQcm94eTo6c2VuZFN5bmMoY29u c3QgVSYgbWVzc2FnZSwgdHlwZW5hbWUgVTo6UmVwbHkmJiByZXBseSwgdWludDY0X3QgZGVzdGlu YXRpb25JRCwgZG91YmxlIHRpbWVvdXQpCiB7CiAgICAgQ09NUElMRV9BU1NFUlQoVTo6aXNTeW5j LCBTeW5jTWVzc2FnZUV4cGVjdGVkKTsKIAogICAgIGlmICghbV9jb25uZWN0aW9uKQogICAgICAg ICByZXR1cm4gZmFsc2U7CiAKLSAgICByZXR1cm4gY29ubmVjdGlvbigpLT5zZW5kU3luYyhtZXNz YWdlLCByZXBseSwgZGVzdGluYXRpb25JRCwgdGltZW91dCk7CisgICAgcmV0dXJuIGNvbm5lY3Rp b24oKS0+c2VuZFN5bmMobWVzc2FnZSwgc3RkOjptb3ZlKHJlcGx5KSwgZGVzdGluYXRpb25JRCwg dGltZW91dCk7CiB9CiAKIH0gLy8gbmFtZXNwYWNlIFdlYktpdAo=