121862 2013-09-24 13:27:56 -0700 Web Inspector: Using Breakpoint Actions Breaks iOS inspection 2013-09-24 14:22:25 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue graouts joepeck timothy webkit-bug-importer oldest_to_newest 932696 0 joepeck 2013-09-24 13:27:56 -0700 Oops. Check for DebuggerAgent.BreakpointActionType before using it when converting between frontend <-> protocol BreakpointAction types. So backends that support BreakpointActions will use it, but backends that don't we won't. 932697 1 webkit-bug-importer 2013-09-24 13:28:40 -0700 <rdar://problem/15069437> 932699 2 212498 joepeck 2013-09-24 13:29:34 -0700 Created attachment 212498 [PATCH] Proposed Fix 932719 3 212498 commit-queue 2013-09-24 14:22:23 -0700 Comment on attachment 212498 [PATCH] Proposed Fix Clearing flags on attachment: 212498 Committed r156358: <http://trac.webkit.org/changeset/156358> 932720 4 commit-queue 2013-09-24 14:22:25 -0700 All reviewed patches have been landed. Closing bug. 212498 2013-09-24 13:29:34 -0700 2013-09-24 14:22:23 -0700 [PATCH] Proposed Fix fix.patch text/plain 2131 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDUzODAzNGUuLjk2NGFlYzUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAyMDEzLTA5LTI0ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogVXNpbmcg QnJlYWtwb2ludCBBY3Rpb25zIEJyZWFrcyBpT1MgaW5zcGVjdGlvbgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIxODYyCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgT25seSB1c2UgRGVidWdnZXJBZ2VudC5C cmVha3BvaW50QWN0aW9uVHlwZSBpZiBpdCBpcyBhdmFpbGFibGUuCisgICAgICAgIE90aGVyd2lz ZSBsZWF2ZSBvcHRpb25zIHVuZGVmaW5lZCBmb3IgYnJlYWtwb2ludHMgc2luY2UgdGhlIGJhY2tl bmQKKyAgICAgICAgZG9lcyBub3Qgc3VwcG9ydCBpdC4KKworICAgICAgICAqIFVzZXJJbnRlcmZh Y2UvRGVidWdnZXJNYW5hZ2VyLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkRlYnVnZ2VyTWFu YWdlci5wcm90b3R5cGUuX3NldEJyZWFrcG9pbnQpOgorCisyMDEzLTA5LTI0ICBKb3NlcGggUGVj b3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKICAgICAgICAgV2ViIEluc3BlY3RvcjogSW5j bHVkZSBpT1MgNyBJbnNwZWN0b3IuanNvbiBWZXJzaW9uCiAgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjE4NTIKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dl Ykluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvRGVidWdnZXJNYW5hZ2VyLmpzIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvRGVidWdnZXJNYW5hZ2VyLmpzCmluZGV4IDBiZGNk NTQuLjQyZTAxZTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJm YWNlL0RlYnVnZ2VyTWFuYWdlci5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlcklu dGVyZmFjZS9EZWJ1Z2dlck1hbmFnZXIuanMKQEAgLTUxNCwxMCArNTE0LDEzIEBAIFdlYkluc3Bl Y3Rvci5EZWJ1Z2dlck1hbmFnZXIucHJvdG90eXBlID0gewogCiAgICAgICAgIC8vIENvbnZlcnQg QnJlYWtwb2ludEFjdGlvbiB0eXBlcyB0byBEZWJ1Z2dlckFnZW50IHByb3RvY29sIHR5cGVzLgog ICAgICAgICAvLyBOT1RFOiBCcmVha3BvaW50Lm9wdGlvbnMgcmV0dXJucyBuZXcgb2JqZWN0cyBl YWNoIHRpbWUsIHNvIGl0IGlzIHNhZmUgdG8gbW9kaWZ5LgotICAgICAgICB2YXIgb3B0aW9ucyA9 IGJyZWFrcG9pbnQub3B0aW9uczsKLSAgICAgICAgaWYgKG9wdGlvbnMuYWN0aW9ucy5sZW5ndGgp IHsKLSAgICAgICAgICAgIGZvciAodmFyIGkgPSAwOyBpIDwgb3B0aW9ucy5hY3Rpb25zLmxlbmd0 aDsgKytpKQotICAgICAgICAgICAgICAgIG9wdGlvbnMuYWN0aW9uc1tpXS50eXBlID0gdGhpcy5f ZGVidWdnZXJCcmVha3BvaW50QWN0aW9uVHlwZShvcHRpb25zLmFjdGlvbnNbaV0udHlwZSk7Cisg ICAgICAgIHZhciBvcHRpb25zOworICAgICAgICBpZiAoRGVidWdnZXJBZ2VudC5CcmVha3BvaW50 QWN0aW9uVHlwZSkgeworICAgICAgICAgICAgb3B0aW9ucyA9IGJyZWFrcG9pbnQub3B0aW9uczsK KyAgICAgICAgICAgIGlmIChvcHRpb25zLmFjdGlvbnMubGVuZ3RoKSB7CisgICAgICAgICAgICAg ICAgZm9yICh2YXIgaSA9IDA7IGkgPCBvcHRpb25zLmFjdGlvbnMubGVuZ3RoOyArK2kpCisgICAg ICAgICAgICAgICAgICAgIG9wdGlvbnMuYWN0aW9uc1tpXS50eXBlID0gdGhpcy5fZGVidWdnZXJC cmVha3BvaW50QWN0aW9uVHlwZShvcHRpb25zLmFjdGlvbnNbaV0udHlwZSk7CisgICAgICAgICAg ICB9CiAgICAgICAgIH0KIAogICAgICAgICAvLyBDT01QQVRJQklMSVRZIChpT1MgNyk6IGlPUyA3 IGFuZCBlYXJsaWVyLCBEZWJ1Z2dlckFnZW50LnNldEJyZWFrcG9pbnQqIHRvb2sgYSAiY29uZGl0 aW9uIiBzdHJpbmcgYXJndW1lbnQuCg==