121837 2013-09-24 06:04:51 -0700 [WIN] Add executable entry points to DRT and WinLauncher 2013-10-30 12:09:03 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 paroga paroga commit-queue oldest_to_newest 932515 0 paroga 2013-09-24 06:04:51 -0700 [WIN] Add executable entry points to DRT and WinLauncher 932518 1 212457 paroga 2013-09-24 06:07:52 -0700 Created attachment 212457 Patch 933134 2 212457 bfulgham 2013-09-25 11:44:38 -0700 Comment on attachment 212457 Patch What is the point of this patch? Why do you want to move away from the simple loader program running a separate DLL? 933141 3 paroga 2013-09-25 11:54:43 -0700 (In reply to comment #2) > (From update of attachment 212457 [details]) > What is the point of this patch? Why do you want to move away from the simple loader program running a separate DLL? a) makes SLN files "smaller" and easier to understand b) DLLLauncher is IMHO a workaround for Apple DLLs: - Embeds the MSVC80 CRT manifest - Requires that the path to the Apple DLLs exist on the system 944963 4 212457 bfulgham 2013-10-30 10:16:58 -0700 Comment on attachment 212457 Patch We will not accept this patch, as it removes functionality we need. 944967 5 212457 paroga 2013-10-30 10:21:25 -0700 Comment on attachment 212457 Patch (In reply to comment #4) > (From update of attachment 212457 [details]) > We will not accept this patch, as it removes functionality we need. It does not remove functionality! It's ok that the Apple port needs the *Launcher applications, but the Cairo port does not. Having additional binaries adds no value there. I don't see a big problem in splitting this function, so the build system can decide how to link it (with or without *Launcher) 945062 6 212457 bfulgham 2013-10-30 11:25:35 -0700 Comment on attachment 212457 Patch r=me. 945108 7 212457 commit-queue 2013-10-30 12:09:00 -0700 Comment on attachment 212457 Patch Clearing flags on attachment: 212457 Committed r158302: <http://trac.webkit.org/changeset/158302> 945109 8 commit-queue 2013-10-30 12:09:03 -0700 All reviewed patches have been landed. Closing bug. 212457 2013-09-24 06:07:52 -0700 2013-10-30 12:09:00 -0700 Patch bug-121837.patch text/plain 2619 paroga ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAzYmFl MDgyLi41YWI0NDY4IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTMtMDktMjQgIFBhdHJpY2sgR2Fuc3RlcmVyICA8 cGFyb2dhQHdlYmtpdC5vcmc+CisKKyAgICAgICAgW1dJTl0gQWRkIGV4ZWN1dGFibGUgZW50cnkg cG9pbnRzIHRvIERSVCBhbmQgV2luTGF1bmNoZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMTgzNworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgYWxsb3dzIHRvIGNvbXBpbGUgYW5kIHJ1biB0aGUg ZXhlY3V0YWJsZXMgd2l0aG91dCBETExMYXVuY2hlci4KKworICAgICAgICAqIER1bXBSZW5kZXJU cmVlL3dpbi9EdW1wUmVuZGVyVHJlZS5jcHA6CisgICAgICAgIChtYWluKToKKyAgICAgICAgKGRs bExhdW5jaGVyRW50cnlQb2ludCk6CisgICAgICAgICogV2luTGF1bmNoZXIvV2luTGF1bmNoZXIu Y3BwOgorICAgICAgICAod1dpbk1haW4pOgorICAgICAgICAoZGxsTGF1bmNoZXJFbnRyeVBvaW50 KToKKwogMjAxMy0wOS0xNCAgUGF0cmljayBHYW5zdGVyZXIgIDxwYXJvZ2FAd2Via2l0Lm9yZz4K IAogICAgICAgICBBZGQgQ01ha2UgYmFzZSBidWlsZCBzeXN0ZW0gZm9yIFdpbkNhaXJvIHBvcnQK ZGlmZiAtLWdpdCBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL3dpbi9EdW1wUmVuZGVyVHJlZS5jcHAg Yi9Ub29scy9EdW1wUmVuZGVyVHJlZS93aW4vRHVtcFJlbmRlclRyZWUuY3BwCmluZGV4IDYwOTgx ZTEuLmZiNjNjZDMgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL3dpbi9EdW1wUmVu ZGVyVHJlZS5jcHAKKysrIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvd2luL0R1bXBSZW5kZXJUcmVl LmNwcApAQCAtMTMwNiw3ICsxMzA2LDcgQEAgc3RhdGljIExPTkcgV0lOQVBJIGV4Y2VwdGlvbkZp bHRlcihFWENFUFRJT05fUE9JTlRFUlMqKQogICAgIHJldHVybiBFWENFUFRJT05fQ09OVElOVUVf U0VBUkNIOwogfQogCi1leHRlcm4gIkMiIF9fZGVjbHNwZWMoZGxsZXhwb3J0KSBpbnQgV0lOQVBJ IGRsbExhdW5jaGVyRW50cnlQb2ludChpbnQgYXJnYywgY29uc3QgY2hhciogYXJndltdKQoraW50 IG1haW4oaW50IGFyZ2MsIGNvbnN0IGNoYXIqIGFyZ3ZbXSkKIHsKICAgICAvLyBDeWd3aW4gY2Fs bHMgOjpTZXRFcnJvck1vZGUoU0VNX0ZBSUxDUklUSUNBTEVSUk9SUyksIHdoaWNoIHdlIHdpbGwg aW5oZXJpdC4gVGhpcyBpcyBiYWQgZm9yCiAgICAgLy8gdGVzdGluZy9kZWJ1Z2dpbmcsIGFzIGl0 IGNhdXNlcyB0aGUgcG9zdC1tb3J0ZW0gZGVidWdnZXIgbm90IHRvIGJlIGludm9rZWQuIFdlIHJl c2V0IHRoZQpAQCAtMTQ2OSwzICsxNDY5LDggQEAgZXh0ZXJuICJDIiBfX2RlY2xzcGVjKGRsbGV4 cG9ydCkgaW50IFdJTkFQSSBkbGxMYXVuY2hlckVudHJ5UG9pbnQoaW50IGFyZ2MsIGNvbnMKIAog ICAgIHJldHVybiAwOwogfQorCitleHRlcm4gIkMiIF9fZGVjbHNwZWMoZGxsZXhwb3J0KSBpbnQg V0lOQVBJIGRsbExhdW5jaGVyRW50cnlQb2ludChpbnQgYXJnYywgY29uc3QgY2hhciogYXJndltd KQoreworICAgIHJldHVybiBtYWluKGFyZ2MsIGFyZ3YpOworfQpkaWZmIC0tZ2l0IGEvVG9vbHMv V2luTGF1bmNoZXIvV2luTGF1bmNoZXIuY3BwIGIvVG9vbHMvV2luTGF1bmNoZXIvV2luTGF1bmNo ZXIuY3BwCmluZGV4IDMwZTdkZDUuLjExNzBjNzcgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1dpbkxhdW5j aGVyL1dpbkxhdW5jaGVyLmNwcAorKysgYi9Ub29scy9XaW5MYXVuY2hlci9XaW5MYXVuY2hlci5j cHAKQEAgLTQxMyw3ICs0MTMsNyBAQCBzdGF0aWMgYm9vbCBzZXRUb0RlZmF1bHRQcmVmZXJlbmNl cygpCiBleHRlcm4gIkMiIHZvaWQgX0NGUnVuTG9vcFNldFdpbmRvd3NNZXNzYWdlUXVldWVNYXNr KENGUnVuTG9vcFJlZiwgdWludDMyX3QsIENGU3RyaW5nUmVmKTsKICNlbmRpZgogCi1leHRlcm4g IkMiIF9fZGVjbHNwZWMoZGxsZXhwb3J0KSBpbnQgV0lOQVBJIGRsbExhdW5jaGVyRW50cnlQb2lu dChISU5TVEFOQ0UsIEhJTlNUQU5DRSwgTFBUU1RSLCBpbnQgbkNtZFNob3cpCitpbnQgV0lOQVBJ IHdXaW5NYWluKEhJTlNUQU5DRSwgSElOU1RBTkNFLCBQV1NUUiwgaW50IG5DbWRTaG93KQogewog I2lmZGVmIF9DUlREQkdfTUFQX0FMTE9DCiAgICAgX0NydFNldFJlcG9ydEZpbGUoX0NSVF9XQVJO LCBfQ1JUREJHX0ZJTEVfU1RERVJSKTsKQEAgLTk2NiwzICs5NjYsOCBAQCBzdGF0aWMgdm9pZCBs b2FkVVJMKEJTVFIgdXJsQlN0cikKIAogICAgIFNldEZvY3VzKGdWaWV3V2luZG93KTsKIH0KKwor ZXh0ZXJuICJDIiBfX2RlY2xzcGVjKGRsbGV4cG9ydCkgaW50IFdJTkFQSSBkbGxMYXVuY2hlckVu dHJ5UG9pbnQoSElOU1RBTkNFIGhJbnN0YW5jZSwgSElOU1RBTkNFIGhQcmV2SW5zdGFuY2UsIExQ V1NUUiBscHN0ckNtZExpbmUsIGludCBuQ21kU2hvdykKK3sKKyAgICByZXR1cm4gd1dpbk1haW4o aEluc3RhbmNlLCBoUHJldkluc3RhbmNlLCBscHN0ckNtZExpbmUsIG5DbWRTaG93KTsKK30K