121834 2013-09-24 04:03:05 -0700 [WIN] Add missing USE(CFNETWORK) to WebError.h 2013-10-30 10:31:57 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 paroga paroga commit-queue oldest_to_newest 932492 0 paroga 2013-09-24 04:03:05 -0700 [WIN] Add missing USE(CFNETWORK) to WebError.h 932493 1 212450 paroga 2013-09-24 04:05:37 -0700 Created attachment 212450 Patch 933132 2 212450 bfulgham 2013-09-25 11:43:45 -0700 Comment on attachment 212450 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=212450&action=review This should be USE(CF), as it's a CFDictionaryRef we are trying to protect against. > Source/WebKit/win/WebError.h:93 > +#if USE(CFNETWORK) This should be USE(CF), as it's a CFDictionaryRef we are trying to protect against. 933142 3 212450 paroga 2013-09-25 11:56:45 -0700 Comment on attachment 212450 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=212450&action=review >> Source/WebKit/win/WebError.h:93 >> +#if USE(CFNETWORK) > > This should be USE(CF), as it's a CFDictionaryRef we are trying to protect against. But it's only used by CFNETWORK code. See http://trac.webkit.org/browser/trunk/Source/WebKit/win/WebError.cpp?rev=149716#L218 944961 4 212450 bfulgham 2013-10-30 10:13:03 -0700 Comment on attachment 212450 Patch Okay. r=me 944985 5 212450 commit-queue 2013-10-30 10:31:56 -0700 Comment on attachment 212450 Patch Clearing flags on attachment: 212450 Committed r158278: <http://trac.webkit.org/changeset/158278> 944986 6 commit-queue 2013-10-30 10:31:57 -0700 All reviewed patches have been landed. Closing bug. 212450 2013-09-24 04:05:37 -0700 2013-10-30 10:31:56 -0700 Patch bug-121834.patch text/plain 999 paroga ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvd2luL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv d2luL0NoYW5nZUxvZwppbmRleCBjNzFjNTBlLi4wN2U1NjljIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L3dpbi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC93aW4vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTQgQEAKKzIwMTMtMDktMjQgIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dhQHdl YmtpdC5vcmc+CisKKyAgICAgICAgW1dJTl0gQWRkIG1pc3NpbmcgVVNFKENGTkVUV09SSykgdG8g V2ViRXJyb3IuaAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTIxODM0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgV2ViRXJyb3IuY3BwIHVzZXMgVVNFKENGTkVUV09SSyksIHNvIGFkZCBpdCB0byB0aGUgaGVh ZGVyIHRvby4KKworICAgICAgICAqIFdlYkVycm9yLmg6CisKIDIwMTMtMDktMjQgIFBhdHJpY2sg R2Fuc3RlcmVyICA8cGFyb2dhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgW1dJTl0gUmVkdWNlIHVz YWdlIG9mIENGU1RSKCkgaW4gV2ViUHJlZmVyZW5jZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQvd2luL1dlYkVycm9yLmggYi9Tb3VyY2UvV2ViS2l0L3dpbi9XZWJFcnJvci5oCmluZGV4IDBl NzhjZjIuLjAxNmVhN2QgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvd2luL1dlYkVycm9yLmgK KysrIGIvU291cmNlL1dlYktpdC93aW4vV2ViRXJyb3IuaApAQCAtOTAsNyArOTAsOSBAQCBwdWJs aWM6CiBwcml2YXRlOgogICAgIFVMT05HIG1fcmVmQ291bnQ7CiAgICAgQ09NUHRyPElQcm9wZXJ0 eUJhZz4gbV91c2VySW5mbzsKKyNpZiBVU0UoQ0ZORVRXT1JLKQogICAgIFJldGFpblB0cjxDRkRp Y3Rpb25hcnlSZWY+IG1fY2ZFcnJvclVzZXJJbmZvRGljdDsKKyNlbmRpZgogICAgIFdlYkNvcmU6 OlJlc291cmNlRXJyb3IgbV9lcnJvcjsKIH07CiAK