121826 2013-09-24 00:46:08 -0700 [EFL] Build failed at ProcessLauncherEfl.cpp 2013-09-24 07:24:02 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Linux RESOLVED FIXED P2 Normal --- 1 changseok changseok cdumez commit-queue gyuyoung.kim gyuyoung.kim lucas.de.marchi rakuco oldest_to_newest 932455 0 changseok 2013-09-24 00:46:08 -0700 Build command: ./Tools/Scripts/build-webkit --efl --prefix=/usr/local --makeargs="-j8 -Wno-deprecated-declarations" --no-svg --datalist-element [ 94%] Building CXX object Source/WebKit2/CMakeFiles/WebKit2.dir/UIProcess/Plugins/unix/PluginProcessProxyUnix.cpp.o [ 94%] Building CXX object Source/WebKit2/CMakeFiles/WebKit2.dir/UIProcess/Storage/StorageManager.cpp.o /home/shivamidow/Projects/WebKit/Source/WebKit2/UIProcess/Launcher/efl/ProcessLauncherEfl.cpp: In member function ‘void WebKit::ProcessLauncher::launchProcess()’: /home/shivamidow/Projects/WebKit/Source/WebKit2/UIProcess/Launcher/efl/ProcessLauncherEfl.cpp:70:20: error: ‘AF_UNIX’ was not declared in this scope /home/shivamidow/Projects/WebKit/Source/WebKit2/UIProcess/Launcher/efl/ProcessLauncherEfl.cpp:70:29: error: ‘SOCK_STREAM’ was not declared in this scope /home/shivamidow/Projects/WebKit/Source/WebKit2/UIProcess/Launcher/efl/ProcessLauncherEfl.cpp:70:52: error: ‘socketpair’ was not declared in this scope make[2]: *** [Source/WebKit2/CMakeFiles/WebKit2.dir/UIProcess/Launcher/efl/ProcessLauncherEfl.cpp.o] Error 1 make[2]: *** Waiting for unfinished jobs.... make[1]: *** [Source/WebKit2/CMakeFiles/WebKit2.dir/all] Error 2 make: *** [all] Error 2 I guess proper headers are missing. 932456 1 212435 changseok 2013-09-24 00:50:05 -0700 Created attachment 212435 Patch 932504 2 212435 gyuyoung.kim 2013-09-24 05:28:35 -0700 Comment on attachment 212435 Patch In build fix patch case, you don't need to get review. Look at other "Unreviewed build fix patch". 932505 3 212435 gyuyoung.kim 2013-09-24 05:29:42 -0700 Comment on attachment 212435 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=212435&action=review > Source/WebKit2/ChangeLog:8 > + Fixed a build failure with adding socket.h. It would be good if you mention what revision makes a build break. 932531 4 changseok 2013-09-24 06:45:43 -0700 (In reply to comment #3) > (From update of attachment 212435 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=212435&action=review > > > Source/WebKit2/ChangeLog:8 > > + Fixed a build failure with adding socket.h. > > It would be good if you mention what revision makes a build break. I know. if this happened to gtk port, I would do like that "Unreviewed fix". On my side, I'm a just newbie to efl port, so it's hard to know what happens after my last build for efl port almost a year ago.. :p 932532 5 gyuyoung.kim 2013-09-24 06:48:56 -0700 (In reply to comment #4) > (In reply to comment #3) > > (From update of attachment 212435 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=212435&action=review > > > > > Source/WebKit2/ChangeLog:8 > > > + Fixed a build failure with adding socket.h. > > > > It would be good if you mention what revision makes a build break. > > I know. if this happened to gtk port, I would do like that "Unreviewed fix". > On my side, I'm a just newbie to efl port, so it's hard to know what happens after my last build for efl port almost a year ago.. :p Ok, I see. Go ahead. 932546 6 212435 commit-queue 2013-09-24 07:23:59 -0700 Comment on attachment 212435 Patch Clearing flags on attachment: 212435 Committed r156333: <http://trac.webkit.org/changeset/156333> 932547 7 commit-queue 2013-09-24 07:24:02 -0700 All reviewed patches have been landed. Closing bug. 212435 2013-09-24 00:50:05 -0700 2013-09-24 07:23:59 -0700 Patch bug-121826-20130924165003.patch text/plain 1307 changseok U3VidmVyc2lvbiBSZXZpc2lvbjogMTU2MzE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggODI5ZDU2NTk5NjJjOTI0 YzQ4OTk5YmQxMzUwNDViZmZkNGI4NTUxNC4uYTczYjdjM2Q1OGY2ODc2ZmNlNmM3ZTBjMzI0ZWVm NDdmMDNlZTQ0OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEzLTA5LTI0ICBDaGFu Z1Nlb2sgT2ggIDxjaGFuZ3Nlb2sub2hAY29sbGFib3JhLmNvbT4KKworICAgICAgICBbRUZMXSBC dWlsZCBmYWlsZWQgYXQgUHJvY2Vzc0xhdW5jaGVyRWZsLmNwcAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIxODI2CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4ZWQgYSBidWlsZCBmYWlsdXJlIHdpdGgg YWRkaW5nIHNvY2tldC5oLgorCisgICAgICAgICogVUlQcm9jZXNzL0xhdW5jaGVyL2VmbC9Qcm9j ZXNzTGF1bmNoZXJFZmwuY3BwOgorCiAyMDEzLTA5LTIzICBQYXRyaWNrIEdhbnN0ZXJlciAgPHBh cm9nYUB3ZWJraXQub3JnPgogCiAgICAgICAgIHVzZSBOT01JTk1BWCBpbnN0ZWFkIG9mICNkZWZp bmUgbWluIG1pbgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0xhdW5jaGVy L2VmbC9Qcm9jZXNzTGF1bmNoZXJFZmwuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0xh dW5jaGVyL2VmbC9Qcm9jZXNzTGF1bmNoZXJFZmwuY3BwCmluZGV4IDI2ZjdmMGY5MGIyZTM3MmQ1 Yjg1NjY4NmY3NjM4ZGY3NjRlNjk0OTguLjNiZDFlYTYwM2UzMTg4YjQzYzMwNTk1NTUxNmY3MTcx ZmVhNmQ0MjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9MYXVuY2hlci9l ZmwvUHJvY2Vzc0xhdW5jaGVyRWZsLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv TGF1bmNoZXIvZWZsL1Byb2Nlc3NMYXVuY2hlckVmbC5jcHAKQEAgLTI4LDYgKzI4LDcgQEAKICNp bmNsdWRlIDxXZWJDb3JlL05ldHdvcmtpbmdDb250ZXh0Lmg+CiAjaW5jbHVkZSA8V2ViQ29yZS9S ZXNvdXJjZUhhbmRsZS5oPgogI2luY2x1ZGUgPFdlYkNvcmUvUnVuTG9vcC5oPgorI2luY2x1ZGUg PHN5cy9zb2NrZXQuaD4KICNpbmNsdWRlIDx3dGYvU3RkTGliRXh0cmFzLmg+CiAjaW5jbHVkZSA8 d3RmL3RleHQvQ1N0cmluZy5oPgogI2luY2x1ZGUgPHd0Zi90ZXh0L1dURlN0cmluZy5oPgo=