121799 2013-09-23 12:44:47 -0700 webkitdirs.pm needs --64-bit option for automated Win64 build 2013-11-18 17:29:34 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Windows 7 RESOLVED FIXED InRadar P2 Normal --- 0 alex.christensen webkit-unassigned bfulgham commit-queue dbates mrowe oldest_to_newest 932254 0 alex.christensen 2013-09-23 12:44:47 -0700 In order to automate Win64 builds, I need a way to put "|x64" at the end of the Visual Studio configuration. Visual Studio defaults to Win32, so there's no need to put "|Win32" at the end of the configuration, unless someone thinks we should be that explicit. 932256 1 212382 alex.christensen 2013-09-23 12:46:14 -0700 Created attachment 212382 Patch 932258 2 212382 bfulgham 2013-09-23 13:07:31 -0700 Comment on attachment 212382 Patch Looks great to me. Let the EWS's run and if it looks good, go ahead and land it. 932268 3 212382 commit-queue 2013-09-23 13:37:27 -0700 Comment on attachment 212382 Patch Clearing flags on attachment: 212382 Committed r156290: <http://trac.webkit.org/changeset/156290> 932269 4 commit-queue 2013-09-23 13:37:29 -0700 All reviewed patches have been landed. Closing bug. 951905 5 bfulgham 2013-11-18 17:29:34 -0800 <rdar://problem/15498810> 212382 2013-09-23 12:46:14 -0700 2013-09-23 13:37:27 -0700 Patch bug-121799-20130923134750.patch text/plain 2355 alex.christensen SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE1NjI4NSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDEzLTA5LTIzICBBbGV4IENocmlzdGVuc2VuICA8YWxleC5jaHJpc3RlbnNl bkBmbGV4c2ltLmNvbT4KKworICAgICAgICBBZGRlZCAtLTY0LWJpdCBvcHRpb24gZm9yIFdpbmRv d3MgYnVpbGQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMjE3OTkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIFNjcmlwdHMvd2Via2l0ZGlycy5wbToKKyAgICAgICAgKGRldGVybWluZVBhc3NlZENvbmZp Z3VyYXRpb24pOiBBZGQgInx4NjQiIGZvciA2NC1iaXQgY29uZmlndXJhdGlvbi4KKyAgICAgICAg KGlzV2luNjQpOiBBZGRlZC4KKyAgICAgICAgKGRldGVybWluZUlzV2luNjQpOiBBZGRlZC4KKwog MjAxMy0wOS0yMyAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCiAgICAg ICAgIExpc3RIYXNoU2V0IHNob3VsZCB1c2Ugc3RkOjpyZXZlcnNlX2l0ZXJhdG9yIGZvciByZXZl cnNlIGl0ZXJhdG9ycwpJbmRleDogVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQkocmV2aXNpb24gMTU2MTE4KQorKysg VG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCSh3b3JraW5nIGNvcHkpCkBAIC05NCw2ICs5NCw3 IEBAIG15ICRxbWFrZWJpbiA9ICJxbWFrZSI7ICMgQWxsb3cgb3ZlcnJpZGUKIG15ICRpc0d0azsK IG15ICRpc1dpbkNFOwogbXkgJGlzV2luQ2Fpcm87CitteSAkaXNXaW42NDsKIG15ICRpc0VmbDsK IG15ICRpc0JsYWNrQmVycnk7CiBteSAkaXNJbnNwZWN0b3JGcm9udGVuZDsKQEAgLTYyMywxOCAr NjI0LDIxIEBAIHN1YiBkZXRlcm1pbmVQYXNzZWRDb25maWd1cmF0aW9uCiAgICAgICAgICAgICBz cGxpY2UoQEFSR1YsICRpLCAxKTsKICAgICAgICAgICAgICRwYXNzZWRDb25maWd1cmF0aW9uID0g IkRlYnVnIjsKICAgICAgICAgICAgICRwYXNzZWRDb25maWd1cmF0aW9uIC49ICJfV2luQ2Fpcm8i IGlmIChpc1dpbkNhaXJvKCkgJiYgaXNDeWd3aW4oKSk7CisgICAgICAgICAgICAkcGFzc2VkQ29u ZmlndXJhdGlvbiAuPSAifHg2NCIgaWYgaXNXaW42NCgpOwogICAgICAgICAgICAgcmV0dXJuOwog ICAgICAgICB9CiAgICAgICAgIGlmICgkb3B0ID1+IC9eLS1yZWxlYXNlJC9pKSB7CiAgICAgICAg ICAgICBzcGxpY2UoQEFSR1YsICRpLCAxKTsKICAgICAgICAgICAgICRwYXNzZWRDb25maWd1cmF0 aW9uID0gIlJlbGVhc2UiOwogICAgICAgICAgICAgJHBhc3NlZENvbmZpZ3VyYXRpb24gLj0gIl9X aW5DYWlybyIgaWYgKGlzV2luQ2Fpcm8oKSAmJiBpc0N5Z3dpbigpKTsKKyAgICAgICAgICAgICRw YXNzZWRDb25maWd1cmF0aW9uIC49ICJ8eDY0IiBpZiBpc1dpbjY0KCk7CiAgICAgICAgICAgICBy ZXR1cm47CiAgICAgICAgIH0KICAgICAgICAgaWYgKCRvcHQgPX4gL14tLXByb2ZpbChlfGluZykk L2kpIHsKICAgICAgICAgICAgIHNwbGljZShAQVJHViwgJGksIDEpOwogICAgICAgICAgICAgJHBh c3NlZENvbmZpZ3VyYXRpb24gPSAiUHJvZmlsaW5nIjsKICAgICAgICAgICAgICRwYXNzZWRDb25m aWd1cmF0aW9uIC49ICJfV2luQ2Fpcm8iIGlmIChpc1dpbkNhaXJvKCkgJiYgaXNDeWd3aW4oKSk7 CisgICAgICAgICAgICAkcGFzc2VkQ29uZmlndXJhdGlvbiAuPSAifHg2NCIgaWYgaXNXaW42NCgp OwogICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICB9CiAgICAgfQpAQCAtMTE5Nyw2ICsxMjAx LDE4IEBAIHN1YiBkZXRlcm1pbmVJc1dpbkNhaXJvKCkKICAgICAkaXNXaW5DYWlybyA9IGNoZWNr Rm9yQXJndW1lbnRBbmRSZW1vdmVGcm9tQVJHVigiLS13aW5jYWlybyIpOwogfQogCitzdWIgaXNX aW42NCgpCit7CisgICAgZGV0ZXJtaW5lSXNXaW42NCgpOworICAgIHJldHVybiAkaXNXaW42NDsK K30KKworc3ViIGRldGVybWluZUlzV2luNjQoKQoreworICAgIHJldHVybiBpZiBkZWZpbmVkKCRp c1dpbjY0KTsKKyAgICAkaXNXaW42NCA9IGNoZWNrRm9yQXJndW1lbnRBbmRSZW1vdmVGcm9tQVJH VigiLS02NC1iaXQiKTsKK30KKwogc3ViIGlzQ3lnd2luKCkKIHsKICAgICByZXR1cm4gKCReTyBl cSAiY3lnd2luIikgfHwgMDsK