121783 2013-09-23 04:42:34 -0700 [GTK][WK2] --disalble-credential-storage does not hide remember password checkbox 2015-07-07 10:04:34 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rego rego cgarcia mcatanzaro mrobinson oldest_to_newest 932106 0 rego 2013-09-23 04:42:34 -0700 In WebKitGTK+ 2.0.4 and WK2 --disalble-credential-storage does not hide the checkbox used to remember passwords. 932107 1 212340 rego 2013-09-23 04:46:20 -0700 Created attachment 212340 Patch 932108 2 rego 2013-09-23 04:53:07 -0700 (In reply to comment #1) > Created an attachment (id=212340) [details] > Patch Current patch applies in trunk and it's fixing the issue in the widget directly. There's a different alternative to fix this problem, similar to current code (that won't apply in trunk): diff --git a/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp b/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp index 0d9df77..bc43489 100644 --- a/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp +++ b/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp @@ -1740,10 +1740,13 @@ void webkitWebViewSubmitFormRequest(WebKitWebView* webView, WebKitFormSubmission void webkitWebViewHandleAuthenticationChallenge(WebKitWebView* webView, AuthenticationChallengeProxy* authenticationChallenge) { CredentialStorageMode credentialStorageMode; - if (webkit_settings_get_enable_private_browsing(webkit_web_view_get_settings(webView))) - credentialStorageMode = DisallowPersistentStorage; - else +#if ENABLE(CREDENTIAL_STORAGE) + if (!webkit_settings_get_enable_private_browsing(webkit_web_view_get_settings(webView))) credentialStorageMode = AllowPersistentStorage; + else +#else + credentialStorageMode = DisallowPersistentStorage; +#endif webkitWebViewBaseAddAuthenticationDialog(WEBKIT_WEB_VIEW_BASE(webView), webkitAuthenticationDialogNew(authenticationChallenge, credentialStorageMode)); } The new API has already a similar #if (see http://trac.webkit.org/browser/trunk/Source/WebKit2/UIProcess/API/gtk/WebKitAuthenticationRequest.cpp#L143). Please tell me your preferences and I can provide a different patch if required :-) 932128 3 mrobinson 2013-09-23 07:30:07 -0700 I think the alternative fix is the way to go. 932158 4 212353 rego 2013-09-23 09:03:38 -0700 Created attachment 212353 Patch Patch implementing the other alternative. Take into account that this doesn't apply in trunk. 932266 5 mrobinson 2013-09-23 13:26:50 -0700 Why won't the patch apply in trunk? 932267 6 rego 2013-09-23 13:33:57 -0700 (In reply to comment #5) > Why won't the patch apply in trunk? This code has changed, since we added the new API to configure the authentication dialogue. For example, see http://trac.webkit.org/browser/trunk/Source/WebKit2/UIProcess/API/gtk/WebKitAuthenticationRequest.cpp#L143 The problem is not present in trunk or in the last releases. So, this patch only apply in webkit-2.0 branch (or in a tar of our last stable release 2.0.4). 932279 7 mrobinson 2013-09-23 14:05:18 -0700 Ah, I see. Are we going to ship any more 2.0.x releases? 932297 8 rego 2013-09-23 14:43:31 -0700 (In reply to comment #7) > Ah, I see. Are we going to ship any more 2.0.x releases? According to CarlosGC yes. We've already merged some patches as you can see in: https://trac.webkit.org/wiki/WebKitGTK/2.0.x 1107466 9 mcatanzaro 2015-07-07 10:04:24 -0700 Obsolete -> fixed ? 212340 2013-09-23 04:46:20 -0700 2013-09-23 09:03:38 -0700 Patch bug-121783-20130923134747.patch text/plain 1759 rego U3VidmVyc2lvbiBSZXZpc2lvbjogMTU2MTQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzlhMzViY2NhODY2NDRh OTAwNTUwOTViNWE1OWVjOTA0NWM3YzhiYy4uZWE2MjkyZjk1OThkMWY1YjFhNWVhM2Q5ZWQ3NmM4 MTRkMzZiYWYyYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTA5LTIzICBNYW51 ZWwgUmVnbyBDYXNhc25vdmFzICA8cmVnb0BpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdW1dL Ml0gLS1kaXNhbGJsZS1jcmVkZW50aWFsLXN0b3JhZ2UgZG9lcyBub3QgaGlkZSByZW1lbWJlciBw YXNzd29yZCBjaGVja2JveAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTIxNzgzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgSGlkZSAicmVtZW1iZXIgcGFzc3dvcmQiIGNoZWNrYm94IGluIGF1dGhlbnRpY2F0 aW9uIHdpZGdldCB3aGVuCisgICAgICAgIGNyZWRlbnRpYWwgc3RvcmFnZSBpcyBkaXNhYmxlZC4K KworICAgICAgICAqIHBsYXRmb3JtL2d0ay9XZWJLaXRBdXRoZW50aWNhdGlvbldpZGdldC5jcHA6 CisgICAgICAgICh3ZWJraXRBdXRoZW50aWNhdGlvbldpZGdldEluaXRpYWxpemUpOgorCiAyMDEz LTA5LTE5ICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKICAgICAgICAg SGFuZGxlIG51bGwgZm9udCBmYW1pbGllcy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2d0ay9XZWJLaXRBdXRoZW50aWNhdGlvbldpZGdldC5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ndGsvV2ViS2l0QXV0aGVudGljYXRpb25XaWRnZXQuY3BwCmluZGV4IGU0N2Q1 OTk3ODcxYWQ5OGMzZmQyZjJkMGVkNGMwMDhjOThiNTU0YmUuLmQxOTNjZTQyNzUxNDdlMDc3NzFj ZjVlNjg2YjQ2MmI2NmQ4MzhjMzIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2d0ay9XZWJLaXRBdXRoZW50aWNhdGlvbldpZGdldC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3RrL1dlYktpdEF1dGhlbnRpY2F0aW9uV2lkZ2V0LmNwcApAQCAtMTgwLDcgKzE4 MCwxMSBAQCBzdGF0aWMgdm9pZCB3ZWJraXRBdXRoZW50aWNhdGlvbldpZGdldEluaXRpYWxpemUo V2ViS2l0QXV0aGVudGljYXRpb25XaWRnZXQqIGF1dAogICAgICAgICAgICAgTlVMTCk7CiAgICAg fQogICAgIGd0a19lbnRyeV9zZXRfdmlzaWJpbGl0eShHVEtfRU5UUlkocHJpdi0+cGFzc3dvcmRF bnRyeSksIEZBTFNFKTsKKyNpZiBFTkFCTEUoQ1JFREVOVElBTF9TVE9SQUdFKQogICAgIGd0a193 aWRnZXRfc2V0X3Zpc2libGUocHJpdi0+cmVtZW1iZXJDaGVja0J1dHRvbiwgcHJpdi0+Y3JlZGVu dGlhbFN0b3JhZ2VNb2RlICE9IERpc2FsbG93UGVyc2lzdGVudFN0b3JhZ2UpOworI2Vsc2UKKyAg ICBndGtfd2lkZ2V0X3NldF92aXNpYmxlKHByaXYtPnJlbWVtYmVyQ2hlY2tCdXR0b24sIEZBTFNF KTsKKyNlbmRpZgogCiAgICAgY29uc3QgQ3JlZGVudGlhbCYgY3JlZGVudGlhbEZyb21QZXJzaXN0 ZW50U3RvcmFnZSA9IHByaXYtPmNoYWxsZW5nZS5wcm9wb3NlZENyZWRlbnRpYWwoKTsKICAgICBp ZiAoIWNyZWRlbnRpYWxGcm9tUGVyc2lzdGVudFN0b3JhZ2UuaXNFbXB0eSgpKSB7Cg== 212353 2013-09-23 09:03:38 -0700 2015-07-07 10:04:34 -0700 Patch 0001-GTK-WK2-disalble-credential-storage-does-not-hide-re.patch text/plain 1880 rego ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBiYWJlMDdlLi4yYzg4MmExIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTMtMDktMjMgIE1hbnVlbCBSZWdvIENhc2Fzbm92YXMgIDxyZWdvQGlnYWxpYS5jb20+ CisKKyAgICAgICAgW0dUS11bV0syXSAtLWRpc2FsYmxlLWNyZWRlbnRpYWwtc3RvcmFnZSBkb2Vz IG5vdCBoaWRlIHJlbWVtYmVyIHBhc3N3b3JkIGNoZWNrYm94CisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjE3ODMKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBIaWRlICJyZW1lbWJlciBwYXNzd29yZCIgY2hl Y2tib3ggaW4gYXV0aGVudGljYXRpb24gd2lkZ2V0IHdoZW4KKyAgICAgICAgY3JlZGVudGlhbCBz dG9yYWdlIGlzIGRpc2FibGVkLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0 V2ViVmlldy5jcHA6CisgICAgICAgICh3ZWJraXRXZWJWaWV3SGFuZGxlQXV0aGVudGljYXRpb25D aGFsbGVuZ2UpOgorCiAyMDEzLTA4LTE0ICBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgIDxnbnNAZ25v bWUub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQgYnVpbGQgZml4LgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlldy5jcHAgYi9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3LmNwcAppbmRleCAwZDlkZjc3 Li5iYzQzNDg5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9X ZWJLaXRXZWJWaWV3LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9X ZWJLaXRXZWJWaWV3LmNwcApAQCAtMTc0MCwxMCArMTc0MCwxMyBAQCB2b2lkIHdlYmtpdFdlYlZp ZXdTdWJtaXRGb3JtUmVxdWVzdChXZWJLaXRXZWJWaWV3KiB3ZWJWaWV3LCBXZWJLaXRGb3JtU3Vi bWlzc2lvbgogdm9pZCB3ZWJraXRXZWJWaWV3SGFuZGxlQXV0aGVudGljYXRpb25DaGFsbGVuZ2Uo V2ViS2l0V2ViVmlldyogd2ViVmlldywgQXV0aGVudGljYXRpb25DaGFsbGVuZ2VQcm94eSogYXV0 aGVudGljYXRpb25DaGFsbGVuZ2UpCiB7CiAgICAgQ3JlZGVudGlhbFN0b3JhZ2VNb2RlIGNyZWRl bnRpYWxTdG9yYWdlTW9kZTsKLSAgICBpZiAod2Via2l0X3NldHRpbmdzX2dldF9lbmFibGVfcHJp dmF0ZV9icm93c2luZyh3ZWJraXRfd2ViX3ZpZXdfZ2V0X3NldHRpbmdzKHdlYlZpZXcpKSkKLSAg ICAgICAgY3JlZGVudGlhbFN0b3JhZ2VNb2RlID0gRGlzYWxsb3dQZXJzaXN0ZW50U3RvcmFnZTsK LSAgICBlbHNlCisjaWYgRU5BQkxFKENSRURFTlRJQUxfU1RPUkFHRSkKKyAgICBpZiAoIXdlYmtp dF9zZXR0aW5nc19nZXRfZW5hYmxlX3ByaXZhdGVfYnJvd3Npbmcod2Via2l0X3dlYl92aWV3X2dl dF9zZXR0aW5ncyh3ZWJWaWV3KSkpCiAgICAgICAgIGNyZWRlbnRpYWxTdG9yYWdlTW9kZSA9IEFs bG93UGVyc2lzdGVudFN0b3JhZ2U7CisgICAgZWxzZQorI2Vsc2UKKyAgICAgICAgY3JlZGVudGlh bFN0b3JhZ2VNb2RlID0gRGlzYWxsb3dQZXJzaXN0ZW50U3RvcmFnZTsKKyNlbmRpZgogCiAgICAg d2Via2l0V2ViVmlld0Jhc2VBZGRBdXRoZW50aWNhdGlvbkRpYWxvZyhXRUJLSVRfV0VCX1ZJRVdf QkFTRSh3ZWJWaWV3KSwgd2Via2l0QXV0aGVudGljYXRpb25EaWFsb2dOZXcoYXV0aGVudGljYXRp b25DaGFsbGVuZ2UsIGNyZWRlbnRpYWxTdG9yYWdlTW9kZSkpOwogfQotLSAKMS44LjQucmMzCgo=