121759 2013-09-21 23:26:30 -0700 Fix too-strict type error exceptions introduced in WebGL bindings 2013-09-22 00:09:58 -0700 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 darin darin commit-queue dino kondapallykalyan oldest_to_newest 931876 0 darin 2013-09-21 23:26:30 -0700 Fix too-strict type error exceptions introduced in WebGL bindings 931877 1 212294 darin 2013-09-21 23:26:59 -0700 Created attachment 212294 Patch 931879 2 212294 ap 2013-09-21 23:32:55 -0700 Comment on attachment 212294 Patch r=me Please wait for EWS results - the patch is #1 in the queue now, so it should be fast. 931881 3 ap 2013-09-22 00:04:37 -0700 *** Bug 121758 has been marked as a duplicate of this bug. *** 931884 4 darin 2013-09-22 00:09:58 -0700 Committed r156243: <http://trac.webkit.org/changeset/156243> 212294 2013-09-21 23:26:59 -0700 2013-09-22 00:00:18 -0700 Patch bug-121759-20130921232659.patch text/plain 4589 darin U3VidmVyc2lvbiBSZXZpc2lvbjogMTU2MjQwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWY2NTlmYzBhYWNjYWI3 Y2YzODZiODgxM2FhMjQ2NzQxZjM5MzYzMi4uMWFjNzg0Zjg0MGJiZGJhZjk5MjRhOGE3YWRiOWIw OWM0Y2M3MTEyMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIxIEBACiAyMDEzLTA5LTIxICBEYXJp biBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KIAorICAgICAgICBGaXggdG9vLXN0cmljdCB0eXBl IGVycm9yIGV4Y2VwdGlvbnMgaW50cm9kdWNlZCBpbiBXZWJHTCBiaW5kaW5ncworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIxNzU5CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBiaW5kaW5ncy9qcy9KU1dl YkdMUmVuZGVyaW5nQ29udGV4dEN1c3RvbS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpKU1dlYkdM UmVuZGVyaW5nQ29udGV4dDo6Z2V0QXR0YWNoZWRTaGFkZXJzKTogQWxsb3cgdW5kZWZpbmVkCisg ICAgICAgIG9yIG51bGwgd2l0aG91dCB0aHJvd2luZyB0eXBlIGVycm9yLgorICAgICAgICAoV2Vi Q29yZTo6SlNXZWJHTFJlbmRlcmluZ0NvbnRleHQ6OmdldFByb2dyYW1QYXJhbWV0ZXIpOiBEaXR0 by4KKyAgICAgICAgKFdlYkNvcmU6OkpTV2ViR0xSZW5kZXJpbmdDb250ZXh0OjpnZXRVbmlmb3Jt KTogRGl0dG8uCisgICAgICAgIChXZWJDb3JlOjpkYXRhRnVuY3Rpb25mKTogRGl0dG8uCisgICAg ICAgIChXZWJDb3JlOjpkYXRhRnVuY3Rpb25pKTogRGl0dG8uCisgICAgICAgIChXZWJDb3JlOjpk YXRhRnVuY3Rpb25NYXRyaXgpOiBEaXR0by4KKworMjAxMy0wOS0yMSAgRGFyaW4gQWRsZXIgIDxk YXJpbkBhcHBsZS5jb20+CisKICAgICAgICAgQWRkIEV4ZWNTdGF0ZTo6dW5jaGVja2VkQXJndW1l bnQgYW5kIHVzZSB3aGVyZSBwb3NzaWJsZSB0byBzaHJpbmsgYSBiaXQKICAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMTc1MAogCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU1dlYkdMUmVuZGVyaW5nQ29udGV4dEN1c3RvbS5j cHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU1dlYkdMUmVuZGVyaW5nQ29udGV4dEN1 c3RvbS5jcHAKaW5kZXggY2EwYWVkZjQ1NDI3ZTZmYjkzZmNiZmU3NDJjYzZiMTE2MWNkOWNmZi4u MDUyYzAwYTdmODdjMzU3NjAwMmM1ZDcyNjUwY2VkNGZkM2YyNTBiMyAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNXZWJHTFJlbmRlcmluZ0NvbnRleHRDdXN0b20uY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTV2ViR0xSZW5kZXJpbmdDb250ZXh0 Q3VzdG9tLmNwcApAQCAtMjQ3LDcgKzI0Nyw3IEBAIEpTVmFsdWUgSlNXZWJHTFJlbmRlcmluZ0Nv bnRleHQ6OmdldEF0dGFjaGVkU2hhZGVycyhFeGVjU3RhdGUqIGV4ZWMpCiAgICAgRXhjZXB0aW9u Q29kZSBlYyA9IDA7CiAgICAgV2ViR0xSZW5kZXJpbmdDb250ZXh0KiBjb250ZXh0ID0gc3RhdGlj X2Nhc3Q8V2ViR0xSZW5kZXJpbmdDb250ZXh0Kj4oaW1wbCgpKTsKICAgICBXZWJHTFByb2dyYW0q IHByb2dyYW0gPSB0b1dlYkdMUHJvZ3JhbShleGVjLT51bmNoZWNrZWRBcmd1bWVudCgwKSk7Ci0g ICAgaWYgKCFwcm9ncmFtKQorICAgIGlmICghcHJvZ3JhbSAmJiAhZXhlYy0+dW5jaGVja2VkQXJn dW1lbnQoMCkuaXNVbmRlZmluZWRPck51bGwoKSkKICAgICAgICAgcmV0dXJuIHRocm93VHlwZUVy cm9yKGV4ZWMpOwogICAgIFZlY3RvcjxSZWZQdHI8V2ViR0xTaGFkZXI+ID4gc2hhZGVyczsKICAg ICBib29sIHN1Y2NlZWQgPSBjb250ZXh0LT5nZXRBdHRhY2hlZFNoYWRlcnMocHJvZ3JhbSwgc2hh ZGVycywgZWMpOwpAQCAtMzMxLDcgKzMzMSw3IEBAIEpTVmFsdWUgSlNXZWJHTFJlbmRlcmluZ0Nv bnRleHQ6OmdldFByb2dyYW1QYXJhbWV0ZXIoRXhlY1N0YXRlKiBleGVjKQogICAgIEV4Y2VwdGlv bkNvZGUgZWMgPSAwOwogICAgIFdlYkdMUmVuZGVyaW5nQ29udGV4dCogY29udGV4dCA9IHN0YXRp Y19jYXN0PFdlYkdMUmVuZGVyaW5nQ29udGV4dCo+KGltcGwoKSk7CiAgICAgV2ViR0xQcm9ncmFt KiBwcm9ncmFtID0gdG9XZWJHTFByb2dyYW0oZXhlYy0+dW5jaGVja2VkQXJndW1lbnQoMCkpOwot ICAgIGlmICghcHJvZ3JhbSkKKyAgICBpZiAoIXByb2dyYW0gJiYgIWV4ZWMtPnVuY2hlY2tlZEFy Z3VtZW50KDApLmlzVW5kZWZpbmVkT3JOdWxsKCkpCiAgICAgICAgIHJldHVybiB0aHJvd1R5cGVF cnJvcihleGVjKTsKICAgICB1bnNpZ25lZCBwbmFtZSA9IGV4ZWMtPnVuY2hlY2tlZEFyZ3VtZW50 KDEpLnRvSW50MzIoZXhlYyk7CiAgICAgaWYgKGV4ZWMtPmhhZEV4Y2VwdGlvbigpKQpAQCAtMzk1 LDEwICszOTUsMTAgQEAgSlNWYWx1ZSBKU1dlYkdMUmVuZGVyaW5nQ29udGV4dDo6Z2V0VW5pZm9y bShFeGVjU3RhdGUqIGV4ZWMpCiAgICAgRXhjZXB0aW9uQ29kZSBlYyA9IDA7CiAgICAgV2ViR0xS ZW5kZXJpbmdDb250ZXh0KiBjb250ZXh0ID0gc3RhdGljX2Nhc3Q8V2ViR0xSZW5kZXJpbmdDb250 ZXh0Kj4oaW1wbCgpKTsKICAgICBXZWJHTFByb2dyYW0qIHByb2dyYW0gPSB0b1dlYkdMUHJvZ3Jh bShleGVjLT51bmNoZWNrZWRBcmd1bWVudCgwKSk7Ci0gICAgaWYgKCFwcm9ncmFtKQorICAgIGlm ICghcHJvZ3JhbSAmJiAhZXhlYy0+dW5jaGVja2VkQXJndW1lbnQoMCkuaXNVbmRlZmluZWRPck51 bGwoKSkKICAgICAgICAgcmV0dXJuIHRocm93VHlwZUVycm9yKGV4ZWMpOwogICAgIFdlYkdMVW5p Zm9ybUxvY2F0aW9uKiBsb2NhdGlvbiA9IHRvV2ViR0xVbmlmb3JtTG9jYXRpb24oZXhlYy0+dW5j aGVja2VkQXJndW1lbnQoMSkpOwotICAgIGlmICghbG9jYXRpb24pCisgICAgaWYgKCFsb2NhdGlv biAmJiAhZXhlYy0+dW5jaGVja2VkQXJndW1lbnQoMSkuaXNVbmRlZmluZWRPck51bGwoKSkKICAg ICAgICAgcmV0dXJuIHRocm93VHlwZUVycm9yKGV4ZWMpOwogICAgIFdlYkdMR2V0SW5mbyBpbmZv ID0gY29udGV4dC0+Z2V0VW5pZm9ybShwcm9ncmFtLCBsb2NhdGlvbiwgZWMpOwogICAgIGlmIChl YykgewpAQCAtNDY5LDcgKzQ2OSw3IEBAIHN0YXRpYyBKU0M6OkpTVmFsdWUgZGF0YUZ1bmN0aW9u ZihEYXRhRnVuY3Rpb25Ub0NhbGwgZiwgSlNDOjpFeGVjU3RhdGUqIGV4ZWMsIFdlCiAgICAgCiAg ICAgaWYgKGZ1bmN0aW9uRm9yVW5pZm9ybShmKSkgewogICAgICAgICBsb2NhdGlvbiA9IHRvV2Vi R0xVbmlmb3JtTG9jYXRpb24oZXhlYy0+dW5jaGVja2VkQXJndW1lbnQoMCkpOwotICAgICAgICBp ZiAoIWxvY2F0aW9uKQorICAgICAgICBpZiAoIWxvY2F0aW9uICYmICFleGVjLT51bmNoZWNrZWRB cmd1bWVudCgwKS5pc1VuZGVmaW5lZE9yTnVsbCgpKQogICAgICAgICAgICAgcmV0dXJuIHRocm93 VHlwZUVycm9yKGV4ZWMpOwogICAgIH0gZWxzZQogICAgICAgICBpbmRleCA9IGV4ZWMtPnVuY2hl Y2tlZEFyZ3VtZW50KDApLnRvSW50MzIoZXhlYyk7CkBAIC01NTUsNyArNTU1LDcgQEAgc3RhdGlj IEpTQzo6SlNWYWx1ZSBkYXRhRnVuY3Rpb25pKERhdGFGdW5jdGlvblRvQ2FsbCBmLCBKU0M6OkV4 ZWNTdGF0ZSogZXhlYywgV2UKICAgICAgICAgcmV0dXJuIGV4ZWMtPnZtKCkudGhyb3dFeGNlcHRp b24oZXhlYywgY3JlYXRlTm90RW5vdWdoQXJndW1lbnRzRXJyb3IoZXhlYykpOwogCiAgICAgV2Vi R0xVbmlmb3JtTG9jYXRpb24qIGxvY2F0aW9uID0gdG9XZWJHTFVuaWZvcm1Mb2NhdGlvbihleGVj LT51bmNoZWNrZWRBcmd1bWVudCgwKSk7Ci0gICAgaWYgKCFsb2NhdGlvbikKKyAgICBpZiAoIWxv Y2F0aW9uICYmICFleGVjLT51bmNoZWNrZWRBcmd1bWVudCgwKS5pc1VuZGVmaW5lZE9yTnVsbCgp KQogICAgICAgICByZXR1cm4gdGhyb3dUeXBlRXJyb3IoZXhlYyk7CiAgIAogICAgIFJlZlB0cjxJ bnQzMkFycmF5PiB3ZWJHTEFycmF5ID0gdG9JbnQzMkFycmF5KGV4ZWMtPnVuY2hlY2tlZEFyZ3Vt ZW50KDEpKTsKQEAgLTYxNSw3ICs2MTUsNyBAQCBzdGF0aWMgSlNDOjpKU1ZhbHVlIGRhdGFGdW5j dGlvbk1hdHJpeChEYXRhRnVuY3Rpb25NYXRyaXhUb0NhbGwgZiwgSlNDOjpFeGVjU3RhdAogICAg ICAgICByZXR1cm4gZXhlYy0+dm0oKS50aHJvd0V4Y2VwdGlvbihleGVjLCBjcmVhdGVOb3RFbm91 Z2hBcmd1bWVudHNFcnJvcihleGVjKSk7CiAKICAgICBXZWJHTFVuaWZvcm1Mb2NhdGlvbiogbG9j YXRpb24gPSB0b1dlYkdMVW5pZm9ybUxvY2F0aW9uKGV4ZWMtPnVuY2hlY2tlZEFyZ3VtZW50KDAp KTsKLSAgICBpZiAoIWxvY2F0aW9uKQorICAgIGlmICghbG9jYXRpb24gJiYgIWV4ZWMtPnVuY2hl Y2tlZEFyZ3VtZW50KDApLmlzVW5kZWZpbmVkT3JOdWxsKCkpCiAgICAgICAgIHJldHVybiB0aHJv d1R5cGVFcnJvcihleGVjKTsKIAogICAgIGJvb2wgdHJhbnNwb3NlID0gZXhlYy0+dW5jaGVja2Vk QXJndW1lbnQoMSkudG9Cb29sZWFuKGV4ZWMpOwo=