121753 2013-09-21 18:23:53 -0700 Remove the notion that a CallFrame can have a pointer to an InlineCallFrame, since that doesn't happen anymore 2013-09-21 20:55:11 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 121641 1 fpizlo fpizlo barraclough ggaren mark.lam mhahnenberg msaboff oliver sam oldest_to_newest 931847 0 fpizlo 2013-09-21 18:23:53 -0700 Patch forthcoming. 931848 1 212290 fpizlo 2013-09-21 18:25:13 -0700 Created attachment 212290 the patch 931849 2 212290 fpizlo 2013-09-21 18:25:41 -0700 Comment on attachment 212290 the patch View in context: https://bugs.webkit.org/attachment.cgi?id=212290&action=review > Source/JavaScriptCore/interpreter/CallFrame.cpp:-90 > - I will revert. 931857 3 212290 darin 2013-09-21 20:23:07 -0700 Comment on attachment 212290 the patch View in context: https://bugs.webkit.org/attachment.cgi?id=212290&action=review > Source/JavaScriptCore/interpreter/CallFrame.h:167 > - > + Please don’t add that space; while most humans really don’t care, git doesn’t like it. 931861 4 fpizlo 2013-09-21 20:55:11 -0700 Landed in http://trac.webkit.org/changeset/156239 212290 2013-09-21 18:25:13 -0700 2013-09-21 20:23:06 -0700 the patch blah.patch text/plain 4941 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTU2MjM4KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBA CisyMDEzLTA5LTIxICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg UmVtb3ZlIHRoZSBub3Rpb24gdGhhdCBhIENhbGxGcmFtZSBjYW4gaGF2ZSBhIHBvaW50ZXIgdG8g YW4gSW5saW5lQ2FsbEZyYW1lLCBzaW5jZSB0aGF0IGRvZXNuJ3QgaGFwcGVuIGFueW1vcmUKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMTc1MworCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogaW50ZXJwcmV0 ZXIvQ2FsbEZyYW1lLmNwcDoKKyAgICAgICAgKEpTQzo6Q2FsbEZyYW1lOjpieXRlY29kZU9mZnNl dEZyb21Db2RlT3JpZ2luSW5kZXgpOgorICAgICAgICAqIGludGVycHJldGVyL0NhbGxGcmFtZS5o OgorICAgICAgICAqIGludGVycHJldGVyL1JlZ2lzdGVyLmg6CisKIDIwMTMtMDktMjEgIEZpbGlw IFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCBmaXggdGhl IHJldmVydC4KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnRlcnByZXRlci9DYWxsRnJh bWUuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnRlcnByZXRlci9D YWxsRnJhbWUuY3BwCShyZXZpc2lvbiAxNTYyMzgpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUv aW50ZXJwcmV0ZXIvQ2FsbEZyYW1lLmNwcAkod29ya2luZyBjb3B5KQpAQCAtODcsNyArODcsNiBA QCB1bnNpZ25lZCBDYWxsRnJhbWU6OmJ5dGVjb2RlT2Zmc2V0RnJvbUNvCiAgICAgfQogICAgIHJl dHVybiBjb2RlT3JpZ2luLmJ5dGVjb2RlSW5kZXg7CiB9Ci0KICNlbmRpZiAvLyBFTkFCTEUoREZH X0pJVCkKIAogUmVnaXN0ZXIqIENhbGxGcmFtZTo6ZnJhbWVFeHRlbnRJbnRlcm5hbCgpCkluZGV4 OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaW50ZXJwcmV0ZXIvQ2FsbEZyYW1lLmgKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2ludGVycHJldGVyL0NhbGxGcmFtZS5oCShyZXZp c2lvbiAxNTYyMzgpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaW50ZXJwcmV0ZXIvQ2FsbEZy YW1lLmgJKHdvcmtpbmcgY29weSkKQEAgLTE2NCw3ICsxNjQsNyBAQCBuYW1lc3BhY2UgSlNDICB7 CiAjaWYgRU5BQkxFKERGR19KSVQpCiAgICAgICAgIHVuc2lnbmVkIGJ5dGVjb2RlT2Zmc2V0RnJv bUNvZGVPcmlnaW5JbmRleCgpOwogI2VuZGlmCi0KKyAgICAgICAgCiAgICAgICAgIFJlZ2lzdGVy KiBmcmFtZUV4dGVudCgpCiAgICAgICAgIHsKICAgICAgICAgICAgIGlmICghY29kZUJsb2NrKCkp CkBAIC0xNzQsMTggKzE3NCw2IEBAIG5hbWVzcGFjZSBKU0MgIHsKICAgICAKICAgICAgICAgUmVn aXN0ZXIqIGZyYW1lRXh0ZW50SW50ZXJuYWwoKTsKICAgICAKLSNpZiBFTkFCTEUoREZHX0pJVCkK LSAgICAgICAgSW5saW5lQ2FsbEZyYW1lKiBpbmxpbmVDYWxsRnJhbWUoKSBjb25zdCB7IHJldHVy biB0aGlzW0pTU3RhY2s6OlJldHVyblBDXS5hc0lubGluZUNhbGxGcmFtZSgpOyB9Ci0jZWxzZQot ICAgICAgICAvLyBUaGlzIHdpbGwgbmV2ZXIgYmUgY2FsbGVkIGlmICFFTkFCTEUoREZHX0pJVCkg c2luY2UgYWxsIGNhbGxzIHNob3VsZCBiZSBndWFyZGVkIGJ5Ci0gICAgICAgIC8vIGlzSW5saW5l ZEZyYW1lKCkuIEJ1dCB0byBtYWtlIGl0IGVhc2llciB0byB3cml0ZSBjb2RlIHdpdGhvdXQgaGF2 aW5nIGEgYnVuY2ggb2YKLSAgICAgICAgLy8gI2lmJ3MsIHdlIG1ha2UgYSBkdW1teSBpbXBsZW1l bnRhdGlvbiBhdmFpbGFibGUgYW55d2F5LgotICAgICAgICBJbmxpbmVDYWxsRnJhbWUqIGlubGlu ZUNhbGxGcmFtZSgpIGNvbnN0Ci0gICAgICAgIHsKLSAgICAgICAgICAgIFJFTEVBU0VfQVNTRVJU X05PVF9SRUFDSEVEKCk7Ci0gICAgICAgICAgICByZXR1cm4gMDsKLSAgICAgICAgfQotI2VuZGlm CiAjaWYgVVNFKEpTVkFMVUUzMl82NCkKICAgICAgICAgSW5zdHJ1Y3Rpb24qIGN1cnJlbnRWUEMo KSBjb25zdAogICAgICAgICB7CkBAIC0yNzEsOSArMjU5LDYgQEAgbmFtZXNwYWNlIEpTQyAgewog ICAgICAgICB2b2lkIHNldENvZGVCbG9jayhDb2RlQmxvY2sqIGNvZGVCbG9jaykgeyBzdGF0aWNf Y2FzdDxSZWdpc3Rlcio+KHRoaXMpW0pTU3RhY2s6OkNvZGVCbG9ja10gPSBjb2RlQmxvY2s7IH0K ICAgICAgICAgdm9pZCBzZXRSZXR1cm5QQyh2b2lkKiB2YWx1ZSkgeyBzdGF0aWNfY2FzdDxSZWdp c3Rlcio+KHRoaXMpW0pTU3RhY2s6OlJldHVyblBDXSA9IChJbnN0cnVjdGlvbiopdmFsdWU7IH0K ICAgICAgICAgCi0jaWYgRU5BQkxFKERGR19KSVQpCi0gICAgICAgIHZvaWQgc2V0SW5saW5lQ2Fs bEZyYW1lKElubGluZUNhbGxGcmFtZSogaW5saW5lQ2FsbEZyYW1lKSB7IHN0YXRpY19jYXN0PFJl Z2lzdGVyKj4odGhpcylbSlNTdGFjazo6UmV0dXJuUENdID0gaW5saW5lQ2FsbEZyYW1lOyB9Ci0j ZW5kaWYKICAgICAgICAgQ2FsbEZyYW1lKiBjYWxsZXJGcmFtZU5vRmxhZ3MoKSB7IHJldHVybiBj YWxsZXJGcmFtZSgpLT5yZW1vdmVIb3N0Q2FsbEZyYW1lRmxhZygpOyB9CiAKICAgICAgICAgLy8g Q2FsbEZyYW1lOjppdGVyYXRlKCkgZXhwZWN0cyBhIEZ1bmN0b3IgdGhhdCBpbXBsZW1lbnRzIHRo ZSBmb2xsb3dpbmcgbWV0aG9kOgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2ludGVycHJl dGVyL1JlZ2lzdGVyLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2ludGVy cHJldGVyL1JlZ2lzdGVyLmgJKHJldmlzaW9uIDE1NjIzOCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0 Q29yZS9pbnRlcnByZXRlci9SZWdpc3Rlci5oCSh3b3JraW5nIGNvcHkpCkBAIC00Miw3ICs0Miw2 IEBAIG5hbWVzcGFjZSBKU0MgewogICAgIGNsYXNzIEpTUHJvcGVydHlOYW1lSXRlcmF0b3I7CiAg ICAgY2xhc3MgSlNTY29wZTsKIAotICAgIHN0cnVjdCBJbmxpbmVDYWxsRnJhbWU7CiAgICAgc3Ry dWN0IEluc3RydWN0aW9uOwogCiAgICAgdHlwZWRlZiBFeGVjU3RhdGUgQ2FsbEZyYW1lOwpAQCAt NjEsNyArNjAsNiBAQCBuYW1lc3BhY2UgSlNDIHsKICAgICAgICAgUmVnaXN0ZXImIG9wZXJhdG9y PShDb2RlQmxvY2sqKTsKICAgICAgICAgUmVnaXN0ZXImIG9wZXJhdG9yPShKU1Njb3BlKik7CiAg ICAgICAgIFJlZ2lzdGVyJiBvcGVyYXRvcj0oSW5zdHJ1Y3Rpb24qKTsKLSAgICAgICAgUmVnaXN0 ZXImIG9wZXJhdG9yPShJbmxpbmVDYWxsRnJhbWUqKTsKIAogICAgICAgICBpbnQzMl90IGkoKSBj b25zdDsKICAgICAgICAgSlNBY3RpdmF0aW9uKiBhY3RpdmF0aW9uKCkgY29uc3Q7CkBAIC03MSw3 ICs2OSw2IEBAIG5hbWVzcGFjZSBKU0MgewogICAgICAgICBKU1Byb3BlcnR5TmFtZUl0ZXJhdG9y KiBwcm9wZXJ0eU5hbWVJdGVyYXRvcigpIGNvbnN0OwogICAgICAgICBKU1Njb3BlKiBzY29wZSgp IGNvbnN0OwogICAgICAgICBJbnN0cnVjdGlvbiogdlBDKCkgY29uc3Q7Ci0gICAgICAgIElubGlu ZUNhbGxGcmFtZSogYXNJbmxpbmVDYWxsRnJhbWUoKSBjb25zdDsKICAgICAgICAgaW50MzJfdCB1 bmJveGVkSW50MzIoKSBjb25zdDsKICAgICAgICAgaW50NjRfdCB1bmJveGVkSW50NTIoKSBjb25z dDsKICAgICAgICAgYm9vbCB1bmJveGVkQm9vbGVhbigpIGNvbnN0OwpAQCAtOTYsNyArOTMsNiBA QCBuYW1lc3BhY2UgSlNDIHsKICAgICAgICAgICAgIENhbGxGcmFtZSogY2FsbEZyYW1lOwogICAg ICAgICAgICAgQ29kZUJsb2NrKiBjb2RlQmxvY2s7CiAgICAgICAgICAgICBJbnN0cnVjdGlvbiog dlBDOwotICAgICAgICAgICAgSW5saW5lQ2FsbEZyYW1lKiBpbmxpbmVDYWxsRnJhbWU7CiAgICAg ICAgICAgICBFbmNvZGVkVmFsdWVEZXNjcmlwdG9yIGVuY29kZWRWYWx1ZTsKICAgICAgICAgICAg IGRvdWJsZSBudW1iZXI7CiAgICAgICAgICAgICBpbnQ2NF90IGludGVnZXI7CkBAIC0xNTEsMTIg KzE0Nyw2IEBAIG5hbWVzcGFjZSBKU0MgewogICAgICAgICByZXR1cm4gKnRoaXM7CiAgICAgfQog Ci0gICAgQUxXQVlTX0lOTElORSBSZWdpc3RlciYgUmVnaXN0ZXI6Om9wZXJhdG9yPShJbmxpbmVD YWxsRnJhbWUqIGlubGluZUNhbGxGcmFtZSkKLSAgICB7Ci0gICAgICAgIHUuaW5saW5lQ2FsbEZy YW1lID0gaW5saW5lQ2FsbEZyYW1lOwotICAgICAgICByZXR1cm4gKnRoaXM7Ci0gICAgfQotCiAg ICAgQUxXQVlTX0lOTElORSBpbnQzMl90IFJlZ2lzdGVyOjppKCkgY29uc3QKICAgICB7CiAgICAg ICAgIHJldHVybiBqc1ZhbHVlKCkuYXNJbnQzMigpOwpAQCAtMTc3LDExICsxNjcsNiBAQCBuYW1l c3BhY2UgSlNDIHsKICAgICAgICAgcmV0dXJuIHUudlBDOwogICAgIH0KIAotICAgIEFMV0FZU19J TkxJTkUgSW5saW5lQ2FsbEZyYW1lKiBSZWdpc3Rlcjo6YXNJbmxpbmVDYWxsRnJhbWUoKSBjb25z dAotICAgIHsKLSAgICAgICAgcmV0dXJuIHUuaW5saW5lQ2FsbEZyYW1lOwotICAgIH0KLSAgICAg ICAgCiAgICAgQUxXQVlTX0lOTElORSBpbnQzMl90IFJlZ2lzdGVyOjp1bmJveGVkSW50MzIoKSBj b25zdAogICAgIHsKICAgICAgICAgcmV0dXJuIHBheWxvYWQoKTsK