121746 2013-09-21 10:33:51 -0700 Don't store the "processing-instruction" string for PI tokens in the XPath parser 2013-09-21 10:58:29 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca oldest_to_newest 931786 0 andersca 2013-09-21 10:33:51 -0700 Don't store the "processing-instruction" string for PI tokens in the XPath parser 931787 1 212276 andersca 2013-09-21 10:37:45 -0700 Created attachment 212276 Patch 931788 2 212276 koivisto 2013-09-21 10:39:34 -0700 Comment on attachment 212276 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=212276&action=review > Source/WebCore/xml/XPathParser.cpp:373 > + // either node type of function name This comment doesn't add much. 931790 3 andersca 2013-09-21 10:58:29 -0700 Committed r156230: <http://trac.webkit.org/changeset/156230> 212276 2013-09-21 10:37:45 -0700 2013-09-21 10:39:34 -0700 Patch bug-121746-20130921103749.patch text/plain 3318 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTU2MTQyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzlhMzViY2NhODY2NDRh OTAwNTUwOTViNWE1OWVjOTA0NWM3YzhiYy4uNmQ5ZWE5NzRlNzNlMTUzYWQzYzQ4NjFmZDdjM2Zm NzUxZWQ2NWYxOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEzLTA5LTIxICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKKyAgICAgICAgRG9uJ3Qgc3RvcmUg dGhlICJwcm9jZXNzaW5nLWluc3RydWN0aW9uIiBzdHJpbmcgZm9yIFBJIHRva2VucyBpbiB0aGUg WFBhdGggcGFyc2VyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMjE3NDYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBGb3IgUEkgdG9rZW5zLCB0aGUgc3RyaW5nIGlzIGFsd2F5cyBnb2luZyB0byBiZSAicHJv Y2Vzc2luZy1pbnN0cnVjdGlvbiIsIGFuZCBpdCdzIG5ldmVyIHVzZWQgc28gd2UgZG9uJ3QgbmVl ZCB0byBzYXZlIGl0LgorCisgICAgICAgICogeG1sL1hQYXRoR3JhbW1hci55OgorICAgICAgICAq IHhtbC9YUGF0aFBhcnNlci5jcHA6CisgICAgICAgIChQYXJzZXI6Om5leHRUb2tlbkludGVybmFs KToKKyAgICAgICAgKFBhcnNlcjo6bGV4KToKKwogMjAxMy0wOS0xOSAgQW5kZXJzIENhcmxzc29u ICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCiAgICAgICAgIEhhbmRsZSBudWxsIGZvbnQgZmFtaWxp ZXMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS94bWwvWFBhdGhHcmFtbWFyLnkgYi9Tb3Vy Y2UvV2ViQ29yZS94bWwvWFBhdGhHcmFtbWFyLnkKaW5kZXggZDU1ODIxMWRiMmQ4OWVhMTM3MTY3 NjJhNTEzOTc3NTU1NjBmNjZmMy4uNTEyMDRiYjMxODIxMjIyNjI1ZDQzYzdlMWZmMTIxM2U3MzBk YmE1NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUveG1sL1hQYXRoR3JhbW1hci55CisrKyBi L1NvdXJjZS9XZWJDb3JlL3htbC9YUGF0aEdyYW1tYXIueQpAQCAtMjY2LDE0ICsyNjYsMTIgQEAg Tm9kZVRlc3Q6CiAgICAgUEkgJygnICcpJwogICAgIHsKICAgICAgICAgJCQgPSBuZXcgU3RlcDo6 Tm9kZVRlc3QoU3RlcDo6Tm9kZVRlc3Q6OlByb2Nlc3NpbmdJbnN0cnVjdGlvbk5vZGVUZXN0KTsK LSAgICAgICAgcGFyc2VyLT5kZWxldGVTdHJpbmcoJDEpOwogICAgICAgICBwYXJzZXItPnJlZ2lz dGVyTm9kZVRlc3QoJCQpOwogICAgIH0KICAgICB8CiAgICAgUEkgJygnIExJVEVSQUwgJyknCiAg ICAgewogICAgICAgICAkJCA9IG5ldyBTdGVwOjpOb2RlVGVzdChTdGVwOjpOb2RlVGVzdDo6UHJv Y2Vzc2luZ0luc3RydWN0aW9uTm9kZVRlc3QsICQzLT5zdHJpcFdoaXRlU3BhY2UoKSk7Ci0gICAg ICAgIHBhcnNlci0+ZGVsZXRlU3RyaW5nKCQxKTsKICAgICAgICAgcGFyc2VyLT5kZWxldGVTdHJp bmcoJDMpOwogICAgICAgICBwYXJzZXItPnJlZ2lzdGVyTm9kZVRlc3QoJCQpOwogICAgIH0KZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3htbC9YUGF0aFBhcnNlci5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS94bWwvWFBhdGhQYXJzZXIuY3BwCmluZGV4IDc0OTE4MGRiZTVlZThmOWIxMjJmY2RhMWU2 OTgxNjljMDA5ZjhmODAuLmEwM2YxZmVjY2I1NzJlMmQ3N2E4YTFiNmMxNmI3MjMyOTIwNzA0ODIg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3htbC9YUGF0aFBhcnNlci5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUveG1sL1hQYXRoUGFyc2VyLmNwcApAQCAtMTA5LDE0ICsxMDksNyBAQCBzdGF0 aWMgYm9vbCBpc0F4aXNOYW1lKGNvbnN0IFN0cmluZyYgbmFtZSwgU3RlcDo6QXhpcyYgdHlwZSkK IAogc3RhdGljIGJvb2wgaXNOb2RlVHlwZU5hbWUoY29uc3QgU3RyaW5nJiBuYW1lKQogewotICAg IERFRklORV9TVEFUSUNfTE9DQUwoSGFzaFNldDxTdHJpbmc+LCBub2RlVHlwZU5hbWVzLCAoKSk7 Ci0gICAgaWYgKG5vZGVUeXBlTmFtZXMuaXNFbXB0eSgpKSB7Ci0gICAgICAgIG5vZGVUeXBlTmFt ZXMuYWRkKCJjb21tZW50Iik7Ci0gICAgICAgIG5vZGVUeXBlTmFtZXMuYWRkKCJ0ZXh0Iik7Ci0g ICAgICAgIG5vZGVUeXBlTmFtZXMuYWRkKCJwcm9jZXNzaW5nLWluc3RydWN0aW9uIik7Ci0gICAg ICAgIG5vZGVUeXBlTmFtZXMuYWRkKCJub2RlIik7Ci0gICAgfQotICAgIHJldHVybiBub2RlVHlw ZU5hbWVzLmNvbnRhaW5zKG5hbWUpOworICAgIHJldHVybiBuYW1lID09ICJjb21tZW50IiB8fCBu YW1lID09ICJ0ZXh0IiB8fCBuYW1lID09ICJwcm9jZXNzaW5nLWluc3RydWN0aW9uIiB8fCBuYW1l ID09ICJub2RlIjsKIH0KIAogLy8gUmV0dXJucyB3aGV0aGVyIHRoZSBjdXJyZW50IHRva2VuIGNh biBwb3NzaWJseSBiZSBhIGJpbmFyeSBvcGVyYXRvciwgZ2l2ZW4KQEAgLTM3MywxNyArMzY2LDE4 IEBAIFRva2VuIFBhcnNlcjo6bmV4dFRva2VuSW50ZXJuYWwoKQogICAgIH0KIAogICAgIHNraXBX UygpOworCiAgICAgaWYgKHBlZWtDdXJIZWxwZXIoKSA9PSAnKCcpIHsKLSAgICAgICAgLy9ub3Rl OiB3ZSBkb24ndCBzd2FsbG93IHRoZSAoaGVyZSEKLSAgICAgICAgCi0gICAgICAgIC8vZWl0aGVy IG5vZGUgdHlwZSBvZiBmdW5jdGlvbiBuYW1lCisgICAgICAgIC8vIG5vdGU6IHdlIGRvbid0IHN3 YWxsb3cgdGhlICcoJyBoZXJlIQorCisgICAgICAgIC8vIGVpdGhlciBub2RlIHR5cGUgb2YgZnVu Y3Rpb24gbmFtZQogICAgICAgICBpZiAoaXNOb2RlVHlwZU5hbWUobmFtZSkpIHsKICAgICAgICAg ICAgIGlmIChuYW1lID09ICJwcm9jZXNzaW5nLWluc3RydWN0aW9uIikKLSAgICAgICAgICAgICAg ICByZXR1cm4gVG9rZW4oUEksIG5hbWUpOworICAgICAgICAgICAgICAgIHJldHVybiBUb2tlbihQ SSk7CiAKICAgICAgICAgICAgIHJldHVybiBUb2tlbihOT0RFVFlQRSwgbmFtZSk7CiAgICAgICAg IH0KLSAgICAgICAgLy9tdXN0IGJlIGEgZnVuY3Rpb24gbmFtZS4KKwogICAgICAgICByZXR1cm4g VG9rZW4oRlVOQ1RJT05OQU1FLCBuYW1lKTsKICAgICB9CiAKQEAgLTQzNCw3ICs0MjgsNiBAQCBp bnQgUGFyc2VyOjpsZXgodm9pZCogZGF0YSkKICAgICAgICAgeXlsdmFsLT5lcW9wID0gdG9rLmVx b3A7CiAgICAgICAgIGJyZWFrOwogICAgIGNhc2UgTk9ERVRZUEU6Ci0gICAgY2FzZSBQSToKICAg ICBjYXNlIEZVTkNUSU9OTkFNRToKICAgICBjYXNlIExJVEVSQUw6CiAgICAgY2FzZSBWQVJJQUJM RVJFRkVSRU5DRToK