121745 2013-09-21 09:53:30 -0700 Don't bloat Obj-C bindings with inlined attribute retrieval. 2013-09-21 20:30:10 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kling kling cdumez commit-queue darin jonlee oldest_to_newest 931782 0 kling 2013-09-21 09:53:30 -0700 fastGetAttribute() is overkill here. 931783 1 212275 kling 2013-09-21 09:54:06 -0700 Created attachment 212275 Patch idea 931794 2 212275 commit-queue 2013-09-21 11:45:02 -0700 Comment on attachment 212275 Patch idea Clearing flags on attachment: 212275 Committed r156232: <http://trac.webkit.org/changeset/156232> 931795 3 commit-queue 2013-09-21 11:45:04 -0700 All reviewed patches have been landed. Closing bug. 931841 4 jonlee 2013-09-21 17:10:47 -0700 Changing the binding output should also include change expected test results. Fixed in http://trac.webkit.org/changeset/156236 931859 5 darin 2013-09-21 20:30:10 -0700 Is fastGetAttribute inlined!? I didn’t realize! 212275 2013-09-21 09:54:06 -0700 2013-09-21 11:45:02 -0700 Patch idea bug-121745.diff text/plain 1626 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBmZmI2MTZiLi4xNGY2NjFiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTUg QEAKIDIwMTMtMDktMjEgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgogCisgICAg ICAgIERvbid0IGJsb2F0IE9iai1DIGJpbmRpbmdzIHdpdGggaW5saW5lZCBhdHRyaWJ1dGUgcmV0 cmlldmFsLgorICAgICAgICA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMTIxNzQ1PgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEhhY2sgYmluZGluZ3MgZ2Vu ZXJhdG9yIHRvIGFsd2F5cyB1c2UgZ2V0QXR0cmlidXRlKCkgZm9yIE9iamVjdGl2ZS1DLgorICAg ICAgICBSZWR1Y2VzIFdlYkNvcmUgYmluYXJ5IHNpemUgYnkgMjUxMjAgYnl0ZXMuCisKKzIwMTMt MDktMjEgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgorCiAgICAgICAgIEdpdmUg cHVyaXR5IGhpbnRzIHRvIGNvbXBpbGVyIHRvIGF2b2lkIHBlbmFsaXppbmcgcmVwZWF0ZWQgY2Fs bHMgdG8gc29tZSBmdW5jdGlvbnMuCiAgICAgICAgIDxodHRwczovL3dlYmtpdC5vcmcvYi8xMjE3 NDQ+CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdl bmVyYXRvck9iakMucG0gYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5l cmF0b3JPYmpDLnBtCmluZGV4IDhkNjZmZDguLmVkZjExOWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvck9iakMucG0KKysrIGIvU291cmNl L1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yT2JqQy5wbQpAQCAtMTIzMiw2 ICsxMjMyLDEyIEBAIHN1YiBHZW5lcmF0ZUltcGxlbWVudGF0aW9uCiAgICAgICAgICAgICBteSAk Z2V0dGVyU2lnID0gIi0gKCRhdHRyaWJ1dGVUeXBlKSRhdHRyaWJ1dGVJbnRlcmZhY2VOYW1lXG4i OwogCiAgICAgICAgICAgICBteSAoJGZ1bmN0aW9uTmFtZSwgQGFyZ3VtZW50cykgPSAkY29kZUdl bmVyYXRvci0+R2V0dGVyRXhwcmVzc2lvbihcJWltcGxJbmNsdWRlcywgJGludGVyZmFjZU5hbWUs ICRhdHRyaWJ1dGUpOworCisgICAgICAgICAgICAjIFRvIGF2b2lkIGJsb2F0aW5nIE9iai1DIGJp bmRpbmdzLCB3ZSB1c2UgZ2V0QXR0cmlidXRlKCkgaW5zdGVhZCBvZiBmYXN0R2V0QXR0cmlidXRl KCkuCisgICAgICAgICAgICBpZiAoJGZ1bmN0aW9uTmFtZSBlcSAiZmFzdEdldEF0dHJpYnV0ZSIp IHsKKyAgICAgICAgICAgICAgICAkZnVuY3Rpb25OYW1lID0gImdldEF0dHJpYnV0ZSI7CisgICAg ICAgICAgICB9CisKICAgICAgICAgICAgIG15ICRnZXR0ZXJFeHByZXNzaW9uUHJlZml4ID0gIiRm dW5jdGlvbk5hbWUoIiAuIGpvaW4oIiwgIiwgQGFyZ3VtZW50cyk7CiAKICAgICAgICAgICAgICMg RklYTUU6IFNwZWNpYWwgY2FzZSBhdHRyaWJ1dGUgb3duZXJEb2N1bWVudCB0byBjYWxsIGRvY3Vt ZW50LiBUaGlzIG1ha2VzIGl0IHJldHVybiB0aGUK