121736 2013-09-20 23:53:07 -0700 Shrink valueForBasicShape by removing repeated calls to cssValuePool() 2013-09-21 01:02:42 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 darin darin commit-queue esprehn+autocc glenn macpherson menard oldest_to_newest 931730 0 darin 2013-09-20 23:53:07 -0700 Shrink valueForBasicShape by removing repeated calls to cssValuePool() 931731 1 212257 darin 2013-09-20 23:53:26 -0700 Created attachment 212257 Patch 931750 2 212257 commit-queue 2013-09-21 01:02:40 -0700 Comment on attachment 212257 Patch Clearing flags on attachment: 212257 Committed r156225: <http://trac.webkit.org/changeset/156225> 931751 3 commit-queue 2013-09-21 01:02:42 -0700 All reviewed patches have been landed. Closing bug. 212257 2013-09-20 23:53:26 -0700 2013-09-21 01:02:40 -0700 Patch bug-121736-20130920235326.patch text/plain 6614 darin U3VidmVyc2lvbiBSZXZpc2lvbjogMTU2MjI0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDI2MTQ2NGNjZGEyNjEx MGYyYjExNTUyYjg1Mzc0NTM1ZGY5OTYzNi4uNWQwMGQ2NDU2N2NhNTVhZTQ3MmQ2MGI0Njk0OTFh MTE4MGE2NDkxNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE1IEBACiAyMDEzLTA5LTIwICBEYXJp biBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KIAorICAgICAgICBTaHJpbmsgdmFsdWVGb3JCYXNp Y1NoYXBlIGJ5IHJlbW92aW5nIHJlcGVhdGVkIGNhbGxzIHRvIGNzc1ZhbHVlUG9vbCgpCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjE3MzYKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGNzcy9CYXNpY1No YXBlRnVuY3Rpb25zLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OnZhbHVlRm9yQmFzaWNTaGFwZSk6 IFB1dCB0aGUgcG9vbCBpbnRvIGEgbG9jYWwgdmFyaWFibGUgYW5kIHVzZSB0aGF0LgorCisyMDEz LTA5LTIwICBEYXJpbiBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KKwogICAgICAgICBBbm90aGVy IENTUyBwYXJzZXIgbGVhayBmaXgKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTEyMTczMAogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQmFz aWNTaGFwZUZ1bmN0aW9ucy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQmFzaWNTaGFwZUZ1bmN0 aW9ucy5jcHAKaW5kZXggYzU4ODUwOTVlMDQzNzkwODkzMmExYTY4MDAxNDNiZDI1YWExZGVlMy4u MTM1YTk2M2Y4YWFhNzVmYjdhYTIyNzg1ZjVmYjliOWNmNDZkMWMwNiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvY3NzL0Jhc2ljU2hhcGVGdW5jdGlvbnMuY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL2Nzcy9CYXNpY1NoYXBlRnVuY3Rpb25zLmNwcApAQCAtNDAsMTggKzQwLDIwIEBAIG5hbWVz cGFjZSBXZWJDb3JlIHsKIAogUGFzc1JlZlB0cjxDU1NWYWx1ZT4gdmFsdWVGb3JCYXNpY1NoYXBl KGNvbnN0IEJhc2ljU2hhcGUqIGJhc2ljU2hhcGUpCiB7CisgICAgQ1NTVmFsdWVQb29sJiBwb29s ID0gY3NzVmFsdWVQb29sKCk7CisKICAgICBSZWZQdHI8Q1NTQmFzaWNTaGFwZT4gYmFzaWNTaGFw ZVZhbHVlOwogICAgIHN3aXRjaCAoYmFzaWNTaGFwZS0+dHlwZSgpKSB7CiAgICAgY2FzZSBCYXNp Y1NoYXBlOjpCYXNpY1NoYXBlUmVjdGFuZ2xlVHlwZTogewogICAgICAgICBjb25zdCBCYXNpY1No YXBlUmVjdGFuZ2xlKiByZWN0YW5nbGUgPSBzdGF0aWNfY2FzdDxjb25zdCBCYXNpY1NoYXBlUmVj dGFuZ2xlKj4oYmFzaWNTaGFwZSk7CiAgICAgICAgIFJlZlB0cjxDU1NCYXNpY1NoYXBlUmVjdGFu Z2xlPiByZWN0YW5nbGVWYWx1ZSA9IENTU0Jhc2ljU2hhcGVSZWN0YW5nbGU6OmNyZWF0ZSgpOwog Ci0gICAgICAgIHJlY3RhbmdsZVZhbHVlLT5zZXRYKGNzc1ZhbHVlUG9vbCgpLmNyZWF0ZVZhbHVl KHJlY3RhbmdsZS0+eCgpKSk7Ci0gICAgICAgIHJlY3RhbmdsZVZhbHVlLT5zZXRZKGNzc1ZhbHVl UG9vbCgpLmNyZWF0ZVZhbHVlKHJlY3RhbmdsZS0+eSgpKSk7Ci0gICAgICAgIHJlY3RhbmdsZVZh bHVlLT5zZXRXaWR0aChjc3NWYWx1ZVBvb2woKS5jcmVhdGVWYWx1ZShyZWN0YW5nbGUtPndpZHRo KCkpKTsKLSAgICAgICAgcmVjdGFuZ2xlVmFsdWUtPnNldEhlaWdodChjc3NWYWx1ZVBvb2woKS5j cmVhdGVWYWx1ZShyZWN0YW5nbGUtPmhlaWdodCgpKSk7Ci0gICAgICAgIHJlY3RhbmdsZVZhbHVl LT5zZXRSYWRpdXNYKGNzc1ZhbHVlUG9vbCgpLmNyZWF0ZVZhbHVlKHJlY3RhbmdsZS0+Y29ybmVy UmFkaXVzWCgpKSk7Ci0gICAgICAgIHJlY3RhbmdsZVZhbHVlLT5zZXRSYWRpdXNZKGNzc1ZhbHVl UG9vbCgpLmNyZWF0ZVZhbHVlKHJlY3RhbmdsZS0+Y29ybmVyUmFkaXVzWSgpKSk7CisgICAgICAg IHJlY3RhbmdsZVZhbHVlLT5zZXRYKHBvb2wuY3JlYXRlVmFsdWUocmVjdGFuZ2xlLT54KCkpKTsK KyAgICAgICAgcmVjdGFuZ2xlVmFsdWUtPnNldFkocG9vbC5jcmVhdGVWYWx1ZShyZWN0YW5nbGUt PnkoKSkpOworICAgICAgICByZWN0YW5nbGVWYWx1ZS0+c2V0V2lkdGgocG9vbC5jcmVhdGVWYWx1 ZShyZWN0YW5nbGUtPndpZHRoKCkpKTsKKyAgICAgICAgcmVjdGFuZ2xlVmFsdWUtPnNldEhlaWdo dChwb29sLmNyZWF0ZVZhbHVlKHJlY3RhbmdsZS0+aGVpZ2h0KCkpKTsKKyAgICAgICAgcmVjdGFu Z2xlVmFsdWUtPnNldFJhZGl1c1gocG9vbC5jcmVhdGVWYWx1ZShyZWN0YW5nbGUtPmNvcm5lclJh ZGl1c1goKSkpOworICAgICAgICByZWN0YW5nbGVWYWx1ZS0+c2V0UmFkaXVzWShwb29sLmNyZWF0 ZVZhbHVlKHJlY3RhbmdsZS0+Y29ybmVyUmFkaXVzWSgpKSk7CiAKICAgICAgICAgYmFzaWNTaGFw ZVZhbHVlID0gcmVjdGFuZ2xlVmFsdWUucmVsZWFzZSgpOwogICAgICAgICBicmVhazsKQEAgLTYw LDkgKzYyLDkgQEAgUGFzc1JlZlB0cjxDU1NWYWx1ZT4gdmFsdWVGb3JCYXNpY1NoYXBlKGNvbnN0 IEJhc2ljU2hhcGUqIGJhc2ljU2hhcGUpCiAgICAgICAgIGNvbnN0IEJhc2ljU2hhcGVDaXJjbGUq IGNpcmNsZSA9IHN0YXRpY19jYXN0PGNvbnN0IEJhc2ljU2hhcGVDaXJjbGUqPihiYXNpY1NoYXBl KTsKICAgICAgICAgUmVmUHRyPENTU0Jhc2ljU2hhcGVDaXJjbGU+IGNpcmNsZVZhbHVlID0gQ1NT QmFzaWNTaGFwZUNpcmNsZTo6Y3JlYXRlKCk7CiAKLSAgICAgICAgY2lyY2xlVmFsdWUtPnNldENl bnRlclgoY3NzVmFsdWVQb29sKCkuY3JlYXRlVmFsdWUoY2lyY2xlLT5jZW50ZXJYKCkpKTsKLSAg ICAgICAgY2lyY2xlVmFsdWUtPnNldENlbnRlclkoY3NzVmFsdWVQb29sKCkuY3JlYXRlVmFsdWUo Y2lyY2xlLT5jZW50ZXJZKCkpKTsKLSAgICAgICAgY2lyY2xlVmFsdWUtPnNldFJhZGl1cyhjc3NW YWx1ZVBvb2woKS5jcmVhdGVWYWx1ZShjaXJjbGUtPnJhZGl1cygpKSk7CisgICAgICAgIGNpcmNs ZVZhbHVlLT5zZXRDZW50ZXJYKHBvb2wuY3JlYXRlVmFsdWUoY2lyY2xlLT5jZW50ZXJYKCkpKTsK KyAgICAgICAgY2lyY2xlVmFsdWUtPnNldENlbnRlclkocG9vbC5jcmVhdGVWYWx1ZShjaXJjbGUt PmNlbnRlclkoKSkpOworICAgICAgICBjaXJjbGVWYWx1ZS0+c2V0UmFkaXVzKHBvb2wuY3JlYXRl VmFsdWUoY2lyY2xlLT5yYWRpdXMoKSkpOwogCiAgICAgICAgIGJhc2ljU2hhcGVWYWx1ZSA9IGNp cmNsZVZhbHVlLnJlbGVhc2UoKTsKICAgICAgICAgYnJlYWs7CkBAIC03MSwxMCArNzMsMTAgQEAg UGFzc1JlZlB0cjxDU1NWYWx1ZT4gdmFsdWVGb3JCYXNpY1NoYXBlKGNvbnN0IEJhc2ljU2hhcGUq IGJhc2ljU2hhcGUpCiAgICAgICAgIGNvbnN0IEJhc2ljU2hhcGVFbGxpcHNlKiBlbGxpcHNlID0g c3RhdGljX2Nhc3Q8Y29uc3QgQmFzaWNTaGFwZUVsbGlwc2UqPihiYXNpY1NoYXBlKTsKICAgICAg ICAgUmVmUHRyPENTU0Jhc2ljU2hhcGVFbGxpcHNlPiBlbGxpcHNlVmFsdWUgPSBDU1NCYXNpY1No YXBlRWxsaXBzZTo6Y3JlYXRlKCk7CiAKLSAgICAgICAgZWxsaXBzZVZhbHVlLT5zZXRDZW50ZXJY KGNzc1ZhbHVlUG9vbCgpLmNyZWF0ZVZhbHVlKGVsbGlwc2UtPmNlbnRlclgoKSkpOwotICAgICAg ICBlbGxpcHNlVmFsdWUtPnNldENlbnRlclkoY3NzVmFsdWVQb29sKCkuY3JlYXRlVmFsdWUoZWxs aXBzZS0+Y2VudGVyWSgpKSk7Ci0gICAgICAgIGVsbGlwc2VWYWx1ZS0+c2V0UmFkaXVzWChjc3NW YWx1ZVBvb2woKS5jcmVhdGVWYWx1ZShlbGxpcHNlLT5yYWRpdXNYKCkpKTsKLSAgICAgICAgZWxs aXBzZVZhbHVlLT5zZXRSYWRpdXNZKGNzc1ZhbHVlUG9vbCgpLmNyZWF0ZVZhbHVlKGVsbGlwc2Ut PnJhZGl1c1koKSkpOworICAgICAgICBlbGxpcHNlVmFsdWUtPnNldENlbnRlclgocG9vbC5jcmVh dGVWYWx1ZShlbGxpcHNlLT5jZW50ZXJYKCkpKTsKKyAgICAgICAgZWxsaXBzZVZhbHVlLT5zZXRD ZW50ZXJZKHBvb2wuY3JlYXRlVmFsdWUoZWxsaXBzZS0+Y2VudGVyWSgpKSk7CisgICAgICAgIGVs bGlwc2VWYWx1ZS0+c2V0UmFkaXVzWChwb29sLmNyZWF0ZVZhbHVlKGVsbGlwc2UtPnJhZGl1c1go KSkpOworICAgICAgICBlbGxpcHNlVmFsdWUtPnNldFJhZGl1c1kocG9vbC5jcmVhdGVWYWx1ZShl bGxpcHNlLT5yYWRpdXNZKCkpKTsKIAogICAgICAgICBiYXNpY1NoYXBlVmFsdWUgPSBlbGxpcHNl VmFsdWUucmVsZWFzZSgpOwogICAgICAgICBicmVhazsKQEAgLTg2LDcgKzg4LDcgQEAgUGFzc1Jl ZlB0cjxDU1NWYWx1ZT4gdmFsdWVGb3JCYXNpY1NoYXBlKGNvbnN0IEJhc2ljU2hhcGUqIGJhc2lj U2hhcGUpCiAgICAgICAgIHBvbHlnb25WYWx1ZS0+c2V0V2luZFJ1bGUocG9seWdvbi0+d2luZFJ1 bGUoKSk7CiAgICAgICAgIGNvbnN0IFZlY3RvcjxMZW5ndGg+JiB2YWx1ZXMgPSBwb2x5Z29uLT52 YWx1ZXMoKTsKICAgICAgICAgZm9yICh1bnNpZ25lZCBpID0gMDsgaSA8IHZhbHVlcy5zaXplKCk7 IGkgKz0gMikKLSAgICAgICAgICAgIHBvbHlnb25WYWx1ZS0+YXBwZW5kUG9pbnQoY3NzVmFsdWVQ b29sKCkuY3JlYXRlVmFsdWUodmFsdWVzLmF0KGkpKSwgY3NzVmFsdWVQb29sKCkuY3JlYXRlVmFs dWUodmFsdWVzLmF0KGkgKyAxKSkpOworICAgICAgICAgICAgcG9seWdvblZhbHVlLT5hcHBlbmRQ b2ludChwb29sLmNyZWF0ZVZhbHVlKHZhbHVlcy5hdChpKSksIHBvb2wuY3JlYXRlVmFsdWUodmFs dWVzLmF0KGkgKyAxKSkpOwogCiAgICAgICAgIGJhc2ljU2hhcGVWYWx1ZSA9IHBvbHlnb25WYWx1 ZS5yZWxlYXNlKCk7CiAgICAgICAgIGJyZWFrOwpAQCAtOTUsMTIgKzk3LDEyIEBAIFBhc3NSZWZQ dHI8Q1NTVmFsdWU+IHZhbHVlRm9yQmFzaWNTaGFwZShjb25zdCBCYXNpY1NoYXBlKiBiYXNpY1No YXBlKQogICAgICAgICBjb25zdCBCYXNpY1NoYXBlSW5zZXRSZWN0YW5nbGUqIHJlY3RhbmdsZSA9 IHN0YXRpY19jYXN0PGNvbnN0IEJhc2ljU2hhcGVJbnNldFJlY3RhbmdsZSo+KGJhc2ljU2hhcGUp OwogICAgICAgICBSZWZQdHI8Q1NTQmFzaWNTaGFwZUluc2V0UmVjdGFuZ2xlPiByZWN0YW5nbGVW YWx1ZSA9IENTU0Jhc2ljU2hhcGVJbnNldFJlY3RhbmdsZTo6Y3JlYXRlKCk7CiAKLSAgICAgICAg cmVjdGFuZ2xlVmFsdWUtPnNldFRvcChjc3NWYWx1ZVBvb2woKS5jcmVhdGVWYWx1ZShyZWN0YW5n bGUtPnRvcCgpKSk7Ci0gICAgICAgIHJlY3RhbmdsZVZhbHVlLT5zZXRSaWdodChjc3NWYWx1ZVBv b2woKS5jcmVhdGVWYWx1ZShyZWN0YW5nbGUtPnJpZ2h0KCkpKTsKLSAgICAgICAgcmVjdGFuZ2xl VmFsdWUtPnNldEJvdHRvbShjc3NWYWx1ZVBvb2woKS5jcmVhdGVWYWx1ZShyZWN0YW5nbGUtPmJv dHRvbSgpKSk7Ci0gICAgICAgIHJlY3RhbmdsZVZhbHVlLT5zZXRMZWZ0KGNzc1ZhbHVlUG9vbCgp LmNyZWF0ZVZhbHVlKHJlY3RhbmdsZS0+bGVmdCgpKSk7Ci0gICAgICAgIHJlY3RhbmdsZVZhbHVl LT5zZXRSYWRpdXNYKGNzc1ZhbHVlUG9vbCgpLmNyZWF0ZVZhbHVlKHJlY3RhbmdsZS0+Y29ybmVy UmFkaXVzWCgpKSk7Ci0gICAgICAgIHJlY3RhbmdsZVZhbHVlLT5zZXRSYWRpdXNZKGNzc1ZhbHVl UG9vbCgpLmNyZWF0ZVZhbHVlKHJlY3RhbmdsZS0+Y29ybmVyUmFkaXVzWSgpKSk7CisgICAgICAg IHJlY3RhbmdsZVZhbHVlLT5zZXRUb3AocG9vbC5jcmVhdGVWYWx1ZShyZWN0YW5nbGUtPnRvcCgp KSk7CisgICAgICAgIHJlY3RhbmdsZVZhbHVlLT5zZXRSaWdodChwb29sLmNyZWF0ZVZhbHVlKHJl Y3RhbmdsZS0+cmlnaHQoKSkpOworICAgICAgICByZWN0YW5nbGVWYWx1ZS0+c2V0Qm90dG9tKHBv b2wuY3JlYXRlVmFsdWUocmVjdGFuZ2xlLT5ib3R0b20oKSkpOworICAgICAgICByZWN0YW5nbGVW YWx1ZS0+c2V0TGVmdChwb29sLmNyZWF0ZVZhbHVlKHJlY3RhbmdsZS0+bGVmdCgpKSk7CisgICAg ICAgIHJlY3RhbmdsZVZhbHVlLT5zZXRSYWRpdXNYKHBvb2wuY3JlYXRlVmFsdWUocmVjdGFuZ2xl LT5jb3JuZXJSYWRpdXNYKCkpKTsKKyAgICAgICAgcmVjdGFuZ2xlVmFsdWUtPnNldFJhZGl1c1ko cG9vbC5jcmVhdGVWYWx1ZShyZWN0YW5nbGUtPmNvcm5lclJhZGl1c1koKSkpOwogCiAgICAgICAg IGJhc2ljU2hhcGVWYWx1ZSA9IHJlY3RhbmdsZVZhbHVlLnJlbGVhc2UoKTsKICAgICAgICAgYnJl YWs7CkBAIC0xMDgsNyArMTEwLDcgQEAgUGFzc1JlZlB0cjxDU1NWYWx1ZT4gdmFsdWVGb3JCYXNp Y1NoYXBlKGNvbnN0IEJhc2ljU2hhcGUqIGJhc2ljU2hhcGUpCiAgICAgZGVmYXVsdDoKICAgICAg ICAgYnJlYWs7CiAgICAgfQotICAgIHJldHVybiBjc3NWYWx1ZVBvb2woKS5jcmVhdGVWYWx1ZTxQ YXNzUmVmUHRyPENTU0Jhc2ljU2hhcGU+ID4oYmFzaWNTaGFwZVZhbHVlLnJlbGVhc2UoKSk7Cisg ICAgcmV0dXJuIHBvb2wuY3JlYXRlVmFsdWUoYmFzaWNTaGFwZVZhbHVlLnJlbGVhc2UoKSk7CiB9 CiAKIHN0YXRpYyBMZW5ndGggY29udmVydFRvTGVuZ3RoKGNvbnN0IFJlbmRlclN0eWxlKiBzdHls ZSwgY29uc3QgUmVuZGVyU3R5bGUqIHJvb3RTdHlsZSwgQ1NTUHJpbWl0aXZlVmFsdWUqIHZhbHVl KQo=