121721 2013-09-20 14:59:48 -0700 Shaders that fail to compile should be marked as such 2013-09-20 15:16:16 -0700 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dino dino commit-queue kondapallykalyan noam webkit-bug-importer oldest_to_newest 931621 0 dino 2013-09-20 14:59:48 -0700 We expect all output from ANGLE to pass compilation via glCompileShader. Currently we have some test cases that still fail compilation. We'll fix that, but in the meantime we should make sure that we do mark uncompilable shaders as an error. 931622 1 webkit-bug-importer 2013-09-20 15:00:24 -0700 <rdar://problem/15044901> 931626 2 212228 dino 2013-09-20 15:09:02 -0700 Created attachment 212228 Patch 931628 3 dino 2013-09-20 15:16:16 -0700 Committed r156205: <http://trac.webkit.org/changeset/156205> 212228 2013-09-20 15:09:02 -0700 2013-09-20 15:10:55 -0700 Patch bug-121721-20130920150901.patch text/plain 3232 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMTU2MTAwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjY5MmJhMmQzOTE1M2Yy YTM4NWE2M2RhOThmYmY0MTBiZmU5ZGViYi4uMzY4MzdmYzY2MmNlZTkyNjdkNjg3YjI2YmE0ZDJl NTU3OTBkODliMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEzLTA5LTIwICBEZWFu IEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KKworICAgICAgICBTaGFkZXJzIHRoYXQgZmFpbCB0 byBjb21waWxlIHNob3VsZCBiZSBtYXJrZWQgYXMgc3VjaAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIxNzIxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgMS4gQWRkIGEgbmV3IGxvZ2dpbmcgY2hhbm5lbCBm b3IgV2ViR0wuCisKKyAgICAgICAgMi4gSWYgYSB0cmFuc2xhdGVkIHNoYWRlciBmYWlscyB0byBj b21waWxlICh0ZWNobmljYWxseQorICAgICAgICB0aGlzIHNob3VsZCBuZXZlciBoYXBwZW4pLCBt YXJrIGl0IGFzIGludmFsaWQuCisKKyAgICAgICAgVGVzdDogaHR0cHM6Ly93d3cua2hyb25vcy5v cmcvcmVnaXN0cnkvd2ViZ2wvc2RrL3Rlc3RzL2NvbmZvcm1hbmNlL2dsc2wvbWlzYy9zaGFkZXIt d2l0aC1ub24tcmVzZXJ2ZWQtd29yZHMuaHRtbAorCisgICAgICAgICogcGxhdGZvcm0vTG9nZ2lu Zy5oOiBOZXcgV2ViR0wgY2hhbm5lbC4KKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9vcGVu Z2wvR3JhcGhpY3NDb250ZXh0M0RPcGVuR0xDb21tb24uY3BwOgorICAgICAgICAoV2ViQ29yZTo6 R3JhcGhpY3NDb250ZXh0M0Q6OmNvbXBpbGVTaGFkZXIpOiBMb2cgdGhlIHJhdyBhbmQgdHJhbnNs YXRlZAorICAgICAgICBpbnB1dCB0byBnbENvbXBpbGVTaGFkZXIsIGJ1dCBtYXJrIHRoZSBlbnRy eSBhcyBpbnZhbGlkLgorCiAyMDEzLTA5LTE5ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBw bGUuY29tPgogCiAgICAgICAgIFJFR1JFU1NJT04gKHIxNDk5MjgpOiBDYW52YXNTdHlsZTo6b3Bl cmF0b3I9IGxlYWtzIGV2ZXJ5dGhpbmcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL0xvZ2dpbmcuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0xvZ2dpbmcuaAppbmRleCA2 OTdiNDEwZWFiNTI4YTQ4OGMzYjU2ZmE5ZmMwMTUxNDMwNzYyZWM5Li45ZTA0ZTU5OGU2MTg5MDc2 MDVmZTIxNDVjMTRhZmU5ODhkMDkwODI1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9Mb2dnaW5nLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vTG9nZ2luZy5oCkBA IC02Niw2ICs2Niw3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICBNKFN0b3JhZ2VBUEkpIFwK ICAgICBNKFRocmVhZGluZykgXAogICAgIE0oV2ViQXVkaW8pIFwKKyAgICBNKFdlYkdMKSBcCiAK ICNkZWZpbmUgREVDTEFSRV9MT0dfQ0hBTk5FTChuYW1lKSBcCiAgICAgZXh0ZXJuIFdURkxvZ0No YW5uZWwgSk9JTl9MT0dfQ0hBTk5FTF9XSVRIX1BSRUZJWChMT0dfQ0hBTk5FTF9QUkVGSVgsIG5h bWUpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvb3Blbmds L0dyYXBoaWNzQ29udGV4dDNET3BlbkdMQ29tbW9uLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL29wZW5nbC9HcmFwaGljc0NvbnRleHQzRE9wZW5HTENvbW1vbi5jcHAKaW5k ZXggM2NlZDA3ODczM2I2YjI0MDYzODU0MzEwZmZjYmVlOWRlYTY0NTBiOS4uNDM4NWY2ZmIyNmE4 ZmNkY2UwNzc2YWJiOTU4ZmJjMTlkYzc3NzUzMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3Mvb3BlbmdsL0dyYXBoaWNzQ29udGV4dDNET3BlbkdMQ29tbW9uLmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9vcGVuZ2wvR3JhcGhpY3ND b250ZXh0M0RPcGVuR0xDb21tb24uY3BwCkBAIC00Miw2ICs0Miw3IEBACiAjaW5jbHVkZSAiSW1h Z2VEYXRhLmgiCiAjaW5jbHVkZSAiSW50UmVjdC5oIgogI2luY2x1ZGUgIkludFNpemUuaCIKKyNp bmNsdWRlICJMb2dnaW5nLmgiCiAjaW5jbHVkZSAiTm90SW1wbGVtZW50ZWQuaCIKICNpbmNsdWRl IDxjc3RyaW5nPgogI2luY2x1ZGUgPHJ1bnRpbWUvQXJyYXlCdWZmZXIuaD4KQEAgLTQ2OSwxMCAr NDcwLDE1IEBAIHZvaWQgR3JhcGhpY3NDb250ZXh0M0Q6OmNvbXBpbGVTaGFkZXIoUGxhdGZvcm0z RE9iamVjdCBzaGFkZXIpCiAgICAgICAgIDo6Z2xHZXRTaGFkZXJJbmZvTG9nKHNoYWRlciwgbGVu Z3RoLCAmc2l6ZSwgaW5mby5nZXQoKSk7CiAKICAgICAgICAgZW50cnkubG9nID0gaW5mby5nZXQo KTsKKworICAgICAgICBpZiAoR0xDb21waWxlU3VjY2VzcyAhPSBHTF9UUlVFKSB7CisgICAgICAg ICAgICBlbnRyeS5pc1ZhbGlkID0gZmFsc2U7CisgICAgICAgICAgICBMT0coV2ViR0wsICJFcnJv cjogc2hhZGVyIHRyYW5zbGF0b3IgcHJvZHVjZWQgYSBzaGFkZXIgdGhhdCBPcGVuR0wgd291bGQg bm90IGNvbXBpbGUuIik7CisgICAgICAgICAgICBMT0coV2ViR0wsICItLS0gYmVnaW4gb3JpZ2lu YWwgc2hhZGVyIHNvdXJjZSAtLS1cbiVzXG4tLS0gZW5kIG9yaWdpbmFsIHNoYWRlciBzb3VyY2Ug LS0tXG4iLCBnZXRTaGFkZXJTb3VyY2Uoc2hhZGVyKS51dGY4KCkuZGF0YSgpKTsKKyAgICAgICAg ICAgIExPRyhXZWJHTCwgIi0tLSBiZWdpbiB0cmFuc2xhdGVkIHNoYWRlciBzb3VyY2UgLS0tXG4l c1xuLS0tIGVuZCB0cmFuc2xhdGVkIHNoYWRlciBzb3VyY2UgLS0tIiwgdHJhbnNsYXRlZFNoYWRl clB0cik7CisgICAgICAgIH0KICAgICB9CiAgICAgCi0gICAgLy8gQVNTRVJUIHRoYXQgQU5HTEUg Z2VuZXJhdGVkIEdMU0wgd2lsbCBiZSBhY2NlcHRlZCBieSBPcGVuR0wuCi0gICAgQVNTRVJUKEdM Q29tcGlsZVN1Y2Nlc3MgPT0gR0xfVFJVRSk7CiAjaWYgUExBVEZPUk0oQkxBQ0tCRVJSWSkgJiYg IWRlZmluZWQoTkRFQlVHKQogICAgIGlmIChHTENvbXBpbGVTdWNjZXNzICE9IEdMX1RSVUUpCiAg ICAgICAgIEJCTE9HKEJsYWNrQmVycnk6OlBsYXRmb3JtOjpMb2dMZXZlbFdhcm4sICJUaGUgc2hh ZGVyIHZhbGlkYXRlZCwgYnV0IGRpZG4ndCBjb21waWxlLlxuIik7Cg==