121720 2013-09-20 14:46:23 -0700 WebFontDescription needs different declaration in DOMPrivate.idl 2013-09-21 17:12:20 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC Windows 7 RESOLVED DUPLICATE 121552 P3 Trivial --- 0 alex.christensen webkit-unassigned bfulgham paroga sfalken oldest_to_newest 931604 0 alex.christensen 2013-09-20 14:46:23 -0700 Back in the stone age (http://trac.webkit.org/changeset/27755) Steve added a declaration of WebFontDescription that worked with Visual Studio up through VS2010. VS2012 does not like this declaration, but it can be fixed simply without breaking anything. The idl file requires "interface WebFontDescription;" but WebKit.h that is generated from the idl file requires "typedef struct WebFontDescription WebFontDescription;", so using the cpp_quote MIDL attribute puts that string into WebKit.h. 931617 1 212224 alex.christensen 2013-09-20 14:57:21 -0700 Created attachment 212224 Patch 931619 2 212225 alex.christensen 2013-09-20 14:59:17 -0700 Created attachment 212225 patch 931638 3 alex.christensen 2013-09-20 15:39:14 -0700 *** This bug has been marked as a duplicate of bug 121552 *** 931667 4 bfulgham 2013-09-20 16:54:21 -0700 Yeah -- this is a better patch than the one paroga landed. I think we should use *this* version. 931842 5 alex.christensen 2013-09-21 17:12:20 -0700 I like Patrick's solution. There's no reason to have the interface declaration and the typedef when just having "struct WebFontDescription" in one location works. 212224 2013-09-20 14:57:21 -0700 2013-09-20 14:59:50 -0700 Patch bug-121720-20130920155856.patch text/plain 222 alex.christensen SW5kZXg6IFNvdXJjZS9XZWJLaXQvd2luL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09CkluZGV4OiBTb3Vy Y2UvV2ViS2l0L3dpbi9JbnRlcmZhY2VzL0RPTVByaXZhdGUuaWRsCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K 212225 2013-09-20 14:59:17 -0700 2013-09-20 15:40:39 -0700 patch diff text/plain 1022 alex.christensen SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDE1NjIw MykKKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEzLTA5 LTIwICBBbGV4IENocmlzdGVuc2VuICA8YWxleC5jaHJpc3RlbnNlbkBmbGV4c2ltLmNvbT4KKwor ICAgICAgICBDb21waWxlIGZpeCBmb3IgVlMyMDEyLgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIxNzIwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBJbnRlcmZhY2VzL0RPTVByaXZhdGUuaWRsOgorICAg ICAgICBVc2VkIGNwcF9xdW90ZSB0byBwdXQgV2ViRm9udERlc2NyaXB0aW9uIHN0cnVjdCBkZWNs YXJhdGlvbiBpbiBXZWJLaXQuaCwgYWRkZWQgaW50ZXJmYWNlIGRlY2xhcmF0aW9uLgorCiAyMDEz LTA5LTIwICBQYXRyaWNrIEdhbnN0ZXJlciAgPHBhcm9nYUB3ZWJraXQub3JnPgogCiAgICAgICAg IEZpeCBNSURMIGZpbGVzIGZvciBWaXN1YWwgU3R1ZGlvIDIwMTIKSW5kZXg6IEludGVyZmFjZXMv RE9NUHJpdmF0ZS5pZGwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gSW50ZXJmYWNlcy9ET01Qcml2YXRlLmlkbAko cmV2aXNpb24gMTU2MTE4KQorKysgSW50ZXJmYWNlcy9ET01Qcml2YXRlLmlkbAkod29ya2luZyBj b3B5KQpAQCAtMzEsNyArMzEsOCBAQAogCiBpbnRlcmZhY2UgSURPTUVsZW1lbnQ7CiAKLXR5cGVk ZWYgc3RydWN0IFdlYkZvbnREZXNjcmlwdGlvbiBXZWJGb250RGVzY3JpcHRpb247CitpbnRlcmZh Y2UgV2ViRm9udERlc2NyaXB0aW9uOworY3BwX3F1b3RlICgidHlwZWRlZiBzdHJ1Y3QgV2ViRm9u dERlc2NyaXB0aW9uIFdlYkZvbnREZXNjcmlwdGlvbjsiKQogCiBbCiAgICAgb2JqZWN0LAo=