121716 2013-09-20 14:09:46 -0700 Remove includes from LineWidth.h 2013-09-20 20:35:54 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 121261 1 zoltan zoltan commit-queue eflews.bot esprehn+autocc glenn gyuyoung.kim kondapallykalyan philn webkit-ews xan.lopez oldest_to_newest 931579 0 zoltan 2013-09-20 14:09:46 -0700 In r156197 I removed logicalLineHeight from LineWIdth.h, so we don't need to include RenderBlock.h and RenderRubyRun.h anymore in LineWidth.h. 931589 1 212217 zoltan 2013-09-20 14:24:21 -0700 Created attachment 212217 proposed patch 931591 2 212217 webkit-ews 2013-09-20 14:29:33 -0700 Comment on attachment 212217 proposed patch Attachment 212217 did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/2030006 931593 3 212217 webkit-ews 2013-09-20 14:30:17 -0700 Comment on attachment 212217 proposed patch Attachment 212217 did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/2033005 931595 4 212217 eflews.bot 2013-09-20 14:32:40 -0700 Comment on attachment 212217 proposed patch Attachment 212217 did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/1865203 931602 5 212220 zoltan 2013-09-20 14:45:01 -0700 Created attachment 212220 proposed patch 931705 6 212220 darin 2013-09-20 20:08:48 -0700 Comment on attachment 212220 proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=212220&action=review > Source/WebCore/rendering/LineWidth.h:38 > +struct LineSegment; Our normal style is to put struct forward declarations into a separate paragraph. I’ll still say cq+ though. No need to hold this up on such a small thing. 931707 7 zoltan 2013-09-20 20:28:28 -0700 (In reply to comment #6) > (From update of attachment 212220 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=212220&action=review > > > Source/WebCore/rendering/LineWidth.h:38 > > +struct LineSegment; > > Our normal style is to put struct forward declarations into a separate paragraph. I’ll still say cq+ though. No need to hold this up on such a small thing. It's good to know. Thanks for the review and the comment, I'll update it eventually, when I need to touch the code around the forward declarations. 931708 8 212220 commit-queue 2013-09-20 20:35:51 -0700 Comment on attachment 212220 proposed patch Clearing flags on attachment: 212220 Committed r156220: <http://trac.webkit.org/changeset/156220> 931709 9 commit-queue 2013-09-20 20:35:54 -0700 All reviewed patches have been landed. Closing bug. 212217 2013-09-20 14:24:21 -0700 2013-09-20 14:45:01 -0700 proposed patch includeremove.patch text/plain 1836 zoltan ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA2OTA3MTdhLi43MmU1MDE0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjAg QEAKIDIwMTMtMDktMjAgIFpvbHRhbiBIb3J2YXRoICA8em9sdGFuQHdlYmtpdC5vcmc+CiAKKyAg ICAgICAgUmVtb3ZlIGluY2x1ZGVzIGZyb20gTGluZVdpZHRoLmgKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMTcxNgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEluIHIxNTYxOTcgSSByZW1vdmVkIGxvZ2lj YWxMaW5lSGVpZ2h0IGZyb20gTGluZVdJZHRoLmgsIHNvIHdlIGRvbid0IG5lZWQgdG8gaW5jbHVk ZSBSZW5kZXJCbG9jay5oCisgICAgICAgIGFuZCBSZW5kZXJSdWJ5UnVuLmggYW55bW9yZSBpbiBM aW5lV2lkdGguaC4KKworICAgICAgICBObyBuZXcgdGVzdHMsIG5vIGJlaGF2aW9yIGNoYW5nZS4K KworICAgICAgICAqIHJlbmRlcmluZy9MaW5lV2lkdGguY3BwOgorICAgICAgICAqIHJlbmRlcmlu Zy9MaW5lV2lkdGguaDoKKworMjAxMy0wOS0yMCAgWm9sdGFuIEhvcnZhdGggIDx6b2x0YW5Ad2Vi a2l0Lm9yZz4KKwogICAgICAgICBNb3ZlIGxvZ2ljYWxIZWlnaHRGb3JMaW5lIG91dCBvZiBMaW5l V2lkdGguaAogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTIxNTc1CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9MaW5lV2lkdGgu Y3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0xpbmVXaWR0aC5jcHAKaW5kZXggMmY3ZDZi NC4uNWI2Nzc5MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0xpbmVXaWR0 aC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0xpbmVXaWR0aC5jcHAKQEAgLTMw LDYgKzMwLDEwIEBACiAjaW5jbHVkZSAiY29uZmlnLmgiCiAjaW5jbHVkZSAiTGluZVdpZHRoLmgi CiAKKyNpbmNsdWRlICJMYXlvdXRVbml0LmgiCisjaW5jbHVkZSAiUmVuZGVyQmxvY2suaCIKKyNp bmNsdWRlICJSZW5kZXJSdWJ5UnVuLmgiCisKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogTGluZVdp ZHRoOjpMaW5lV2lkdGgoUmVuZGVyQmxvY2smIGJsb2NrLCBib29sIGlzRmlyc3RMaW5lLCBJbmRl bnRUZXh0T3JOb3Qgc2hvdWxkSW5kZW50VGV4dCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9MaW5lV2lkdGguaCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9MaW5lV2lk dGguaAppbmRleCAyZTMyMzJmLi44ODliZDkwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvTGluZVdpZHRoLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0xpbmVX aWR0aC5oCkBAIC0zMCwxMSArMzAsMTUgQEAKICNpZm5kZWYgTGluZVdpZHRoX2gKICNkZWZpbmUg TGluZVdpZHRoX2gKIAotI2luY2x1ZGUgIlJlbmRlckJsb2NrLmgiCi0jaW5jbHVkZSAiUmVuZGVy UnVieVJ1bi5oIgotCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKK2NsYXNzIEZsb2F0aW5nT2JqZWN0 OworY2xhc3MgTGF5b3V0VW5pdDsKK3N0cnVjdCBMaW5lU2VnbWVudDsKK2NsYXNzIFJlbmRlckJs b2NrOworY2xhc3MgUmVuZGVyT2JqZWN0OworY2xhc3MgUmVuZGVyUnVieVJ1bjsKKwogZW51bSBJ bmRlbnRUZXh0T3JOb3QgeyBEb05vdEluZGVudFRleHQsIEluZGVudFRleHQgfTsKIAogY2xhc3Mg TGluZVdpZHRoIHsK 212220 2013-09-20 14:45:01 -0700 2013-09-20 20:35:51 -0700 proposed patch includeremove.patch text/plain 1816 zoltan ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA2OTA3MTdhLi5lMjUyMzY1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjAg QEAKIDIwMTMtMDktMjAgIFpvbHRhbiBIb3J2YXRoICA8em9sdGFuQHdlYmtpdC5vcmc+CiAKKyAg ICAgICAgUmVtb3ZlIGluY2x1ZGVzIGZyb20gTGluZVdpZHRoLmgKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMTcxNgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEluIHIxNTYxOTcgSSByZW1vdmVkIGxvZ2lj YWxMaW5lSGVpZ2h0IGZyb20gTGluZVdpZHRoLmgsIHNvIHdlIGRvbid0IG5lZWQgdG8gaW5jbHVk ZSBSZW5kZXJCbG9jay5oCisgICAgICAgIGFuZCBSZW5kZXJSdWJ5UnVuLmggYW55bW9yZSBpbiBM aW5lV2lkdGguaC4KKworICAgICAgICBObyBuZXcgdGVzdHMsIG5vIGJlaGF2aW9yIGNoYW5nZS4K KworICAgICAgICAqIHJlbmRlcmluZy9MaW5lV2lkdGguY3BwOgorICAgICAgICAqIHJlbmRlcmlu Zy9MaW5lV2lkdGguaDoKKworMjAxMy0wOS0yMCAgWm9sdGFuIEhvcnZhdGggIDx6b2x0YW5Ad2Vi a2l0Lm9yZz4KKwogICAgICAgICBNb3ZlIGxvZ2ljYWxIZWlnaHRGb3JMaW5lIG91dCBvZiBMaW5l V2lkdGguaAogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTIxNTc1CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9MaW5lV2lkdGgu Y3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0xpbmVXaWR0aC5jcHAKaW5kZXggMmY3ZDZi NC4uZmMxZjQ2NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0xpbmVXaWR0 aC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0xpbmVXaWR0aC5jcHAKQEAgLTMw LDYgKzMwLDkgQEAKICNpbmNsdWRlICJjb25maWcuaCIKICNpbmNsdWRlICJMaW5lV2lkdGguaCIK IAorI2luY2x1ZGUgIlJlbmRlckJsb2NrLmgiCisjaW5jbHVkZSAiUmVuZGVyUnVieVJ1bi5oIgor CiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKIExpbmVXaWR0aDo6TGluZVdpZHRoKFJlbmRlckJsb2Nr JiBibG9jaywgYm9vbCBpc0ZpcnN0TGluZSwgSW5kZW50VGV4dE9yTm90IHNob3VsZEluZGVudFRl eHQpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvTGluZVdpZHRoLmggYi9T b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvTGluZVdpZHRoLmgKaW5kZXggMmUzMjMyZi4uNDI3Yzc0 YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0xpbmVXaWR0aC5oCisrKyBi L1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9MaW5lV2lkdGguaApAQCAtMzAsMTEgKzMwLDE2IEBA CiAjaWZuZGVmIExpbmVXaWR0aF9oCiAjZGVmaW5lIExpbmVXaWR0aF9oCiAKLSNpbmNsdWRlICJS ZW5kZXJCbG9jay5oIgotI2luY2x1ZGUgIlJlbmRlclJ1YnlSdW4uaCIKKyNpbmNsdWRlICJMYXlv dXRVbml0LmgiCiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAorY2xhc3MgRmxvYXRpbmdPYmplY3Q7 CitzdHJ1Y3QgTGluZVNlZ21lbnQ7CitjbGFzcyBSZW5kZXJCbG9jazsKK2NsYXNzIFJlbmRlck9i amVjdDsKK2NsYXNzIFJlbmRlclJ1YnlSdW47CisKIGVudW0gSW5kZW50VGV4dE9yTm90IHsgRG9O b3RJbmRlbnRUZXh0LCBJbmRlbnRUZXh0IH07CiAKIGNsYXNzIExpbmVXaWR0aCB7Cg==