121696 2013-09-20 10:54:46 -0700 Add an argument to ImageSource::createFrameAtIndex to hint a decoder that we expect a scaled image. 2013-09-20 13:34:36 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 yongjun_zhang webkit-unassigned commit-queue ddkilzer joepeck koivisto yongjun_zhang oldest_to_newest 931461 0 yongjun_zhang 2013-09-20 10:54:46 -0700 Some platform image decoders have the capability to decode an image in different scale levels. If we are going to paint an image in scaled down size, we can hint the decoder to give the image in the right scale to save some memory. 931473 1 212197 yongjun_zhang 2013-09-20 11:16:00 -0700 Created attachment 212197 add scale to hint platform decoders that we expect a scaled image. 931487 2 212197 koivisto 2013-09-20 11:35:36 -0700 Comment on attachment 212197 add scale to hint platform decoders that we expect a scaled image. View in context: https://bugs.webkit.org/attachment.cgi?id=212197&action=review > Source/WebCore/platform/graphics/ImageSource.h:148 > + PassNativeImagePtr createFrameAtIndex(size_t, float* scale = 0); It is not clear if this scale parameter is input, output or both. Maybe a more descriptive name would help? 931561 3 212197 commit-queue 2013-09-20 13:34:34 -0700 Comment on attachment 212197 add scale to hint platform decoders that we expect a scaled image. Clearing flags on attachment: 212197 Committed r156195: <http://trac.webkit.org/changeset/156195> 931562 4 commit-queue 2013-09-20 13:34:36 -0700 All reviewed patches have been landed. Closing bug. 212197 2013-09-20 11:16:00 -0700 2013-09-20 13:34:34 -0700 add scale to hint platform decoders that we expect a scaled image. createFrameAtIndex.patch text/plain 2963 yongjun_zhang SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1NjE4MCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDEzLTA5LTIwICBZb25nanVu IFpoYW5nICA8eW9uZ2p1bl96aGFuZ0BhcHBsZS5jb20+CisKKyAgICAgICAgQWRkIGFuIGFyZ3Vt ZW50IHRvIEltYWdlU291cmNlOjpjcmVhdGVGcmFtZUF0SW5kZXggdG8gaGludCBhIGRlY29kZXIg dGhhdCB3ZSBleHBlY3QgYSBzY2FsZWQgaW1hZ2UuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjE2OTYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgYW4gYXJndW1lbnQgdG8gSW1hZ2VTb3VyY2U6OmNy ZWF0ZUZyYW1lQXRJbmRleC4gIEEgcGxhdGZvcm0gaW1hZ2UgZGVjb2RlciBjYW4gZGVjaWRlIHRo ZSBvcHRpbWFsCisgICAgICAgIHNjYWxlIGJhc2VkIG9uIHRoZSBoaW50IGFuZCBwYXNzIHRoZSBy ZWFsIHNjYWxlIGl0IHVzZWQgZm9yIGRlY29kaW5nLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywg bm8gYmVoYXZpb3IgY2hhbmdlLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvSW1hZ2VT b3VyY2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SW1hZ2VTb3VyY2U6OmNyZWF0ZUZyYW1lQXRJ bmRleCk6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvSW1hZ2VTb3VyY2UuaDoKKyAgICAg ICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jZy9JbWFnZVNvdXJjZUNHLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OkltYWdlU291cmNlOjpjcmVhdGVGcmFtZUF0SW5kZXgpOgorCiAyMDEzLTA5LTIwICBS eW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAgIHJlbmRlclN0eWxlT2ZF bmNsb3NpbmdUZXh0Tm9kZSBzaG91bGQgdXBkYXRlIHN0eWxlIGJlZm9yZSB1c2luZyBhIHJlbmRl cmVyCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9JbWFnZVNvdXJjZS5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvSW1hZ2VT b3VyY2UuY3BwCShyZXZpc2lvbiAxNTYxODApCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9JbWFnZVNvdXJjZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEzNiw4ICsxMzYsMTAg QEAgc2l6ZV90IEltYWdlU291cmNlOjpmcmFtZUNvdW50KCkgY29uc3QKICAgICByZXR1cm4gbV9k ZWNvZGVyID8gbV9kZWNvZGVyLT5mcmFtZUNvdW50KCkgOiAwOwogfQogCi1QYXNzTmF0aXZlSW1h Z2VQdHIgSW1hZ2VTb3VyY2U6OmNyZWF0ZUZyYW1lQXRJbmRleChzaXplX3QgaW5kZXgpCitQYXNz TmF0aXZlSW1hZ2VQdHIgSW1hZ2VTb3VyY2U6OmNyZWF0ZUZyYW1lQXRJbmRleChzaXplX3QgaW5k ZXgsIGZsb2F0KiBzY2FsZSkKIHsKKyAgICBVTlVTRURfUEFSQU0oc2NhbGUpOworCiAgICAgaWYg KCFtX2RlY29kZXIpCiAgICAgICAgIHJldHVybiAwOwogCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9JbWFnZVNvdXJjZS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL0ltYWdlU291cmNlLmgJKHJldmlzaW9uIDE1NjE4MCkKKysr IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0ltYWdlU291cmNlLmgJKHdvcmtpbmcg Y29weSkKQEAgLTE0NSw3ICsxNDUsNyBAQCBwdWJsaWM6CiAKICAgICAvLyBDYWxsZXJzIHNob3Vs ZCBub3QgY2FsbCB0aGlzIGFmdGVyIGNhbGxpbmcgY2xlYXIoKSB3aXRoIGEgaGlnaGVyIGluZGV4 OwogICAgIC8vIHNlZSBjb21tZW50cyBvbiBjbGVhcigpIGFib3ZlLgotICAgIFBhc3NOYXRpdmVJ bWFnZVB0ciBjcmVhdGVGcmFtZUF0SW5kZXgoc2l6ZV90KTsKKyAgICBQYXNzTmF0aXZlSW1hZ2VQ dHIgY3JlYXRlRnJhbWVBdEluZGV4KHNpemVfdCwgZmxvYXQqIHNjYWxlID0gMCk7CiAKICAgICBm bG9hdCBmcmFtZUR1cmF0aW9uQXRJbmRleChzaXplX3QpOwogICAgIGJvb2wgZnJhbWVIYXNBbHBo YUF0SW5kZXgoc2l6ZV90KTsgLy8gV2hldGhlciBvciBub3QgdGhlIGZyYW1lIGFjdHVhbGx5IHVz ZWQgYW55IGFscGhhLgpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2cv SW1hZ2VTb3VyY2VDRy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvY2cvSW1hZ2VTb3VyY2VDRy5jcHAJKHJldmlzaW9uIDE1NjE4MCkKKysrIFNvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NnL0ltYWdlU291cmNlQ0cuY3BwCSh3b3JraW5n IGNvcHkpCkBAIC0yOTEsOCArMjkxLDEwIEBAIHNpemVfdCBJbWFnZVNvdXJjZTo6ZnJhbWVDb3Vu dCgpIGNvbnN0CiAgICAgcmV0dXJuIG1fZGVjb2RlciA/IENHSW1hZ2VTb3VyY2VHZXRDb3VudCht X2RlY29kZXIpIDogMDsKIH0KIAotQ0dJbWFnZVJlZiBJbWFnZVNvdXJjZTo6Y3JlYXRlRnJhbWVB dEluZGV4KHNpemVfdCBpbmRleCkKK0NHSW1hZ2VSZWYgSW1hZ2VTb3VyY2U6OmNyZWF0ZUZyYW1l QXRJbmRleChzaXplX3QgaW5kZXgsIGZsb2F0KiBzY2FsZSkKIHsKKyAgICBVTlVTRURfUEFSQU0o c2NhbGUpOworCiAgICAgaWYgKCFpbml0aWFsaXplZCgpKQogICAgICAgICByZXR1cm4gMDsKIAo=