121681 2013-09-20 07:41:06 -0700 [Qt] Crash when trying to download blob URL 2013-09-25 07:50:25 -0700 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 allan.jensen allan.jensen abrhm commit-queue hausmann jturcotte kadam ossy zarvai oldest_to_newest 931325 0 allan.jensen 2013-09-20 07:41:06 -0700 If a webpage sets up a link that triggers a download of a blob URL, qtwebkit crashes. 931328 1 212163 allan.jensen 2013-09-20 07:45:12 -0700 Created attachment 212163 Patch 931330 2 commit-queue 2013-09-20 07:47:17 -0700 Attachment 212163 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/platform/qt/TestExpectations', u'Source/WebCore/ChangeLog', u'Source/WebCore/platform/network/qt/ResourceRequestQt.cpp', u'Source/WebKit/qt/ChangeLog', u'Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp']" exit_code: 1 Source/WebCore/platform/network/qt/ResourceRequestQt.cpp:65: One line control clauses should not use braces. [whitespace/braces] [4] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style. 932537 3 212163 commit-queue 2013-09-24 07:15:11 -0700 Comment on attachment 212163 Patch Clearing flags on attachment: 212163 Committed r156330: <http://trac.webkit.org/changeset/156330> 932538 4 commit-queue 2013-09-24 07:15:13 -0700 All reviewed patches have been landed. Closing bug. 932786 5 ossy 2013-09-24 16:30:12 -0700 (In reply to comment #3) > (From update of attachment 212163 [details]) > Clearing flags on attachment: 212163 > > Committed r156330: <http://trac.webkit.org/changeset/156330> FYI: It broke the !ENABLE(BLOB) builds. 932794 6 allan.jensen 2013-09-24 16:43:59 -0700 (In reply to comment #5) > (In reply to comment #3) > > (From update of attachment 212163 [details] [details]) > > Clearing flags on attachment: 212163 > > > > Committed r156330: <http://trac.webkit.org/changeset/156330> > > FYI: It broke the !ENABLE(BLOB) builds. Thanks for the warning. I will try to fix it tomorrow. 933003 7 allan.jensen 2013-09-25 07:50:25 -0700 Compile fix for !ENABLE(BLOB) landed in r156394 212163 2013-09-20 07:45:12 -0700 2013-09-24 07:15:11 -0700 Patch bug-121681-20130920164511.patch text/plain 7066 allan.jensen U3VidmVyc2lvbiBSZXZpc2lvbjogMTU2MTQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2Q1YWU1ODc1OGY2MDZm MzYxZjU5YmZjZmRmYzc4ZWE3MzM1NTk5MC4uMTE0OTljMTJhNzdkNmJjMWIzZGI1NGIxOGY1M2I3 NzZmMWM5NmQxNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEzLTA5LTIwICBBbGxh biBTYW5kZmVsZCBKZW5zZW4gIDxhbGxhbi5qZW5zZW5AZGlnaWEuY29tPgorCisgICAgICAgIFtR dF0gQ3Jhc2ggd2hlbiB0cnlpbmcgdG8gZG93bmxvYWQgYmxvYiB1cmwKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMTY4MQorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlc29sdmUgYW55IGJsb2IgVVJMcyBi ZWZvcmUgY3JlYXRpbmcgYSBRVXJsLgorCisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9xdC9S ZXNvdXJjZVJlcXVlc3RRdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjphcHBlbmRCbG9iUmVzb2x2 ZWQpOgorICAgICAgICAoV2ViQ29yZTo6cmVzb2x2ZUJsb2JVcmwpOgorICAgICAgICAoV2ViQ29y ZTo6UmVzb3VyY2VSZXF1ZXN0Ojp0b05ldHdvcmtSZXF1ZXN0KToKKwogMjAxMy0wOS0yMCAgQW50 dGkgS29pdmlzdG8gIDxhbnR0aUBhcHBsZS5jb20+CiAKICAgICAgICAgQWRkIGNvdmFyaWFudCBS ZW5kZXJFbGVtZW50KiBFbGVtZW50OjpyZW5kZXJlcigpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0L3F0L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCmluZGV4IGZjMjFl N2RhMjRlYjc0ODZiZjgyMGUxY2U1M2M0YzgyMWU0MDJlM2EuLmUwYTk4YzAxMzI2YWMxNTJhMDFi NTg1NDYzNmVhNGU2MWRjMDNhZWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdl TG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIw MTMtMDktMjAgIEFsbGFuIFNhbmRmZWxkIEplbnNlbiAgPGFsbGFuLmplbnNlbkBkaWdpYS5jb20+ CisKKyAgICAgICAgW1F0XSBDcmFzaCB3aGVuIHRyeWluZyB0byBkb3dubG9hZCBibG9iIHVybAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIxNjgxCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRG8gbm90IGNy YXNoIGlmIGEgZG93bmxvYWQgd2FzIHRyaWdnZXJlZCBvbiBhIHJlc291cmNlIFdlYkNvcmUgaGFu ZGxlcyBpbnRlcm5hbGx5LgorCisgICAgICAgICogV2ViQ29yZVN1cHBvcnQvRnJhbWVMb2FkZXJD bGllbnRRdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpGcmFtZUxvYWRlckNsaWVudFF0Ojpjb252 ZXJ0TWFpblJlc291cmNlTG9hZFRvRG93bmxvYWQpOgorCiAyMDEzLTA5LTE5ICBBbGxhbiBTYW5k ZmVsZCBKZW5zZW4gIDxhbGxhbi5qZW5zZW5AZGlnaWEuY29tPgogCiAgICAgICAgIEtlZXAgY2hh c2luZyB0aGUgZGVmaW5pdGlvbiBvZiBRQWNjZXNzaWJsZVdpZGdldApkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9xdC9SZXNvdXJjZVJlcXVlc3RRdC5jcHAgYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3F0L1Jlc291cmNlUmVxdWVzdFF0LmNwcApp bmRleCBlODRlNjc3YTVmNzJjNzFlODljNjAwZmQ3NzcwMGJiNjgyMjE0YzJjLi4zZmY5NDQxNzMz MjE1ZGFiZjgzZjJkODdhMjY3ZmMxNWFlZWU3YTA5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9uZXR3b3JrL3F0L1Jlc291cmNlUmVxdWVzdFF0LmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3F0L1Jlc291cmNlUmVxdWVzdFF0LmNwcApAQCAtMTgs NiArMTgsOSBAQAogKi8KIAogI2luY2x1ZGUgImNvbmZpZy5oIgorI2luY2x1ZGUgIkJsb2JEYXRh LmgiCisjaW5jbHVkZSAiQmxvYlJlZ2lzdHJ5SW1wbC5oIgorI2luY2x1ZGUgIkJsb2JTdG9yYWdl RGF0YS5oIgogI2luY2x1ZGUgIk5ldHdvcmtpbmdDb250ZXh0LmgiCiAjaW5jbHVkZSAiUmVzb3Vy Y2VSZXF1ZXN0LmgiCiAjaW5jbHVkZSAiVGhpcmRQYXJ0eUNvb2tpZXNRdC5oIgpAQCAtNDAsMTAg KzQzLDU2IEBAIHVuc2lnbmVkIGluaXRpYWxpemVNYXhpbXVtSFRUUENvbm5lY3Rpb25Db3VudFBl ckhvc3QoKQogICAgIHJldHVybiA2ICogKDEgKyAzICsgMik7CiB9CiAKK3N0YXRpYyB2b2lkIGFw cGVuZEJsb2JSZXNvbHZlZChRQnl0ZUFycmF5JiBkYXRhLCBjb25zdCBRVXJsJiB1cmwsIFFTdHJp bmcqIGNvbnRlbnRUeXBlID0gMCkKK3sKKyAgICBSZWZQdHI8QmxvYlN0b3JhZ2VEYXRhPiBibG9i RGF0YSA9IHN0YXRpY19jYXN0PEJsb2JSZWdpc3RyeUltcGwmPihibG9iUmVnaXN0cnkoKSkuZ2V0 QmxvYkRhdGFGcm9tVVJMKHVybCk7CisgICAgaWYgKCFibG9iRGF0YSkKKyAgICAgICAgcmV0dXJu OworCisgICAgaWYgKGNvbnRlbnRUeXBlKQorICAgICAgICAqY29udGVudFR5cGUgPSBibG9iRGF0 YS0+Y29udGVudFR5cGUoKTsKKworICAgIEJsb2JEYXRhSXRlbUxpc3Q6OmNvbnN0X2l0ZXJhdG9y IGl0ID0gYmxvYkRhdGEtPml0ZW1zKCkuYmVnaW4oKTsKKyAgICBjb25zdCBCbG9iRGF0YUl0ZW1M aXN0Ojpjb25zdF9pdGVyYXRvciBpdGVuZCA9IGJsb2JEYXRhLT5pdGVtcygpLmVuZCgpOworICAg IGZvciAoOyBpdCAhPSBpdGVuZDsgKytpdCkgeworICAgICAgICBjb25zdCBCbG9iRGF0YUl0ZW0m IGJsb2JJdGVtID0gKml0OworICAgICAgICBpZiAoYmxvYkl0ZW0udHlwZSA9PSBCbG9iRGF0YUl0 ZW06OkRhdGEpCisgICAgICAgICAgICBkYXRhLmFwcGVuZChibG9iSXRlbS5kYXRhLT5kYXRhKCkg KyBzdGF0aWNfY2FzdDxpbnQ+KGJsb2JJdGVtLm9mZnNldCksIHN0YXRpY19jYXN0PGludD4oYmxv Ykl0ZW0ubGVuZ3RoKSk7CisgICAgICAgIGVsc2UgaWYgKGJsb2JJdGVtLnR5cGUgPT0gQmxvYkRh dGFJdGVtOjpCbG9iKQorICAgICAgICAgICAgYXBwZW5kQmxvYlJlc29sdmVkKGRhdGEsIGJsb2JJ dGVtLnVybCk7CisgICAgICAgIGVsc2UgaWYgKGJsb2JJdGVtLnR5cGUgPT0gQmxvYkRhdGFJdGVt OjpGaWxlKSB7CisgICAgICAgICAgICAvLyBGaWxlIHR5cGVzIGFyZSBub3QgYWxsb3dlZCBoZXJl LCBzbyBqdXN0IGlnbm9yZSBpdC4KKyAgICAgICAgfSBlbHNlCisgICAgICAgICAgICBBU1NFUlRf Tk9UX1JFQUNIRUQoKTsKKyAgICB9Cit9CisKK3N0YXRpYyB2b2lkIHJlc29sdmVCbG9iVXJsKGNv bnN0IFFVcmwmIHVybCwgUVVybCYgcmVzb2x2ZWRVcmwpCit7CisgICAgUmVmUHRyPEJsb2JTdG9y YWdlRGF0YT4gYmxvYkRhdGEgPSBzdGF0aWNfY2FzdDxCbG9iUmVnaXN0cnlJbXBsJj4oYmxvYlJl Z2lzdHJ5KCkpLmdldEJsb2JEYXRhRnJvbVVSTCh1cmwpOworICAgIGlmICghYmxvYkRhdGEpCisg ICAgICAgIHJldHVybjsKKworICAgIFFCeXRlQXJyYXkgZGF0YTsKKyAgICBRU3RyaW5nIGNvbnRl bnRUeXBlOworICAgIGFwcGVuZEJsb2JSZXNvbHZlZChkYXRhLCB1cmwsICZjb250ZW50VHlwZSk7 CisKKyAgICBRU3RyaW5nIGRhdGFVcmkoUVN0cmluZ0xpdGVyYWwoImRhdGE6IikpOworICAgIGRh dGFVcmkuYXBwZW5kKGNvbnRlbnRUeXBlKTsKKyAgICBkYXRhVXJpLmFwcGVuZChRU3RyaW5nTGl0 ZXJhbCgiO2Jhc2U2NCwiKSk7CisgICAgZGF0YVVyaS5hcHBlbmQoUVN0cmluZzo6ZnJvbUxhdGlu MShkYXRhLnRvQmFzZTY0KCkpKTsKKyAgICByZXNvbHZlZFVybCA9IFFVcmwoZGF0YVVyaSk7Cit9 CisKIFFOZXR3b3JrUmVxdWVzdCBSZXNvdXJjZVJlcXVlc3Q6OnRvTmV0d29ya1JlcXVlc3QoTmV0 d29ya2luZ0NvbnRleHQgKmNvbnRleHQpIGNvbnN0CiB7CiAgICAgUU5ldHdvcmtSZXF1ZXN0IHJl cXVlc3Q7Ci0gICAgcmVxdWVzdC5zZXRVcmwodXJsKCkpOworICAgIFFVcmwgbmV3dXJsID0gdXJs KCk7CisKKyAgICBpZiAobmV3dXJsLnNjaGVtZSgpID09IFFMYXRpbjFTdHJpbmcoImJsb2IiKSkK KyAgICAgICAgcmVzb2x2ZUJsb2JVcmwodXJsKCksIG5ld3VybCk7CisKKyAgICByZXF1ZXN0LnNl dFVybChuZXd1cmwpOwogICAgIHJlcXVlc3Quc2V0T3JpZ2luYXRpbmdPYmplY3QoY29udGV4dCA/ IGNvbnRleHQtPm9yaWdpbmF0aW5nT2JqZWN0KCkgOiAwKTsKIAogICAgIGNvbnN0IEhUVFBIZWFk ZXJNYXAgJmhlYWRlcnMgPSBodHRwSGVhZGVyRmllbGRzKCk7CmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50UXQuY3BwIGIvU291cmNl L1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9GcmFtZUxvYWRlckNsaWVudFF0LmNwcAppbmRleCA4 YzczNWE1NzE4NzQxZDNiMDQ3NmI4ZmVhYzBhZDU1MjNkMzY1NDA4Li4xOTgxZmQxYmRhZTdkMjJi OWIyYWE0NTRkNzUzMTczYmE5MTc0NDNiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L3F0L1dl YkNvcmVTdXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50UXQuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQv cXQvV2ViQ29yZVN1cHBvcnQvRnJhbWVMb2FkZXJDbGllbnRRdC5jcHAKQEAgLTk4MiwxMiArOTgy LDE3IEBAIFdURjo6UGFzc1JlZlB0cjxXZWJDb3JlOjpEb2N1bWVudExvYWRlcj4gRnJhbWVMb2Fk ZXJDbGllbnRRdDo6Y3JlYXRlRG9jdW1lbnRMb2FkCiAgICAgcmV0dXJuIGxvYWRlci5yZWxlYXNl KCk7CiB9CiAKLXZvaWQgRnJhbWVMb2FkZXJDbGllbnRRdDo6Y29udmVydE1haW5SZXNvdXJjZUxv YWRUb0Rvd25sb2FkKFdlYkNvcmU6OkRvY3VtZW50TG9hZGVyKiBkb2N1bWVudExvYWRlciwgY29u c3QgV2ViQ29yZTo6UmVzb3VyY2VSZXF1ZXN0JiwgY29uc3QgV2ViQ29yZTo6UmVzb3VyY2VSZXNw b25zZSYpCit2b2lkIEZyYW1lTG9hZGVyQ2xpZW50UXQ6OmNvbnZlcnRNYWluUmVzb3VyY2VMb2Fk VG9Eb3dubG9hZChXZWJDb3JlOjpEb2N1bWVudExvYWRlciogZG9jdW1lbnRMb2FkZXIsIGNvbnN0 IFdlYkNvcmU6OlJlc291cmNlUmVxdWVzdCYgcmVxdWVzdCwgY29uc3QgV2ViQ29yZTo6UmVzb3Vy Y2VSZXNwb25zZSYpCiB7CiAgICAgaWYgKCFtX3dlYkZyYW1lKQogICAgICAgICByZXR1cm47CiAK ICAgICBRTmV0d29ya1JlcGx5SGFuZGxlciogaGFuZGxlciA9IGRvY3VtZW50TG9hZGVyLT5tYWlu UmVzb3VyY2VMb2FkZXIoKS0+aGFuZGxlKCktPmdldEludGVybmFsKCktPm1fam9iOworICAgIGlm ICghaGFuZGxlcikgeworICAgICAgICBxV2FybmluZygiQXR0ZW1wdGVkIHRvIGRvd25sb2FkIHVu c3VwcG9ydGVkIFVSTCAlcyIsIHJlcXVlc3QudXJsKCkuc3RyaW5nKCkuY2hhcmFjdGVyczgoKSk7 CisgICAgICAgIHJldHVybjsKKyAgICB9CisKICAgICBRTmV0d29ya1JlcGx5KiByZXBseSA9IGhh bmRsZXItPnJlbGVhc2UoKTsKICAgICBpZiAocmVwbHkpIHsKICAgICAgICAgaWYgKG1fd2ViRnJh bWUtPnBhZ2VBZGFwdGVyLT5mb3J3YXJkVW5zdXBwb3J0ZWRDb250ZW50KQpkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDU3NThj NDY4NTBlZDdlZDI0Y2Y0ZGQ2YjBkN2I2YmE4MGE5ODNlODAuLjdjNzA0NjM0MGZhOWExZDk2NGUz MTlhMTA4NDU5Y2YyNjAwOTBhMTggMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZwor KysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMy0wOS0yMCAg QWxsYW4gU2FuZGZlbGQgSmVuc2VuICA8YWxsYW4uamVuc2VuQGRpZ2lhLmNvbT4KKworICAgICAg ICBbUXRdIENyYXNoIHdoZW4gdHJ5aW5nIHRvIGRvd25sb2FkIGJsb2IgdXJsCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjE2ODEKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVbnNraXAgdHdvIHRlc3RzIHRo YXQgZG93bmxvYWRzIGJsb2IgVVJMcy4gTm90ZSB0aGUgdHdvIHRlc3RzIGRvIG5vdCB1c2UgdGhl IGRvd25sb2FkIGF0dHJpYnV0ZSBmZWF0dXJlLgorCisgICAgICAgICogcGxhdGZvcm0vcXQvVGVz dEV4cGVjdGF0aW9uczoKKwogMjAxMy0wOS0yMCAgR2Fib3IgQWJyYWhhbSAgPGFicmhtQGluZi51 LXN6ZWdlZC5odT4KIAogICAgICAgICBbUXRdIFVucmV2aWV3ZWQgZ2FyZGVuaW5nLiBSZWJhc2Ug dGVzdHMuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9UZXN0RXhwZWN0YXRp b25zIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvVGVzdEV4cGVjdGF0aW9ucwppbmRleCAwZDFm ODY2MzMwZmU3NzQwNzVlMDhkY2E5YWY5YjdjNjEyM2Y1ZmEwLi5kM2JjY2MwNzVmYmZkOWVhMDNh MTcwZDdmNGFmN2ZlYmFjM2Q2MTdhIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9x dC9UZXN0RXhwZWN0YXRpb25zCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL3F0L1Rlc3RFeHBl Y3RhdGlvbnMKQEAgLTQxNywxMCArNDE3LDggQEAgZmFzdC9ldmVudHMvcGxhdGZvcm0td2hlZWxl dmVudC1wYWdpbmcteS1pbi1zY3JvbGxpbmctZGl2Lmh0bWwKIGZhc3QvZXZlbnRzL3BsYXRmb3Jt LXdoZWVsZXZlbnQtcGFnaW5nLXktaW4tc2Nyb2xsaW5nLXBhZ2UuaHRtbAogCiAjIFRlc3RzIHRo YXQgcmVxdWlyZSBFTkFCTEUoRE9XTkxPQURfQVRUUklCVVRFKS4KLWZhc3QvZG9tL0hUTUxBbmNo b3JFbGVtZW50L2FuY2hvci1ub2Rvd25sb2FkLmh0bWwKIGZhc3QvZG9tL0hUTUxBbmNob3JFbGVt ZW50L2FuY2hvci1kb3dubG9hZC5odG1sCiBmYXN0L2RvbS9IVE1MQW5jaG9yRWxlbWVudC9hbmNo b3Itbm9kb3dubG9hZC1zZXQuaHRtbAotZmFzdC9kb20vSFRNTEFuY2hvckVsZW1lbnQvYW5jaG9y LWRvd25sb2FkLXVuc2V0Lmh0bWwKIAogIyBSZXF1aXJlIEVOQUJMRShDVVNUT01fRUxFTUVOVFMp IHN1cHBvcnQKIHdlYmtpdC5vcmcvYi8xMTA3MzUgZmFzdC9kb20vY3VzdG9tIFsgU2tpcCBdCg==