121672 2013-09-20 04:34:22 -0700 [CMake] Use COMPILE_DEFINITIONS target property for setting BUILDING_* defines 2013-09-20 06:22:22 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 paroga paroga benjamin cmarcelo commit-queue gyuyoung.kim rakuco oldest_to_newest 931267 0 paroga 2013-09-20 04:34:22 -0700 [CMake] Use COMPILE_DEFINITIONS target property for setting BUILDING_* defines 931270 1 212149 paroga 2013-09-20 04:41:45 -0700 Created attachment 212149 Patch 931292 2 212149 gyuyoung.kim 2013-09-20 05:55:48 -0700 Comment on attachment 212149 Patch Looks make sense. 931303 3 212149 commit-queue 2013-09-20 06:22:20 -0700 Comment on attachment 212149 Patch Clearing flags on attachment: 212149 Committed r156159: <http://trac.webkit.org/changeset/156159> 931304 4 commit-queue 2013-09-20 06:22:22 -0700 All reviewed patches have been landed. Closing bug. 212149 2013-09-20 04:41:45 -0700 2013-09-20 06:22:20 -0700 Patch bug-121672.patch text/plain 5989 paroga ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DTWFrZUxpc3RzLnR4dCBiL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9DTWFrZUxpc3RzLnR4dAppbmRleCBmMDIwYzNmLi42MzU0NjZiIDEw MDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ01ha2VMaXN0cy50eHQKKysrIGIvU291 cmNlL0phdmFTY3JpcHRDb3JlL0NNYWtlTGlzdHMudHh0CkBAIC02NjQsOSArNjY0LDEwIEBAIGFk ZF9zdWJkaXJlY3Rvcnkoc2hlbGwpCiAKIFdFQktJVF9XUkFQX1NPVVJDRUxJU1QoJHtKYXZhU2Ny aXB0Q29yZV9TT1VSQ0VTfSkKIGluY2x1ZGVfZGlyZWN0b3JpZXMoJHtKYXZhU2NyaXB0Q29yZV9J TkNMVURFX0RJUkVDVE9SSUVTfSkKLWFkZF9kZWZpbml0aW9ucygtREJVSUxESU5HX0phdmFTY3Jp cHRDb3JlIC1EU1RBVElDQUxMWV9MSU5LRURfV0lUSF9XVEYpCithZGRfZGVmaW5pdGlvbnMoLURT VEFUSUNBTExZX0xJTktFRF9XSVRIX1dURikKIGFkZF9saWJyYXJ5KEphdmFTY3JpcHRDb3JlICR7 SmF2YVNjcmlwdENvcmVfTElCUkFSWV9UWVBFfSAke0phdmFTY3JpcHRDb3JlX0hFQURFUlN9ICR7 SmF2YVNjcmlwdENvcmVfU09VUkNFU30pCiB0YXJnZXRfbGlua19saWJyYXJpZXMoSmF2YVNjcmlw dENvcmUgJHtKYXZhU2NyaXB0Q29yZV9MSUJSQVJJRVN9KQorc2V0X3RhcmdldF9wcm9wZXJ0aWVz KEphdmFTY3JpcHRDb3JlIFBST1BFUlRJRVMgQ09NUElMRV9ERUZJTklUSU9OUyAiQlVJTERJTkdf SmF2YVNjcmlwdENvcmUiKQogc2V0X3RhcmdldF9wcm9wZXJ0aWVzKEphdmFTY3JpcHRDb3JlIFBS T1BFUlRJRVMgRk9MREVSICJKYXZhU2NyaXB0Q29yZSIpCiBzZXRfdGFyZ2V0X3Byb3BlcnRpZXMo SmF2YVNjcmlwdENvcmUgUFJPUEVSVElFUyBMSU5LX0lOVEVSRkFDRV9MSUJSQVJJRVMgIiIpCiAK ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDU0ZTNkZWYuLmU5NDE5MTYgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTA5LTIwICBQYXRyaWNrIEdhbnN0 ZXJlciAgPHBhcm9nYUB3ZWJraXQub3JnPgorCisgICAgICAgIFtDTWFrZV0gVXNlIENPTVBJTEVf REVGSU5JVElPTlMgdGFyZ2V0IHByb3BlcnR5IGZvciBzZXR0aW5nIEJVSUxESU5HXyogZGVmaW5l cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIxNjcy CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU2luY2Ug dGhlIHNjb3BlIG9mIGFkZF9kZWZpbml0aW9ucygpIGlzIGFsd2F5cyBhIHdob2xlIGZpbGUsIHdl IG5lZWQgdG8gdXNlCisgICAgICAgIHRhcmdldCBwcm9wZXJ0aWVzIGluc3RlYWQgdG8gc2V0IGRl ZmluaXRpb25zIG9ubHkgZm9yIHNwZWNpZmljIHRhcmdldHMuCisKKyAgICAgICAgKiBDTWFrZUxp c3RzLnR4dDoKKwogMjAxMy0wOS0xNCAgUGF0cmljayBHYW5zdGVyZXIgIDxwYXJvZ2FAd2Via2l0 Lm9yZz4KIAogICAgICAgICBBZGQgQ01ha2UgYmFzZSBidWlsZCBzeXN0ZW0gZm9yIFdpbkNhaXJv IHBvcnQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFu Z2VMb2cKaW5kZXggOTMxMjE2My4uNTdmNWZjOCAxMDA2NDQKLS0tIGEvU291cmNlL1dURi9DaGFu Z2VMb2cKKysrIGIvU291cmNlL1dURi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMy0w OS0yMCAgUGF0cmljayBHYW5zdGVyZXIgIDxwYXJvZ2FAd2Via2l0Lm9yZz4KKworICAgICAgICBb Q01ha2VdIFVzZSBDT01QSUxFX0RFRklOSVRJT05TIHRhcmdldCBwcm9wZXJ0eSBmb3Igc2V0dGlu ZyBCVUlMRElOR18qIGRlZmluZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTEyMTY3MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFNpbmNlIHRoZSBzY29wZSBvZiBhZGRfZGVmaW5pdGlvbnMoKSBpcyBhbHdh eXMgYSB3aG9sZSBmaWxlLCB3ZSBuZWVkIHRvIHVzZQorICAgICAgICB0YXJnZXQgcHJvcGVydGll cyBpbnN0ZWFkIHRvIHNldCBkZWZpbml0aW9ucyBvbmx5IGZvciBzcGVjaWZpYyB0YXJnZXRzLgor CisgICAgICAgICogd3RmL0NNYWtlTGlzdHMudHh0OgorCiAyMDEzLTA5LTE5ICBKb3NlcGggUGVj b3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKICAgICAgICAgQVNTRVJUcyBpbiBpc01haW5U aHJlYWQgYWZ0ZXIgVVNFKFdFQl9USFJFQUQpIE1haW5UaHJlYWQgY2hhbmdlcwpkaWZmIC0tZ2l0 IGEvU291cmNlL1dURi93dGYvQ01ha2VMaXN0cy50eHQgYi9Tb3VyY2UvV1RGL3d0Zi9DTWFrZUxp c3RzLnR4dAppbmRleCA4OGNjMWQxLi4zZmExOTBmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0 Zi9DTWFrZUxpc3RzLnR4dAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9DTWFrZUxpc3RzLnR4dApAQCAt MjYyLDkgKzI2Miw5IEBAIFdFQktJVF9JTkNMVURFX0NPTkZJR19GSUxFU19JRl9FWElTVFMoKQog CiBXRUJLSVRfV1JBUF9TT1VSQ0VMSVNUKCR7V1RGX1NPVVJDRVN9KQogaW5jbHVkZV9kaXJlY3Rv cmllcygke1dURl9JTkNMVURFX0RJUkVDVE9SSUVTfSkKLWFkZF9kZWZpbml0aW9ucygtREJVSUxE SU5HX1dURikKIGFkZF9saWJyYXJ5KFdURiBTVEFUSUMgJHtXVEZfSEVBREVSU30gJHtXVEZfU09V UkNFU30pCiB0YXJnZXRfbGlua19saWJyYXJpZXMoV1RGICR7V1RGX0xJQlJBUklFU30pCitzZXRf dGFyZ2V0X3Byb3BlcnRpZXMoV1RGIFBST1BFUlRJRVMgQ09NUElMRV9ERUZJTklUSU9OUyAiQlVJ TERJTkdfV1RGIikKIHNldF90YXJnZXRfcHJvcGVydGllcyhXVEYgUFJPUEVSVElFUyBGT0xERVIg IkphdmFTY3JpcHRDb3JlIikKIAogaWYgKFdURl9PVVRQVVRfTkFNRSkKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL0NNYWtlTGlzdHMudHh0IGIvU291cmNlL1dlYkNvcmUvQ01ha2VMaXN0cy50 eHQKaW5kZXggMGE1MWZjOC4uYjIxZDNlMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ01h a2VMaXN0cy50eHQKKysrIGIvU291cmNlL1dlYkNvcmUvQ01ha2VMaXN0cy50eHQKQEAgLTMyMTQs MTAgKzMyMTQsMTAgQEAgbGlzdChBUFBFTkQgV2ViQ29yZV9TT1VSQ0VTICR7REVSSVZFRF9TT1VS Q0VTX1dFQkNPUkVfRElSfS9XZWJLaXRWZXJzaW9uLmgpCiBXRUJLSVRfV1JBUF9TT1VSQ0VMSVNU KCR7V2ViQ29yZV9JRExfRklMRVN9ICR7V2ViQ29yZV9TT1VSQ0VTfSkKIFdFQktJVF9XUkFQX1NP VVJDRUxJU1QoJHtXZWJDb3JlVGVzdFN1cHBvcnRfSURMX0ZJTEVTfSAke1dlYkNvcmVUZXN0U3Vw cG9ydF9TT1VSQ0VTfSkKIAotYWRkX2RlZmluaXRpb25zKC1EQlVJTERJTkdfV2ViQ29yZSkKIGlu Y2x1ZGVfZGlyZWN0b3JpZXMoJHtXZWJDb3JlX0lOQ0xVREVfRElSRUNUT1JJRVN9ICR7V2ViQ29y ZVRlc3RTdXBwb3J0X0lOQ0xVREVfRElSRUNUT1JJRVN9KQogCiBhZGRfbGlicmFyeShXZWJDb3Jl ICR7V2ViQ29yZV9MSUJSQVJZX1RZUEV9ICR7V2ViQ29yZV9TT1VSQ0VTfSkKK3NldF90YXJnZXRf cHJvcGVydGllcyhXZWJDb3JlIFBST1BFUlRJRVMgQ09NUElMRV9ERUZJTklUSU9OUyAiQlVJTERJ TkdfV2ViQ29yZSIpCiBzZXRfdGFyZ2V0X3Byb3BlcnRpZXMoV2ViQ29yZSBQUk9QRVJUSUVTIEZP TERFUiAiV2ViQ29yZSIpCiBzZXRfdGFyZ2V0X3Byb3BlcnRpZXMoV2ViQ29yZSBQUk9QRVJUSUVT IExJTktfSU5URVJGQUNFX0xJQlJBUklFUyAiIikKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IGU4YzBiOGMuLjYy NzAxMmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2Uv V2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMy0wOS0yMCAgUGF0cmljayBH YW5zdGVyZXIgIDxwYXJvZ2FAd2Via2l0Lm9yZz4KKworICAgICAgICBbQ01ha2VdIFVzZSBDT01Q SUxFX0RFRklOSVRJT05TIHRhcmdldCBwcm9wZXJ0eSBmb3Igc2V0dGluZyBCVUlMRElOR18qIGRl ZmluZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEy MTY3MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNp bmNlIHRoZSBzY29wZSBvZiBhZGRfZGVmaW5pdGlvbnMoKSBpcyBhbHdheXMgYSB3aG9sZSBmaWxl LCB3ZSBuZWVkIHRvIHVzZQorICAgICAgICB0YXJnZXQgcHJvcGVydGllcyBpbnN0ZWFkIHRvIHNl dCBkZWZpbml0aW9ucyBvbmx5IGZvciBzcGVjaWZpYyB0YXJnZXRzLgorCisgICAgICAgICogQ01h a2VMaXN0cy50eHQ6CisKIDIwMTMtMDktMTQgIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dhQHdl YmtpdC5vcmc+CiAKICAgICAgICAgQWRkIENNYWtlIGJhc2UgYnVpbGQgc3lzdGVtIGZvciBXaW5D YWlybyBwb3J0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0NNYWtlTGlzdHMudHh0IGIvU291 cmNlL1dlYktpdC9DTWFrZUxpc3RzLnR4dAppbmRleCBlYTExZTIyLi5jNGVjODNjIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0L0NNYWtlTGlzdHMudHh0CisrKyBiL1NvdXJjZS9XZWJLaXQvQ01h a2VMaXN0cy50eHQKQEAgLTg2LDExICs4NiwxMSBAQCBzZXQoV2ViS2l0X0xJQlJBUklFUwogCiBX RUJLSVRfSU5DTFVERV9DT05GSUdfRklMRVNfSUZfRVhJU1RTKCkKIAotYWRkX2RlZmluaXRpb25z KC1EQlVJTERJTkdfV2ViS2l0KQogaW5jbHVkZV9kaXJlY3Rvcmllcygke1dlYktpdF9JTkNMVURF X0RJUkVDVE9SSUVTfSkKIGFkZF9saWJyYXJ5KFdlYktpdCAke1dlYktpdF9MSUJSQVJZX1RZUEV9 ICR7V2ViS2l0X1NPVVJDRVN9KQogYWRkX2RlcGVuZGVuY2llcyhXZWJLaXQgV2ViQ29yZSkKIHRh cmdldF9saW5rX2xpYnJhcmllcyhXZWJLaXQgJHtXZWJLaXRfTElCUkFSSUVTfSkKK3NldF90YXJn ZXRfcHJvcGVydGllcyhXZWJLaXQgUFJPUEVSVElFUyBDT01QSUxFX0RFRklOSVRJT05TICJCVUlM RElOR19XZWJLaXQiKQogc2V0X3RhcmdldF9wcm9wZXJ0aWVzKFdlYktpdCBQUk9QRVJUSUVTIEZP TERFUiAiV2ViS2l0IikKIHNldF90YXJnZXRfcHJvcGVydGllcyhXZWJLaXQgUFJPUEVSVElFUyBM SU5LX0lOVEVSRkFDRV9MSUJSQVJJRVMgIiIpCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQv Q2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cKaW5kZXggOWNhNmY2Ni4uZTVhZDU3 NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktp dC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMy0wOS0yMCAgUGF0cmljayBHYW5zdGVy ZXIgIDxwYXJvZ2FAd2Via2l0Lm9yZz4KKworICAgICAgICBbQ01ha2VdIFVzZSBDT01QSUxFX0RF RklOSVRJT05TIHRhcmdldCBwcm9wZXJ0eSBmb3Igc2V0dGluZyBCVUlMRElOR18qIGRlZmluZXMK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMTY3Mgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNpbmNlIHRo ZSBzY29wZSBvZiBhZGRfZGVmaW5pdGlvbnMoKSBpcyBhbHdheXMgYSB3aG9sZSBmaWxlLCB3ZSBu ZWVkIHRvIHVzZQorICAgICAgICB0YXJnZXQgcHJvcGVydGllcyBpbnN0ZWFkIHRvIHNldCBkZWZp bml0aW9ucyBvbmx5IGZvciBzcGVjaWZpYyB0YXJnZXRzLgorCisgICAgICAgICogQ01ha2VMaXN0 cy50eHQ6CisKIDIwMTMtMDktMTQgIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dhQHdlYmtpdC5v cmc+CiAKICAgICAgICAgQWRkIENNYWtlIGJhc2UgYnVpbGQgc3lzdGVtIGZvciBXaW5DYWlybyBw b3J0Cg==