121665 2013-09-20 02:32:43 -0700 Web Inspector: Keep DOM tree expanded on page reload 2025-08-15 09:05:24 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 contact graouts commit-queue graouts joepeck peter.avis timothy webkit-bug-importer oldest_to_newest 931233 0 contact 2013-09-20 02:32:43 -0700 When inspecting a web page with Web Inspector it's common to drill down the DOM tree and select an element to Inspect. Having altered that element externally the page is then reloaded. However, when the page is subsequently reloaded the DOM tree is then totally collapsed necessitating drilling down through the DOM again. When iterating through site designs this makes for an extremely tiresome debugging experience. Can we see the same action as the Chrome/Firefox dev tools whereby the current expansion state of the DOM is retained on subsequent page loads? 931234 1 webkit-bug-importer 2013-09-20 02:33:05 -0700 <rdar://problem/15038868> 933491 2 212707 graouts 2013-09-26 07:50:14 -0700 Created attachment 212707 Testcase The attached test case shows that if you inspect the black rectangle, which is <div> nested 10 levels deep, and hit reload, we more often than not expand to the same place in the tree again. However, there are cases when we do not. Trying the same thing in the Chrome inspector seems to work a lot more reliably. 933505 3 212711 graouts 2013-09-26 08:09:18 -0700 Created attachment 212711 Patch 933508 4 graouts 2013-09-26 08:10:55 -0700 Attached patch seems to work well with pages I've tested (apple.com, store.apple.com, lemonde.fr) but doesn't work for pages where the selected content had been generated by script, which also fails in the Chrome Web Inspector. I think this patch brings us to parity with Chrome. 933585 5 212711 joepeck 2013-09-26 10:44:06 -0700 Comment on attachment 212711 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=212711&action=review > Source/WebInspectorUI/UserInterface/DOMTreeContentView.js:-300 > - // A selection was made while waiting for the async reply. Just bail now. > - if (this._domTreeOutline.selectedTreeElement) > - return; I think this will regress a rarer scenario (the reason this code was originally added). However, I think we should take this patch, which improves a very common case, and we should address the rare scenario in a different way. I would guess the scenario this breaks is: 1. Inspect for apple.com 2. Inspect the inspector (aim to inspect element something deep in the tree, like a deeply nested DOM node in the DOM tree) 3. When inspector² opens, quickly select something else in the DOM tree, like the Quick Console node => after a few beats, the DOM Tree will switch to show the originally selected "inspect element" node I think we would want to do something like this bail only if "a <em>user</em> selection was made while waiting for the async reply". 933613 6 contact 2013-09-26 11:27:35 -0700 The principal reason this came to my attention was inspecting the iOS simulator. Viewing and inspecting any web page there causes this issue. 933614 7 212711 commit-queue 2013-09-26 11:28:42 -0700 Comment on attachment 212711 Patch Clearing flags on attachment: 212711 Committed r156481: <http://trac.webkit.org/changeset/156481> 933615 8 commit-queue 2013-09-26 11:28:44 -0700 All reviewed patches have been landed. Closing bug. 2136787 9 peter.avis 2025-08-15 09:05:24 -0700 The bug is back again. Go to apple.com -> select a nested element -> reload page -> the domain is collapsed and the previously selected dom element not selected anymore Im using Release 225 (WebKit 20623.1.1.1) 212707 2013-09-26 07:50:14 -0700 2013-09-26 07:50:14 -0700 Testcase expansion.html text/html 352 graouts PGRpdj4KICA8ZGl2PgogICAgPGRpdj4KICAgICAgPGRpdj4KICAgICAgICA8ZGl2PgogICAgICAg ICAgPGRpdj4KICAgICAgICAgICAgPGRpdj4KICAgICAgICAgICAgICA8ZGl2PgogICAgICAgICAg ICAgICAgPGRpdj4KICAgICAgICAgICAgICAgICAgPGRpdiBzdHlsZT0id2lkdGg6IDEwMHB4OyBo ZWlnaHQ6IDEwMHB4OyBiYWNrZ3JvdW5kLWNvbG9yOiBibGFjazsiPjwvZGl2PgogICAgICAgICAg ICAgICAgPC9kaXY+CiAgICAgICAgICAgICAgPC9kaXY+CiAgICAgICAgICAgIDwvZGl2PgogICAg ICAgICAgPC9kaXY+CiAgICAgICAgPC9kaXY+CiAgICAgIDwvZGl2PgogICAgPC9kaXY+CiAgPC9k aXY+CjwvZGl2Pg== 212711 2013-09-26 08:09:18 -0700 2013-09-26 11:28:42 -0700 Patch bug-121665-20130926170922.patch text/plain 1744 graouts U3VidmVyc2lvbiBSZXZpc2lvbjogMTU2NDUxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCA5 NjljM2NlMzQ1Y2RjNmY1MWE5NGY4YTAxMWY1YjQwZDQ1NDg2NzNmLi4xMzg1ZjYzMDhjZjU1YTFm YjUzNmQxZjljZDJkYThiMDgxM2JlZjFkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxMy0wOS0yNiAgQW50b2luZSBRdWludCAgPGdyYW91dHNAYXBwbGUuY29t PgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IEtlZXAgRE9NIHRyZWUgZXhwYW5kZWQgb24gcGFn ZSByZWxvYWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTEyMTY2NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEFsbG93IHRoZSBub2RlIHRoYXQgd2FzIHNlbGVjdGVkIGJlZm9yZSByZWxvYWRpbmcgdGhlIHBh Z2UgdG8gYmUgc2VsZWN0ZWQKKyAgICAgICAgYXQgdGhlIHBhZ2UgaXMgcmVsb2FkZWQuIENyZWRp dCBnb2VzIHRvIEpvc2VwaCBQZWNvcmFybyBmb3IgdGhlIGZpeC4KKworICAgICAgICAqIFVzZXJJ bnRlcmZhY2UvRE9NVHJlZUNvbnRlbnRWaWV3LmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkRP TVRyZWVDb250ZW50Vmlldy5wcm90b3R5cGUuX3Jvb3RET01Ob2RlQXZhaWxhYmxlLnNlbGVjdE5v ZGUpOgorCiAyMDEzLTA5LTI0ICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+ CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogVXNpbmcgQnJlYWtwb2ludCBBY3Rpb25zIEJyZWFr cyBpT1MgaW5zcGVjdGlvbgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJ bnRlcmZhY2UvRE9NVHJlZUNvbnRlbnRWaWV3LmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1Vz ZXJJbnRlcmZhY2UvRE9NVHJlZUNvbnRlbnRWaWV3LmpzCmluZGV4IDUwYmQwYjZhNWU4NGZkM2Fk YWVjOTkyNzdjMzE0MDBlYjY4MTNjODcuLjAwYzVmYzMwOWRkOWNhMTRhMjU0NTQxMGI1Yzg0Njdl MDI4NzFlM2MgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L0RPTVRyZWVDb250ZW50Vmlldy5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlcklu dGVyZmFjZS9ET01UcmVlQ29udGVudFZpZXcuanMKQEAgLTI5NSwxMCArMjk1LDYgQEAgV2ViSW5z cGVjdG9yLkRPTVRyZWVDb250ZW50Vmlldy5wcm90b3R5cGUgPSB7CiAKICAgICAgICAgZnVuY3Rp b24gc2VsZWN0Tm9kZShsYXN0U2VsZWN0ZWROb2RlKQogICAgICAgICB7Ci0gICAgICAgICAgICAv LyBBIHNlbGVjdGlvbiB3YXMgbWFkZSB3aGlsZSB3YWl0aW5nIGZvciB0aGUgYXN5bmMgcmVwbHku IEp1c3QgYmFpbCBub3cuCi0gICAgICAgICAgICBpZiAodGhpcy5fZG9tVHJlZU91dGxpbmUuc2Vs ZWN0ZWRUcmVlRWxlbWVudCkKLSAgICAgICAgICAgICAgICByZXR1cm47Ci0KICAgICAgICAgICAg IHZhciBub2RlVG9Gb2N1cyA9IGxhc3RTZWxlY3RlZE5vZGU7CiAgICAgICAgICAgICBpZiAoIW5v ZGVUb0ZvY3VzKQogICAgICAgICAgICAgICAgIG5vZGVUb0ZvY3VzID0gcm9vdERPTU5vZGUuYm9k eSB8fCByb290RE9NTm9kZS5kb2N1bWVudEVsZW1lbnQ7Cg==