121661 2013-09-20 00:26:57 -0700 Frequent RELEASE_ASSERT crashes in Structure::checkOffsetConsistency on WebGL swizzler tests 2013-10-18 13:20:05 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar, MakingBotsRed P2 Normal --- 1 ap fpizlo dino fpizlo ggaren oliver webkit-bug-importer oldest_to_newest 931208 0 ap 2013-09-20 00:26:57 -0700 All these tests are quite crashy, particularly on leaks tester for whatever reason: <http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=swizzlers> RELEASE_ASSERT(numberOfSlotsForLastOffset(m_offset, m_inlineCapacity) == propertyTable->propertyStorageSize()); Thread 12 Crashed:: JSC Compilation Thread 0 com.apple.JavaScriptCore 0x000000010d91280a WTFCrash + 42 (Assertions.cpp:342) 1 com.apple.JavaScriptCore 0x000000010d395a9f JSC::Structure::checkOffsetConsistency() const + 207 (StructureInlines.h:233) 2 com.apple.JavaScriptCore 0x000000010d394c89 JSC::Structure::outOfLineCapacity() const + 25 (Structure.h:182) 3 com.apple.JavaScriptCore 0x000000010d49ee2f JSC::DFG::ByteCodeParser::parseBlock(unsigned int) + 16639 (DFGByteCodeParser.cpp:2518) 4 com.apple.JavaScriptCore 0x000000010d499ab2 JSC::DFG::ByteCodeParser::parseCodeBlock() + 2002 (DFGByteCodeParser.cpp:3589) 5 com.apple.JavaScriptCore 0x000000010d4a50fa JSC::DFG::ByteCodeParser::parse() + 250 (DFGByteCodeParser.cpp:3626) 6 com.apple.JavaScriptCore 0x000000010d4a53de JSC::DFG::parse(JSC::DFG::Graph&) + 62 (DFGByteCodeParser.cpp:3666) 7 com.apple.JavaScriptCore 0x000000010d59446e JSC::DFG::Plan::compileInThreadImpl(JSC::DFG::LongLivedState&) + 190 (DFGPlan.cpp:155) 8 com.apple.JavaScriptCore 0x000000010d5941a2 JSC::DFG::Plan::compileInThread(JSC::DFG::LongLivedState&) + 242 (DFGPlan.cpp:116) 9 com.apple.JavaScriptCore 0x000000010d634cc4 JSC::DFG::Worklist::runThread() + 468 (DFGWorklist.cpp:239) 10 com.apple.JavaScriptCore 0x000000010d633d95 JSC::DFG::Worklist::threadFunction(void*) + 21 (DFGWorklist.cpp:261) 11 com.apple.JavaScriptCore 0x000000010d959400 WTF::threadEntryPoint(void*) + 144 (Threading.cpp:70) 12 com.apple.JavaScriptCore 0x000000010d959dd8 WTF::wtfThreadEntryPoint(void*) + 104 (ThreadingPthreads.cpp:195) 13 libsystem_c.dylib 0x00007fff96e23772 _pthread_start + 327 14 libsystem_c.dylib 0x00007fff96e101a1 thread_start + 13 931211 1 webkit-bug-importer 2013-09-20 00:39:33 -0700 <rdar://problem/15038349> 941271 2 214586 fpizlo 2013-10-18 10:59:01 -0700 Created attachment 214586 the patch 941272 3 214587 fpizlo 2013-10-18 11:01:26 -0700 Created attachment 214587 the patch 941275 4 214587 mhahnenberg 2013-10-18 11:08:47 -0700 Comment on attachment 214587 the patch View in context: https://bugs.webkit.org/attachment.cgi?id=214587&action=review r=me > Source/JavaScriptCore/ChangeLog:21 > + keeping in sync with m_offset, we have the checkOffsetConsistency method. It's meant to be it in sync > Source/JavaScriptCore/ChangeLog:39 > + outOfLineCapacity(), and is right to do wo without holding any locks (since in all cases where do so > Source/JavaScriptCore/ChangeLog:44 > + property table modified - instead what happens is that so downstream structure steals the some downstream 941309 5 fpizlo 2013-10-18 13:20:05 -0700 Landed in http://trac.webkit.org/changeset/157645 214586 2013-10-18 10:59:01 -0700 2013-10-18 11:01:26 -0700 the patch blah.patch text/plain 5129 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTU3NjQxKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDU4IEBA CisyMDEzLTEwLTE4ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg RnJlcXVlbnQgUkVMRUFTRV9BU1NFUlQgY3Jhc2hlcyBpbiBTdHJ1Y3R1cmU6OmNoZWNrT2Zmc2V0 Q29uc2lzdGVuY3kgb24gV2ViR0wgc3dpenpsZXIgdGVzdHMKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMTY2MQorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorICAgICAgICAKKyAgICAgICAgVGhpcyBtZXRob2Qgc2hvdWxkbid0 IGhhdmUgYmVlbiBjYWxsZWQgZnJvbSB0aGUgY29uY3VycmVudCBKSVQgdGhyZWFkLiBUaGF0J3Mg aGFyZCB0byBwcmV2ZW50CisgICAgICAgIHNvIEkgYWRkZWQgYSByZXR1cm4tZWFybHkgY2hlY2sg dXNpbmcgaXNDb21waWxhdGlvblRocmVhZCgpLgorICAgICAgICAKKyAgICAgICAgSGVyZSdzIHdo eSB0aGlzIG1ha2VzIHNlbnNlLiBTdHJ1Y3R1cmUgaGFzIHR3byB3YXlzIHRvIHRlbGwgeW91IGFi b3V0IHRoZSBsYXlvdXQgb2YgdGhlIG9iamVjdHMKKyAgICAgICAgaXQgaXMgZGVzY3JpYmluZzog bV9vZmZzZXQgYW5kIHRoZSBwcm9wZXJ0eSB0YWJsZS4gTW9zdCBzdHJ1Y3R1cmVzIG9ubHkgaGF2 ZSBtX29mZnNldCBhbmQgcmVwb3J0CisgICAgICAgIG51bGwgZm9yIHRoZSBwcm9wZXJ0eSB0YWJs ZS4gSWYgdGhlIHByb3BlcnR5IHRhYmxlIGlzIHRoZXJlLCBpdCB3aWxsIHRlbGwgeW91IGFkZGl0 aW9uYWwKKyAgICAgICAgaW5mb3JtYXRpb24gYW5kIHRoYXQgaW5mb3JtYXRpb24gc3Vic3VtZXMg bV9vZmZzZXQgLSBidXQgdGhlIG1fb2Zmc2V0IGlzIHN0aWxsIHRoZXJlLiBTbywgd2hlbgorICAg ICAgICB3ZSBoYXZlIGEgcHJvcGVydHkgdGFibGUsIHdlIGhhdmUgdG8ga2VlcCBpdCBpbiBzeW5j IHdpdGggdGhlIG1fb2Zmc2V0LiBUaGVyZSBpcyBhIGJ1bmNoIG9mCisgICAgICAgIG1hY2hpbmVy eSB0byBkbyB0aGlzLgorICAgICAgICAKKyAgICAgICAgQ2hhbmdpbmcgdGhlIHByb3BlcnR5IHRh YmxlIG9ubHkgaGFwcGVucyBvbiB0aGUgbWFpbiB0aHJlYWQuCisgICAgICAgIAorICAgICAgICBC ZWNhdXNlIHRoZSBtYWNoaW5lcnkgdG8gY2hhbmdlIHRoZSBwcm9wZXJ0eSB0YWJsZSBpcyBzbyBj b21wbGV4LCBlc3BlY2lhbGx5IHdpdGggcmVzcGVjdCB0bworICAgICAgICBrZWVwaW5nIGluIHN5 bmMgd2l0aCBtX29mZnNldCwgd2UgaGF2ZSB0aGUgY2hlY2tPZmZzZXRDb25zaXN0ZW5jeSBtZXRo b2QuIEl0J3MgbWVhbnQgdG8gYmUKKyAgICAgICAgY2FsbGVkIGF0IGtleSBwb2ludHMgYmVmb3Jl IGFuZCBhZnRlciBjaGFuZ2VzIHRvIHRoZSBwcm9wZXJ0eSB0YWJsZSBvciB0aGUgb2Zmc2V0Lgor CisgICAgICAgIE1vc3QgY2xpZW50cyBvZiBTdHJ1Y3R1cmUgd2hvIGNhcmUgYWJvdXQgb2JqZWN0 IGxheW91dCwgaW5jbHVkaW5nIHRoZSBjb25jdXJyZW50IHRocmVhZCwgd2lsbAorICAgICAgICB3 YW50IHRvIGtub3cgbV9vZmZzZXQgYW5kIG5vdCB0aGUgcHJvcGVydHkgdGFibGUuIElmIHRoZXkg d2FudCB0aGUgcHJvcGVydHkgdGFibGUsIHRoZXkgd2lsbAorICAgICAgICBhbHJlYWR5IGJlIHN1 cGVyIGNhcmVmdWwuIFRoZSBjb25jdXJyZW50IHRocmVhZCBoYXMgc3BlY2lhbCBtZXRob2RzIGZv ciB0aGlzLCBsaWtlCisgICAgICAgIFN0cnVjdHVyZTo6Z2V0Q29uY3VycmVudGx5KCksIHdoaWNo IHVzZXMgZmluZS1ncmFpbmVkIGxvY2tpbmcgdG8gZW5zdXJlIHRoYXQgaXQgc2VlcyBhIGNvaGVy ZW50CisgICAgICAgIHZpZXcgb2YgdGhlIHByb3BlcnR5IHRhYmxlLgorICAgICAgICAKKyAgICAg ICAgQWRkaW5nIGxvY2tpbmcgdG8gY2hlY2tPZmZzZXRDb25zaXN0ZW5jeSgpIGlzIHByb2JhYmx5 IGEgYmFkIGlkZWEgc2luY2UgdGhhdCBtZXRob2QgbWF5IGJlCisgICAgICAgIGNhbGxlZCB3aGVu IHRoZSByZWxldmFudCBsb2NrIGlzIGFscmVhZHkgaGVsZC4gU28sIHdlJ2QgaGF2ZSBhd2t3YXJk IHJlY3Vyc2l2ZSBsb2NraW5nIGlzc3Vlcy4KKyAgICAgICAgCisgICAgICAgIEJ1dCByaWdodCBu b3csIHRoZSBjb25jdXJyZW50IEpJVCB0aHJlYWQgbWF5IGNhbGwgYSBtZXRob2QsIGxpa2UgU3Ry dWN0dXJlOjpvdXRPZkxpbmVDYXBhY2l0eSgpLAorICAgICAgICB3aGljaCBoYXMgYSBjYWxsIHRv IGNoZWNrT2Zmc2V0Q29uc2lzdGVuY3koKS4gVGhlIGNhbGwgdG8gY2hlY2tPZmZzZXRDb25zaXN0 ZW5jeSgpIGlzIHRoZXJlCisgICAgICAgIGJlY2F1c2Ugd2UgaGF2ZSBmb3VuZCB0aGF0IGl0IGhl bHBzIHF1aWNrbHkgaWRlbnRpZnkgc2l0dWF0aW9ucyB3aGVyZSB0aGUgcHJvcGVydHkgdGFibGUg YW5kCisgICAgICAgIG1fb2Zmc2V0IGdldCBvdXQgb2Ygc3luYyAtIG1haW5seSBiZWNhdXNlIGNv ZGUgdGhhdCBjaGFuZ2VzIGVpdGhlciBvZiB0aG9zZSB0aGluZ3Mgd2lsbCB1c3VhbGx5CisgICAg ICAgIGFsc28gd2FudCB0byBrbm93IHRoZSBvdXRPZkxpbmVDYXBhY2l0eSgpLiBCdXQgU3RydWN0 dXJlOjpvdXRPZkxpbmVDYXBhY2l0eSgpIGRvZXNuJ3QgKmFjdHVhbGx5KgorICAgICAgICBuZWVk IHRoZSBwcm9wZXJ0eSB0YWJsZTsgaXQgdXNlcyB0aGUgbV9vZmZzZXQuIFRoZSBjb25jdXJyZW50 IEpJVCBpcyBjb3JyZWN0IHRvIGNhbGwKKyAgICAgICAgb3V0T2ZMaW5lQ2FwYWNpdHkoKSwgYW5k IGlzIHJpZ2h0IHRvIGRvIHdvIHdpdGhvdXQgaG9sZGluZyBhbnkgbG9ja3MgKHNpbmNlIGluIGFs bCBjYXNlcyB3aGVyZQorICAgICAgICBpdCBjYWxscyBvdXRPZkxpbmVDYXBhY2l0eSgpIGl0IGhh cyBhbHJlYWR5IHByb3ZlbiB0aGF0IG1fb2Zmc2V0IGlzIGltbXV0YWJsZSkuIEJ1dCBiZWNhdXNl CisgICAgICAgIG91dE9mTGluZUNhcGFjaXR5KCkgY2FsbHMgY2hlY2tPZmZzZXRDb25zaXN0ZW5j eSgpLCBhbmQgY2hlY2tPZmZzZXRDb25zaXN0ZW5jeSgpIGRvZXNuJ3QgZ3JhYgorICAgICAgICBs b2NrcywgYW5kIHRoYXQgc2FtZSBzdHJ1Y3R1cmUgaXMgaGF2aW5nIGl0cyBwcm9wZXJ0eSB0YWJs ZSBtb2RpZmllZCBieSB0aGUgbWFpbiB0aHJlYWQsIHdlIGVuZAorICAgICAgICB1cCB3aXRoIHRo ZXNlIHNwdXJpb3VzIGFzc2VydGlvbiBmYWlsdXJlcy4KKyAgICAgICAgCisgICAgICAgIEkgc3Vz cGVjdCB0aGVyZSBhcmUgb3RoZXIgY29kZSBwYXRocyB0aGF0IGxlYWQgdG8gdGhlIGNvbmN1cnJl bnQgSklUIGNhbGxpbmcgc29tZSBTdHJ1Y3R1cmUKKyAgICAgICAgbWV0aG9kIHRoYXQgaXQgaXMg ZmluZSBhbmQgc2FmZSB0byBjYWxsLCBidXQgdGhlbiB0aGF0IG1ldGhvZCBjYWxscyBjaGVja09m ZnNldENvbnNpc3RlbmN5KCksCisgICAgICAgIGFuZCB0aGVuIHlvdSBoYXZlIGEgcG9zc2libGUg Y3Jhc2guCisgICAgICAgIAorICAgICAgICBUaGUgbW9zdCBzZW5zaWJsZSBzb2x1dGlvbiB0byB0 aGlzIGFwcGVhcnMgdG8gYmUgdG8gbWFrZSBzdXJlIHRoYXQgY2hlY2tPZmZzZXRDb25zaXN0ZW5j eSgpIGlzCisgICAgICAgIGF3YXJlIG9mIGl0cyB1c2VsZXNzbmVzcyB0byB0aGUgY29uY3VycmVu dCBKSVQgdGhyZWFkLiBUaGlzIGNoYW5nZSBtYWtlcyBpdCByZXR1cm4gZWFybHkgaWYKKyAgICAg ICAgaXQncyBpbiB0aGUgY29uY3VycmVudCBKSVQuCisgICAgICAgIAorICAgICAgICAqIHJ1bnRp bWUvU3RydWN0dXJlSW5saW5lcy5oOgorICAgICAgICAoSlNDOjpTdHJ1Y3R1cmU6OmNoZWNrT2Zm c2V0Q29uc2lzdGVuY3kpOgorCiAyMDEzLTEwLTE4ICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFw cGxlLmNvbT4KIAogICAgICAgICBBZGQgU1BJIHRvIGRpc2FibGUgdGhlIGdhcmJhZ2UgY29sbGVj dG9yIHRpbWVyCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9TdHJ1Y3R1cmVJ bmxpbmVzLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvU3Ry dWN0dXJlSW5saW5lcy5oCShyZXZpc2lvbiAxNTc2NDApCisrKyBTb3VyY2UvSmF2YVNjcmlwdENv cmUvcnVudGltZS9TdHJ1Y3R1cmVJbmxpbmVzLmgJKHdvcmtpbmcgY29weSkKQEAgLTIzMiw2ICsy MzIsMTMgQEAgQUxXQVlTX0lOTElORSBib29sIFN0cnVjdHVyZTo6Y2hlY2tPZmZzZQogICAgICAg ICByZXR1cm4gdHJ1ZTsKICAgICB9CiAKKyAgICAvLyBXZSBjYW5ub3QgcmVsaWFibHkgYXNzZXJ0 IHRoaW5ncyBhYm91dCB0aGUgcHJvcGVydHkgdGFibGUgaW4gdGhlIGNvbmN1cnJlbnQKKyAgICAv LyBjb21waWxhdGlvbiB0aHJlYWQuIEl0IGlzIHBvc3NpYmxlIGZvciB0aGUgdGFibGUgdG8gYmUg c3RvbGVuIGFuZCB0aGVuIGhhdmUKKyAgICAvLyB0aGluZ3MgYWRkZWQgdG8gaXQsIHdoaWNoIGxl YWRzIHRvIHRoZSBvZmZzZXRzIGJlaW5nIGFsbCBtZXNzZWQgdXAuIFdlIGNvdWxkCisgICAgLy8g Z2V0IGFyb3VuZCB0aGlzIGJ5IGdyYWJiaW5nIGEgbG9jayBoZXJlLCBidXQgSSB0aGluayB0aGF0 IHdvdWxkIGJlIG92ZXJraWxsLgorICAgIGlmIChpc0NvbXBpbGF0aW9uVGhyZWFkKCkpCisgICAg ICAgIHJldHVybiB0cnVlOworICAgIAogICAgIFJFTEVBU0VfQVNTRVJUKG51bWJlck9mU2xvdHNG b3JMYXN0T2Zmc2V0KG1fb2Zmc2V0LCBtX2lubGluZUNhcGFjaXR5KSA9PSBwcm9wZXJ0eVRhYmxl LT5wcm9wZXJ0eVN0b3JhZ2VTaXplKCkpOwogICAgIHVuc2lnbmVkIHRvdGFsU2l6ZSA9IHByb3Bl cnR5VGFibGUtPnByb3BlcnR5U3RvcmFnZVNpemUoKTsKICAgICBSRUxFQVNFX0FTU0VSVCgodG90 YWxTaXplIDwgaW5saW5lQ2FwYWNpdHkoKSA/IDAgOiB0b3RhbFNpemUgLSBpbmxpbmVDYXBhY2l0 eSgpKSA9PSBudW1iZXJPZk91dE9mTGluZVNsb3RzRm9yTGFzdE9mZnNldChtX29mZnNldCkpOwo= 214587 2013-10-18 11:01:26 -0700 2013-10-18 11:08:47 -0700 the patch blah.patch text/plain 5437 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTU3NjQxKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDYxIEBA CisyMDEzLTEwLTE4ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg RnJlcXVlbnQgUkVMRUFTRV9BU1NFUlQgY3Jhc2hlcyBpbiBTdHJ1Y3R1cmU6OmNoZWNrT2Zmc2V0 Q29uc2lzdGVuY3kgb24gV2ViR0wgc3dpenpsZXIgdGVzdHMKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMTY2MQorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorICAgICAgICAKKyAgICAgICAgVGhpcyBtZXRob2Qgc2hvdWxkbid0 IGhhdmUgYmVlbiBjYWxsZWQgZnJvbSB0aGUgY29uY3VycmVudCBKSVQgdGhyZWFkLiBUaGF0J3Mg aGFyZCB0byBwcmV2ZW50CisgICAgICAgIHNvIEkgYWRkZWQgYSByZXR1cm4tZWFybHkgY2hlY2sg dXNpbmcgaXNDb21waWxhdGlvblRocmVhZCgpLgorICAgICAgICAKKyAgICAgICAgSGVyZSdzIHdo eSB0aGlzIG1ha2VzIHNlbnNlLiBTdHJ1Y3R1cmUgaGFzIHR3byB3YXlzIHRvIHRlbGwgeW91IGFi b3V0IHRoZSBsYXlvdXQgb2YgdGhlIG9iamVjdHMKKyAgICAgICAgaXQgaXMgZGVzY3JpYmluZzog bV9vZmZzZXQgYW5kIHRoZSBwcm9wZXJ0eSB0YWJsZS4gTW9zdCBzdHJ1Y3R1cmVzIG9ubHkgaGF2 ZSBtX29mZnNldCBhbmQgcmVwb3J0CisgICAgICAgIG51bGwgZm9yIHRoZSBwcm9wZXJ0eSB0YWJs ZS4gSWYgdGhlIHByb3BlcnR5IHRhYmxlIGlzIHRoZXJlLCBpdCB3aWxsIHRlbGwgeW91IGFkZGl0 aW9uYWwKKyAgICAgICAgaW5mb3JtYXRpb24gYW5kIHRoYXQgaW5mb3JtYXRpb24gc3Vic3VtZXMg bV9vZmZzZXQgLSBidXQgdGhlIG1fb2Zmc2V0IGlzIHN0aWxsIHRoZXJlLiBTbywgd2hlbgorICAg ICAgICB3ZSBoYXZlIGEgcHJvcGVydHkgdGFibGUsIHdlIGhhdmUgdG8ga2VlcCBpdCBpbiBzeW5j IHdpdGggdGhlIG1fb2Zmc2V0LiBUaGVyZSBpcyBhIGJ1bmNoIG9mCisgICAgICAgIG1hY2hpbmVy eSB0byBkbyB0aGlzLgorICAgICAgICAKKyAgICAgICAgQ2hhbmdpbmcgdGhlIHByb3BlcnR5IHRh YmxlIG9ubHkgaGFwcGVucyBvbiB0aGUgbWFpbiB0aHJlYWQuCisgICAgICAgIAorICAgICAgICBC ZWNhdXNlIHRoZSBtYWNoaW5lcnkgdG8gY2hhbmdlIHRoZSBwcm9wZXJ0eSB0YWJsZSBpcyBzbyBj b21wbGV4LCBlc3BlY2lhbGx5IHdpdGggcmVzcGVjdCB0bworICAgICAgICBrZWVwaW5nIGluIHN5 bmMgd2l0aCBtX29mZnNldCwgd2UgaGF2ZSB0aGUgY2hlY2tPZmZzZXRDb25zaXN0ZW5jeSBtZXRo b2QuIEl0J3MgbWVhbnQgdG8gYmUKKyAgICAgICAgY2FsbGVkIGF0IGtleSBwb2ludHMgYmVmb3Jl IGFuZCBhZnRlciBjaGFuZ2VzIHRvIHRoZSBwcm9wZXJ0eSB0YWJsZSBvciB0aGUgb2Zmc2V0Lgor CisgICAgICAgIE1vc3QgY2xpZW50cyBvZiBTdHJ1Y3R1cmUgd2hvIGNhcmUgYWJvdXQgb2JqZWN0 IGxheW91dCwgaW5jbHVkaW5nIHRoZSBjb25jdXJyZW50IHRocmVhZCwgd2lsbAorICAgICAgICB3 YW50IHRvIGtub3cgbV9vZmZzZXQgYW5kIG5vdCB0aGUgcHJvcGVydHkgdGFibGUuIElmIHRoZXkg d2FudCB0aGUgcHJvcGVydHkgdGFibGUsIHRoZXkgd2lsbAorICAgICAgICBhbHJlYWR5IGJlIHN1 cGVyIGNhcmVmdWwuIFRoZSBjb25jdXJyZW50IHRocmVhZCBoYXMgc3BlY2lhbCBtZXRob2RzIGZv ciB0aGlzLCBsaWtlCisgICAgICAgIFN0cnVjdHVyZTo6Z2V0Q29uY3VycmVudGx5KCksIHdoaWNo IHVzZXMgZmluZS1ncmFpbmVkIGxvY2tpbmcgdG8gZW5zdXJlIHRoYXQgaXQgc2VlcyBhIGNvaGVy ZW50CisgICAgICAgIHZpZXcgb2YgdGhlIHByb3BlcnR5IHRhYmxlLgorICAgICAgICAKKyAgICAg ICAgQWRkaW5nIGxvY2tpbmcgdG8gY2hlY2tPZmZzZXRDb25zaXN0ZW5jeSgpIGlzIHByb2JhYmx5 IGEgYmFkIGlkZWEgc2luY2UgdGhhdCBtZXRob2QgbWF5IGJlCisgICAgICAgIGNhbGxlZCB3aGVu IHRoZSByZWxldmFudCBsb2NrIGlzIGFscmVhZHkgaGVsZC4gU28sIHdlJ2QgaGF2ZSBhd2t3YXJk IHJlY3Vyc2l2ZSBsb2NraW5nIGlzc3Vlcy4KKyAgICAgICAgCisgICAgICAgIEJ1dCByaWdodCBu b3csIHRoZSBjb25jdXJyZW50IEpJVCB0aHJlYWQgbWF5IGNhbGwgYSBtZXRob2QsIGxpa2UgU3Ry dWN0dXJlOjpvdXRPZkxpbmVDYXBhY2l0eSgpLAorICAgICAgICB3aGljaCBoYXMgYSBjYWxsIHRv IGNoZWNrT2Zmc2V0Q29uc2lzdGVuY3koKS4gVGhlIGNhbGwgdG8gY2hlY2tPZmZzZXRDb25zaXN0 ZW5jeSgpIGlzIHRoZXJlCisgICAgICAgIGJlY2F1c2Ugd2UgaGF2ZSBmb3VuZCB0aGF0IGl0IGhl bHBzIHF1aWNrbHkgaWRlbnRpZnkgc2l0dWF0aW9ucyB3aGVyZSB0aGUgcHJvcGVydHkgdGFibGUg YW5kCisgICAgICAgIG1fb2Zmc2V0IGdldCBvdXQgb2Ygc3luYyAtIG1haW5seSBiZWNhdXNlIGNv ZGUgdGhhdCBjaGFuZ2VzIGVpdGhlciBvZiB0aG9zZSB0aGluZ3Mgd2lsbCB1c3VhbGx5CisgICAg ICAgIGFsc28gd2FudCB0byBrbm93IHRoZSBvdXRPZkxpbmVDYXBhY2l0eSgpLiBCdXQgU3RydWN0 dXJlOjpvdXRPZkxpbmVDYXBhY2l0eSgpIGRvZXNuJ3QgKmFjdHVhbGx5KgorICAgICAgICBuZWVk IHRoZSBwcm9wZXJ0eSB0YWJsZTsgaXQgdXNlcyB0aGUgbV9vZmZzZXQuIFRoZSBjb25jdXJyZW50 IEpJVCBpcyBjb3JyZWN0IHRvIGNhbGwKKyAgICAgICAgb3V0T2ZMaW5lQ2FwYWNpdHkoKSwgYW5k IGlzIHJpZ2h0IHRvIGRvIHdvIHdpdGhvdXQgaG9sZGluZyBhbnkgbG9ja3MgKHNpbmNlIGluIGFs bCBjYXNlcyB3aGVyZQorICAgICAgICBpdCBjYWxscyBvdXRPZkxpbmVDYXBhY2l0eSgpIGl0IGhh cyBhbHJlYWR5IHByb3ZlbiB0aGF0IG1fb2Zmc2V0IGlzIGltbXV0YWJsZSkuIEJ1dCBiZWNhdXNl CisgICAgICAgIG91dE9mTGluZUNhcGFjaXR5KCkgY2FsbHMgY2hlY2tPZmZzZXRDb25zaXN0ZW5j eSgpLCBhbmQgY2hlY2tPZmZzZXRDb25zaXN0ZW5jeSgpIGRvZXNuJ3QgZ3JhYgorICAgICAgICBs b2NrcywgYW5kIHRoYXQgc2FtZSBzdHJ1Y3R1cmUgaXMgaGF2aW5nIGl0cyBwcm9wZXJ0eSB0YWJs ZSBtb2RpZmllZCBieSB0aGUgbWFpbiB0aHJlYWQsIHdlIGVuZAorICAgICAgICB1cCB3aXRoIHRo ZXNlIHNwdXJpb3VzIGFzc2VydGlvbiBmYWlsdXJlcy4gRldJVywgdGhlIHN0cnVjdHVyZSBpc24n dCAqYWN0dWFsbHkqIGhhdmluZyAqaXRzKgorICAgICAgICBwcm9wZXJ0eSB0YWJsZSBtb2RpZmll ZCAtIGluc3RlYWQgd2hhdCBoYXBwZW5zIGlzIHRoYXQgc28gZG93bnN0cmVhbSBzdHJ1Y3R1cmUg c3RlYWxzIHRoZQorICAgICAgICBwcm9wZXJ0eSB0YWJsZSBhbmQgdGhlbiBzdGFydHMgYWRkaW5n IHRoaW5ncyB0byBpdC4gVGhlIGNvbmN1cnJlbnQgdGhyZWFkIGxvYWRzIHRoZSBwcm9wZXJ0eQor ICAgICAgICB0YWJsZSBiZWZvcmUgaXRzIHN0b2xlbiwgYW5kIGhlbmNlIHRoZSBiYWRuZXNzLgor ICAgICAgICAKKyAgICAgICAgSSBzdXNwZWN0IHRoZXJlIGFyZSBvdGhlciBjb2RlIHBhdGhzIHRo YXQgbGVhZCB0byB0aGUgY29uY3VycmVudCBKSVQgY2FsbGluZyBzb21lIFN0cnVjdHVyZQorICAg ICAgICBtZXRob2QgdGhhdCBpdCBpcyBmaW5lIGFuZCBzYWZlIHRvIGNhbGwsIGJ1dCB0aGVuIHRo YXQgbWV0aG9kIGNhbGxzIGNoZWNrT2Zmc2V0Q29uc2lzdGVuY3koKSwKKyAgICAgICAgYW5kIHRo ZW4geW91IGhhdmUgYSBwb3NzaWJsZSBjcmFzaC4KKyAgICAgICAgCisgICAgICAgIFRoZSBtb3N0 IHNlbnNpYmxlIHNvbHV0aW9uIHRvIHRoaXMgYXBwZWFycyB0byBiZSB0byBtYWtlIHN1cmUgdGhh dCBjaGVja09mZnNldENvbnNpc3RlbmN5KCkgaXMKKyAgICAgICAgYXdhcmUgb2YgaXRzIHVzZWxl c3NuZXNzIHRvIHRoZSBjb25jdXJyZW50IEpJVCB0aHJlYWQuIFRoaXMgY2hhbmdlIG1ha2VzIGl0 IHJldHVybiBlYXJseSBpZgorICAgICAgICBpdCdzIGluIHRoZSBjb25jdXJyZW50IEpJVC4KKyAg ICAgICAgCisgICAgICAgICogcnVudGltZS9TdHJ1Y3R1cmVJbmxpbmVzLmg6CisgICAgICAgIChK U0M6OlN0cnVjdHVyZTo6Y2hlY2tPZmZzZXRDb25zaXN0ZW5jeSk6CisKIDIwMTMtMTAtMTggIERh bmllbCBCYXRlcyAgPGRhYmF0ZXNAYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBTUEkgdG8gZGlz YWJsZSB0aGUgZ2FyYmFnZSBjb2xsZWN0b3IgdGltZXIKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0 Q29yZS9ydW50aW1lL1N0cnVjdHVyZUlubGluZXMuaAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvcnVudGltZS9TdHJ1Y3R1cmVJbmxpbmVzLmgJKHJldmlzaW9uIDE1NzY0MCkK KysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1N0cnVjdHVyZUlubGluZXMuaAkod29y a2luZyBjb3B5KQpAQCAtMjMyLDYgKzIzMiwxMyBAQCBBTFdBWVNfSU5MSU5FIGJvb2wgU3RydWN0 dXJlOjpjaGVja09mZnNlCiAgICAgICAgIHJldHVybiB0cnVlOwogICAgIH0KIAorICAgIC8vIFdl IGNhbm5vdCByZWxpYWJseSBhc3NlcnQgdGhpbmdzIGFib3V0IHRoZSBwcm9wZXJ0eSB0YWJsZSBp biB0aGUgY29uY3VycmVudAorICAgIC8vIGNvbXBpbGF0aW9uIHRocmVhZC4gSXQgaXMgcG9zc2li bGUgZm9yIHRoZSB0YWJsZSB0byBiZSBzdG9sZW4gYW5kIHRoZW4gaGF2ZQorICAgIC8vIHRoaW5n cyBhZGRlZCB0byBpdCwgd2hpY2ggbGVhZHMgdG8gdGhlIG9mZnNldHMgYmVpbmcgYWxsIG1lc3Nl ZCB1cC4gV2UgY291bGQKKyAgICAvLyBnZXQgYXJvdW5kIHRoaXMgYnkgZ3JhYmJpbmcgYSBsb2Nr IGhlcmUsIGJ1dCBJIHRoaW5rIHRoYXQgd291bGQgYmUgb3ZlcmtpbGwuCisgICAgaWYgKGlzQ29t cGlsYXRpb25UaHJlYWQoKSkKKyAgICAgICAgcmV0dXJuIHRydWU7CisgICAgCiAgICAgUkVMRUFT RV9BU1NFUlQobnVtYmVyT2ZTbG90c0Zvckxhc3RPZmZzZXQobV9vZmZzZXQsIG1faW5saW5lQ2Fw YWNpdHkpID09IHByb3BlcnR5VGFibGUtPnByb3BlcnR5U3RvcmFnZVNpemUoKSk7CiAgICAgdW5z aWduZWQgdG90YWxTaXplID0gcHJvcGVydHlUYWJsZS0+cHJvcGVydHlTdG9yYWdlU2l6ZSgpOwog ICAgIFJFTEVBU0VfQVNTRVJUKCh0b3RhbFNpemUgPCBpbmxpbmVDYXBhY2l0eSgpID8gMCA6IHRv dGFsU2l6ZSAtIGlubGluZUNhcGFjaXR5KCkpID09IG51bWJlck9mT3V0T2ZMaW5lU2xvdHNGb3JM YXN0T2Zmc2V0KG1fb2Zmc2V0KSk7Cg==