121650 2013-09-19 18:03:11 -0700 ASSERTs in isMainThread after USE(WEB_THREAD) MainThread changes 2013-09-19 18:40:18 -0700 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 joepeck webkit-unassigned benjamin cmarcelo commit-queue dbates oldest_to_newest 931145 0 joepeck 2013-09-19 18:03:11 -0700 I broke Safari Extensions with my change outside of USE(WEB_THREAD): 1 0x10cc62680 WTFCrash 2 0x10cc85ffa WTF::isMainThread() 3 0x10ead5836 WebCore::localizedString(char const*) 4 0x10b41d4f8 WebKit::WebProcess::initializeProcessName(WebKit::ChildProcessInitializationParameters const&) 5 0x10b0073c7 WebKit::ChildProcess::initialize(WebKit::ChildProcessInitializationParameters const&) 6 0x10b25b2aa int WebKit::ChildProcessMain<WebKit::WebProcess, WebKit::WebContentProcessMainDelegate>(int, char**) 7 0x10b25b08b WebContentProcessMain 8 0x10afa3d18 WebKit::BootstrapMain(int, char**) 9 0x10afa3b92 main So I will suggest a more targeted fix not changing anything outside of USE(WEB_THREAD). 931147 1 212111 joepeck 2013-09-19 18:04:48 -0700 Created attachment 212111 [PATCH] Proposed Fix 931157 2 212111 commit-queue 2013-09-19 18:40:16 -0700 Comment on attachment 212111 [PATCH] Proposed Fix Clearing flags on attachment: 212111 Committed r156134: <http://trac.webkit.org/changeset/156134> 931158 3 commit-queue 2013-09-19 18:40:18 -0700 All reviewed patches have been landed. Closing bug. 212111 2013-09-19 18:04:48 -0700 2013-09-19 18:40:15 -0700 [PATCH] Proposed Fix suggested-fix.patch text/plain 1341 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFuZ2VMb2cK aW5kZXggZjE4ZDI1Mi4uMmRiNTg1OSAxMDA2NDQKLS0tIGEvU291cmNlL1dURi9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dURi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMy0wOS0xOSAg Sm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgorCisgICAgICAgIEFTU0VSVHMg aW4gaXNNYWluVGhyZWFkIGFmdGVyIFVTRShXRUJfVEhSRUFEKSBNYWluVGhyZWFkIGNoYW5nZXMK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMTY1MAor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogd3RmL21h Yy9NYWluVGhyZWFkTWFjLm1tOgorICAgICAgICAoV1RGOjppbml0aWFsaXplTWFpblRocmVhZFBs YXRmb3JtKToKKwogMjAxMy0wOS0xOSAgRGFuaWVsIEJhdGVzICA8ZGFiYXRlc0BhcHBsZS5jb20+ CiAKICAgICAgICAgW2lPU10gRGVmaW5lIG1haW5UaHJlYWRFc3RhYmxpc2hlZEFzUHRocmVhZE1h aW4gdG8gYmUgdHJ1ZSBpbiBXVEY6OmluaXRpYWxpemVNYWluVGhyZWFkUGxhdGZvcm0oKQpkaWZm IC0tZ2l0IGEvU291cmNlL1dURi93dGYvbWFjL01haW5UaHJlYWRNYWMubW0gYi9Tb3VyY2UvV1RG L3d0Zi9tYWMvTWFpblRocmVhZE1hYy5tbQppbmRleCA3MGMwY2ZkLi4zNzk0ZDkzIDEwMDY0NAot LS0gYS9Tb3VyY2UvV1RGL3d0Zi9tYWMvTWFpblRocmVhZE1hYy5tbQorKysgYi9Tb3VyY2UvV1RG L3d0Zi9tYWMvTWFpblRocmVhZE1hYy5tbQpAQCAtNzIsMTIgKzcyLDEyIEBAIHZvaWQgaW5pdGlh bGl6ZU1haW5UaHJlYWRQbGF0Zm9ybSgpCiAgICAgQVNTRVJUKCFzdGF0aWNNYWluVGhyZWFkQ2Fs bGVyKTsKICAgICBzdGF0aWNNYWluVGhyZWFkQ2FsbGVyID0gW1tKU1dURk1haW5UaHJlYWRDYWxs ZXIgYWxsb2NdIGluaXRdOwogCi0gICAgbWFpblRocmVhZEVzdGFibGlzaGVkQXNQdGhyZWFkTWFp biA9IHRydWU7Ci0KICNpZiAhVVNFKFdFQl9USFJFQUQpCisgICAgbWFpblRocmVhZEVzdGFibGlz aGVkQXNQdGhyZWFkTWFpbiA9IGZhbHNlOwogICAgIG1haW5UaHJlYWRQdGhyZWFkID0gcHRocmVh ZF9zZWxmKCk7CiAgICAgbWFpblRocmVhZE5TVGhyZWFkID0gW1tOU1RocmVhZCBjdXJyZW50VGhy ZWFkXSByZXRhaW5dOwogI2Vsc2UKKyAgICBtYWluVGhyZWFkRXN0YWJsaXNoZWRBc1B0aHJlYWRN YWluID0gdHJ1ZTsKICAgICBBU1NFUlQoIW1haW5UaHJlYWRQdGhyZWFkKTsKICAgICBBU1NFUlQo IW1haW5UaHJlYWROU1RocmVhZCk7CiAjZW5kaWYK