12165 2007-01-08 10:39:14 -0800 REGRESSION: text encoding problem at jn.sapo.pt 2007-01-13 08:52:12 -0800 1 1 1 Unclassified WebKit Page Loading 420+ Mac OS X 10.4 RESOLVED FIXED Regression P1 Normal --- 1 jluisfa ap ap oldest_to_newest 36242 0 jluisfa 2007-01-08 10:39:14 -0800 Safari and Firefox show fine this site <http://jn.sapo.pt> but Webkit no. It has some problem with the reading of the Text Enconding. 36256 1 ap 2007-01-08 12:19:16 -0800 Confirmed as a regression with r18673. That appears to be caused by some garbage before the beginning of HTML document: ---------------------------------------------- <script language="JavaScript" type="text/JavaScript"> document.write ('<SCR' + 'IPT SRC="http://ads.sapo.pt/js.ng/site=lusomundo&chan=jn&adsize=1x1&type=richmedia&TileID='+TileID+'"></SCR' + 'IPT>'); </script>  <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" "http://www.w3.org/TR/html4/loose.dtd"> <html> <head> <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> ---------------------------------------------- 36266 2 jluisfa 2007-01-08 13:25:33 -0800 The validator.w3.org says about <http://sapo.pt>: Sorry! This document can not be checked. Sorry, I am unable to validate this document because on line 636, 660 it contained one or more bytes that I cannot interpret as utf-8 (in other words, the bytes found are not valid values in the specified Character Encoding). Please check both the content of the file and the character encoding indication. 36268 3 jluisfa 2007-01-08 13:32:13 -0800 Correction: The validator.w3.org says about <http://jn.sapo.pt/> ... and not "The validator.w3.org says about <http://sapo.pt> ..." 35249 4 12414 ap 2007-01-13 04:32:26 -0800 Created attachment 12414 proposed fix Invalid HTML has lots of ways to fool our charset meta detector. I'm wondering why we aren't getting a lot more reports of such, though. 35253 5 12414 darin 2007-01-13 07:11:58 -0800 Comment on attachment 12414 proposed fix I guess this is OK, but I'm worried that it's a little risky to ignore tags in scripts when we don't know enough about script syntax to properly handle comments inside the script and know when the script ends. But ... r=me 35221 6 ap 2007-01-13 08:52:12 -0800 Committed revision 18833. 12414 2007-01-13 04:32:26 -0800 2007-01-13 07:11:58 -0800 proposed fix 12165r1_patch.txt text/plain 5325 ap SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDE4ODMyKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDctMDEtMTMgIEFsZXhleSBQcm9za3VyeWFr b3YgIDxhcEB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFRlc3QgZm9yIGh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEyMTY1CisgICAgICAgIFJFR1JFU1NJT046IHRleHQgZW5jb2RpbmcgcHJvYmxlbSBhdCBq bi5zYXBvLnB0CisKKyAgICAgICAgKiBmYXN0L2VuY29kaW5nL3NjcmlwdC1pbi1oZWFkLWV4cGVj dGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZmFzdC9lbmNvZGluZy9zY3JpcHQtaW4taGVhZC5o dG1sOiBBZGRlZC4KKwogMjAwNy0wMS0xMyAgRXJpYyBTZWlkZWwgIDxlcmljQHdlYmtpdC5vcmc+ CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgaHlhdHQuCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2Vu Y29kaW5nL3NjcmlwdC1pbi1oZWFkLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRU ZXN0cy9mYXN0L2VuY29kaW5nL3NjcmlwdC1pbi1oZWFkLWV4cGVjdGVkLnR4dAkocmV2aXNpb24g MCkKKysrIExheW91dFRlc3RzL2Zhc3QvZW5jb2Rpbmcvc2NyaXB0LWluLWhlYWQtZXhwZWN0ZWQu dHh0CShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDYgQEAKK1Rlc3QgZm9yIGJ1ZyAxMjE2NTogdGV4 dCBlbmNvZGluZyBwcm9ibGVtIGF0IGpuLnNhcG8ucHQKKworU2hvdWxkIHNlZSBhIHN1Y2Nlc3Mg bWVzc2FnZSBiZWxvdy4KKworU1XQodCh0JVTUworCgpQcm9wZXJ0eSBjaGFuZ2VzIG9uOiBMYXlv dXRUZXN0cy9mYXN0L2VuY29kaW5nL3NjcmlwdC1pbi1oZWFkLWV4cGVjdGVkLnR4dApfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCk5hbWU6IHN2bjptaW1lLXR5cGUKICAgKyB0ZXh0L3BsYWluCk5hbWU6IHN2bjplb2wtc3R5 bGUKICAgKyBuYXRpdmUKCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2VuY29kaW5nL3NjcmlwdC1p bi1oZWFkLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9lbmNvZGluZy9zY3Jp cHQtaW4taGVhZC5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9lbmNvZGlu Zy9zY3JpcHQtaW4taGVhZC5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDMwIEBACis8IS0t IHRlbXAgLS0+PHNjcmlwdCBsYW5ndWFnZT0iSmF2YVNjcmlwdCIgdHlwZT0idGV4dC9KYXZhU2Ny aXB0Ij4KK2RvY3VtZW50LndyaXRlICgnPFNDUicgKyAnSVBUPicgKworICAgICdpZiAod2luZG93 LmxheW91dFRlc3RDb250cm9sbGVyKSB7JyArCisgICAgICAgICdsYXlvdXRUZXN0Q29udHJvbGxl ci5kdW1wQXNUZXh0KCk7JyArCisgICAgICAgICdsYXlvdXRUZXN0Q29udHJvbGxlci53YWl0VW50 aWxEb25lKCk7JyArCisgICAgJ30nICsKKworICAgICdzZXRUaW1lb3V0KGZ1bmN0aW9uICgpIHsn ICsKKyAgICAgICAgPCEtLSBUaGUgbGV0dGVycyBDQ0UgYmVsb3cgYXJlIEN5cmlsbGljLCBzbyB3 ZSBkbyB0ZXN0IHRoYXQgdGhlIGVuY29kaW5nIGlzIGNvcnJlY3QuIC0tPgorICAgICAgICA8IS0t IFdlIGFsc28gdGFrZSBhbiBvcHBvcnR1bml0eSB0byB0ZXN0IHRoYXQgdGhpcyB3ZWlyZGx5IGxv Y2F0ZWQgc2NyaXB0IGFjdHVhbGx5IGV4ZWN1dGVzLiAtLT4KKyAgICAgICAgJ2RvY3VtZW50Lmdl dEVsZW1lbnRCeUlkKCJyZXN1bHQiKS5pbm5lckhUTUw9IlNV8/PlU1MiOycgKworICAgICAgICAn aWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlciknICsKKyAgICAgICAgICAgICdsYXlvdXRU ZXN0Q29udHJvbGxlci5ub3RpZnlEb25lKCk7JyArCisgICAgJ30sIDApOycgKworJzwvU0NSJyAr ICdJUFQ+Jyk7IDwvc2NyaXB0PgorPCEtLSAvdGVtcCAtLT48IS0tSEVBREVSLS0+CisKKzwhRE9D VFlQRSBIVE1MIFBVQkxJQyAiLS8vVzNDLy9EVEQgSFRNTCA0LjAxIFRyYW5zaXRpb25hbC8vRU4i CisiaHR0cDovL3d3dy53My5vcmcvVFIvaHRtbDQvbG9vc2UuZHRkIj4KKzxodG1sPgorPGhlYWQ+ Cis8bWV0YSBodHRwLWVxdWl2PSJDb250ZW50LVR5cGUiIGNvbnRlbnQ9InRleHQvaHRtbDsgY2hh cnNldD1rb2k4LXIiPgorPC9oZWFkPgorPGJvZHk+Cis8cD5UZXN0IGZvciA8YSBocmVmPSJodHRw Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjE2NSI+YnVnIDEyMTY1PC9hPjoK K3RleHQgZW5jb2RpbmcgcHJvYmxlbSBhdCBqbi5zYXBvLnB0PC9wPgorPHA+U2hvdWxkIHNlZSBh IHN1Y2Nlc3MgbWVzc2FnZSBiZWxvdy48L3A+Cis8ZGl2IGlkPSJyZXN1bHQiPjwvZGl2PgorPC9i b2R5PgorPC9odG1sPgoKUHJvcGVydHkgY2hhbmdlcyBvbjogTGF5b3V0VGVzdHMvZmFzdC9lbmNv ZGluZy9zY3JpcHQtaW4taGVhZC5odG1sCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTmFtZTogc3ZuOm1pbWUtdHlwZQog ICArIHRleHQvaHRtbAoKSW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdl YkNvcmUvQ2hhbmdlTG9nCShyZXZpc2lvbiAxODgzMikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3 b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDctMDEtMTMgIEFsZXhleSBQcm9za3Vy eWFrb3YgIDxhcEB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIGh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEy MTY1CisgICAgICAgIFJFR1JFU1NJT046IHRleHQgZW5jb2RpbmcgcHJvYmxlbSBhdCBqbi5zYXBv LnB0CisKKyAgICAgICAgVGVzdDogZmFzdC9lbmNvZGluZy9zY3JpcHQtaW4taGVhZC5odG1sCisK KyAgICAgICAgKiBsb2FkZXIvVGV4dFJlc291cmNlRGVjb2Rlci5jcHA6CisgICAgICAgIChXZWJD b3JlOjpUZXh0UmVzb3VyY2VEZWNvZGVyOjpjaGVja0ZvckhlYWRDaGFyc2V0KToKKyAgICAgICAg SWdub3JlIHRhZ3Mgd2l0aGluIDxzY3JpcHQ+IGVsZW1lbnRzIGluIGhlYWQsIGp1c3QgbGlrZSB3 ZSBkbyBmb3IgPHRpdGxlPi4KKwogMjAwNy0wMS0xMyAgTGFycyBLbm9sbCA8bGFyc0B0cm9sbHRl Y2guY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE1hY2llagpJbmRleDogV2ViQ29yZS9sb2Fk ZXIvVGV4dFJlc291cmNlRGVjb2Rlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9sb2FkZXIv VGV4dFJlc291cmNlRGVjb2Rlci5jcHAJKHJldmlzaW9uIDE4ODMwKQorKysgV2ViQ29yZS9sb2Fk ZXIvVGV4dFJlc291cmNlRGVjb2Rlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQ4MywxMCArNDgz LDEyIEBAIGJvb2wgVGV4dFJlc291cmNlRGVjb2Rlcjo6Y2hlY2tGb3JIZWFkQ2gKICAgICAvLyBt YXRjaGVzIGJlaGF2aW9yIGluIG90aGVyIGJyb3dzZXJzOyBtb3JlIGRldGFpbHMgaW4KICAgICAv LyA8aHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzU5MD4uCiAgICAgCi0g ICAgLy8gQWRkaXRpb25hbGx5LCB3ZSBpZ25vcmUgdGhpbmdzIHRoYXQgbG9va3MgbGlrZSB0YWdz IGluIDx0aXRsZT47IHNlZQotICAgIC8vIDxodHRwOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD00NTYwPi4KKyAgICAvLyBBZGRpdGlvbmFsbHksIHdlIGlnbm9yZSB0aGluZ3MgdGhh dCBsb29rcyBsaWtlIHRhZ3MgaW4gPHRpdGxlPiBhbmQgPHNjcmlwdD47IHNlZQorICAgIC8vIDxo dHRwOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NTYwPiBhbmQKKyAgICAvLyA8 aHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIxNjU+LgogICAgIAogICAg IGJvb2wgd2l0aGluVGl0bGUgPSBmYWxzZTsKKyAgICBib29sIHdpdGhpblNjcmlwdCA9IGZhbHNl OwogCiAgICAgY29uc3QgY2hhciogcHRyID0gbV9idWZmZXIuZGF0YSgpOwogICAgIGNvbnN0IGNo YXIqIHBFbmQgPSBwdHIgKyBtX2J1ZmZlci5zaXplKCk7CkBAIC01NDgsNiArNTUwLDggQEAgYm9v bCBUZXh0UmVzb3VyY2VEZWNvZGVyOjpjaGVja0ZvckhlYWRDaAogICAgICAgICAgICAgCiAgICAg ICAgICAgICBpZiAodGFnID09IHRpdGxlVGFnKQogICAgICAgICAgICAgICAgIHdpdGhpblRpdGxl ID0gIWVuZDsKKyAgICAgICAgICAgIGVsc2UgaWYgKHRhZyA9PSBzY3JpcHRUYWcpCisgICAgICAg ICAgICAgICAgd2l0aGluU2NyaXB0ID0gIWVuZDsKICAgICAgICAgICAgIAogICAgICAgICAgICAg aWYgKCFlbmQgJiYgdGFnID09IG1ldGFUYWcpIHsKICAgICAgICAgICAgICAgICBjb25zdCBjaGFy KiBlbmQgPSBwdHI7CkBAIC01OTMsNyArNTk3LDcgQEAgYm9vbCBUZXh0UmVzb3VyY2VEZWNvZGVy OjpjaGVja0ZvckhlYWRDaAogICAgICAgICAgICAgfSBlbHNlIGlmICh0YWcgIT0gc2NyaXB0VGFn ICYmIHRhZyAhPSBub3NjcmlwdFRhZyAmJiB0YWcgIT0gc3R5bGVUYWcgJiYKICAgICAgICAgICAg ICAgICAgICAgICAgdGFnICE9IGxpbmtUYWcgJiYgdGFnICE9IG1ldGFUYWcgJiYgdGFnICE9IG9i amVjdFRhZyAmJgogICAgICAgICAgICAgICAgICAgICAgICB0YWcgIT0gdGl0bGVUYWcgJiYgdGFn ICE9IGJhc2VUYWcgJiYgCi0gICAgICAgICAgICAgICAgICAgICAgIChlbmQgfHwgdGFnICE9IGh0 bWxUYWcpICYmICF3aXRoaW5UaXRsZSAmJgorICAgICAgICAgICAgICAgICAgICAgICAoZW5kIHx8 IHRhZyAhPSBodG1sVGFnKSAmJiAhd2l0aGluVGl0bGUgJiYgIXdpdGhpblNjcmlwdCAmJgogICAg ICAgICAgICAgICAgICAgICAgICAodGFnICE9IGhlYWRUYWcpICYmIGlzYWxwaGEodG1wWzBdKSkg ewogICAgICAgICAgICAgICAgIG1fY2hlY2tlZEZvckhlYWRDaGFyc2V0ID0gdHJ1ZTsKICAgICAg ICAgICAgICAgICByZXR1cm4gdHJ1ZTsK