<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>121633</bug_id>
          
          <creation_ts>2013-09-19 14:00:32 -0700</creation_ts>
          <short_desc>[GTK] Clean up the Skip* functions in the GObject DOM bindings code generator</short_desc>
          <delta_ts>2013-09-20 11:11:20 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKitGTK</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Martin Robinson">mrobinson</reporter>
          <assigned_to name="Martin Robinson">mrobinson</assigned_to>
          <cc>cdumez</cc>
    
    <cc>cgarcia</cc>
    
    <cc>commit-queue</cc>
    
    <cc>gustavo</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>931069</commentid>
    <comment_count>0</comment_count>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2013-09-19 14:00:32 -0700</bug_when>
    <thetext>These functions are used for skipping attributes and functions that we do not support. There is a lot of code that call these functions and then tacks on other criteria for skipping. That extra code should go into the SkipFoo function itself.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>931101</commentid>
    <comment_count>1</comment_count>
      <attachid>212104</attachid>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2013-09-19 15:06:09 -0700</bug_when>
    <thetext>Created attachment 212104
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>931408</commentid>
    <comment_count>2</comment_count>
      <attachid>212104</attachid>
    <who name="Gustavo Noronha (kov)">gustavo</who>
    <bug_when>2013-09-20 09:38:51 -0700</bug_when>
    <thetext>Comment on attachment 212104
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=212104&amp;action=review

&gt; Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:-247
&gt; -

nit: does this improve readability in your opinion?

&gt; Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:-907
&gt; -        if ($paramIDLType eq &quot;EventListener&quot; || $paramIDLType eq &quot;MediaQueryListListener&quot;) {
&gt; -            # EventListeners are handled elsewhere.
&gt; -            return;
&gt; -        }

Where are these skipped in this for loop? Or do they not even get here in the function-&gt;parameters?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>931422</commentid>
    <comment_count>3</comment_count>
      <attachid>212104</attachid>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2013-09-20 09:58:54 -0700</bug_when>
    <thetext>Comment on attachment 212104
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=212104&amp;action=review

&gt;&gt; Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:-247
&gt;&gt; -
&gt; 
&gt; nit: does this improve readability in your opinion?

I clumped these because they are all used in the following block. I&apos;m happy to restore the newline though. :)

&gt;&gt; Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:-907
&gt;&gt; -        }
&gt; 
&gt; Where are these skipped in this for loop? Or do they not even get here in the function-&gt;parameters?

These are skipped at line 880/890.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>931470</commentid>
    <comment_count>4</comment_count>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2013-09-20 11:11:20 -0700</bug_when>
    <thetext>Committed r156182: &lt;http://trac.webkit.org/changeset/156182&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>212104</attachid>
            <date>2013-09-19 15:06:09 -0700</date>
            <delta_ts>2013-09-20 09:58:54 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-121633-20130919150608.patch</filename>
            <type>text/plain</type>
            <size>7513</size>
            <attacher name="Martin Robinson">mrobinson</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTU2MTEwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmU4MmRmZmJjMzU3ZTM2
YjBjNTFjNzQyMTkzNzMxOWZhZTdiZmNlYS4uMTJkNDhkMGQ1YjRhNjEzODlmM2QxZWY4YzY3MzYz
NmM2MWQ2NjNlNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEzLTA5LTE5ICBNYXJ0
aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBDbGVh
biB1cCB0aGUgU2tpcCogZnVuY3Rpb25zIGluIHRoZSBHT2JqZWN0IERPTSBiaW5kaW5ncyBjb2Rl
IGdlbmVyYXRvcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/
aWQ9MTIxNjMzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg
ICAgKiBiaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JHT2JqZWN0LnBtOgorICAgICAgICAo
U2tpcEF0dHJpYnV0ZSk6IEZvbGQgaW4gc29tZSBza2lwcGluZyBjaGVja3MgdGhhdCBhcmUgdXNl
ZCBieSBhbGwgY2FsbGVycy4KKyAgICAgICAgKFNraXBGdW5jdGlvbik6IERpdHRvLgorICAgICAg
ICAoR2VuZXJhdGVQcm9wZXJ0aWVzKTogUmVseSBvbiBTa2lwQXR0cmlidXRlIG1vcmUgdGhvcm91
Z2hseS4KKyAgICAgICAgKEdlbmVyYXRlRnVuY3Rpb24pOiBSZWx5IG9uIFNraXBGdW5jdGlvbiBt
b3JlIHRob3JvdWdobHkuCisgICAgICAgIChHZW5lcmF0ZUZ1bmN0aW9ucyk6IFJlbHkgb24gU2tp
cEF0dHJpYnV0ZSBtb3JlIHRob3JvdWdobHkuCisKIDIwMTMtMDktMTkgIEFuZHJlYXMgS2xpbmcg
IDxha2xpbmdAYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBTVkdQcm9wZXJ0eUluZm8uY3BwCmRp
ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JH
T2JqZWN0LnBtIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9y
R09iamVjdC5wbQppbmRleCBiOGFiYjFjYTM3NmUxMjkxMzU3ZWQxODM2ZWVkOTVmZjMxMTU5YWFh
Li5hOTIxZTc3ZTU0ZDM5NWJkOTZkYTQxMTA0MWU5NTliYzJlMzkxMGJjIDEwMDY0NAotLS0gYS9T
b3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JHT2JqZWN0LnBtCisr
KyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckdPYmplY3Qu
cG0KQEAgLTIyNiw2ICsyMjYsMTQgQEAgc3ViIFNraXBBdHRyaWJ1dGUgewogICAgICAgICByZXR1
cm4gMTsKICAgICB9CiAKKyAgICBpZiAoJGF0dHJpYnV0ZS0+c2lnbmF0dXJlLT50eXBlIGVxICJF
dmVudExpc3RlbmVyIikgeworICAgICAgICByZXR1cm4gMTsKKyAgICB9CisKKyAgICBpZiAoJGF0
dHJpYnV0ZS0+c2lnbmF0dXJlLT50eXBlIGVxICJNZWRpYVF1ZXJ5TGlzdExpc3RlbmVyIikgewor
ICAgICAgICByZXR1cm4gMTsKKyAgICB9CisKICAgICAjIFNraXAgaW5kZXhlZCBkYXRhYmFzZSBh
dHRyaWJ1dGVzIGZvciBub3csIHRoZXkgYXJlbid0IHlldCBzdXBwb3J0ZWQgZm9yIHRoZSBHT2Jq
ZWN0IGdlbmVyYXRvci4KICAgICBpZiAoJGF0dHJpYnV0ZS0+c2lnbmF0dXJlLT5uYW1lID1+IC9e
KD86d2Via2l0KT9bSWldbmRleGVkREIvIG9yICRhdHRyaWJ1dGUtPnNpZ25hdHVyZS0+bmFtZSA9
fiAvXig/OndlYmtpdCk/SURCLykgewogICAgICAgICByZXR1cm4gMTsKQEAgLTIzNSw2ICsyNDMs
NyBAQCBzdWIgU2tpcEF0dHJpYnV0ZSB7CiB9CiAKIHN1YiBTa2lwRnVuY3Rpb24geworICAgIG15
ICRvYmplY3QgPSBzaGlmdDsKICAgICBteSAkZnVuY3Rpb24gPSBzaGlmdDsKICAgICBteSAkZGVj
YW1lbGl6ZSA9IHNoaWZ0OwogICAgIG15ICRwcmVmaXggPSBzaGlmdDsKQEAgLTI0NCw3ICsyNTMs
NiBAQCBzdWIgU2tpcEZ1bmN0aW9uIHsKICAgICBteSAkaXNDdXN0b21GdW5jdGlvbiA9ICRmdW5j
dGlvbi0+c2lnbmF0dXJlLT5leHRlbmRlZEF0dHJpYnV0ZXMtPnsiQ3VzdG9tIn07CiAgICAgbXkg
JGNhbGxXaXRoID0gJGZ1bmN0aW9uLT5zaWduYXR1cmUtPmV4dGVuZGVkQXR0cmlidXRlcy0+eyJD
YWxsV2l0aCJ9OwogICAgIG15ICRpc1Vuc3VwcG9ydGVkQ2FsbFdpdGggPSAkY29kZUdlbmVyYXRv
ci0+RXh0ZW5kZWRBdHRyaWJ1dGVDb250YWlucygkY2FsbFdpdGgsICJTY3JpcHRBcmd1bWVudHMi
KSB8fCAkY29kZUdlbmVyYXRvci0+RXh0ZW5kZWRBdHRyaWJ1dGVDb250YWlucygkY2FsbFdpdGgs
ICJDYWxsU3RhY2siKTsKLQogICAgIGlmICgoJGlzQ3VzdG9tRnVuY3Rpb24gfHwgJGlzVW5zdXBw
b3J0ZWRDYWxsV2l0aCkgJiYKICAgICAgICAgJGZ1bmN0aW9uTmFtZSBuZSAid2Via2l0X2RvbV9u
b2RlX3JlcGxhY2VfY2hpbGQiICYmCiAgICAgICAgICRmdW5jdGlvbk5hbWUgbmUgIndlYmtpdF9k
b21fbm9kZV9pbnNlcnRfYmVmb3JlIiAmJgpAQCAtMjU1LDIxICsyNjMsNDMgQEAgc3ViIFNraXBG
dW5jdGlvbiB7CiAgICAgICAgIHJldHVybiAxOwogICAgIH0KIAotICAgIGlmICgkZnVuY3Rpb24t
PnNpZ25hdHVyZS0+bmFtZSBlcSAiZ2V0U1ZHRG9jdW1lbnQiKSB7CisgICAgIyBTa2lwIGZ1bmN0
aW9ucyB0aGF0IGhhdmUgY2FsbGJhY2sgcGFyYW1ldGVycywgYmVjYXVzZSB0aGlzIGNvZGUgZ2Vu
ZXJhdG9yIGRvZXNuJ3Qga25vdworICAgICMgaG93IHRvIGF1dG8tZ2VuZXJhdGUgY2FsbGJhY2tz
LiAgU2tpcCBmdW5jdGlvbnMgdGhhdCBoYXZlICJNZWRpYVF1ZXJ5TGlzdExpc3RlbmVyIiBvcgor
ICAgICMgc2VxdWVuY2U8VD4gcGFyYW1ldGVycywgYmVjYXVzZSB0aGlzIGNvZGUgZ2VuZXJhdG9y
IGRvZXNuJ3Qga25vdyBob3cgdG8gYXV0by1nZW5lcmF0ZQorICAgICMgTWVkaWFRdWVyeUxpc3RM
aXN0ZW5lciBvciBzZXF1ZW5jZTxUPi4gU2tpcCBFdmVudExpc3RlbmVycyBiZWNhdXNlIHRoZXkg
YXJlIGhhbmRsZWQgZWxzZXdoZXJlLgorICAgIGZvcmVhY2ggbXkgJHBhcmFtIChAeyRmdW5jdGlv
bi0+cGFyYW1ldGVyc30pIHsKKyAgICAgICAgaWYgKCRjb2RlR2VuZXJhdG9yLT5Jc0NhbGxiYWNr
SW50ZXJmYWNlKCRwYXJhbS0+dHlwZSkgfHwKKyAgICAgICAgICAgICRwYXJhbS0+ZXh0ZW5kZWRB
dHRyaWJ1dGVzLT57IkNsYW1wIn0gfHwKKyAgICAgICAgICAgICRwYXJhbS0+dHlwZSBlcSAiTWVk
aWFRdWVyeUxpc3RMaXN0ZW5lciIgfHwKKyAgICAgICAgICAgICRwYXJhbS0+dHlwZSBlcSAiRXZl
bnRMaXN0ZW5lciIgfHwKKyAgICAgICAgICAgICRjb2RlR2VuZXJhdG9yLT5HZXRTZXF1ZW5jZVR5
cGUoJHBhcmFtLT50eXBlKSkgeworICAgICAgICAgICAgcmV0dXJuIDE7CisgICAgICAgIH0KKyAg
ICB9CisKKyAgICAjIFRoaXMgaXMgZm9yIERhdGFUcmFuc2Zlckl0ZW1MaXN0LmlkbCBhZGQoRmls
ZSkgbWV0aG9kCisgICAgaWYgKCRmdW5jdGlvbk5hbWUgZXEgIndlYmtpdF9kb21fZGF0YV90cmFu
c2Zlcl9pdGVtX2xpc3RfYWRkIiAmJiBAeyRmdW5jdGlvbi0+cGFyYW1ldGVyc30gPT0gMSkgewog
ICAgICAgICByZXR1cm4gMTsKICAgICB9CiAKLSAgICBpZiAoJGZ1bmN0aW9uLT5zaWduYXR1cmUt
Pm5hbWUgZXEgImdldENTU0NhbnZhc0NvbnRleHQiKSB7CisKKyAgICBpZiAoJGZ1bmN0aW9uLT5z
aWduYXR1cmUtPm5hbWUgZXEgInNldCIgYW5kICRwYXJlbnROb2RlLT5leHRlbmRlZEF0dHJpYnV0
ZXMtPnsiVHlwZWRBcnJheSJ9KSB7CiAgICAgICAgIHJldHVybiAxOwogICAgIH0KIAotICAgIGlm
ICgkZnVuY3Rpb24tPnNpZ25hdHVyZS0+bmFtZSBlcSAic2V0UmFuZ2VUZXh0IiAmJiBAeyRmdW5j
dGlvbi0+cGFyYW1ldGVyc30gPT0gMSkgeworICAgIGlmICgkb2JqZWN0IGVxICJNZWRpYVF1ZXJ5
TGlzdExpc3RlbmVyIikgewogICAgICAgICByZXR1cm4gMTsKICAgICB9CiAKLSAgICAjIFRoaXMg
aXMgZm9yIERhdGFUcmFuc2Zlckl0ZW1MaXN0LmlkbCBhZGQoRmlsZSkgbWV0aG9kCi0gICAgaWYg
KCRmdW5jdGlvbk5hbWUgZXEgIndlYmtpdF9kb21fZGF0YV90cmFuc2Zlcl9pdGVtX2xpc3RfYWRk
IiAmJgotICAgICAgICBAeyRmdW5jdGlvbi0+cGFyYW1ldGVyc30gPT0gMSkgeworICAgIGlmICgk
ZnVuY3Rpb24tPnNpZ25hdHVyZS0+bmFtZSBlcSAiZ2V0U1ZHRG9jdW1lbnQiKSB7CisgICAgICAg
IHJldHVybiAxOworICAgIH0KKworICAgIGlmICgkZnVuY3Rpb24tPnNpZ25hdHVyZS0+bmFtZSBl
cSAiZ2V0Q1NTQ2FudmFzQ29udGV4dCIpIHsKKyAgICAgICAgcmV0dXJuIDE7CisgICAgfQorCisg
ICAgaWYgKCRmdW5jdGlvbi0+c2lnbmF0dXJlLT5uYW1lIGVxICJzZXRSYW5nZVRleHQiICYmIEB7
JGZ1bmN0aW9uLT5wYXJhbWV0ZXJzfSA9PSAxKSB7CiAgICAgICAgIHJldHVybiAxOwogICAgIH0K
IApAQCAtMjg1LDE5ICszMTUsNiBAQCBzdWIgU2tpcEZ1bmN0aW9uIHsKICAgICAgICAgcmV0dXJu
IDE7CiAgICAgfQogCi0gICAgIyBTa2lwIGZ1bmN0aW9ucyB0aGF0IGhhdmUgY2FsbGJhY2sgcGFy
YW1ldGVycywgYmVjYXVzZSB0aGlzCi0gICAgIyBjb2RlIGdlbmVyYXRvciBkb2Vzbid0IGtub3cg
aG93IHRvIGF1dG8tZ2VuZXJhdGUgY2FsbGJhY2tzLgotICAgICMgU2tpcCBmdW5jdGlvbnMgdGhh
dCBoYXZlICJNZWRpYVF1ZXJ5TGlzdExpc3RlbmVyIiBvciBzZXF1ZW5jZTxUPiBwYXJhbWV0ZXJz
LCBiZWNhdXNlIHRoaXMKLSAgICAjIGNvZGUgZ2VuZXJhdG9yIGRvZXNuJ3Qga25vdyBob3cgdG8g
YXV0by1nZW5lcmF0ZSBNZWRpYVF1ZXJ5TGlzdExpc3RlbmVyIG9yIHNlcXVlbmNlPFQ+LgotICAg
IGZvcmVhY2ggbXkgJHBhcmFtIChAeyRmdW5jdGlvbi0+cGFyYW1ldGVyc30pIHsKLSAgICAgICAg
aWYgKCRjb2RlR2VuZXJhdG9yLT5Jc0NhbGxiYWNrSW50ZXJmYWNlKCRwYXJhbS0+dHlwZSkgfHwK
LSAgICAgICAgICAgICRwYXJhbS0+ZXh0ZW5kZWRBdHRyaWJ1dGVzLT57IkNsYW1wIn0gfHwKLSAg
ICAgICAgICAgICRwYXJhbS0+dHlwZSBlcSAiTWVkaWFRdWVyeUxpc3RMaXN0ZW5lciIgfHwKLSAg
ICAgICAgICAgICRjb2RlR2VuZXJhdG9yLT5HZXRTZXF1ZW5jZVR5cGUoJHBhcmFtLT50eXBlKSkg
ewotICAgICAgICAgICAgcmV0dXJuIDE7Ci0gICAgICAgIH0KLSAgICB9Ci0KICAgICByZXR1cm4g
MDsKIH0KIApAQCAtNjQyLDEwICs2NTksNyBAQCBFT0YKICAgICAgICAgfQogCiAgICAgICAgIGZv
cmVhY2ggbXkgJGF0dHJpYnV0ZSAoQHJlYWRhYmxlUHJvcGVydGllcykgewotICAgICAgICAgICAg
aWYgKCRhdHRyaWJ1dGUtPnNpZ25hdHVyZS0+dHlwZSBuZSAiRXZlbnRMaXN0ZW5lciIgJiYKLSAg
ICAgICAgICAgICAgICAkYXR0cmlidXRlLT5zaWduYXR1cmUtPnR5cGUgbmUgIk1lZGlhUXVlcnlM
aXN0TGlzdGVuZXIiKSB7Ci0gICAgICAgICAgICAgICAgR2VuZXJhdGVQcm9wZXJ0eSgkYXR0cmli
dXRlLCAkaW50ZXJmYWNlTmFtZSwgXEB3cml0ZWFibGVQcm9wZXJ0aWVzLCAkaW50ZXJmYWNlKTsK
LSAgICAgICAgICAgIH0KKyAgICAgICAgICAgIEdlbmVyYXRlUHJvcGVydHkoJGF0dHJpYnV0ZSwg
JGludGVyZmFjZU5hbWUsIFxAd3JpdGVhYmxlUHJvcGVydGllcywgJGludGVyZmFjZSk7CiAgICAg
ICAgIH0KIAogICAgICAgICBwdXNoKEBjQm9keVByb3BlcnRpZXMsICJ9O1xuXG4iKTsKQEAgLTg3
MywxNiArODg3LDEwIEBAIHN1YiBHZW5lcmF0ZUZ1bmN0aW9uIHsKIAogICAgIG15ICRkZWNhbWVs
aXplID0gZGVjYW1lbGl6ZSgkaW50ZXJmYWNlTmFtZSk7CiAKLSAgICBpZiAoJG9iamVjdCBlcSAi
TWVkaWFRdWVyeUxpc3RMaXN0ZW5lciIpIHsKLSAgICAgICAgcmV0dXJuOwotICAgIH0KLQotICAg
IGlmIChTa2lwRnVuY3Rpb24oJGZ1bmN0aW9uLCAkZGVjYW1lbGl6ZSwgJHByZWZpeCkpIHsKKyAg
ICBpZiAoU2tpcEZ1bmN0aW9uKCRvYmplY3QsICRmdW5jdGlvbiwgJGRlY2FtZWxpemUsICRwcmVm
aXgpKSB7CiAgICAgICAgIHJldHVybjsKICAgICB9CiAKLSAgICByZXR1cm4gaWYgKCRmdW5jdGlv
bi0+c2lnbmF0dXJlLT5uYW1lIGVxICJzZXQiIGFuZCAkcGFyZW50Tm9kZS0+ZXh0ZW5kZWRBdHRy
aWJ1dGVzLT57IlR5cGVkQXJyYXkifSk7Ci0KICAgICBteSAkZnVuY3Rpb25TaWdUeXBlID0gJHBy
ZWZpeCBlcSAic2V0XyIgPyAidm9pZCIgOiAkZnVuY3Rpb24tPnNpZ25hdHVyZS0+dHlwZTsKICAg
ICBteSAkZnVuY3Rpb25OYW1lID0gIndlYmtpdF9kb21fIiAuICRkZWNhbWVsaXplIC4gIl8iIC4g
JHByZWZpeCAuIGRlY2FtZWxpemUoJGZ1bmN0aW9uLT5zaWduYXR1cmUtPm5hbWUpOwogICAgIG15
ICRyZXR1cm5UeXBlID0gR2V0R2xpYlR5cGVOYW1lKCRmdW5jdGlvblNpZ1R5cGUpOwpAQCAtODk4
LDE0ICs5MDYsOCBAQCBzdWIgR2VuZXJhdGVGdW5jdGlvbiB7CiAgICAgbXkgJHN5bWJvbFNpZyA9
ICIke2NsYXNzTmFtZX0qIjsKIAogICAgIG15IEBjYWxsSW1wbFBhcmFtczsKLQogICAgIGZvcmVh
Y2ggbXkgJHBhcmFtIChAeyRmdW5jdGlvbi0+cGFyYW1ldGVyc30pIHsKICAgICAgICAgbXkgJHBh
cmFtSURMVHlwZSA9ICRwYXJhbS0+dHlwZTsKLSAgICAgICAgaWYgKCRwYXJhbUlETFR5cGUgZXEg
IkV2ZW50TGlzdGVuZXIiIHx8ICRwYXJhbUlETFR5cGUgZXEgIk1lZGlhUXVlcnlMaXN0TGlzdGVu
ZXIiKSB7Ci0gICAgICAgICAgICAjIEV2ZW50TGlzdGVuZXJzIGFyZSBoYW5kbGVkIGVsc2V3aGVy
ZS4KLSAgICAgICAgICAgIHJldHVybjsKLSAgICAgICAgfQotCiAgICAgICAgIG15ICRwYXJhbVR5
cGUgPSBHZXRHbGliVHlwZU5hbWUoJHBhcmFtSURMVHlwZSk7CiAgICAgICAgIG15ICRjb25zdCA9
ICRwYXJhbVR5cGUgZXEgImdjaGFyKiIgPyAiY29uc3QgIiA6ICIiOwogICAgICAgICBteSAkcGFy
YW1OYW1lID0gJHBhcmFtLT5uYW1lOwpAQCAtMTIwMiwxMiArMTIwNCwxMCBAQCBzdWIgR2VuZXJh
dGVGdW5jdGlvbnMgewogCiAgICAgVE9QOgogICAgIGZvcmVhY2ggbXkgJGF0dHJpYnV0ZSAoQHsk
aW50ZXJmYWNlLT5hdHRyaWJ1dGVzfSkgewotICAgICAgICBpZiAoU2tpcEF0dHJpYnV0ZSgkYXR0
cmlidXRlKSB8fAotICAgICAgICAgICAgJGF0dHJpYnV0ZS0+c2lnbmF0dXJlLT50eXBlIGVxICJF
dmVudExpc3RlbmVyIiB8fAotICAgICAgICAgICAgJGF0dHJpYnV0ZS0+c2lnbmF0dXJlLT50eXBl
IGVxICJNZWRpYVF1ZXJ5TGlzdExpc3RlbmVyIikgeworICAgICAgICBpZiAoU2tpcEF0dHJpYnV0
ZSgkYXR0cmlidXRlKSkgewogICAgICAgICAgICAgbmV4dCBUT1A7CiAgICAgICAgIH0KLSAgICAg
ICAgCisKICAgICAgICAgaWYgKCRhdHRyaWJ1dGUtPnNpZ25hdHVyZS0+bmFtZSBlcSAidHlwZSIK
ICAgICAgICAgICAgICMgVGhpcyB3aWxsIGNvbmZsaWN0IHdpdGggdGhlIGdldF90eXBlKCkgZnVu
Y3Rpb24gd2UgZGVmaW5lIHRvIHJldHVybiBhIEdUeXBlCiAgICAgICAgICAgICAjIGFjY29yZGlu
ZyB0byBHT2JqZWN0IGNvbnZlbnRpb25zLiAgU2tpcCB0aGlzIGZvciBub3cuCg==
</data>
<flag name="review"
          id="234264"
          type_id="1"
          status="+"
          setter="gustavo"
    />
          </attachment>
      

    </bug>

</bugzilla>