121626 2013-09-19 12:15:20 -0700 Spatial Navigation : User should be able to navigate html elements having element.style.cursor="pointer" 2013-10-20 08:07:51 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) All All UNCONFIRMED http://jsfiddle.net/nsKjk/5/ P2 Normal --- 0 kandalkar.abhijeet58 webkit-unassigned cmarcelo commit-queue cshu esprehn+autocc joepeck kandalkar.abhijeet58 kangil.han simon.fraser tonikitoo oldest_to_newest 931039 0 kandalkar.abhijeet58 2013-09-19 12:15:20 -0700 Spatial Navigation: User should be able to navigate html elements having element.style.cursor="pointer" Using cursor properties is common practice in Web development. Refer URL mentioned above; button is created using <span> which behaves like hyperlink. As <span> is not focusable WebKit doesn’t draw focus ring. So to make <span> focusable element for spatial navigation, we need to adopt same approach mentioned in URL. 1. If any HTML element has style.cursor="pointer", consider it as candidate for Spatial Navigation. 2. If such element is chosen as best candidate, focus it by drawing border/outline around it. @Antonio/Simon, Please let me know your comments ? 931054 1 tonikitoo 2013-09-19 13:07:39 -0700 > @Antonio/Simon, > Please let me know your comments ? Sounds good with me. Does Opera 12 (pre-blink) do similarly? 931540 2 kandalkar.abhijeet58 2013-09-20 13:00:10 -0700 I checked Opera V12.14, Opera doesn't support this feature. We should implement it in Webkit. Started working on it :) 935775 3 213246 kandalkar.abhijeet58 2013-10-03 08:00:13 -0700 Created attachment 213246 Updated patch-1 936168 4 213246 tonikitoo 2013-10-04 06:00:39 -0700 Comment on attachment 213246 Updated patch-1 View in context: https://bugs.webkit.org/attachment.cgi?id=213246&action=review r-. See comments. Also, a question: this property (cursor: point) seems inheritable. What happens if one does <body style="cursor:point"> ? > Source/WebCore/dom/Element.cpp:251 > +bool Element::isSpatialNavigationFocusable() const > +{ > + if (!document().frame() && !document().frame()->settings().spatialNavigationEnabled()) > + return false; > + > + if (!inDocument()) > + return false; > + > + if (!renderer() || renderer()->style()->visibility() != VISIBLE) > + return false; > + > + return (renderer()->style()->cursor() == CURSOR_POINTER); > +} > + this does not belong to Element. See more below. > Source/WebCore/page/FocusController.cpp:768 > + if (!element->isSpatialNavigationFocusable() && !element->isKeyboardFocusable(event) && !element->isFrameOwnerElement() && !canScrollInDirection(element, direction)) isSpatialNavigationFocusable belong, I believe to SpatialNavigation.h, and should likely be a static method, taking an Element* Additionally, it should be named with cursor:point case in mind. isSpatialNavigationFocusable is too generic in this case. Maybe hasCursorPointStyle? 937196 5 simon.fraser 2013-10-07 12:49:46 -0700 Is this behavior described in a spec anywhere? 940382 6 kandalkar.abhijeet58 2013-10-16 08:56:40 -0700 No, this behavior is not belongs to spec This change will improve user interaction using spatial Navigation. (In reply to comment #5) > Is this behavior described in a spec anywhere? 940392 7 simon.fraser 2013-10-16 09:07:06 -0700 (In reply to comment #6) > No, this behavior is not belongs to spec > This change will improve user interaction using spatial Navigation. Then I don't think it should be implemented. If it's specified, then it's OK to implement. We want interoperability between browsers. 941694 8 kandalkar.abhijeet58 2013-10-20 08:07:51 -0700 Hi Simon, I agree with your point about interoperability between browsers but we are implementing this feature only if the spatial navigation is enabled. If user enabled spatial navigation then only this behavior is enabled for him. I think this behavior will be helpful for user who wants to navigate WebPages using key navigation. Moreover reasons to enable such behavior are, 1. To make spatial navigation more user interactive. 2. Opera browser already has this feature implemented. (Opera Version 12.14 using presto rendering engine) - http://www.opera.com/help/tutorials/nomouse/ 3. Most of web developers are using cursor pointer CSS style along with JavaScript event handlers, without abovementioned change user will not able to navigate such links. <div style=”cursor: pointer” onclick=”navigateToUrl(‘www.google.com’)”> Click me</div> (In reply to comment #7) > (In reply to comment #6) > > No, this behavior is not belongs to spec > > This change will improve user interaction using spatial Navigation. > > Then I don't think it should be implemented. If it's specified, then it's OK to implement. We want interoperability between browsers. 941695 9 kandalkar.abhijeet58 2013-10-20 08:07:51 -0700 Hi Simon, I agree with your point about interoperability between browsers but we are implementing this feature only if the spatial navigation is enabled. If user enabled spatial navigation then only this behavior is enabled for him. I think this behavior will be helpful for user who wants to navigate WebPages using key navigation. Moreover reasons to enable such behavior are, 1. To make spatial navigation more user interactive. 2. Opera browser already has this feature implemented. (Opera Version 12.14 using presto rendering engine) - http://www.opera.com/help/tutorials/nomouse/ 3. Most of web developers are using cursor pointer CSS style along with JavaScript event handlers, without abovementioned change user will not able to navigate such links. <div style=”cursor: pointer” onclick=”navigateToUrl(‘www.google.com’)”> Click me</div> (In reply to comment #7) > (In reply to comment #6) > > No, this behavior is not belongs to spec > > This change will improve user interaction using spatial Navigation. > > Then I don't think it should be implemented. If it's specified, then it's OK to implement. We want interoperability between browsers. 213246 2013-10-03 08:00:13 -0700 2013-10-04 06:00:39 -0700 Updated patch-1 patch1_121626.diff text/plain 9258 kandalkar.abhijeet58 SW5kZXg6IFNvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV2ViQ29yZS9kb20vRWxlbWVudC5jcHAJKHJldmlzaW9uIDE1NjgzMikKKysrIFNvdXJjZS9X ZWJDb3JlL2RvbS9FbGVtZW50LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjEyLDcgKzIxMiw3IEBA CiAKIGJvb2wgRWxlbWVudDo6c3VwcG9ydHNGb2N1cygpIGNvbnN0CiB7Ci0gICAgcmV0dXJuIGhh c1JhcmVEYXRhKCkgJiYgZWxlbWVudFJhcmVEYXRhKCktPnRhYkluZGV4U2V0RXhwbGljaXRseSgp OworICAgIHJldHVybiBpc1NwYXRpYWxOYXZpZ2F0aW9uRm9jdXNhYmxlKCkgfHwgKGhhc1JhcmVE YXRhKCkgJiYgZWxlbWVudFJhcmVEYXRhKCktPnRhYkluZGV4U2V0RXhwbGljaXRseSgpKTsKIH0K IAogRWxlbWVudCogRWxlbWVudDo6Zm9jdXNEZWxlZ2F0ZSgpCkBAIC0yMzUsNiArMjM1LDIwIEBA CiAgICAgcmV0dXJuIGlzRm9jdXNhYmxlKCk7CiB9CiAKK2Jvb2wgRWxlbWVudDo6aXNTcGF0aWFs TmF2aWdhdGlvbkZvY3VzYWJsZSgpIGNvbnN0Cit7CisgICAgaWYgKCFkb2N1bWVudCgpLmZyYW1l KCkgJiYgIWRvY3VtZW50KCkuZnJhbWUoKS0+c2V0dGluZ3MoKS5zcGF0aWFsTmF2aWdhdGlvbkVu YWJsZWQoKSkKKyAgICAgICAgcmV0dXJuIGZhbHNlOworCisgICAgaWYgKCFpbkRvY3VtZW50KCkp CisgICAgICAgIHJldHVybiBmYWxzZTsKKworICAgIGlmICghcmVuZGVyZXIoKSB8fCByZW5kZXJl cigpLT5zdHlsZSgpLT52aXNpYmlsaXR5KCkgIT0gVklTSUJMRSkKKyAgICAgICAgcmV0dXJuIGZh bHNlOworCisgICAgcmV0dXJuIChyZW5kZXJlcigpLT5zdHlsZSgpLT5jdXJzb3IoKSA9PSBDVVJT T1JfUE9JTlRFUik7Cit9CisKIGJvb2wgRWxlbWVudDo6c2hvdWxkVXNlSW5wdXRNZXRob2QoKQog ewogICAgIHJldHVybiBpc0NvbnRlbnRFZGl0YWJsZShVc2VyU2VsZWN0QWxsSXNBbHdheXNOb25F ZGl0YWJsZSk7CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5oCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmgJKHJldmlzaW9uIDE1NjgzMikKKysrIFNv dXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmgJKHdvcmtpbmcgY29weSkKQEAgLTMzMyw2ICszMzMs OCBAQAogICAgIHZpcnR1YWwgYm9vbCBpc0tleWJvYXJkRm9jdXNhYmxlKEtleWJvYXJkRXZlbnQq KSBjb25zdDsKICAgICB2aXJ0dWFsIGJvb2wgaXNNb3VzZUZvY3VzYWJsZSgpIGNvbnN0OwogCisg ICAgYm9vbCBpc1NwYXRpYWxOYXZpZ2F0aW9uRm9jdXNhYmxlKCkgY29uc3Q7CisKICAgICB2aXJ0 dWFsIGJvb2wgc2hvdWxkVXNlSW5wdXRNZXRob2QoKTsKIAogICAgIHZpcnR1YWwgc2hvcnQgdGFi SW5kZXgoKSBjb25zdDsKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1NjgzMikKKysrIFNvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDEz LTEwLTAzICBBYmhpamVldCBLYW5kYWxrYXIgIDxhYmhpamVldC5rQHNhbXN1bmcuY29tPgorCisg ICAgICAgIFNwYXRpYWwgTmF2aWdhdGlvbiA6IFVzZXIgc2hvdWxkIGJlIGFibGUgdG8gbmF2aWdh dGUgaHRtbCBlbGVtZXRzIGhhdmluZyBlbGVtZW50LnN0eWxlLmN1cnNvcj0icG9pbnRlciIKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMTYyNgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFib3ZlIGNoYW5n ZXMgYWxsb3cgU3BhdGlhbCBOYXZpZ2F0aW9uIHRvIHN1cHBvcnQgZm9jdXMgZm9yIGh0bWwgZWxl bWVudHMgd2hpY2ggYXJlIG5vdCB0cmVhdGVkIGFzIGZvY3VzYWJsZSBieSB3ZWJraXQuIEZvciBl eGFtcGxlLCBlbGVtZW50cyBoYXZpbmcgQ1NTIHN0eWxlIHBvaW50ZXIgY3Vyc29yLgorCisgICAg ICAgIFRlc3Q6IGZhc3Qvc3BhdGlhbC1uYXZpZ2F0aW9uL3NuYXYtY3Vyc29yLXBvaW50ZXIuaHRt bAorCisgICAgICAgICogZG9tL0VsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RWxlbWVu dDo6c3VwcG9ydHNGb2N1cyk6CisgICAgICAgIChXZWJDb3JlOjpFbGVtZW50Ojppc1NwYXRpYWxO YXZpZ2F0aW9uRm9jdXNhYmxlKToKKyAgICAgICAgKiBkb20vRWxlbWVudC5oOgorICAgICAgICAq IHBhZ2UvRm9jdXNDb250cm9sbGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZvY3VzQ29udHJv bGxlcjo6ZmluZEZvY3VzQ2FuZGlkYXRlSW5Db250YWluZXIpOgorCiAyMDEzLTEwLTAzICBaYW4g RG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KIAogICAgICAgICBBZGQgdGhlIE5vdERl bGV0YWJsZSwgT3BlcmF0aW9uc05vdERlbGV0YWJsZSBJREwgYXR0cmlidXRlcwpJbmRleDogU291 cmNlL1dlYkNvcmUvcGFnZS9Gb2N1c0NvbnRyb2xsZXIuY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9XZWJDb3JlL3BhZ2UvRm9jdXNDb250cm9sbGVyLmNwcAkocmV2aXNpb24gMTU2ODMyKQorKysg U291cmNlL1dlYkNvcmUvcGFnZS9Gb2N1c0NvbnRyb2xsZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBA IC03NjUsNyArNzY1LDcgQEAKICAgICAgICAgaWYgKGVsZW1lbnQgPT0gZm9jdXNlZE5vZGUpCiAg ICAgICAgICAgICBjb250aW51ZTsKIAotICAgICAgICBpZiAoIWVsZW1lbnQtPmlzS2V5Ym9hcmRG b2N1c2FibGUoZXZlbnQpICYmICFlbGVtZW50LT5pc0ZyYW1lT3duZXJFbGVtZW50KCkgJiYgIWNh blNjcm9sbEluRGlyZWN0aW9uKGVsZW1lbnQsIGRpcmVjdGlvbikpCisgICAgICAgIGlmICghZWxl bWVudC0+aXNTcGF0aWFsTmF2aWdhdGlvbkZvY3VzYWJsZSgpICYmICFlbGVtZW50LT5pc0tleWJv YXJkRm9jdXNhYmxlKGV2ZW50KSAmJiAhZWxlbWVudC0+aXNGcmFtZU93bmVyRWxlbWVudCgpICYm ICFjYW5TY3JvbGxJbkRpcmVjdGlvbihlbGVtZW50LCBkaXJlY3Rpb24pKQogICAgICAgICAgICAg Y29udGludWU7CiAKICAgICAgICAgRm9jdXNDYW5kaWRhdGUgY2FuZGlkYXRlID0gRm9jdXNDYW5k aWRhdGUoZWxlbWVudCwgZGlyZWN0aW9uKTsKSW5kZXg6IExheW91dFRlc3RzL2Zhc3Qvc3BhdGlh bC1uYXZpZ2F0aW9uL3NuYXYtY3Vyc29yLXBvaW50ZXItZXhwZWN0ZWQudHh0Cj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIExheW91dFRlc3RzL2Zhc3Qvc3BhdGlhbC1uYXZpZ2F0aW9uL3NuYXYtY3Vyc29yLXBvaW50 ZXItZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9zcGF0aWFs LW5hdmlnYXRpb24vc25hdi1jdXJzb3ItcG9pbnRlci1leHBlY3RlZC50eHQJKHJldmlzaW9uIDAp CkBAIC0wLDAgKzEsMzUgQEAKK0QxUzFEMlMyRDExUzExRDEyUzEyCisKKworCisKKworCisKKwor CisKK0hpLCBJIGFtIHBhcmFncmFwaAorCisKK0hpLCBJIGFtIHNwYW4gCisKK0kgYW0gCiticmVh a2FibGUgCitkaXYgZWxlbWVudAorCisKK1BBU1MgZ0ZvY3VzZWREb2N1bWVudC5hY3RpdmVFbGVt ZW50LmdldEF0dHJpYnV0ZSgiaWQiKSBpcyAiUzEiCitQQVNTIGdGb2N1c2VkRG9jdW1lbnQuYWN0 aXZlRWxlbWVudC5nZXRBdHRyaWJ1dGUoImlkIikgaXMgIkQyIgorUEFTUyBnRm9jdXNlZERvY3Vt ZW50LmFjdGl2ZUVsZW1lbnQuZ2V0QXR0cmlidXRlKCJpZCIpIGlzICJTMiIKK0ZBSUwgZ0ZvY3Vz ZWREb2N1bWVudC5hY3RpdmVFbGVtZW50LmdldEF0dHJpYnV0ZSgiaWQiKSBzaG91bGQgYmUgcCAo b2YgdHlwZSBzdHJpbmcpLiBXYXMgbnVsbCAob2YgdHlwZSBvYmplY3QpLgorUEFTUyBnRm9jdXNl ZERvY3VtZW50LmFjdGl2ZUVsZW1lbnQuZ2V0QXR0cmlidXRlKCJpZCIpIGlzICJzIgorUEFTUyBn Rm9jdXNlZERvY3VtZW50LmFjdGl2ZUVsZW1lbnQuZ2V0QXR0cmlidXRlKCJpZCIpIGlzICJkIgor UEFTUyBnRm9jdXNlZERvY3VtZW50LmFjdGl2ZUVsZW1lbnQuZ2V0QXR0cmlidXRlKCJpZCIpIGlz ICJzIgorRkFJTCBnRm9jdXNlZERvY3VtZW50LmFjdGl2ZUVsZW1lbnQuZ2V0QXR0cmlidXRlKCJp ZCIpIHNob3VsZCBiZSBwIChvZiB0eXBlIHN0cmluZykuIFdhcyBudWxsIChvZiB0eXBlIG9iamVj dCkuCitQQVNTIGdGb2N1c2VkRG9jdW1lbnQuYWN0aXZlRWxlbWVudC5nZXRBdHRyaWJ1dGUoImlk IikgaXMgIlMyIgorUEFTUyBnRm9jdXNlZERvY3VtZW50LmFjdGl2ZUVsZW1lbnQuZ2V0QXR0cmli dXRlKCJpZCIpIGlzICJTMTIiCitQQVNTIGdGb2N1c2VkRG9jdW1lbnQuYWN0aXZlRWxlbWVudC5n ZXRBdHRyaWJ1dGUoImlkIikgaXMgIkQxMiIKK1BBU1MgZ0ZvY3VzZWREb2N1bWVudC5hY3RpdmVF bGVtZW50LmdldEF0dHJpYnV0ZSgiaWQiKSBpcyAiUzExIgorUEFTUyBnRm9jdXNlZERvY3VtZW50 LmFjdGl2ZUVsZW1lbnQuZ2V0QXR0cmlidXRlKCJpZCIpIGlzICJEMTEiCisKSW5kZXg6IExheW91 dFRlc3RzL2Zhc3Qvc3BhdGlhbC1uYXZpZ2F0aW9uL3NuYXYtY3Vyc29yLXBvaW50ZXIuaHRtbAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L3NwYXRpYWwtbmF2aWdhdGlvbi9zbmF2LWN1 cnNvci1wb2ludGVyLmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L3NwYXRp YWwtbmF2aWdhdGlvbi9zbmF2LWN1cnNvci1wb2ludGVyLmh0bWwJKHJldmlzaW9uIDApCkBAIC0w LDAgKzEsMTA0IEBACis8IS0tCisgICAgVGhpcyB0ZXN0IGVuc3VyZXMgdGhhdCB0aGUgaHRtbCBl bGVtZW50IGhhdmluZyBjc3Mgc3R5bGUgY3Vyc29yIHBvaW50ZXIgc2hvdWxkIGJlIGNvbnNpZGVy ZWQgYXMgY2FuZGlkYXRlIGZvciBTcGF0aWFsIE5hdmlnYXRpb24gYWxnb3JpdGhtLgorCisgICAg KiBQcmUtY29uZGl0aW9uczoKKyAgICAxKSBUZXN0UnVubmVyIHN1cHBvcnQgZm9yIFNOYXYgZW5h YmxlL2Rpc2FibGUuCisKKyAgICAqIE5hdmlnYXRpb24gc3RlcHM6CisgICAgMSkgTG9hZHMgdGhp cyBwYWdlLCBmb2N1cyBnb2VzIHRvICJzdGFydCIgYXV0b21hdGljYWxseS4KKyAgICAyKSBGb2N1 cyBtb3ZlcyBhd2F5IGluIDQgZGlmZmVyZW50IGRpcmVjdGlvbnMgdG8gbmVpZ2hib3Igbm9kZXMg YW5kIGFzIHBlciByZXN1bHRNYXAgdmFsdWVzLgorLS0+CisKKzxodG1sPgorICA8aGVhZD4KKyAg ICA8c2NyaXB0IHNyYz0iLi4vLi4vcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48L3NjcmlwdD4K KyAgICA8c2NyaXB0IHNyYz0icmVzb3VyY2VzL3NwYXRpYWwtbmF2aWdhdGlvbi11dGlscy5qcyI+ PC9zY3JpcHQ+CisgICAgPHNjcmlwdCB0eXBlPSJhcHBsaWNhdGlvbi9qYXZhc2NyaXB0Ij4KKwor CisgICAgdmFyIHJlc3VsdE1hcCA9IFsKKyAgICAgICAgWyJEb3duIiwgIlMxIl0sCisgICAgICAg IFsiRG93biIsICJEMiJdLAorICAgICAgICBbIkRvd24iLCAiUzIiXSwKKyAgICAgICAgWyJEb3du IiwgInAiXSwKKyAgICAgICAgWyJEb3duIiwgInMiXSwKKyAgICAgICAgWyJEb3duIiwgImQiXSwK KyAgICAgICAgWyJVcCIsICJzIl0sCisgICAgICAgIFsiVXAiLCAicCJdLAorICAgICAgICBbIlVw IiwgIlMyIl0sCisgICAgICAgIFsiUmlnaHQiLCAiUzEyIl0sCisgICAgICAgIFsiVXAiLCAiRDEy Il0sCisgICAgICAgIFsiVXAiLCAiUzExIl0sCisgICAgICAgIFsiVXAiLCAiRDExIl0sCisgICAg ICAgIFsiRE9ORSIsICJET05FIl0KKyAgICBdOworCisgICAgaWYgKHdpbmRvdy50ZXN0UnVubmVy KSB7CisgICAgICB0ZXN0UnVubmVyLmR1bXBBc1RleHQoKTsKKyAgICAgIHRlc3RSdW5uZXIuc2V0 U3BhdGlhbE5hdmlnYXRpb25FbmFibGVkKHRydWUpOworICAgICAgdGVzdFJ1bm5lci5vdmVycmlk ZVByZWZlcmVuY2UoIldlYktpdFRhYlRvTGlua3NQcmVmZXJlbmNlS2V5IiwgMSk7CisgICAgICB0 ZXN0UnVubmVyLndhaXRVbnRpbERvbmUoKTsKKyAgICB9CisKKyAgICBmdW5jdGlvbiBydW5UZXN0 KCkKKyAgICB7CisgICAgICAvLyBzdGFydGluZyB0aGUgdGVzdCBpdHNlbGY6IGdldCB0byBhIGtu b3duIHBsYWNlLgorICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInN0YXJ0IikuZm9jdXMo KTsKKyAgICAgIGluaXRUZXN0KHJlc3VsdE1hcCwgdGVzdENvbXBsZXRlZCk7CisgICAgfQorCisg ICAgZnVuY3Rpb24gdGVzdENvbXBsZXRlZCgpCisgICAgeworICAgICAgaWYgKHdpbmRvdy50ZXN0 UnVubmVyKQorICAgICAgICB0ZXN0UnVubmVyLm5vdGlmeURvbmUoKTsKKyAgICB9CisKKyAgICB3 aW5kb3cub25sb2FkID0gcnVuVGVzdDsKKyAgICA8L3NjcmlwdD4KKyAgICA8c2NyaXB0IHNyYz0i Li4vcmVzb3VyY2VzL2pzLXRlc3QtcG9zdC5qcyI+PC9zY3JpcHQ+CisgICAgPHN0eWxlPgorICAg ICAgICBzcGFuLnNwYW5TdHlsZQorICAgICAgICB7CisgICAgICAgICAgICBjdXJzb3I6IHBvaW50 ZXI7CisgICAgICAgICAgICBkaXNwbGF5OiBibG9jazsKKyAgICAgICAgICAgIGhlaWdodDogNTBw eDsKKyAgICAgICAgICAgIHdpZHRoOiA1MHB4OworICAgICAgICAgICAgYm9yZGVyLXN0eWxlOiBz b2xpZDsKKyAgICAgICAgICAgIGJvcmRlci13aWR0aDogMXB4OworICAgICAgICAgICAgdGV4dC1h bGlnbjogY2VudGVyOworICAgICAgICB9CisKKyAgICAgICAgZGl2LmRpdlN0eWxlCisgICAgICAg IHsKKyAgICAgICAgICAgIGN1cnNvcjogcG9pbnRlcjsKKyAgICAgICAgICAgIGRpc3BsYXk6IGJs b2NrOworICAgICAgICAgICAgaGVpZ2h0OiA1MHB4OworICAgICAgICAgICAgd2lkdGg6IDUwcHg7 CisgICAgICAgICAgICBib3JkZXItc3R5bGU6IHNvbGlkOworICAgICAgICAgICAgYm9yZGVyLXdp ZHRoOiAxcHg7CisgICAgICAgICAgICB0ZXh0LWFsaWduOiBjZW50ZXI7CisgICAgICAgIH0KKyAg ICA8L3N0eWxlPgorICA8L2hlYWQ+Cis8Ym9keSBpZD0ic29tZS1jb250ZW50IiB4bWxucz0iaHR0 cDovL3d3dy53My5vcmcvMTk5OS94aHRtbCIgc3R5bGU9InBhZGRpbmc6MjBweCI+CisgICAgPGRp diBpZD0ic3RhcnQiIGNsYXNzPSJkaXZTdHlsZSIgc3R5bGU9InBvc2l0aW9uOmFic29sdXRlO3Rv cDowcHg7bGVmdDo1MHB4IiA+RDE8L2Rpdj4KKworICAgIDxzcGFuIGlkPSJTMSIgY2xhc3M9InNw YW5TdHlsZSIgc3R5bGU9InBvc2l0aW9uOmFic29sdXRlO3RvcDo2MHB4O2xlZnQ6NTBweCIgPlMx PC9zcGFuPgorICAgIDxkaXYgaWQ9IkQyIiBjbGFzcz0iZGl2U3R5bGUiIHN0eWxlPSJwb3NpdGlv bjphYnNvbHV0ZTt0b3A6MTIwcHg7bGVmdDo1MHB4IiA+RDI8L2Rpdj4KKyAgICA8c3BhbiBpZD0i UzIiIGNsYXNzPSJzcGFuU3R5bGUiIHN0eWxlPSJwb3NpdGlvbjphYnNvbHV0ZTt0b3A6MTgwcHg7 bGVmdDo1MHB4O3otaW5kZXg6MTAwIiA+UzI8L3NwYW4+ICAKKyAKKyAgICA8ZGl2IGlkPSJEMTEi IGNsYXNzPSJkaXZTdHlsZSIgc3R5bGU9InBvc2l0aW9uOmFic29sdXRlO3RvcDowcHg7bGVmdDoy MDVweCIgPkQxMTwvZGl2PgorICAgIDxzcGFuIGlkPSJTMTEiIGNsYXNzPSJzcGFuU3R5bGUiIHN0 eWxlPSJwb3NpdGlvbjphYnNvbHV0ZTt0b3A6NjBweDtsZWZ0OjIwNXB4IiA+UzExPC9zcGFuPgor ICAgIDxkaXYgaWQ9IkQxMiIgY2xhc3M9ImRpdlN0eWxlIiBzdHlsZT0icG9zaXRpb246YWJzb2x1 dGU7dG9wOjEyMHB4O2xlZnQ6MjA1cHgiID5EMTI8L2Rpdj4KKyAgICA8c3BhbiBpZD0iUzEyIiBj bGFzcz0ic3BhblN0eWxlIiBzdHlsZT0icG9zaXRpb246YWJzb2x1dGU7dG9wOjE4MHB4O2xlZnQ6 MjA1cHg7ei1pbmRleDoxMDEiID5TMTI8L3NwYW4+IAorICAgIDxicj48YnI+PGJyPjxicj48YnI+ PGJyPjxicj48YnI+PGJyPjxicj48YnI+CisgICAgPHAgaXM9InAiIHN0eWxlPSJjdXJzb3I6cG9p bnRlcjsiPiBIaSwgSSBhbSBwYXJhZ3JhcGggPC9wPgorICAgIDxicj4KKyAgICA8c3BhbiBpZD0i cyIgc3R5bGU9ImN1cnNvcjpwb2ludGVyOyI+IEhpLCBJIGFtIHNwYW4gPC9zcGFuPgorICAgIDxi cj48YnI+CisgICAgPGRpdiBpZD0iZCIgc3R5bGU9ImN1cnNvcjpwb2ludGVyOyI+IEkgYW0gPGJy PmJyZWFrYWJsZSA8YnI+ZGl2IGVsZW1lbnQgPC9kaXY+CisgICAgPGJyPjxicj4KKworICAgIDxk aXYgaWQ9ImNvbnNvbGUiPjwvZGl2PgorPC9ib2R5PgorPC9odG1sPgpJbmRleDogTGF5b3V0VGVz dHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNp b24gMTU2ODMyKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0x LDMgKzEsMTUgQEAKKzIwMTMtMTAtMDMgIEFiaGlqZWV0IEthbmRhbGthciAgPGFiaGlqZWV0LmtA c2Ftc3VuZy5jb20+CisKKyAgICAgICAgU3BhdGlhbCBOYXZpZ2F0aW9uIDogVXNlciBzaG91bGQg YmUgYWJsZSB0byBuYXZpZ2F0ZSBodG1sIGVsZW1ldHMgaGF2aW5nIGVsZW1lbnQuc3R5bGUuY3Vy c29yPSJwb2ludGVyIgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTIxNjI2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgQWRkZWQgdGVzdCB0byBjaGVjayBiZWhhdmlvciBvZiBTcGF0aWFsIE5hdmlnYXRpb24g Zm9yIGVsZW1lbnRzIGhhdmluZyBDU1Mgc3R5bGUgcG9pbnRlciBjdXNyc29yLgorCisgICAgICAg ICogZmFzdC9zcGF0aWFsLW5hdmlnYXRpb24vc25hdi1jdXJzb3ItcG9pbnRlci1leHBlY3RlZC50 eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3Qvc3BhdGlhbC1uYXZpZ2F0aW9uL3NuYXYtY3Vyc29y LXBvaW50ZXIuaHRtbDogQWRkZWQuCisKIDIwMTMtMTAtMDMgIFJ5b3N1a2UgTml3YSAgPHJuaXdh QHdlYmtpdC5vcmc+CiAKICAgICAgICAgQWRkIGJhY2sgLmh0YWNjZXNzIGZpbGVzIGVycm9uZW91 c2x5IHJlbW92ZWQgaW4gcjE1NjgyNy4K