121625 2013-09-19 11:43:29 -0700 JSC: X86 disassembler shows 16, 32 and 64 bit displacements as unsigned 2013-09-19 13:07:22 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 msaboff msaboff oldest_to_newest 931032 0 msaboff 2013-09-19 11:43:29 -0700 8 bit offsets are shown as signed. The other sizes should be output as signed as well. 931052 1 212091 msaboff 2013-09-19 13:06:41 -0700 Created attachment 212091 Patch for landing This patch has already been rubber stamped by Phil Pizlo. 931053 2 msaboff 2013-09-19 13:07:22 -0700 Fix landed in change set r156111 < https://trac.webkit.org/r156111> 212091 2013-09-19 13:06:41 -0700 2013-09-19 13:06:41 -0700 Patch for landing 121625.patch text/plain 2192 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTU2MTA5KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDEzLTA5LTE5ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIEpTQzogWDg2IGRpc2Fzc2VtYmxlciBzaG93cyAxNiwgMzIgYW5kIDY0IGJpdCBkaXNwbGFj ZW1lbnRzIGFzIHVuc2lnbmVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xMjE2MjUKKworICAgICAgICBSdWJiZXItc3RhbXBlZCBieSBGaWxpcCBQaXps by4KKworICAgICAgICBDaGVuZ2VkIDE2LCAzMiBhbmQgNjQgYml0IG9mZnNldHMgdG8gYmUgc2ln bmVkLiAgS2VwdCB0aGUgb3JpZ2luYWwgdGFiIGluZGVudGVkCisgICAgICAgIHNwYWNpbmcgdG8g bWF0Y2ggdGhlIHJlc3Qgb2YgdGhlIGZpbGUuCisKKyAgICAgICAgKiBkaXNhc3NlbWJsZXIvdWRp czg2L3VkaXM4Nl9zeW4tYXR0LmM6CisgICAgICAgIChnZW5fb3BlcmFuZCk6CisKIDIwMTMtMDkt MTkgIERhbmllbCBCYXRlcyAgPGRhYmF0ZXNAYXBwbGUuY29tPgogCiAgICAgICAgIFJlbW92ZSBu YW1lcyBvZiB1bnVzZWQgYXJndW1lbnRzIGZyb20gdGhlIHg4Ni94ODYtNjQgZnVuY3Rpb24gcHJv dG90eXBlCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGlzYXNzZW1ibGVyL3VkaXM4Ni91 ZGlzODZfc3luLWF0dC5jCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kaXNh c3NlbWJsZXIvdWRpczg2L3VkaXM4Nl9zeW4tYXR0LmMJKHJldmlzaW9uIDE1NjEwOSkKKysrIFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9kaXNhc3NlbWJsZXIvdWRpczg2L3VkaXM4Nl9zeW4tYXR0LmMJ KHdvcmtpbmcgY29weSkKQEAgLTY2LDE0ICs2NiwyNSBAQCBnZW5fb3BlcmFuZChzdHJ1Y3QgdWQq IHUsIHN0cnVjdCB1ZF9vcGVyCiAJCWlmIChvcC0+b2Zmc2V0ID09IDgpIHsKIAkJCWlmIChvcC0+ bHZhbC5zYnl0ZSA8IDApCiAJCQkJbWthc20odSwgIi0weCV4IiwgKC1vcC0+bHZhbC5zYnl0ZSkg JiAweGZmKTsKLQkJCWVsc2UJbWthc20odSwgIjB4JXgiLCBvcC0+bHZhbC5zYnl0ZSk7CisJCQll bHNlCisJCQkJbWthc20odSwgIjB4JXgiLCBvcC0+bHZhbC5zYnl0ZSk7CiAJCX0gCi0JCWVsc2Ug aWYgKG9wLT5vZmZzZXQgPT0gMTYpIAotCQkJbWthc20odSwgIjB4JXgiLCBvcC0+bHZhbC51d29y ZCk7Ci0JCWVsc2UgaWYgKG9wLT5vZmZzZXQgPT0gMzIpIAotICAgICAgICAgICAgICAgICAgICAg ICAgbWthc20odSwgIjB4JWx4IiwgKHVuc2lnbmVkIGxvbmcpb3AtPmx2YWwudWR3b3JkKTsKLQkJ ZWxzZSBpZiAob3AtPm9mZnNldCA9PSA2NCkgCi0JCQlta2FzbSh1LCAiMHgiIEZNVDY0ICJ4Iiwg b3AtPmx2YWwudXF3b3JkKTsKKwkJZWxzZSBpZiAob3AtPm9mZnNldCA9PSAxNikgeworCQkJaWYg KG9wLT5sdmFsLnN3b3JkIDwgMCkKKwkJCQlta2FzbSh1LCAiLTB4JXgiLCAoLW9wLT5sdmFsLnN3 b3JkKSAmIDB4ZmZmZik7CisJCQllbHNlCisJCQkJbWthc20odSwgIjB4JXgiLCBvcC0+bHZhbC5z d29yZCk7CisJCX0gZWxzZSBpZiAob3AtPm9mZnNldCA9PSAzMikgeworCQkJaWYgKG9wLT5sdmFs LnNkd29yZCA8IDApCisJCQkJbWthc20odSwgIi0weCV4IiwgKC1vcC0+bHZhbC5zZHdvcmQpICYg MHhmZmZmZmZmZik7CisJCQllbHNlCisJCQkJbWthc20odSwgIjB4JXgiLCBvcC0+bHZhbC5zZHdv cmQpOworCQl9IGVsc2UgaWYgKG9wLT5vZmZzZXQgPT0gNjQpIHsKKwkJCWlmIChvcC0+bHZhbC5z ZHdvcmQgPCAwKQorCQkJCW1rYXNtKHUsICItMHgiIEZNVDY0ICJ4IiwgLW9wLT5sdmFsLnNxd29y ZCk7CisJCQllbHNlCisJCQkJbWthc20odSwgIjB4IiBGTVQ2NCAieCIsIG9wLT5sdmFsLnNxd29y ZCk7CisJCX0KIAogCQlpZiAob3AtPmJhc2UpCiAJCQlta2FzbSh1LCAiKCUlJXMiLCB1ZF9yZWdf dGFiW29wLT5iYXNlIC0gVURfUl9BTF0pOwo=