121620 2013-09-19 11:06:12 -0700 Add a style guideline regarding spacing in range-based for loops 2017-03-25 19:01:24 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mitz mitz andersca commit-queue darin dpranke glenn oldest_to_newest 931016 0 mitz 2013-09-19 11:06:12 -0700 Add a style guideline regarding spacing in range-based for loops 931017 1 212082 mitz 2013-09-19 11:09:25 -0700 Created attachment 212082 Add a style guideline and a corresponding check in the style checker 1291287 2 mitz 2017-03-25 19:01:24 -0700 Committed <https://trac.webkit.org/r156105>. 212082 2013-09-19 11:09:25 -0700 2013-09-19 11:10:41 -0700 Add a style guideline and a corresponding check in the style checker bug-121620-20130919110925.patch text/plain 5189 mitz SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE1NjEwNCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE3IEBACisyMDEzLTA5LTE5ICBEYW4gQmVybnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CisK KyAgICAgICAgQWRkIGEgc3R5bGUgZ3VpZGVsaW5lIHJlZ2FyZGluZyBzcGFjaW5nIGluIHJhbmdl LWJhc2VkIGZvciBsb29wcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTIxNjIwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5weToKKyAgICAg ICAgKGNoZWNrX3NwYWNpbmcpOiBBZGRlZCBjaGVja2luZyB0aGF0IHRoZXJlIGFyZSBzcGFjZXMg YXJvdW5kIHRoZSBjb2xvbiBpbiBhIHJhbmdlLWJhc2VkIGZvcgorICAgICAgICBsb29wLgorICAg ICAgICAoQ3BwQ2hlY2tlcik6IEFkZGVkIHdoaXRlc3BhY2UvY29sb24gdG8gdGhlIGNhdGVnb3Jp ZXMgc2V0LgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3Vu aXR0ZXN0LnB5OgorICAgICAgICAoV2ViS2l0U3R5bGVUZXN0LnRlc3Rfc3BhY2luZyk6IEFkZGVk IHR3byB0ZXN0cyBmb3IgdGhlIG5ldyBjaGVjay4KKwogMjAxMy0wOS0xOCAgU2FtIFdlaW5pZyAg PHNhbUB3ZWJraXQub3JnPgogCiAgICAgICAgIFJlcGxhY2UgdXNlIG9mIE93bkFycmF5UHRyPEZv bz4gd2l0aCBzdGQ6OnVuaXF1ZV9wdHI8Rm9vW10+IGluIFRvb2xzCkluZGV4OiBUb29scy9TY3Jp cHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5weQo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9T Y3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5weQkocmV2aXNpb24gMTU1NjIxKQor KysgVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHkJKHdvcmtpbmcg Y29weSkKQEAgLTE5MDcsNiArMTkwNyw4IEBAIGRlZiBjaGVja19zcGFjaW5nKGZpbGVfZXh0ZW5z aW9uLCBjbGVhbl8KICAgICAgICAgc3RhdGVtZW50ID0gbWF0Y2hlZC5ncm91cCgnc3RhdGVtZW50 JykKICAgICAgICAgY29uZGl0aW9uLCByZXN0ID0gdXBfdG9fdW5tYXRjaGVkX2Nsb3NpbmdfcGFy ZW4obWF0Y2hlZC5ncm91cCgncmVtYWluZGVyJykpCiAgICAgICAgIGlmIGNvbmRpdGlvbiBpcyBu b3QgTm9uZToKKyAgICAgICAgICAgIGlmIHN0YXRlbWVudCA9PSAnZm9yJyBhbmQgc2VhcmNoKHIn KD86W14gOl06W146XXxbXjpdOlteIDpdKScsIGNvbmRpdGlvbik6CisgICAgICAgICAgICAgICAg ZXJyb3IobGluZV9udW1iZXIsICd3aGl0ZXNwYWNlL2NvbG9uJywgNCwgJ01pc3Npbmcgc3BhY2Ug YXJvdW5kIDogaW4gcmFuZ2UtYmFzZWQgZm9yIHN0YXRlbWVudCcpCiAgICAgICAgICAgICBjb25k aXRpb25fbWF0Y2ggPSBzZWFyY2gocicoP1A8bGVhZGluZz5bIF0qKSg/UDxzZXBhcmF0b3I+Liku KlteIF0rKD9QPHRyYWlsaW5nPlsgXSopJywgY29uZGl0aW9uKQogICAgICAgICAgICAgaWYgY29u ZGl0aW9uX21hdGNoOgogICAgICAgICAgICAgICAgIG5fbGVhZGluZyA9IGxlbihjb25kaXRpb25f bWF0Y2guZ3JvdXAoJ2xlYWRpbmcnKSkKQEAgLTM2OTksNiArMzcwMSw3IEBAIGNsYXNzIENwcENo ZWNrZXIob2JqZWN0KToKICAgICAgICAgJ3J1bnRpbWUvdmlydHVhbCcsCiAgICAgICAgICd3aGl0 ZXNwYWNlL2JsYW5rX2xpbmUnLAogICAgICAgICAnd2hpdGVzcGFjZS9icmFjZXMnLAorICAgICAg ICAnd2hpdGVzcGFjZS9jb2xvbicsCiAgICAgICAgICd3aGl0ZXNwYWNlL2NvbW1hJywKICAgICAg ICAgJ3doaXRlc3BhY2UvY29tbWVudHMnLAogICAgICAgICAnd2hpdGVzcGFjZS9kZWNsYXJhdGlv bicsCkluZGV4OiBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcF91bml0 dGVzdC5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNr ZXJzL2NwcF91bml0dGVzdC5weQkocmV2aXNpb24gMTU1NjIxKQorKysgVG9vbHMvU2NyaXB0cy93 ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHBfdW5pdHRlc3QucHkJKHdvcmtpbmcgY29weSkKQEAg LTM4NDksNyArMzg0OSwxOCBAQCBjbGFzcyBXZWJLaXRTdHlsZVRlc3QoQ3BwU3R5bGVUZXN0QmFz ZSk6CiAgICAgICAgICMgICAgICdyZXR1cm4gY29uZGl0aW9uID8gMTowOycsCiAgICAgICAgICMg ICAgICcnKQogCi0gICAgICAgICMgMy4gUGxhY2Ugc3BhY2VzIGJldHdlZW4gY29udHJvbCBzdGF0 ZW1lbnRzIGFuZCB0aGVpciBwYXJlbnRoZXNlcy4KKyAgICAgICAgIyAzLiBQbGFjZSBzcGFjZXMg YXJvdW5kIHRoZSBjb2xvbiBpbiBhIHJhbmdlLWJhc2VkIGZvciBsb29wLgorICAgICAgICBzZWxm LmFzc2VydF9tdWx0aV9saW5lX2xpbnQoCisgICAgICAgICAgICAnICAgIGZvciAoY29uc3QgV1RG OjpWZWN0b3ImIHZlY3RvciA6IHZlY3RvcnMpXG4nCisgICAgICAgICAgICAnICAgICAgICBwcm9j ZXNzKHZlY3Rvcik7XG4nLAorICAgICAgICAgICAgJycpCisKKyAgICAgICAgc2VsZi5hc3NlcnRf bXVsdGlfbGluZV9saW50KAorICAgICAgICAgICAgJyAgICBmb3IgKGNvbnN0IFZlY3RvciYgdmVj dG9yOiB2ZWN0b3JzKVxuJworICAgICAgICAgICAgJyAgICAgICAgcHJvY2Vzcyh2ZWN0b3IpO1xu JywKKyAgICAgICAgICAgICdNaXNzaW5nIHNwYWNlIGFyb3VuZCA6IGluIHJhbmdlLWJhc2VkIGZv ciBzdGF0ZW1lbnQgIFt3aGl0ZXNwYWNlL2NvbG9uXSBbNF0nKQorCisgICAgICAgICMgNS4gUGxh Y2Ugc3BhY2VzIGJldHdlZW4gY29udHJvbCBzdGF0ZW1lbnRzIGFuZCB0aGVpciBwYXJlbnRoZXNl cy4KICAgICAgICAgc2VsZi5hc3NlcnRfbXVsdGlfbGluZV9saW50KAogICAgICAgICAgICAgJyAg ICBpZiAoY29uZGl0aW9uKVxuJwogICAgICAgICAgICAgJyAgICAgICAgZG9JdCgpO1xuJywKQEAg LTM4NTksNyArMzg3MCw3IEBAIGNsYXNzIFdlYktpdFN0eWxlVGVzdChDcHBTdHlsZVRlc3RCYXNl KToKICAgICAgICAgICAgICcgICAgICAgIGRvSXQoKTtcbicsCiAgICAgICAgICAgICAnTWlzc2lu ZyBzcGFjZSBiZWZvcmUgKCBpbiBpZiggIFt3aGl0ZXNwYWNlL3BhcmVuc10gWzVdJykKIAotICAg ICAgICAjIDQuIERvIG5vdCBwbGFjZSBzcGFjZXMgYmV0d2VlbiBhIGZ1bmN0aW9uIGFuZCBpdHMg cGFyZW50aGVzZXMsCisgICAgICAgICMgNi4gRG8gbm90IHBsYWNlIHNwYWNlcyBiZXR3ZWVuIGEg ZnVuY3Rpb24gYW5kIGl0cyBwYXJlbnRoZXNlcywKICAgICAgICAgIyAgICBvciBiZXR3ZWVuIGEg cGFyZW50aGVzaXMgYW5kIGl0cyBjb250ZW50LgogICAgICAgICBzZWxmLmFzc2VydF9tdWx0aV9s aW5lX2xpbnQoCiAgICAgICAgICAgICAnZihhLCBiKTsnLApJbmRleDogV2Vic2l0ZXMvd2Via2l0 Lm9yZy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2Vic2l0ZXMvd2Via2l0Lm9yZy9DaGFuZ2VM b2cJKHJldmlzaW9uIDE1NjEwNCkKKysrIFdlYnNpdGVzL3dlYmtpdC5vcmcvQ2hhbmdlTG9nCSh3 b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTMtMDktMTkgIERhbiBCZXJuc3RlaW4g IDxtaXR6QGFwcGxlLmNvbT4KKworICAgICAgICBBZGQgYSBzdHlsZSBndWlkZWxpbmUgcmVnYXJk aW5nIHNwYWNpbmcgaW4gcmFuZ2UtYmFzZWQgZm9yIGxvb3BzCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjE2MjAKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGNvZGluZy9jb2Rpbmctc3R5bGUuaHRtbDog QWRkZWQgdGhlIGd1aWRlbGluZSB0aGF0IHNwYWNlcyBzaG91bGQgYmUgcGxhY2VkCisgICAgICAg IGFyb3VuZCB0aGUgY29sb24gaW4gYSByYW5nZS1iYXNlZCBmb3IgbG9vcC4KKwogMjAxMy0wOS0x MCAgQmV0aCBEYWtpbiAgPGJkYWtpbkBhcHBsZS5jb20+CiAKICAgICAgICAgQWRkaW5nIGFub3Ro ZXIgc2NyZWVuc2hvdCBmb3IgYSBwb3RlbnRpYWwgYmxvZyBwb3N0LgpJbmRleDogV2Vic2l0ZXMv d2Via2l0Lm9yZy9jb2RpbmcvY29kaW5nLXN0eWxlLmh0bWwKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2Vic2l0 ZXMvd2Via2l0Lm9yZy9jb2RpbmcvY29kaW5nLXN0eWxlLmh0bWwJKHJldmlzaW9uIDE1NTYyMSkK KysrIFdlYnNpdGVzL3dlYmtpdC5vcmcvY29kaW5nL2NvZGluZy1zdHlsZS5odG1sCSh3b3JraW5n IGNvcHkpCkBAIC0xODgsNiArMTg4LDIyIEBAIHJldHVybiBjb25kaXRpb24gPyAxOjA7CiA8L3By ZT4KIDwvbGk+CiAKKzxsaSBpZD0ic3BhY2luZy1mb3ItY29sb24iPlBsYWNlIHNwYWNlcyBhcm91 bmQgdGhlIGNvbG9uIGluIGEgcmFuZ2UtYmFzZWQgZm9yIGxvb3AuCis8aDQgY2xhc3M9InJpZ2h0 Ij5SaWdodDo8L2g0PgorPHByZSBjbGFzcz0iY29kZSI+CitWZWN0b3ImbHQ7UGx1Z2luTW9kdWxl SW5mbz4gcGx1Z2luczsKK2ZvciAoY29uc3QgYXV0byZhbXA7IHBsdWdpbiA6IHBsdWdpbnMpCisg ICAgcmVnaXN0ZXJQbHVnaW4ocGx1Z2luKTsKKzwvcHJlPgorCis8aDQgY2xhc3M9Indyb25nIj5X cm9uZzo8L2g0PgorPHByZSBjbGFzcz0iY29kZSI+CitWZWN0b3ImbHQ7UGx1Z2luTW9kdWxlSW5m bz4gcGx1Z2luczsKK2ZvciAoY29uc3QgYXV0byZhbXA7IHBsdWdpbjogcGx1Z2lucykKKyAgICBy ZWdpc3RlclBsdWdpbihwbHVnaW4pOworPC9wcmU+Cis8L2xpPgorCiA8bGkgaWQ9InNwYWNpbmct Y29tbWEtc2VtaWNvbG9uIj5EbyBub3QgcGxhY2Ugc3BhY2VzIGJlZm9yZSBjb21tYSBhbmQgc2Vt aWNvbG9uLgogPGg0IGNsYXNzPSJyaWdodCI+UmlnaHQ6PC9oND4KIDxwcmUgY2xhc3M9ImNvZGUi Pgo=