12161 2007-01-08 04:17:57 -0800 REGRESSION: Crash when control-clicking on an image for contextual menu 2007-01-08 14:41:39 -0800 1 1 1 Unclassified WebKit New Bugs 420+ Mac OS X 10.4 RESOLVED FIXED http://www.gathering.nl/discographie.php NeedsReduction, Regression P1 Major --- 1 daniele.metilli bdakin bdakin oldest_to_newest 36359 0 daniele.metilli 2007-01-08 04:17:57 -0800 Follow these steps: 1 - Go to http://www.gathering.nl/discographie.php. 2 - Control-click (or right-click) on one of the album covers. 3 - WebKit crashes. This happens in the latest nightly (r18654). The shipping version of Safari doesn't crash. 36361 1 ddkilzer 2007-01-08 06:50:33 -0800 Confirmed using locally-built debug build of WebKit r18658 with Safari 2.0.4 (419.3) on Mac OS X 10.4.8 (8L127). Stack trace: Exception: EXC_BAD_ACCESS (0x0001) Codes: KERN_PROTECTION_FAILURE (0x0002) at 0x00000018 Thread 0 Crashed: 0 com.apple.WebCore 0x017f13f8 WebCore::RetainPtr<NSMutableArray>::get() const + 20 (RetainPtr.h:74) 1 com.apple.WebCore 0x014f6e10 WebCore::ContextMenu::platformDescription() const + 40 (ContextMenuMac.mm:135) 2 com.apple.WebKit 0x003517e8 -[WebHTMLView menuForEvent:] + 372 (WebHTMLView.m:2555) 3 com.apple.AppKit 0x93767830 -[NSWindow sendEvent:] + 4520 4 com.apple.Safari 0x00021734 0x1000 + 132916 5 com.apple.AppKit 0x937108d4 -[NSApplication sendEvent:] + 4172 6 com.apple.Safari 0x00021238 0x1000 + 131640 7 com.apple.AppKit 0x93707d10 -[NSApplication run] + 508 8 com.apple.AppKit 0x937f887c NSApplicationMain + 452 9 com.apple.Safari 0x0005c77c 0x1000 + 374652 10 com.apple.Safari 0x0005c624 0x1000 + 374308 36259 2 bdakin 2007-01-08 13:01:39 -0800 Oooh, i see what's going on here. we are missing a nil check. I will have a patch soon. 36264 3 12307 bdakin 2007-01-08 13:14:51 -0800 Created attachment 12307 Nil-check and code clean-up 36269 4 12307 aroben 2007-01-08 13:34:02 -0800 Comment on attachment 12307 Nil-check and code clean-up r=me, although it would be nice if you could go ahead and change every line of ContextMenu::populate again. 36279 5 sam 2007-01-08 14:41:39 -0800 Landed in r18678. 12307 2007-01-08 13:14:51 -0800 2007-01-08 13:34:02 -0800 Nil-check and code clean-up saveDOMMenus.txt text/plain 4478 bdakin SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDE4Njc2 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMDctMDEt MDggIEJldGggRGFraW4gIDxiZGFraW5AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCBmb3IgaHR0cDovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTIxNjEgUkVHUkVTU0lPTjogCisgICAgICAgIENyYXNoIHdoZW4g Y29udHJvbC1jbGlja2luZyBvbiBhbiBpbWFnZSBmb3IgY29udGV4dHVhbCBtZW51CisKKyAgICAg ICAgKiBXZWJWaWV3L1dlYkhUTUxWaWV3Lm06CisgICAgICAgICgtW1dlYkhUTUxWaWV3IG1lbnVG b3JFdmVudDpdKTogV2UgbmVlZCB0byBuaWwtY2hlY2sgY29yZU1lbnUgc2luY2UgCisgICAgICAg IGl0IHdpbGwgYmUgbmlsIGlmIHRoZSBET00gcG9wcGVkIHVwIGEgbWVudSBpbnN0ZWFkLiBJIGNs ZWFuZWQgdXAgCisgICAgICAgIHRoZSBmdW5jdGlvbiB0byBtYWtlIGFsbCB0aGUgbmlsIGNoZWNr cyBlYXJseSByZXR1cm5zIGluc3RlYWQgb2YgCisgICAgICAgIG5lc3RpbmcgYWxsIG9mIHRoZSBj b250ZW50LiBBbHNvIG1vdmVkIHRoZSBhdXRvcmVsZWFzZSB0byBiZSB3aXRoIAorICAgICAgICB0 aGUgY3JlYXRpb24gb2YgdGhlIG1lbnUgaW5zdGVhZCBvZiBhdCB0aGUgcmV0dXJuLgorCiAyMDA3 LTAxLTA4ICBTYW0gV2VpbmlnICA8c2FtQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQg YnkgVGltIEguCkluZGV4OiBXZWJWaWV3L1dlYkhUTUxWaWV3Lm0KPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2Vi Vmlldy9XZWJIVE1MVmlldy5tCShyZXZpc2lvbiAxODY3MikKKysrIFdlYlZpZXcvV2ViSFRNTFZp ZXcubQkod29ya2luZyBjb3B5KQpAQCAtMjU0NCw0MiArMjU0NCw1MSBAQAogCiAgICAgX3ByaXZh dGUtPmhhbmRsaW5nTW91c2VEb3duRXZlbnQgPSBZRVM7CiAgICAgQk9PTCBoYW5kbGVkRXZlbnQg PSBOTzsKLSAgICBGcmFtZSogY29yZWZyYW1lID0gY29yZShbc2VsZiBfZnJhbWVdKTsKLSAgICBp ZiAoY29yZWZyYW1lKQotICAgICAgICBoYW5kbGVkRXZlbnQgPSBjb3JlZnJhbWUtPmV2ZW50SGFu ZGxlcigpLT5zZW5kQ29udGV4dE1lbnVFdmVudChldmVudCk7CisgICAgRnJhbWUqIGNvcmVGcmFt ZSA9IGNvcmUoW3NlbGYgX2ZyYW1lXSk7CisKKyAgICBpZiAoIWNvcmVGcmFtZSkgeworICAgICAg ICBfcHJpdmF0ZS0+aGFuZGxpbmdNb3VzZURvd25FdmVudCA9IE5POworICAgICAgICByZXR1cm4g bmlsOworICAgIH0KKworICAgIGhhbmRsZWRFdmVudCA9IGNvcmVGcmFtZS0+ZXZlbnRIYW5kbGVy KCktPnNlbmRDb250ZXh0TWVudUV2ZW50KGV2ZW50KTsKICAgICBfcHJpdmF0ZS0+aGFuZGxpbmdN b3VzZURvd25FdmVudCA9IE5POwotICAgIAotICAgIGlmIChoYW5kbGVkRXZlbnQgJiYgY29yZWZy YW1lKSB7Ci0gICAgICAgIGlmIChQYWdlKiBwYWdlID0gY29yZWZyYW1lLT5wYWdlKCkpIHsKLSAg ICAgICAgICAgIENvbnRleHRNZW51KiBjb3JlTWVudSA9IHBhZ2UtPmNvbnRleHRNZW51Q29udHJv bGxlcigpLT5jb250ZXh0TWVudSgpOwotICAgICAgICAgICAgTlNBcnJheSogbWVudUl0ZW1zID0g Y29yZU1lbnUtPnBsYXRmb3JtRGVzY3JpcHRpb24oKTsKLSAgICAgICAgICAgIE5TTWVudSogbWVu dSA9IG5pbDsKLSAgICAgICAgICAgIGlmIChtZW51SXRlbXMgJiYgW21lbnVJdGVtcyBjb3VudF0g PiAwKSB7Ci0gICAgICAgICAgICAgICAgbWVudSA9IFtbTlNNZW51IGFsbG9jXSBpbml0XTsKLSAg ICAgICAgICAgICAgICBbbWVudSBzZXRBdXRvZW5hYmxlc0l0ZW1zOk5PXTsKLSAgICAgICAgICAg ICAgICBmb3IgKHVuc2lnbmVkIGkgPSAwOyBpIDwgW21lbnVJdGVtcyBjb3VudF07IGkrKykKLSAg ICAgICAgICAgICAgICAgICAgW21lbnUgYWRkSXRlbTpbbWVudUl0ZW1zIG9iamVjdEF0SW5kZXg6 aV1dOwotICAgICAgICAgICAgfQogCi0gICAgICAgICAgICAvLyBBZGQgdGhlIEluc3BlY3QgRWxl bWVudCBtZW51IGl0ZW0gaWYgdGhlIHByZWZlcmVuY2UgaXMgc2V0IG9yIGlmIHRoaXMgaXMgYSBk ZWJ1ZyBidWlsZAotICAgICAgICAgICAgaWYgKFtXZWJWaWV3IF9kZXZlbG9wZXJFeHRyYXNFbmFi bGVkXSkgewotICAgICAgICAgICAgICAgIGlmICghbWVudSkKLSAgICAgICAgICAgICAgICAgICAg bWVudSA9IFtbTlNNZW51IGFsbG9jXSBpbml0XTsKLSAgICAgICAgICAgICAgICBlbHNlIGlmIChb bWVudSBudW1iZXJPZkl0ZW1zXSkKLSAgICAgICAgICAgICAgICAgICAgW21lbnUgYWRkSXRlbTpb TlNNZW51SXRlbSBzZXBhcmF0b3JJdGVtXV07Ci0gICAgICAgICAgICAgICAgTlNNZW51SXRlbSAq bWVudUl0ZW0gPSBbW1tOU01lbnVJdGVtIGFsbG9jXSBpbml0XSBhdXRvcmVsZWFzZV07Ci0gICAg ICAgICAgICAgICAgW21lbnVJdGVtIHNldEFjdGlvbjpAc2VsZWN0b3IoX2luc3BlY3RFbGVtZW50 OildOwotICAgICAgICAgICAgICAgIFttZW51SXRlbSBzZXRUaXRsZTpVSV9TVFJJTkcoIkluc3Bl Y3QgRWxlbWVudCIsICJJbnNwZWN0IEVsZW1lbnQgY29udGV4dCBtZW51IGl0ZW0iKV07Ci0gICAg ICAgICAgICAgICAgW21lbnVJdGVtIHNldFJlcHJlc2VudGVkT2JqZWN0OltbW1dlYkVsZW1lbnRE aWN0aW9uYXJ5IGFsbG9jXSBpbml0V2l0aEhpdFRlc3RSZXN1bHQ6Ci0gICAgICAgICAgICAgICAg ICAgIGNvcmVNZW51LT5oaXRUZXN0UmVzdWx0KCldIGF1dG9yZWxlYXNlXV07Ci0gICAgICAgICAg ICAgICAgW21lbnUgYWRkSXRlbTptZW51SXRlbV07Ci0gICAgICAgICAgICB9CisgICAgaWYgKCFo YW5kbGVkRXZlbnQpCisgICAgICAgIHJldHVybiBuaWw7CiAKLSAgICAgICAgICAgIHJldHVybiBb bWVudSBhdXRvcmVsZWFzZV07Ci0gICAgICAgIH0KKyAgICBQYWdlKiBwYWdlID0gY29yZUZyYW1l LT5wYWdlKCk7CisgICAgaWYgKCFwYWdlKQorICAgICAgICByZXR1cm4gbmlsOworCisgICAgQ29u dGV4dE1lbnUqIGNvcmVNZW51ID0gcGFnZS0+Y29udGV4dE1lbnVDb250cm9sbGVyKCktPmNvbnRl eHRNZW51KCk7CisgICAgaWYgKCFjb3JlTWVudSkKKyAgICAgICAgcmV0dXJuIG5pbDsKKworICAg IE5TQXJyYXkqIG1lbnVJdGVtcyA9IGNvcmVNZW51LT5wbGF0Zm9ybURlc2NyaXB0aW9uKCk7Cisg ICAgTlNNZW51KiBtZW51ID0gbmlsOworICAgIGlmIChtZW51SXRlbXMgJiYgW21lbnVJdGVtcyBj b3VudF0gPiAwKSB7CisgICAgICAgIG1lbnUgPSBbW1tOU01lbnUgYWxsb2NdIGluaXRdIGF1dG9y ZWxlYXNlXTsKKyAgICAgICAgW21lbnUgc2V0QXV0b2VuYWJsZXNJdGVtczpOT107CisgICAgICAg IGZvciAodW5zaWduZWQgaSA9IDA7IGkgPCBbbWVudUl0ZW1zIGNvdW50XTsgaSsrKQorICAgICAg ICAgICAgW21lbnUgYWRkSXRlbTpbbWVudUl0ZW1zIG9iamVjdEF0SW5kZXg6aV1dOwogICAgIH0K IAotICAgIHJldHVybiBuaWw7CisgICAgLy8gQWRkIHRoZSBJbnNwZWN0IEVsZW1lbnQgbWVudSBp dGVtIGlmIHRoZSBwcmVmZXJlbmNlIGlzIHNldCBvciBpZiB0aGlzIGlzIGEgZGVidWcgYnVpbGQK KyAgICBpZiAoW1dlYlZpZXcgX2RldmVsb3BlckV4dHJhc0VuYWJsZWRdKSB7CisgICAgICAgIGlm ICghbWVudSkKKyAgICAgICAgICAgIG1lbnUgPSBbW1tOU01lbnUgYWxsb2NdIGluaXRdIGF1dG9y ZWxlYXNlXTsKKyAgICAgICAgZWxzZSBpZiAoW21lbnUgbnVtYmVyT2ZJdGVtc10pCisgICAgICAg ICAgICBbbWVudSBhZGRJdGVtOltOU01lbnVJdGVtIHNlcGFyYXRvckl0ZW1dXTsKKyAgICAgICAg TlNNZW51SXRlbSAqbWVudUl0ZW0gPSBbW1tOU01lbnVJdGVtIGFsbG9jXSBpbml0XSBhdXRvcmVs ZWFzZV07CisgICAgICAgIFttZW51SXRlbSBzZXRBY3Rpb246QHNlbGVjdG9yKF9pbnNwZWN0RWxl bWVudDopXTsKKyAgICAgICAgW21lbnVJdGVtIHNldFRpdGxlOlVJX1NUUklORygiSW5zcGVjdCBF bGVtZW50IiwgIkluc3BlY3QgRWxlbWVudCBjb250ZXh0IG1lbnUgaXRlbSIpXTsKKyAgICAgICAg W21lbnVJdGVtIHNldFJlcHJlc2VudGVkT2JqZWN0OltbW1dlYkVsZW1lbnREaWN0aW9uYXJ5IGFs bG9jXSBpbml0V2l0aEhpdFRlc3RSZXN1bHQ6CisgICAgICAgICAgICBjb3JlTWVudS0+aGl0VGVz dFJlc3VsdCgpXSBhdXRvcmVsZWFzZV1dOworICAgICAgICBbbWVudSBhZGRJdGVtOm1lbnVJdGVt XTsKKyAgICB9CisKKyAgICByZXR1cm4gbWVudTsKIH0KIAogLSAoQk9PTClzZWFyY2hGb3I6KE5T U3RyaW5nICopc3RyaW5nIGRpcmVjdGlvbjooQk9PTClmb3J3YXJkIGNhc2VTZW5zaXRpdmU6KEJP T0wpY2FzZUZsYWcgd3JhcDooQk9PTCl3cmFwRmxhZwo=