121591 2013-09-19 00:32:55 -0700 REGRESSION (r149928): CanvasStyle::operator= leaks everything 2013-09-19 09:37:44 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar, Regression P2 Normal --- 1 ap ap benjamin commit-queue esprehn+autocc kling oldest_to_newest 930855 0 ap 2013-09-19 00:32:55 -0700 There is a reason why dirty tricks are not advisable, and the reason is that they are difficult to get right :) 930856 1 212038 ap 2013-09-19 00:35:43 -0700 Created attachment 212038 proposed fix Just fix the leak. It would be nice to make the code less unusual at some point. 930857 2 ap 2013-09-19 00:36:34 -0700 (this leak is very visible on leaks bot, not just theoretical) 930921 3 212038 kling 2013-09-19 06:04:18 -0700 Comment on attachment 212038 proposed fix :| 930966 4 212038 commit-queue 2013-09-19 08:59:32 -0700 Comment on attachment 212038 proposed fix Clearing flags on attachment: 212038 Committed r156099: <http://trac.webkit.org/changeset/156099> 930967 5 commit-queue 2013-09-19 08:59:34 -0700 All reviewed patches have been landed. Closing bug. 930975 6 ap 2013-09-19 09:37:44 -0700 <rdar://problem/15031018> 212038 2013-09-19 00:35:43 -0700 2013-09-19 08:59:31 -0700 proposed fix CanvasStyle.txt text/plain 1516 ap SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1NjA4NikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDEzLTA5LTE5ICBBbGV4ZXkg UHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04gKHIxNDk5 MjgpOiBDYW52YXNTdHlsZTo6b3BlcmF0b3I9IGxlYWtzIGV2ZXJ5dGhpbmcKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMTU5MQorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogaHRtbC9jYW52YXMvQ2FudmFz U3R5bGUuY3BwOiAoV2ViQ29yZTo6Q2FudmFzU3R5bGU6Om9wZXJhdG9yPSk6IERvbid0IGxlYWsu CisKIDIwMTMtMDktMTggIE1paG5lYSBPdmlkZW5pZSAgPG1paG5lYUBhZG9iZS5jb20+CiAKICAg ICAgICAgVW5yZXZpZXdlZCBidWlsZCBmaXggYWZ0ZXIgMTU2MDgyLiBHdWFyZCBTVkcgY29kZSB3 aXRoIGRlZmluZXMuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9DYW52YXNTdHls ZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvQ2FudmFzU3R5 bGUuY3BwCShyZXZpc2lvbiAxNTU3NDQpCisrKyBTb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9D YW52YXNTdHlsZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTIzOCwxMyArMjM4LDggQEAgQ2FudmFz U3R5bGU6OkNhbnZhc1N0eWxlKGNvbnN0IENhbnZhc1N0eQogQ2FudmFzU3R5bGUmIENhbnZhc1N0 eWxlOjpvcGVyYXRvcj0oY29uc3QgQ2FudmFzU3R5bGUmIG90aGVyKQogewogICAgIGlmICh0aGlz ICE9ICZvdGhlcikgewotICAgICAgICBtZW1jcHkodGhpcywgJm90aGVyLCBzaXplb2YoQ2FudmFz U3R5bGUpKTsKLSAgICAgICAgaWYgKG1fdHlwZSA9PSBHcmFkaWVudCkKLSAgICAgICAgICAgIG1f Z3JhZGllbnQtPnJlZigpOwotICAgICAgICBlbHNlIGlmIChtX3R5cGUgPT0gSW1hZ2VQYXR0ZXJu KQotICAgICAgICAgICAgbV9wYXR0ZXJuLT5yZWYoKTsKLSAgICAgICAgZWxzZSBpZiAobV90eXBl ID09IENNWUtBKQotICAgICAgICAgICAgbV9jbXlrYSA9IG5ldyBDTVlLQVZhbHVlcyhvdGhlci5t X2NteWthLT5yZ2JhLCBvdGhlci5tX2NteWthLT5jLCBvdGhlci5tX2NteWthLT5tLCBvdGhlci5t X2NteWthLT55LCBvdGhlci5tX2NteWthLT5rLCBvdGhlci5tX2NteWthLT5hKTsKKyAgICAgICAg dGhpcy0+fkNhbnZhc1N0eWxlKCk7CisgICAgICAgIG5ldyAodGhpcykgQ2FudmFzU3R5bGUob3Ro ZXIpOwogICAgIH0KICAgICByZXR1cm4gKnRoaXM7CiB9Cg==