121585 2013-09-18 20:08:45 -0700 Add XHR tests checking readyState transition when abort() is invoked in various states 2013-09-19 10:56:19 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED BlinkMergeCandidate P2 Normal --- 1 rniwa rniwa andersca ap beidson commit-queue darin oldest_to_newest 930829 0 rniwa 2013-09-18 20:08:45 -0700 Add XHR tests checking readyState transition when abort() is invoked in various states 930831 1 212032 rniwa 2013-09-18 20:09:34 -0700 Created attachment 212032 Adds the test 930971 2 212032 ap 2013-09-19 09:29:32 -0700 Comment on attachment 212032 Adds the test View in context: https://bugs.webkit.org/attachment.cgi?id=212032&action=review > LayoutTests/http/tests/xmlhttprequest/readystatechange-and-abort.html:5 > +<script src="../w3c/resources/testharness.js"></script> > +<script src="../w3c/resources/testharnessreport.js"></script> This concerns me a little - aren't w3c test resources subject to change without notice? Might be worth checking with people who work on importing these. 930992 3 rniwa 2013-09-19 10:33:23 -0700 (In reply to comment #2) > (From update of attachment 212032 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=212032&action=review > > > LayoutTests/http/tests/xmlhttprequest/readystatechange-and-abort.html:5 > > +<script src="../w3c/resources/testharness.js"></script> > > +<script src="../w3c/resources/testharnessreport.js"></script> > > This concerns me a little - aren't w3c test resources subject to change without notice? Might be worth checking with people who work on importing these. In theory but I highly doubt they'll make frequent changes to their test harness script used by tens of thousands of tests at this point. 931009 4 212032 commit-queue 2013-09-19 10:56:17 -0700 Comment on attachment 212032 Adds the test Clearing flags on attachment: 212032 Committed r156103: <http://trac.webkit.org/changeset/156103> 931010 5 commit-queue 2013-09-19 10:56:19 -0700 All reviewed patches have been landed. Closing bug. 212032 2013-09-18 20:09:34 -0700 2013-09-19 10:56:17 -0700 Adds the test bug-121585-20130918200933.patch text/plain 7291 rniwa SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDE1NjA3OCkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEzLTA5LTE4ICBSeW9zdWtlIE5pd2EgIDxy bml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIEFkZCBYSFIgdGVzdHMgY2hlY2tpbmcgcmVhZHlT dGF0ZSB0cmFuc2l0aW9uIHdoZW4gYWJvcnQoKSBpcyBpbnZva2VkIGluIHZhcmlvdXMgc3RhdGVz CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjE1ODUK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNZXJnZSBo dHRwczovL2Nocm9taXVtLmdvb2dsZXNvdXJjZS5jb20vY2hyb21pdW0vYmxpbmsvKy8yZDg1NDc1 NzU3NmRiNTkwNzQ1Y2ZiNzhlMTFjYTQyOGExYWFjMzQyCisKKyAgICAgICAgKiBodHRwL3Rlc3Rz L3htbGh0dHByZXF1ZXN0L3JlYWR5c3RhdGVjaGFuZ2UtYW5kLWFib3J0LWV4cGVjdGVkLnR4dDog QWRkZWQuCisgICAgICAgICogaHR0cC90ZXN0cy94bWxodHRwcmVxdWVzdC9yZWFkeXN0YXRlY2hh bmdlLWFuZC1hYm9ydC5odG1sOiBBZGRlZC4KKwogMjAxMy0wOS0xOCAgUnlvc3VrZSBOaXdhICA8 cm5pd2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBMaW9uIHJlYmFzZWxpbmUgYWZ0ZXIgcjE1NTI1 My4KSW5kZXg6IExheW91dFRlc3RzL2h0dHAvdGVzdHMveG1saHR0cHJlcXVlc3QvcmVhZHlzdGF0 ZWNoYW5nZS1hbmQtYWJvcnQtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3Rz L2h0dHAvdGVzdHMveG1saHR0cHJlcXVlc3QvcmVhZHlzdGF0ZWNoYW5nZS1hbmQtYWJvcnQtZXhw ZWN0ZWQudHh0CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy94bWxodHRw cmVxdWVzdC9yZWFkeXN0YXRlY2hhbmdlLWFuZC1hYm9ydC1leHBlY3RlZC50eHQJKHdvcmtpbmcg Y29weSkKQEAgLTAsMCArMSw4IEBACisKK1BBU1MgVGVzdCBvbnJlYWR5c3RhdGVjaGFuZ2UgaW52 b2NhdGlvbiB3aGVuIGFib3J0KCktZWQgaW4gVU5TRU5UIHN0YXRlLiAKK1BBU1MgVGVzdCBvbnJl YWR5c3RhdGVjaGFuZ2UgaW52b2NhdGlvbiB3aGVuIGFib3J0KCktZWQgaW4gT1BFTkVEIHN0YXRl LiAKK1BBU1MgVGVzdCBvbnJlYWR5c3RhdGVjaGFuZ2UgaW52b2NhdGlvbiB3aGVuIGFib3J0KCkt ZWQgcmlnaHQgYWZ0ZXIgY2FsbGluZyBzZW5kKCkuIAorUEFTUyBUZXN0IG9ucmVhZHlzdGF0ZWNo YW5nZSBpbnZvY2F0aW9uIHdoZW4gYWJvcnQoKS1lZCBpbiBIRUFERVJTX1JFQ0VJVkVEIHN0YXRl LiAKK1BBU1MgVGVzdCBvbnJlYWR5c3RhdGVjaGFuZ2UgaW52b2NhdGlvbiB3aGVuIGFib3J0KCkt ZWQgaW4gTE9BRElORyBzdGF0ZS4gCitQQVNTIFRlc3Qgb25yZWFkeXN0YXRlY2hhbmdlIGludm9j YXRpb24gd2hlbiBhYm9ydCgpLWVkIGluIERPTkUgc3RhdGUuIAorCkluZGV4OiBMYXlvdXRUZXN0 cy9odHRwL3Rlc3RzL3htbGh0dHByZXF1ZXN0L3JlYWR5c3RhdGVjaGFuZ2UtYW5kLWFib3J0Lmh0 bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy94bWxodHRwcmVxdWVzdC9y ZWFkeXN0YXRlY2hhbmdlLWFuZC1hYm9ydC5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVz dHMvaHR0cC90ZXN0cy94bWxodHRwcmVxdWVzdC9yZWFkeXN0YXRlY2hhbmdlLWFuZC1hYm9ydC5o dG1sCSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEsMTY0IEBACis8IURPQ1RZUEUgaHRtbD4KKzxo dG1sPgorPGJvZHk+Cis8c2NyaXB0IHNyYz0iLi4vdzNjL3Jlc291cmNlcy90ZXN0aGFybmVzcy5q cyI+PC9zY3JpcHQ+Cis8c2NyaXB0IHNyYz0iLi4vdzNjL3Jlc291cmNlcy90ZXN0aGFybmVzc3Jl cG9ydC5qcyI+PC9zY3JpcHQ+Cis8c2NyaXB0IHR5cGU9InRleHQvamF2YXNjcmlwdCI+Cit0ZXN0 KGZ1bmN0aW9uKCkKK3sKKyAgICB2YXIgeGhyID0gbmV3IFhNTEh0dHBSZXF1ZXN0OworICAgIHho ci5vbnJlYWR5c3RhdGVjaGFuZ2UgPSB0aGlzLnN0ZXBfZnVuYyhmdW5jdGlvbigpIHsKKyAgICAg ICAgYXNzZXJ0X3VucmVhY2hlZCgiUmVjZWl2ZWQgcmVhZHlzdGF0ZWNoYW5nZSBldmVudCB1bmV4 cGVjdGVkbHk6IHJlYWR5U3RhdGU9IiArIHhoci5yZWFkeVN0YXRlKQorICAgIH0pOworICAgIHho ci5hYm9ydCgpOworICAgIGFzc2VydF9lcXVhbHMoeGhyLnJlYWR5U3RhdGUsIHhoci5VTlNFTlQs ICJ4aHIucmVhZHlTdGF0ZSBhZnRlciBhYm9ydCgpIGNhbGwiKTsKK30sICJUZXN0IG9ucmVhZHlz dGF0ZWNoYW5nZSBpbnZvY2F0aW9uIHdoZW4gYWJvcnQoKS1lZCBpbiBVTlNFTlQgc3RhdGUuIik7 CisKK3Rlc3QoZnVuY3Rpb24oKQoreworICAgIHZhciB4aHIgPSBuZXcgWE1MSHR0cFJlcXVlc3Q7 CisgICAgdmFyIHNlZW5TdGF0ZXMgPSBbXTsKKyAgICB4aHIub25yZWFkeXN0YXRlY2hhbmdlID0g dGhpcy5zdGVwX2Z1bmMoZnVuY3Rpb24oKSB7CisgICAgICAgIHNlZW5TdGF0ZXMucHVzaCh4aHIu cmVhZHlTdGF0ZSk7CisKKyAgICAgICAgc3dpdGNoICh4aHIucmVhZHlTdGF0ZSkgeworICAgICAg ICBjYXNlIHhoci5PUEVORUQ6CisgICAgICAgICAgICByZXR1cm47CisKKyAgICAgICAgY2FzZSB4 aHIuVU5TRU5UOgorICAgICAgICBjYXNlIHhoci5IRUFERVJTX1JFQ0VJVkVEOgorICAgICAgICBj YXNlIHhoci5MT0FESU5HOgorICAgICAgICBjYXNlIHhoci5ET05FOgorICAgICAgICBkZWZhdWx0 OgorICAgICAgICAgICAgYXNzZXJ0X3VucmVhY2hlZCgiVW5leHBlY3RlZCByZWFkeVN0YXRlOiAi ICsgeGhyLnJlYWR5U3RhdGUpOworICAgICAgICAgICAgcmV0dXJuOworICAgICAgICB9CisgICAg fSk7CisgICAgeGhyLm9wZW4oIkdFVCIsICJyZXNvdXJjZXMvdGVzdC5vZ3YiLCB0cnVlKTsKKyAg ICB4aHIuYWJvcnQoKTsKKyAgICBhc3NlcnRfZXF1YWxzKHhoci5yZWFkeVN0YXRlLCB4aHIuVU5T RU5ULCAieGhyLnJlYWR5U3RhdGUgYWZ0ZXIgYWJvcnQoKSBjYWxsIik7CisgICAgYXNzZXJ0X2Fy cmF5X2VxdWFscyhzZWVuU3RhdGVzLCBbeGhyLk9QRU5FRF0pOworfSwgIlRlc3Qgb25yZWFkeXN0 YXRlY2hhbmdlIGludm9jYXRpb24gd2hlbiBhYm9ydCgpLWVkIGluIE9QRU5FRCBzdGF0ZS4iKTsK KwordGVzdChmdW5jdGlvbigpCit7CisgICAgdmFyIHhociA9IG5ldyBYTUxIdHRwUmVxdWVzdDsK KyAgICB2YXIgc2VlblN0YXRlcyA9IFtdOworICAgIHhoci5vbnJlYWR5c3RhdGVjaGFuZ2UgPSB0 aGlzLnN0ZXBfZnVuYyhmdW5jdGlvbigpIHsKKyAgICAgICAgc2VlblN0YXRlcy5wdXNoKHhoci5y ZWFkeVN0YXRlKTsKKworICAgICAgICBzd2l0Y2ggKHhoci5yZWFkeVN0YXRlKSB7CisgICAgICAg IGNhc2UgeGhyLk9QRU5FRDoKKyAgICAgICAgY2FzZSB4aHIuRE9ORToKKyAgICAgICAgICAgIHJl dHVybjsKKworICAgICAgICBjYXNlIHhoci5VTlNFTlQ6CisgICAgICAgIGNhc2UgeGhyLkhFQURF UlNfUkVDRUlWRUQ6CisgICAgICAgIGNhc2UgeGhyLkxPQURJTkc6CisgICAgICAgIGRlZmF1bHQ6 CisgICAgICAgICAgICBhc3NlcnRfdW5yZWFjaGVkKCJVbmV4cGVjdGVkIHJlYWR5U3RhdGU6ICIg KyB4aHIucmVhZHlTdGF0ZSk7CisgICAgICAgICAgICByZXR1cm47CisgICAgICAgIH0KKyAgICB9 KTsKKyAgICB4aHIub3BlbigiR0VUIiwgInJlc291cmNlcy90ZXN0Lm9ndiIsIHRydWUpOworICAg IHhoci5zZW5kKCk7CisgICAgeGhyLmFib3J0KCk7CisgICAgYXNzZXJ0X2VxdWFscyh4aHIucmVh ZHlTdGF0ZSwgeGhyLlVOU0VOVCwgInhoci5yZWFkeVN0YXRlIGFmdGVyIGFib3J0KCkgY2FsbCIp OworICAgIGFzc2VydF9hcnJheV9lcXVhbHMoc2VlblN0YXRlcywgW3hoci5PUEVORUQsIHhoci5E T05FXSk7Cit9LCAiVGVzdCBvbnJlYWR5c3RhdGVjaGFuZ2UgaW52b2NhdGlvbiB3aGVuIGFib3J0 KCktZWQgcmlnaHQgYWZ0ZXIgY2FsbGluZyBzZW5kKCkuIik7CisKK3ZhciBhYm9ydEluSGVhZGVy c1JlY2VpdmVkVGVzdCA9IGFzeW5jX3Rlc3QoIlRlc3Qgb25yZWFkeXN0YXRlY2hhbmdlIGludm9j YXRpb24gd2hlbiBhYm9ydCgpLWVkIGluIEhFQURFUlNfUkVDRUlWRUQgc3RhdGUuIik7CithYm9y dEluSGVhZGVyc1JlY2VpdmVkVGVzdC5zdGVwKGZ1bmN0aW9uKCkKK3sKKyAgICB2YXIgeGhyID0g bmV3IFhNTEh0dHBSZXF1ZXN0OworICAgIHZhciBzZWVuU3RhdGVzID0gW107CisgICAgeGhyLm9u cmVhZHlzdGF0ZWNoYW5nZSA9IGFib3J0SW5IZWFkZXJzUmVjZWl2ZWRUZXN0LnN0ZXBfZnVuYyhm dW5jdGlvbigpIHsKKyAgICAgICAgc2VlblN0YXRlcy5wdXNoKHhoci5yZWFkeVN0YXRlKTsKKwor ICAgICAgICBzd2l0Y2ggKHhoci5yZWFkeVN0YXRlKSB7CisgICAgICAgIGNhc2UgeGhyLk9QRU5F RDoKKyAgICAgICAgY2FzZSB4aHIuRE9ORToKKyAgICAgICAgICAgIHJldHVybjsKKworICAgICAg ICBjYXNlIHhoci5IRUFERVJTX1JFQ0VJVkVEOgorICAgICAgICAgICAgeGhyLmFib3J0KCk7Cisg ICAgICAgICAgICBhc3NlcnRfZXF1YWxzKHhoci5yZWFkeVN0YXRlLCB4aHIuVU5TRU5ULCAieGhy LnJlYWR5U3RhdGUgYWZ0ZXIgYWJvcnQoKSBjYWxsIik7CisgICAgICAgICAgICBhc3NlcnRfYXJy YXlfZXF1YWxzKHNlZW5TdGF0ZXMsIFt4aHIuT1BFTkVELCB4aHIuSEVBREVSU19SRUNFSVZFRCwg eGhyLkRPTkVdKTsKKyAgICAgICAgICAgIGFib3J0SW5IZWFkZXJzUmVjZWl2ZWRUZXN0LmRvbmUo KTsKKyAgICAgICAgICAgIHJldHVybjsKKworICAgICAgICBjYXNlIHhoci5VTlNFTlQ6CisgICAg ICAgIGNhc2UgeGhyLkxPQURJTkc6CisgICAgICAgIGRlZmF1bHQ6CisgICAgICAgICAgICBhc3Nl cnRfdW5yZWFjaGVkKCJVbmV4cGVjdGVkIHJlYWR5U3RhdGU6ICIgKyB4aHIucmVhZHlTdGF0ZSkK KyAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAgfQorICAgIH0pOworICAgIHhoci5vcGVuKCJH RVQiLCAicmVzb3VyY2VzL3Rlc3Qub2d2IiwgdHJ1ZSk7CisgICAgeGhyLnNlbmQoKTsKK30pOwor Cit2YXIgYWJvcnRJbkxvYWRpbmdUZXN0ID0gYXN5bmNfdGVzdCgiVGVzdCBvbnJlYWR5c3RhdGVj aGFuZ2UgaW52b2NhdGlvbiB3aGVuIGFib3J0KCktZWQgaW4gTE9BRElORyBzdGF0ZS4iKTsKK2Fi b3J0SW5Mb2FkaW5nVGVzdC5zdGVwKGZ1bmN0aW9uKCkKK3sKKyAgICB2YXIgeGhyID0gbmV3IFhN TEh0dHBSZXF1ZXN0OworICAgIHZhciBzZWVuU3RhdGVzID0gW107CisgICAgeGhyLm9ucmVhZHlz dGF0ZWNoYW5nZSA9IGFib3J0SW5Mb2FkaW5nVGVzdC5zdGVwX2Z1bmMoZnVuY3Rpb24oKSB7Cisg ICAgICAgIHNlZW5TdGF0ZXMucHVzaCh4aHIucmVhZHlTdGF0ZSk7CisKKyAgICAgICAgc3dpdGNo ICh4aHIucmVhZHlTdGF0ZSkgeworICAgICAgICBjYXNlIHhoci5PUEVORUQ6CisgICAgICAgIGNh c2UgeGhyLkhFQURFUlNfUkVDRUlWRUQ6CisgICAgICAgIGNhc2UgeGhyLkRPTkU6CisgICAgICAg ICAgICByZXR1cm47CisKKyAgICAgICAgY2FzZSB4aHIuTE9BRElORzoKKyAgICAgICAgICAgIHho ci5hYm9ydCgpOworICAgICAgICAgICAgYXNzZXJ0X2VxdWFscyh4aHIucmVhZHlTdGF0ZSwgeGhy LlVOU0VOVCwgInhoci5yZWFkeVN0YXRlIGFmdGVyIGFib3J0KCkgY2FsbCIpOworICAgICAgICAg ICAgYXNzZXJ0X2FycmF5X2VxdWFscyhzZWVuU3RhdGVzLCBbeGhyLk9QRU5FRCwgeGhyLkhFQURF UlNfUkVDRUlWRUQsIHhoci5MT0FESU5HLCB4aHIuRE9ORV0pOworICAgICAgICAgICAgYWJvcnRJ bkxvYWRpbmdUZXN0LmRvbmUoKTsKKyAgICAgICAgICAgIHJldHVybjsKKworICAgICAgICBjYXNl IHhoci5VTlNFTlQ6CisgICAgICAgIGRlZmF1bHQ6CisgICAgICAgICAgICBhc3NlcnRfdW5yZWFj aGVkKCJVbmV4cGVjdGVkIHJlYWR5U3RhdGU6ICIgKyB4aHIucmVhZHlTdGF0ZSkKKyAgICAgICAg ICAgIHJldHVybjsKKyAgICAgICAgfQorICAgIH0pOworICAgIHhoci5vcGVuKCJHRVQiLCAicmVz b3VyY2VzL3Rlc3Qub2d2IiwgdHJ1ZSk7CisgICAgeGhyLnNlbmQoKTsKK30pOworCit2YXIgYWJv cnRJbkRvbmVUZXN0ID0gYXN5bmNfdGVzdCgiVGVzdCBvbnJlYWR5c3RhdGVjaGFuZ2UgaW52b2Nh dGlvbiB3aGVuIGFib3J0KCktZWQgaW4gRE9ORSBzdGF0ZS4iKTsKK2Fib3J0SW5Eb25lVGVzdC5z dGVwKGZ1bmN0aW9uKCkKK3sKKyAgICB2YXIgeGhyID0gbmV3IFhNTEh0dHBSZXF1ZXN0OworICAg IHZhciBzZWVuU3RhdGVzID0gW107CisgICAgeGhyLm9ucmVhZHlzdGF0ZWNoYW5nZSA9IGFib3J0 SW5Eb25lVGVzdC5zdGVwX2Z1bmMoZnVuY3Rpb24oKSB7CisgICAgICAgIHNlZW5TdGF0ZXMucHVz aCh4aHIucmVhZHlTdGF0ZSk7CisKKyAgICAgICAgc3dpdGNoICh4aHIucmVhZHlTdGF0ZSkgewor ICAgICAgICBjYXNlIHhoci5PUEVORUQ6CisgICAgICAgIGNhc2UgeGhyLkhFQURFUlNfUkVDRUlW RUQ6CisgICAgICAgIGNhc2UgeGhyLkxPQURJTkc6CisgICAgICAgICAgICByZXR1cm47CisKKyAg ICAgICAgY2FzZSB4aHIuRE9ORToKKyAgICAgICAgICAgIHhoci5hYm9ydCgpOworICAgICAgICAg ICAgYXNzZXJ0X2VxdWFscyh4aHIucmVhZHlTdGF0ZSwgeGhyLlVOU0VOVCwgInhoci5yZWFkeVN0 YXRlIGFmdGVyIGFib3J0KCkgY2FsbCIpOworICAgICAgICAgICAgYXNzZXJ0X2FycmF5X2VxdWFs cyhzZWVuU3RhdGVzLCBbeGhyLk9QRU5FRCwgeGhyLkhFQURFUlNfUkVDRUlWRUQsIHhoci5MT0FE SU5HLCB4aHIuRE9ORV0pOworICAgICAgICAgICAgYWJvcnRJbkRvbmVUZXN0LmRvbmUoKTsKKyAg ICAgICAgICAgIHJldHVybjsKKworICAgICAgICBjYXNlIHhoci5VTlNFTlQ6CisgICAgICAgIGRl ZmF1bHQ6CisgICAgICAgICAgICBhc3NlcnRfdW5yZWFjaGVkKCJVbmV4cGVjdGVkIHJlYWR5U3Rh dGU6ICIgKyB4aHIucmVhZHlTdGF0ZSkKKyAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAgfQor ICAgIH0pOworICAgIHhoci5vcGVuKCJHRVQiLCAicmVzb3VyY2VzL3Rlc3Qub2d2IiwgdHJ1ZSk7 CisgICAgeGhyLnNlbmQoKTsKK30pOworPC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+Cg==