121545 2013-09-18 00:50:55 -0700 [GTK] Reduce the binary size by compressing the text based web inspector resources 2014-04-15 06:14:18 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cgarcia webkit-unassigned gustavo oldest_to_newest 930562 0 cgarcia 2013-09-18 00:50:55 -0700 Now that web inspector resources are compiled as gresources, we might reduce the binary size a bit by compiling the text based resources compressed. We should check it doesn't affect the performance though. 992992 1 cgarcia 2014-03-21 02:40:56 -0700 I've tried a patch for this (on top of patch attached to bug #130343), and these are the results: Before: -rw-r--r-- 1 cgarcia cgarcia 28M mar 21 10:31 InspectorGResourceBundle.c -rwxr-xr-x 1 cgarcia cgarcia 59M mar 21 10:30 libwebkit2gtk-3.0.so.25.7.0 -rwxr-xr-x 1 cgarcia cgarcia 55M mar 21 10:30 libwebkitgtk-3.0.so.0.22.0 -rwxr-xr-x 1 cgarcia cgarcia 47M mar 21 10:30 WebKitPluginProcess After: -rw-r--r-- 1 cgarcia cgarcia 12M mar 21 10:32 InspectorGResourceBundle.c -rwxr-xr-x 1 cgarcia cgarcia 56M mar 21 10:33 libwebkit2gtk-3.0.so.25.7.0 -rwxr-xr-x 1 cgarcia cgarcia 52M mar 21 10:33 libwebkitgtk-3.0.so.0.22.0 -rwxr-xr-x 1 cgarcia cgarcia 45M mar 21 10:33 WebKitPluginProcess As you can see, one problem of compiling the resources in WEbCore is that all those end up in the plugin proces binary. My currently installed plugin process is 35MB, 10MB less than the compressed version including the inspector resources. So, maybe we should re-consider compiling them in WebCore, even if we have to duplicate some cmake code. I haven't noticed any performance regression when loading the compressed resources. I'll submit the patch as soon as patch for bug #130343 lands. 999885 2 229135 cgarcia 2014-04-11 08:54:21 -0700 Created attachment 229135 Patch Before: -rwxr-xr-x 1 cgarcia cgarcia 58M abr 11 15:38 libwebkit2gtk-3.0.so.25.7.0 After: -rwxr-xr-x 1 cgarcia cgarcia 55M abr 11 17:48 libwebkit2gtk-3.0.so.25.7.0 1000831 3 229135 gustavo 2014-04-15 05:23:09 -0700 Comment on attachment 229135 Patch Nice! 1000841 4 cgarcia 2014-04-15 06:14:18 -0700 Committed r167306: <http://trac.webkit.org/changeset/167306> 229135 2014-04-11 08:54:21 -0700 2014-04-15 05:23:08 -0700 Patch wk2-compress-inspector-resources.diff text/plain 2191 cgarcia ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBmMTcz M2Q1Li5lNjg5OGE1IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTQtMDQtMTEgIENhcmxvcyBHYXJjaWEgQ2FtcG9z ICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdIFJlZHVjZSB0aGUgYmluYXJ5 IHNpemUgYnkgY29tcHJlc3NpbmcgdGhlIHRleHQgYmFzZWQgd2ViIGluc3BlY3RvciByZXNvdXJj ZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMTU0 NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENvbXBy ZXNzIHRleHQgYmFzZWQgZmlsZXMgd2hlbiBjb21waWxpbmcgaW5zcGVjdG9yIHJlc291cmNlcy4g SXQKKyAgICAgICAgcmVkdWNlcyB0aGUgYmluYXJ5IHNpemUgaW4gM01CLgorCisgICAgICAgICog Z3RrL2dlbmVyYXRlLWluc3BlY3Rvci1ncmVzb3VyY2UtbWFuaWZlc3QucHk6CisgICAgICAgIChm aW5kX2FsbF9maWxlc19pbl9kaXJlY3RvcnkpOgorICAgICAgICAoaXNfY29tcHJlc3NpYmxlKToK KwogMjAxNC0wNC0xMCAgWmFuIERvYmVyc2VrICA8emRvYmVyc2VrQGlnYWxpYS5jb20+CiAKICAg ICAgICAgW0NNYWtlXSBBZGQgbWlzc2luZyBXVEYgdW5pdCB0ZXN0cwpkaWZmIC0tZ2l0IGEvVG9v bHMvZ3RrL2dlbmVyYXRlLWluc3BlY3Rvci1ncmVzb3VyY2UtbWFuaWZlc3QucHkgYi9Ub29scy9n dGsvZ2VuZXJhdGUtaW5zcGVjdG9yLWdyZXNvdXJjZS1tYW5pZmVzdC5weQppbmRleCAwYWI0NDc0 Li5jMDM1ZTY4IDEwMDc1NQotLS0gYS9Ub29scy9ndGsvZ2VuZXJhdGUtaW5zcGVjdG9yLWdyZXNv dXJjZS1tYW5pZmVzdC5weQorKysgYi9Ub29scy9ndGsvZ2VuZXJhdGUtaW5zcGVjdG9yLWdyZXNv dXJjZS1tYW5pZmVzdC5weQpAQCAtMjEsNiArMjEsNyBAQCBpbXBvcnQgb3MKIGltcG9ydCBzeXMK IAogQUxMT1dFRF9FWFRFTlNJT05TID0gWycuaHRtbCcsICcuanMnLCAnLmNzcycsICcucG5nJywg Jy5zdmcnXQorQ09NUFJFU1NJQkxFX0VYVEVOU0lPTlMgPSBbJy5odG1sJywgJy5qcycsICcuY3Nz JywgJy5zdmcnXQogCiAKIGRlZiBmaW5kX2FsbF9maWxlc19pbl9kaXJlY3RvcnkoZGlyZWN0b3J5 KToKQEAgLTM4LDYgKzM5LDExIEBAIGRlZiBmaW5kX2FsbF9maWxlc19pbl9kaXJlY3RvcnkoZGly ZWN0b3J5KToKIAogICAgIHJldHVybiB0b19yZXR1cm4KIAorCitkZWYgaXNfY29tcHJlc3NpYmxl KGZpbGVuYW1lKToKKyAgICByZXR1cm4gb3MucGF0aC5zcGxpdGV4dChmaWxlbmFtZSlbMV0gaW4g Q09NUFJFU1NJQkxFX0VYVEVOU0lPTlMKKworCiBpZiBfX25hbWVfXyA9PSAiX19tYWluX18iOgog ICAgIHBhcnNlciA9IGFyZ3BhcnNlLkFyZ3VtZW50UGFyc2VyKGRlc2NyaXB0aW9uPSdHZW5lcmF0 ZSBhIEdSZXNvdXJjZXMgZmlsZSBmb3IgdGhlIGluc3BlY3Rvci4nKQogICAgIHBhcnNlci5hZGRf YXJndW1lbnQoJy0tb3V0cHV0JywgbmFyZ3M9Jz8nLCB0eXBlPWFyZ3BhcnNlLkZpbGVUeXBlKCd3 JyksIGRlZmF1bHQ9c3lzLnN0ZG91dCwKQEAgLTUyLDggKzU4LDEzIEBAIGlmIF9fbmFtZV9fID09 ICJfX21haW5fXyI6CiAiIiIpCiAKICAgICBmb3IgZGlyZWN0b3J5IGluIGV4dHJhX2FyZ3NbMTpd OgotICAgICAgICBmb3IgZmlsZSBpbiBmaW5kX2FsbF9maWxlc19pbl9kaXJlY3RvcnkoZGlyZWN0 b3J5KToKLSAgICAgICAgICAgIGFyZ3VtZW50cy5vdXRwdXQud3JpdGUoIiAgICAgICAgICAgIDxm aWxlPiVzPC9maWxlPlxuIiAlIGZpbGUpCisgICAgICAgIGZvciBmaWxlbmFtZSBpbiBmaW5kX2Fs bF9maWxlc19pbl9kaXJlY3RvcnkoZGlyZWN0b3J5KToKKyAgICAgICAgICAgIGxpbmUgPSAnICAg ICAgICAgICAgPGZpbGUnCisgICAgICAgICAgICBpZiBpc19jb21wcmVzc2libGUoZmlsZW5hbWUp OgorICAgICAgICAgICAgICAgIGxpbmUgKz0gJyBjb21wcmVzc2VkPSJ0cnVlIicKKyAgICAgICAg ICAgIGxpbmUgKz0gJz4lczwvZmlsZT5cbicgJSBmaWxlbmFtZQorCisgICAgICAgICAgICBhcmd1 bWVudHMub3V0cHV0LndyaXRlKGxpbmUpCiAKICAgICBhcmd1bWVudHMub3V0cHV0LndyaXRlKFwK ICAgICAiIiIgICAgPC9ncmVzb3VyY2U+Cg==