121535 2013-09-17 21:02:07 -0700 WinLauncher needs better url handling 2013-09-18 10:20:54 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Windows 7 RESOLVED FIXED P3 Minor --- 0 alex.christensen webkit-unassigned bfulgham commit-queue oldest_to_newest 930502 0 alex.christensen 2013-09-17 21:02:07 -0700 BrowserWindowController.m has a function called addProtocolIfNecessary which prepends "http://" if "://" is not found in the url of MiniBrowser. A similar behaviour can be achieved with a simple one line change that makes it so if you type "webkit.org" into WinLauncher you'll get to your favourite website instead of having to type "http://www.webkit.org/". Also, we defined our own macro MAX_URL_LENGTH which is 1024 instead of INTERNET_MAX_URL_LENGTH from WinInet.h which is 2083. This should be consistent. This makes WinLauncher more stable and user friendly. 930504 1 211969 alex.christensen 2013-09-17 21:05:31 -0700 Created attachment 211969 Patch 930514 2 211969 bfulgham 2013-09-17 21:55:43 -0700 Comment on attachment 211969 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=211969&action=review R=me > Tools/WinLauncher/WinLauncher.cpp:-875 > - Good! 930665 3 211969 commit-queue 2013-09-18 10:20:53 -0700 Comment on attachment 211969 Patch Clearing flags on attachment: 211969 Committed r156048: <http://trac.webkit.org/changeset/156048> 930666 4 commit-queue 2013-09-18 10:20:54 -0700 All reviewed patches have been landed. Closing bug. 211969 2013-09-17 21:05:31 -0700 2013-09-18 10:20:53 -0700 Patch bug-121535-20130917220539.patch text/plain 1867 alex.christensen SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE1NjAyMikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE2IEBACisyMDEzLTA5LTE3ICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdl YmtpdC5vcmc+CisKKyAgICAgICAgSW1wcm92ZWQgV2luTGF1bmNoZXIncyBVUkwgaGFuZGxpbmcu CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjE1MzUK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFdpbkxh dW5jaGVyL1dpbkxhdW5jaGVyLmNwcDoKKyAgICAgICAgKEVkaXRQcm9jKToKKyAgICAgICAgVXNl IElOVEVSTkVUX01BWF9VUkxfTEVOR1RIIGluc3RlYWQgb2Ygb3VyIE1BWF9VUkxfTEVOR1RILgor ICAgICAgICAobG9hZFVSTCk6CisgICAgICAgIFByZXBlbmQgImh0dHA6Ly8iIHRvIFVSTHMgd2l0 aCBubyBzY2hlbWUuCisKIDIwMTMtMDktMTcgIEphZSBIeXVuIFBhcmsgIDxqYWUucGFya0Bjb21w YW55MTAwLm5ldD4KIAogICAgICAgICBVbnJldmlld2VkLiBBZGQgbXlzZWxmIGFzIGEgY29tbWl0 dGVyLgpJbmRleDogVG9vbHMvV2luTGF1bmNoZXIvV2luTGF1bmNoZXIuY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFRvb2xzL1dpbkxhdW5jaGVyL1dpbkxhdW5jaGVyLmNwcAkocmV2aXNpb24gMTU2MDIxKQor KysgVG9vbHMvV2luTGF1bmNoZXIvV2luTGF1bmNoZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC04 NzEsMTUgKzg3MSwxMyBAQCBMUkVTVUxUIENBTExCQUNLIFduZFByb2MoSFdORCBoV25kLCBVSU5U CiAgICAgcmV0dXJuIDA7CiB9CiAKLSNkZWZpbmUgTUFYX1VSTF9MRU5HVEggIDEwMjQKLQogTFJF U1VMVCBDQUxMQkFDSyBFZGl0UHJvYyhIV05EIGhEbGcsIFVJTlQgbWVzc2FnZSwgV1BBUkFNIHdQ YXJhbSwgTFBBUkFNIGxQYXJhbSkKIHsKICAgICBzd2l0Y2ggKG1lc3NhZ2UpIHsKICAgICBjYXNl IFdNX0NIQVI6CiAgICAgICAgIGlmICh3UGFyYW0gPT0gMTMpIHsgLy8gRW50ZXIgS2V5Ci0gICAg ICAgICAgICB3Y2hhcl90IHN0clB0cltNQVhfVVJMX0xFTkdUSF07Ci0gICAgICAgICAgICAqKChM UFdPUkQpc3RyUHRyKSA9IE1BWF9VUkxfTEVOR1RIOyAKKyAgICAgICAgICAgIHdjaGFyX3Qgc3Ry UHRyW0lOVEVSTkVUX01BWF9VUkxfTEVOR1RIXTsKKyAgICAgICAgICAgICooKExQV09SRClzdHJQ dHIpID0gSU5URVJORVRfTUFYX1VSTF9MRU5HVEg7IAogICAgICAgICAgICAgaW50IHN0ckxlbiA9 IFNlbmRNZXNzYWdlKGhEbGcsIEVNX0dFVExJTkUsIDAsIChMUEFSQU0pc3RyUHRyKTsKIAogICAg ICAgICAgICAgc3RyUHRyW3N0ckxlbl0gPSAwOwpAQCAtOTUzLDcgKzk1MSw3IEBAIHN0YXRpYyB2 b2lkIGxvYWRVUkwoQlNUUiB1cmxCU3RyKQogICAgIGlmIChGQUlMRUQoaHIpKQogICAgICAgICBy ZXR1cm47CiAKLSAgICBociA9IHJlcXVlc3QtPmluaXRXaXRoVVJMKHVybEJTdHIsIFdlYlVSTFJl cXVlc3RVc2VQcm90b2NvbENhY2hlUG9saWN5LCA2MCk7CisgICAgaHIgPSByZXF1ZXN0LT5pbml0 V2l0aFVSTCh3Y3NzdHIodXJsQlN0ciwgTCI6Ly8iKSA/IHVybEJTdHIgOiBfYnN0cl90KEwiaHR0 cDovLyIpICsgdXJsQlN0ciwgV2ViVVJMUmVxdWVzdFVzZVByb3RvY29sQ2FjaGVQb2xpY3ksIDYw KTsKICAgICBpZiAoRkFJTEVEKGhyKSkKICAgICAgICAgcmV0dXJuOwogCg==