121532 2013-09-17 20:09:27 -0700 REGRESSION (r155854 - r155967) block with margin-left adjacent to floated block causes text of subsequent blocks to overlap the floated block. 2013-09-18 18:30:09 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 phiw2 bjonesbe bjonesbe commit-queue esprehn+autocc glenn kondapallykalyan oldest_to_newest 930493 0 211965 phiw2 2013-09-17 20:09:27 -0700 Created attachment 211965 testcase See the test case. Basically: a left-floated block is followed by a block of text that has a left margin. The text in blocks that follow that block will then overlap the floated block. possibly: http://trac.webkit.org/changeset/155906 ? live example: http://hibbs.armscontrolwonk.com/archive/2215/packing-pistols-in-vienna#comments see the gravatar image in the comments 930795 1 212030 bjonesbe 2013-09-18 17:22:51 -0700 Created attachment 212030 Patch 930796 2 212030 kling 2013-09-18 17:45:03 -0700 Comment on attachment 212030 Patch r=me 930806 3 212030 commit-queue 2013-09-18 18:30:07 -0700 Comment on attachment 212030 Patch Clearing flags on attachment: 212030 Committed r156075: <http://trac.webkit.org/changeset/156075> 930807 4 commit-queue 2013-09-18 18:30:09 -0700 All reviewed patches have been landed. Closing bug. 211965 2013-09-17 20:09:27 -0700 2013-09-17 20:09:27 -0700 testcase wb_float.html text/html 1361 phiw2 PCFkb2N0eXBlIGh0bWw+CjxodG1sIGxhbmc9ImVuIj4KPGhlYWQ+CjxtZXRhIGNoYXJzZXQ9InV0 Zi04Ij4KPHRpdGxlPnRlc3Q6IHNvbWV0aGluZzwvdGl0bGU+CjxtZXRhIG5hbWU9ImF1dGhvciIg Y29udGVudD0icGhpbGlwcGUgd2l0dGVuYmVyZ2giPgo8c3R5bGUgdHlwZT0idGV4dC9jc3MiPgoK ZGl2IHsgbWFyZ2luOiAxZW0gNSU7IGJvcmRlcjogMXB4IGRvdHRlZDsgcGFkZGluZzogLjY2ZW07 IH0KLypkaXYgaW1nKi8gCmRpdiA+IHA6Zmlyc3Qtb2YtdHlwZSB7IGZsb2F0OiBsZWZ0OyBtYXJn aW46MCAuNWVtIC41ZW0gMDsgd2lkdGg6IDc1cHg7IGhlaWdodDogMTc1cHg7IGJhY2tncm91bmQ6 IHllbGxvdzsgfQpkaXYgPiBwIHsgbWFyZ2luOiAxZW0gMTBweDsgfQpkaXYgPiBwOmZpcnN0LW9m LXR5cGUgKyBwIHsgbWFyZ2luLWxlZnQ6IDEwMHB4OyBiYWNrZ3JvdW5kOiBjeWFuOyB9Cgo8L3N0 eWxlPgoKCjwvaGVhZD4KCjxib2R5Pgo8ZGl2Pgo8cD48L3A+CjxwPkxvcmVtIGlwc3VtIGRvbG9y IHNpdCBhbWV0LCBjb25zZWN0ZXR1ZXIgYWRpcGlzY2luZyBlbGl0LiBOdWxsYSBlZ2VzdGFzLjwv cD4KPHA+SW50ZWdlciB1bGxhbWNvcnBlci4gTnVuYyBwb3J0YSBjb25zZWN0ZXR1ZXIgc2VtLjxw PlF1aXNxdWUgdmFyaXVzIHNhZ2l0dGlzIGxpYmVyby4gRXRpYW0gaXBzdW0gYW50ZSwgaW1wZXJk aWV0IGFjLCB1bGxhbWNvcnBlciBpbiwgdGVtcHVzIHNpdCBhbWV0LCByaXN1cy4gTWF1cmlzIGV1 aXNtb2QsIGFyY3UgaW4gaW50ZXJkdW0gY29uZGltZW50dW0sIGxlY3R1cyB0b3J0b3IgbG9ib3J0 aXMgZWxpdCwgbHVjdHVzIG1vbGVzdGllIG5lcXVlIHJpc3VzIGF0IGVsaXQuIEluIG5lYyBqdXN0 by4gQWxpcXVhbSB2dWxwdXRhdGUsIG5pc2wgZXUgbHVjdHVzIHNhZ2l0dGlzLCB0ZWxsdXMgb2Rp byBlbGVpZmVuZCBsaWd1bGEsIGFjIHZlaGljdWxhIG1hdXJpcyBuaXNsIG5lYyBsZWN0dXMuIE1h ZWNlbmFzIG1hdHRpcyBudWxsYSBpbiBmZWxpcy4gU3VzcGVuZGlzc2UgZmF1Y2lidXMgZGFwaWJ1 cyBudWxsYS4gRG9uZWMgdmVoaWN1bGEgbWV0dXMgZXUgbmlzbC4gVmVzdGlidWx1bSBwb3J0YSBu aXNpIHF1aXMgYW50ZSBwaGFyZXRyYSBzYWdpdHRpcy4gTnVsbGFtIGVsaXQuIE5hbSBpbiBtYXNz YSBhIGVuaW0gdHJpc3RpcXVlIGhlbmRyZXJpdC4gTWF1cmlzIHNlZCBwZWRlIHZlbCBsaWd1bGEg ZmF1Y2lidXMgYWNjdW1zYW4uIE1vcmJpIHZlaGljdWxhIGdyYXZpZGEgc2FwaWVuLiBMb3JlbSBp cHN1bSBkb2xvciBzaXQgYW1ldCwgY29uc2VjdGV0dWVyIGFkaXBpc2NpbmcgZWxpdC4gSW4gdGlu Y2lkdW50IGhlbmRyZXJpdCBlc3QuPC9wPgo8L2Rpdj4KCgo8L2JvZHk+CjwvaHRtbD4= 212030 2013-09-18 17:22:51 -0700 2013-09-18 18:30:07 -0700 Patch bug-121532-20130918172257.patch text/plain 5117 bjonesbe U3VidmVyc2lvbiBSZXZpc2lvbjogMTU2MDY5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmIyOTU2NTlkZmU5NTVl ZTE2NjAxMjk0MzBiOGE4NDc5N2M4NWUwNC4uY2IyY2YyNjMwY2U0NWY0NGMxMjU3ZDAzZDA2M2Nk NzBjZWJlNjdlMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEzLTA5LTE4ICBCZW0g Sm9uZXMtQmV5ICA8YmpvbmVzYmVAYWRvYmUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04gKHIx NTU4NTQgLSByMTU1OTY3KSBibG9jayB3aXRoIG1hcmdpbi1sZWZ0IGFkamFjZW50IHRvIGZsb2F0 ZWQgYmxvY2sgY2F1c2VzIHRleHQgb2Ygc3Vic2VxdWVudCBibG9ja3MgdG8gb3ZlcmxhcCB0aGUg ZmxvYXRlZCBibG9jay4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTEyMTUzMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFdoZW4gcmVmYWN0b3JpbmcgdGhlIGNvZGUsIEkgZW5kZWQgdXAgYWRkaW5nIHRoZSBt YXJnaW4gaW4gaW5zdGVhZCBvZgorICAgICAgICBzdWJ0cmFjdGluZyBpdCBpbiB0aGUgY2FzZSBv ZiBhbiBpbnRydWRpbmcgZmxvYXQuIFRoaXMgcGF0Y2ggZml4ZXMKKyAgICAgICAgdGhhdCBzbyB0 aGF0IHRoZSBtYXJnaW4gaXMgcHJvcGVybHkgaGFuZGxlZC4KKworICAgICAgICBUZXN0OiBmYXN0 L2Jsb2NrL2Zsb2F0L2ludHJ1ZGluZy1mbG9hdC1zaWJsaW5nLXdpdGgtbWFyZ2luLmh0bWwKKwor ICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJCbG9jay5jcHA6CisgICAgICAgIChXZWJDb3JlOjpS ZW5kZXJCbG9jazo6YWRkSW50cnVkaW5nRmxvYXRzKToKKwogMjAxMy0wOS0xOCAgSmVyIE5vYmxl ICA8amVyLm5vYmxlQGFwcGxlLmNvbT4KIAogICAgICAgICBbTVNFXSBUaHJvdyBleGNlcHRpb24g d2hlbiBzZXR0aW5nIHRpbWVzdGFtcE9mZnNldCB3aGlsZSAndXBkYXRpbmcnIHN0YXRlIGlzIHNl dC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9jay5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwCmluZGV4IDRiNDFhMWVl NzQ5NTVkZDQyN2RlNDljNzg5MDU0NDVmYzc3MzJkMTIuLjE5NGQ3N2ZkMmYzNzMxNDdjMzJkY2Y0 YjViN2NjNzRkM2VkMDQyZjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJCbG9jay5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2Nr LmNwcApAQCAtMzg4Nyw4ICszODg3LDggQEAgdm9pZCBSZW5kZXJCbG9jazo6YWRkSW50cnVkaW5n RmxvYXRzKFJlbmRlckJsb2NrKiBwcmV2LCBMYXlvdXRVbml0IGxvZ2ljYWxMZWZ0T2YKICAgICAg ICAgICAgICAgICAvLyBpbnRvIGFjY291bnQuICBPbmx5IGFwcGx5IHRoaXMgY29kZSBpZiBwcmV2 IGlzIHRoZSBwYXJlbnQsIHNpbmNlIG90aGVyd2lzZSB0aGUgbGVmdCBtYXJnaW4KICAgICAgICAg ICAgICAgICAvLyB3aWxsIGdldCBhcHBsaWVkIHR3aWNlLgogICAgICAgICAgICAgICAgIExheW91 dFNpemUgb2Zmc2V0ID0gaXNIb3Jpem9udGFsV3JpdGluZ01vZGUoKQotICAgICAgICAgICAgICAg ICAgICA/IExheW91dFNpemUobG9naWNhbExlZnRPZmZzZXQgKyAocHJldiAhPSBwYXJlbnQoKSA/ IHByZXYtPm1hcmdpbkxlZnQoKSA6IExheW91dFVuaXQoKSksIGxvZ2ljYWxUb3BPZmZzZXQpCi0g ICAgICAgICAgICAgICAgICAgIDogTGF5b3V0U2l6ZShsb2dpY2FsVG9wT2Zmc2V0LCBsb2dpY2Fs TGVmdE9mZnNldCArIChwcmV2ICE9IHBhcmVudCgpID8gcHJldi0+bWFyZ2luVG9wKCkgOiBMYXlv dXRVbml0KCkpKTsKKyAgICAgICAgICAgICAgICAgICAgPyBMYXlvdXRTaXplKGxvZ2ljYWxMZWZ0 T2Zmc2V0IC0gKHByZXYgIT0gcGFyZW50KCkgPyBwcmV2LT5tYXJnaW5MZWZ0KCkgOiBMYXlvdXRV bml0KCkpLCBsb2dpY2FsVG9wT2Zmc2V0KQorICAgICAgICAgICAgICAgICAgICA6IExheW91dFNp emUobG9naWNhbFRvcE9mZnNldCwgbG9naWNhbExlZnRPZmZzZXQgLSAocHJldiAhPSBwYXJlbnQo KSA/IHByZXYtPm1hcmdpblRvcCgpIDogTGF5b3V0VW5pdCgpKSk7CiAKICAgICAgICAgICAgICAg ICBtX2Zsb2F0aW5nT2JqZWN0cy0+YWRkKHItPmNvcHlUb05ld0NvbnRhaW5lcihvZmZzZXQpKTsK ICAgICAgICAgICAgIH0KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91 dFRlc3RzL0NoYW5nZUxvZwppbmRleCAyY2I5OWM4ZmJmOWE3NzNjNDZiMGFiMjdiNTA0NWMyOWE3 MGU5NzQzLi5mZGQ3NTljNDIzODU1MjlhZWQxMmJmZWEwZmQzNWNjYWFhZjZiMGQ3IDEwMDY0NAot LS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTMgQEAKKzIwMTMtMDktMTggIEJlbSBKb25lcy1CZXkgIDxiam9uZXNiZUBhZG9i ZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTiAocjE1NTg1NCAtIHIxNTU5NjcpIGJsb2NrIHdp dGggbWFyZ2luLWxlZnQgYWRqYWNlbnQgdG8gZmxvYXRlZCBibG9jayBjYXVzZXMgdGV4dCBvZiBz dWJzZXF1ZW50IGJsb2NrcyB0byBvdmVybGFwIHRoZSBmbG9hdGVkIGJsb2NrLgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIxNTMyCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBmYXN0L2Jsb2NrL2Zsb2F0 L2ludHJ1ZGluZy1mbG9hdC1zaWJsaW5nLXdpdGgtbWFyZ2luLWV4cGVjdGVkLmh0bWw6IEFkZGVk LgorICAgICAgICAqIGZhc3QvYmxvY2svZmxvYXQvaW50cnVkaW5nLWZsb2F0LXNpYmxpbmctd2l0 aC1tYXJnaW4uaHRtbDogQWRkZWQuCisKIDIwMTMtMDktMTggIEZpbGlwIFBpemxvICA8ZnBpemxv QGFwcGxlLmNvbT4KIAogICAgICAgICBHZXQgcmlkIG9mIHRoZSBqc2MtdGVzdC1saXN0IGJ5IG1v dmluZyBhbGwgbm90LWpzYy1jYXBhYmxlIHRlc3RzIGludG8ganMvZG9tCmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9mYXN0L2Jsb2NrL2Zsb2F0L2ludHJ1ZGluZy1mbG9hdC1zaWJsaW5nLXdpdGgt bWFyZ2luLWV4cGVjdGVkLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2Jsb2NrL2Zsb2F0L2ludHJ1 ZGluZy1mbG9hdC1zaWJsaW5nLXdpdGgtbWFyZ2luLWV4cGVjdGVkLmh0bWwKbmV3IGZpbGUgbW9k ZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4u NDg3NDZmZjdiMmYyMmMwODBjY2M0OWMzYzYxOTFhZWY0MmZkMmFjNgotLS0gL2Rldi9udWxsCisr KyBiL0xheW91dFRlc3RzL2Zhc3QvYmxvY2svZmxvYXQvaW50cnVkaW5nLWZsb2F0LXNpYmxpbmct d2l0aC1tYXJnaW4tZXhwZWN0ZWQuaHRtbApAQCAtMCwwICsxLDI1IEBACis8IURPQ1RZUEUgaHRt bD4KKzxzdHlsZSB0eXBlPSJ0ZXh0L2NzcyI+CisgICAgI2NvbnRhaW5lciB7CisgICAgICAgIGZv bnQ6IDIwcHgvMSBBaGVtOworICAgICAgICBsaW5lLWhlaWdodDogMjBweDsKKyAgICAgICAgYmFj a2dyb3VuZC1jb2xvcjogcmVkOworICAgICAgICB3aWR0aDogNDBweDsKKyAgICAgICAgaGVpZ2h0 OiA0MHB4OworICAgICAgICBjb2xvcjogZ3JlZW47CisgICAgfQorICAgICNmbG9hdCB7CisgICAg ICAgIGZsb2F0OiBsZWZ0OworICAgICAgICB3aWR0aDogMjBweDsKKyAgICAgICAgaGVpZ2h0OiA0 MHB4OworICAgICAgICBiYWNrZ3JvdW5kOiBncmVlbjsKKyAgICB9Cis8L3N0eWxlPgorPGJvZHk+ CisgICAgPHA+WW91IHNob3VsZCBzZWUgYSBzaW5nbGUgZ3JlZW4gc3F1YXJlLiBZb3Ugc2hvdWxk IG5vdCBzZWUgYW55IHJlZC48L3A+CisgICAgPGRpdiBpZD0iY29udGFpbmVyIj4KKyAgICAgICAg PGRpdiBpZD0iZmxvYXQiPjwvZGl2PgorICAgICAgICA8ZGl2IGlkPSJ0ZXh0LW1hcmdpbiI+WDwv ZGl2PgorICAgICAgICA8ZGl2IGlkPSJ0ZXh0Ij5YPC9kaXY+CisgICAgPC9kaXY+Cis8L2JvZHk+ CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Jsb2NrL2Zsb2F0L2ludHJ1ZGluZy1mbG9h dC1zaWJsaW5nLXdpdGgtbWFyZ2luLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2Jsb2NrL2Zsb2F0 L2ludHJ1ZGluZy1mbG9hdC1zaWJsaW5nLXdpdGgtbWFyZ2luLmh0bWwKbmV3IGZpbGUgbW9kZSAx MDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uZGJm ODIyNzA1MzY5YmRjNWY2OWY1NDY5NzVkN2QzYjY3YTkzOWY0YgotLS0gL2Rldi9udWxsCisrKyBi L0xheW91dFRlc3RzL2Zhc3QvYmxvY2svZmxvYXQvaW50cnVkaW5nLWZsb2F0LXNpYmxpbmctd2l0 aC1tYXJnaW4uaHRtbApAQCAtMCwwICsxLDI4IEBACis8IURPQ1RZUEUgaHRtbD4KKzxzdHlsZSB0 eXBlPSJ0ZXh0L2NzcyI+CisgICAgI2NvbnRhaW5lciB7CisgICAgICAgIGZvbnQ6IDIwcHgvMSBB aGVtOworICAgICAgICBsaW5lLWhlaWdodDogMjBweDsKKyAgICAgICAgYmFja2dyb3VuZC1jb2xv cjogcmVkOworICAgICAgICB3aWR0aDogNDBweDsKKyAgICAgICAgaGVpZ2h0OiA0MHB4OworICAg ICAgICBjb2xvcjogZ3JlZW47CisgICAgfQorICAgICNmbG9hdCB7CisgICAgICAgIGZsb2F0OiBs ZWZ0OworICAgICAgICB3aWR0aDogMjBweDsKKyAgICAgICAgaGVpZ2h0OiA0MHB4OworICAgICAg ICBiYWNrZ3JvdW5kOiBncmVlbjsKKyAgICB9CisgICAgI3RleHQtbWFyZ2luIHsKKyAgICAgICAg bWFyZ2luLWxlZnQ6IDIwcHg7CisgICAgfQorPC9zdHlsZT4KKzxib2R5PgorICAgIDxwPllvdSBz aG91bGQgc2VlIGEgc2luZ2xlIGdyZWVuIHNxdWFyZS4gWW91IHNob3VsZCBub3Qgc2VlIGFueSBy ZWQuPC9wPgorICAgIDxkaXYgaWQ9ImNvbnRhaW5lciI+CisgICAgICAgIDxkaXYgaWQ9ImZsb2F0 Ij48L2Rpdj4KKyAgICAgICAgPGRpdiBpZD0idGV4dC1tYXJnaW4iPlg8L2Rpdj4KKyAgICAgICAg PGRpdiBpZD0idGV4dCI+WDwvZGl2PgorICAgIDwvZGl2PgorPC9ib2R5Pgo=