121521 2013-09-17 14:29:36 -0700 run-jsc-stress-tests fails with ruby version 2 2013-09-17 14:43:45 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 msaboff msaboff oldest_to_newest 930397 0 msaboff 2013-09-17 14:29:36 -0700 When running run-javascriptcore-tests with ruby version 2 installed, we get this error: Error: #<LoadError: cannot load such file -- highline> Tools/Scripts/run-jsc-stress-tests:330:in `block (4 levels) in <main>': invalid byte sequence in US-ASCII (ArgumentError) from Tools/Scripts/run-jsc-stress-tests:328:in `each_line' from Tools/Scripts/run-jsc-stress-tests:328:in `block (3 levels) in <main>' from Tools/Scripts/run-jsc-stress-tests:326:in `open' from Tools/Scripts/run-jsc-stress-tests:326:in `block (2 levels) in <main>' from Tools/Scripts/run-jsc-stress-tests:320:in `each' from Tools/Scripts/run-jsc-stress-tests:320:in `block in <main>' from Tools/Scripts/run-jsc-stress-tests:286:in `each' from Tools/Scripts/run-jsc-stress-tests:286:in `<main>' <rdar://problem/15010705> 930401 1 211944 msaboff 2013-09-17 14:36:26 -0700 Created attachment 211944 Patch It appears that ruby version 2 uses the LANG environment variable to figure what character set to use when reading a file. Setting to a UTF8 language makes ruby happy. 930407 2 msaboff 2013-09-17 14:43:45 -0700 Committed r155999: <http://trac.webkit.org/changeset/155999> 211944 2013-09-17 14:36:26 -0700 2013-09-17 14:39:41 -0700 Patch 121521.patch text/plain 1291 msaboff SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE1NTk5NykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDEzLTA5LTE3ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29t PgorCisgICAgICAgIHJ1bi1qc2Mtc3RyZXNzLXRlc3RzIGZhaWxzIHdpdGggcnVieSB2ZXJzaW9u IDIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMTUy MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEV4cGxp Y2l0bHkgc2V0IExBTkcgdG8gZW5fVVMuVVRCLTggYmVmb3JlIHN0YXJ0aW5nIHJ1bi1qc2Mtc3Ry ZXNzLXRlc3RzLgorCisgICAgICAgICogU2NyaXB0cy9ydW4tamF2YXNjcmlwdGNvcmUtdGVzdHM6 CisKIDIwMTMtMDktMTcgIEJyZW50IEZ1bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CiAKICAg ICAgICAgW1dpbmRvd3NdIFVucmV2aWV3ZWQgYnVpbGQgZml4IGFmdGVyIHIxNTU5NjMuCkluZGV4 OiBUb29scy9TY3JpcHRzL3J1bi1qYXZhc2NyaXB0Y29yZS10ZXN0cwo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBU b29scy9TY3JpcHRzL3J1bi1qYXZhc2NyaXB0Y29yZS10ZXN0cwkocmV2aXNpb24gMTU1OTkwKQor KysgVG9vbHMvU2NyaXB0cy9ydW4tamF2YXNjcmlwdGNvcmUtdGVzdHMJKHdvcmtpbmcgY29weSkK QEAgLTIzOCw2ICsyMzgsOCBAQCBpZiAoJHJ1bkxheW91dCkgewogbXkgJGpzY1N0cmVzc1Jlc3Vs dHNEaXIgPSAkcHJvZHVjdERpciAuICIvanNjLXN0cmVzcy1yZXN1bHRzIjsKIAogaWYgKCRydW5K U0NTdHJlc3MpIHsKKyAgICAjIFNldCBMQU5HIGVudmlyb25tZW50IHZhcmlhYmxlIHNvIHRoZSBz dHJlc3MgdGVzdHMgd2lsbCB3b3JrIHdpdGggbmV3ZXIgcnVieSAoPHJkYXI6Ly9wcm9ibGVtLzE1 MDEwNzA1PikKKyAgICAkRU5We0xBTkd9PSJlbl9VUy5VVEItOCI7CiAgICAgbXkgQGpzY1N0cmVz c0RyaXZlckNtZCA9ICgKICAgICAgICAgIi91c3IvYmluL2VudiIsICJydWJ5IiwgIlRvb2xzL1Nj cmlwdHMvcnVuLWpzYy1zdHJlc3MtdGVzdHMiLAogICAgICAgICAiLWoiLCBqc2NQYXRoKCRwcm9k dWN0RGlyKSwgIi1vIiwgJGpzY1N0cmVzc1Jlc3VsdHNEaXIsCg==