121520 2013-09-17 14:26:31 -0700 DFG should use the (x & 0x7fffffff) trick for doing overflow and neg-zero checks on negation in one go 2013-09-17 18:03:50 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 fpizlo fpizlo barraclough ggaren mark.lam mhahnenberg msaboff oliver sam oldest_to_newest 930395 0 fpizlo 2013-09-17 14:26:31 -0700 The baseline JIT uses it already. It's a silly oversight that the DFG doesn't. 930396 1 211942 fpizlo 2013-09-17 14:27:18 -0700 Created attachment 211942 the patch 930465 2 fpizlo 2013-09-17 18:03:50 -0700 Landed in http://trac.webkit.org/changeset/156016 211942 2013-09-17 14:27:18 -0700 2013-09-17 14:51:33 -0700 the patch blah.patch text/plain 3074 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTU1OTk3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBA CisyMDEzLTA5LTE3ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg REZHIHNob3VsZCB1c2UgdGhlICh4ICYgMHg3ZmZmZmZmZikgdHJpY2sgZm9yIGRvaW5nIG92ZXJm bG93IGFuZCBuZWctemVybyBjaGVja3Mgb24gbmVnYXRpb24gaW4gb25lIGdvCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjE1MjAKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGRmZy9ERkdTcGVjdWxhdGl2 ZUpJVC5jcHA6CisgICAgICAgIChKU0M6OkRGRzo6U3BlY3VsYXRpdmVKSVQ6OmNvbXBpbGVBcml0 aE5lZ2F0ZSk6CisgICAgICAgICogZnRsL0ZUTExvd2VyREZHVG9MTFZNLmNwcDoKKyAgICAgICAg KEpTQzo6RlRMOjpMb3dlckRGR1RvTExWTTo6Y29tcGlsZUFyaXRoTmVnYXRlKToKKwogMjAxMy0w OS0xNyAgRmlsaXAgUGl6bG8gIDxmcGl6bG9AYXBwbGUuY29tPgogCiAgICAgICAgIERvbid0IEdD IHdoaWxlIE9TUiBjb21waWxpbmcKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZH U3BlY3VsYXRpdmVKSVQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9k ZmcvREZHU3BlY3VsYXRpdmVKSVQuY3BwCShyZXZpc2lvbiAxNTU5ODUpCisrKyBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvZGZnL0RGR1NwZWN1bGF0aXZlSklULmNwcAkod29ya2luZyBjb3B5KQpAQCAt MzA5MCwxMCArMzA5MCwxMSBAQCB2b2lkIFNwZWN1bGF0aXZlSklUOjpjb21waWxlQXJpdGhOZWdh dGUoCiAKICAgICAgICAgaWYgKGJ5dGVjb2RlQ2FuVHJ1bmNhdGVJbnRlZ2VyKG5vZGUtPmFyaXRo Tm9kZUZsYWdzKCkpKQogICAgICAgICAgICAgbV9qaXQubmVnMzIocmVzdWx0LmdwcigpKTsKLSAg ICAgICAgZWxzZSB7CisgICAgICAgIGVsc2UgaWYgKGJ5dGVjb2RlQ2FuSWdub3JlTmVnYXRpdmVa ZXJvKG5vZGUtPmFyaXRoTm9kZUZsYWdzKCkpKQogICAgICAgICAgICAgc3BlY3VsYXRpb25DaGVj ayhPdmVyZmxvdywgSlNWYWx1ZVJlZ3MoKSwgMCwgbV9qaXQuYnJhbmNoTmVnMzIoTWFjcm9Bc3Nl bWJsZXI6Ok92ZXJmbG93LCByZXN1bHQuZ3ByKCkpKTsKLSAgICAgICAgICAgIGlmICghYnl0ZWNv ZGVDYW5JZ25vcmVOZWdhdGl2ZVplcm8obm9kZS0+YXJpdGhOb2RlRmxhZ3MoKSkpCi0gICAgICAg ICAgICAgICAgc3BlY3VsYXRpb25DaGVjayhOZWdhdGl2ZVplcm8sIEpTVmFsdWVSZWdzKCksIDAs IG1faml0LmJyYW5jaFRlc3QzMihNYWNyb0Fzc2VtYmxlcjo6WmVybywgcmVzdWx0LmdwcigpKSk7 CisgICAgICAgIGVsc2UgeworICAgICAgICAgICAgc3BlY3VsYXRpb25DaGVjayhPdmVyZmxvdywg SlNWYWx1ZVJlZ3MoKSwgMCwgbV9qaXQuYnJhbmNoVGVzdDMyKE1hY3JvQXNzZW1ibGVyOjpaZXJv LCByZXN1bHQuZ3ByKCksIFRydXN0ZWRJbW0zMigweDdmZmZmZmZmKSkpOworICAgICAgICAgICAg bV9qaXQubmVnMzIocmVzdWx0LmdwcigpKTsKICAgICAgICAgfQogCiAgICAgICAgIGludDMyUmVz dWx0KHJlc3VsdC5ncHIoKSwgbm9kZSk7CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZnRs L0ZUTExvd2VyREZHVG9MTFZNLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENv cmUvZnRsL0ZUTExvd2VyREZHVG9MTFZNLmNwcAkocmV2aXNpb24gMTU1OTg1KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL2Z0bC9GVExMb3dlckRGR1RvTExWTS5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTEwMTcsMTMgKzEwMTcsMTUgQEAgcHJpdmF0ZToKICAgICAgICAgICAgIExWYWx1ZSByZXN1 bHQ7CiAgICAgICAgICAgICBpZiAoYnl0ZWNvZGVDYW5UcnVuY2F0ZUludGVnZXIobV9ub2RlLT5h cml0aE5vZGVGbGFncygpKSkKICAgICAgICAgICAgICAgICByZXN1bHQgPSBtX291dC5uZWcodmFs dWUpOwotICAgICAgICAgICAgZWxzZSB7CisgICAgICAgICAgICBlbHNlIGlmIChieXRlY29kZUNh bklnbm9yZU5lZ2F0aXZlWmVybyhtX25vZGUtPmFyaXRoTm9kZUZsYWdzKCkpKSB7CiAgICAgICAg ICAgICAgICAgLy8gV2UgZG9uJ3QgaGF2ZSBhIG5lZ2F0ZS13aXRoLW92ZXJmbG93IGludHJpbnNp Yy4gSG9wZWZ1bGx5IHRoaXMKICAgICAgICAgICAgICAgICAvLyBkb2VzIHRoZSB0cmljaywgdGhv dWdoLgogICAgICAgICAgICAgICAgIExWYWx1ZSBvdmVyZmxvd1Jlc3VsdCA9IG1fb3V0LnN1Yldp dGhPdmVyZmxvdzMyKG1fb3V0LmludDMyWmVybywgdmFsdWUpOwogICAgICAgICAgICAgICAgIHNw ZWN1bGF0ZShPdmVyZmxvdywgbm9WYWx1ZSgpLCAwLCBtX291dC5leHRyYWN0VmFsdWUob3ZlcmZs b3dSZXN1bHQsIDEpKTsKICAgICAgICAgICAgICAgICByZXN1bHQgPSBtX291dC5leHRyYWN0VmFs dWUob3ZlcmZsb3dSZXN1bHQsIDApOwotICAgICAgICAgICAgICAgIHNwZWN1bGF0ZShOZWdhdGl2 ZVplcm8sIG5vVmFsdWUoKSwgMCwgbV9vdXQuaXNaZXJvMzIocmVzdWx0KSk7CisgICAgICAgICAg ICB9IGVsc2UgeworICAgICAgICAgICAgICAgIHNwZWN1bGF0ZShPdmVyZmxvdywgbm9WYWx1ZSgp LCAwLCBtX291dC50ZXN0SXNaZXJvMzIodmFsdWUsIG1fb3V0LmNvbnN0SW50MzIoMHg3ZmZmZmZm ZikpKTsKKyAgICAgICAgICAgICAgICByZXN1bHQgPSBtX291dC5uZWcodmFsdWUpOwogICAgICAg ICAgICAgfQogICAgICAgICAgICAgCiAgICAgICAgICAgICBzZXRJbnQzMihyZXN1bHQpOwo=