121518 2013-09-17 14:15:37 -0700 The way FixupPhase uses alwaysUnboxSimplePrimitives() is almost certainly wrong 2013-09-17 14:15:37 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All NEW P2 Normal --- 1 fpizlo fpizlo barraclough ggaren mark.lam mhahnenberg msaboff oliver sam oldest_to_newest 930386 0 fpizlo 2013-09-17 14:15:37 -0700 What it wants to do is say that even if a local isn't used as a simple primitive but is predicted to be a simple primitive, then it should be unboxed. But what the logic currently does is asks for a local to be unboxed even if it's not predicted to have a type that is a candidate for unboxing; i.e. it accomplishes nothing. More likely it should walk all locals up-front and if they have a "simple primitive" prediction and alwaysUnboxSimplePrimitives() is true, then mark them as being profitable.