121501 2013-09-17 09:55:18 -0700 [CSS Regions] Layout Test for selection direction 2013-09-17 11:03:41 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 118668 1 rego rego commit-queue jfernandez mihnea WebkitBugTracker oldest_to_newest 930275 0 rego 2013-09-17 09:55:18 -0700 Selection is based in DOM tree, so if have the following HTML structure: <div id="source" style="-webkit-flow-into: content;">inside region inside region inside region</div> <div id="outside-region">outside region outside region outside region</div> <div id="region" style="-webkit-flow-from: content;"></div> If you select text from "outside region" to "inside region" the highlighted area is exactly the opposite to what the user is actually selecting. This might seem weird from the user point of view, but it is ok following the DOM tree according to editing specs (https://dvcs.w3.org/hg/editing/raw-file/tip/editing.html). This was not working since r139197 (because of it didn't allow to select content from different flow threads) and it got fixed in r155058. So, we should add a Layout Test to avoid break it again in the future without noticing. 930282 1 211920 rego 2013-09-17 10:04:26 -0700 Created attachment 211920 Patch 930309 2 211920 commit-queue 2013-09-17 11:03:38 -0700 Comment on attachment 211920 Patch Clearing flags on attachment: 211920 Committed r155974: <http://trac.webkit.org/changeset/155974> 930310 3 commit-queue 2013-09-17 11:03:41 -0700 All reviewed patches have been landed. Closing bug. 211920 2013-09-17 10:04:26 -0700 2013-09-17 11:03:38 -0700 Patch bug-121501-20130917190552.patch text/plain 4563 rego U3VidmVyc2lvbiBSZXZpc2lvbjogMTU1OTI5CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNThhMjhjZDk5Y2M2NTUzNzQ0NjRk ODgzZjUwOTNlYjJjNDY4MjllNi4uOTYwNzg4MWNkNDg3YmJmYTIzNmU4Y2E1OGM2OTU0YzIwOWZj NTNjYyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEzLTA5LTE3ICBNYW51ZWwgUmVnbyBDYXNh c25vdmFzICA8cmVnb0BpZ2FsaWEuY29tPgorCisgICAgICAgIFtDU1MgUmVnaW9uc10gTGF5b3V0 IFRlc3QgZm9yIHNlbGVjdGlvbiBkaXJlY3Rpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMTUwMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFNlbGVjdGlvbiBmb2xsb3dzIERPTSB0cmVlLCBzbyB0aGUg aGlnaGxpZ2h0ZWQgdGV4dCBpbiB0aGlzIHRlc3QgY2FzZSBpcworICAgICAgICB0aGUgb3Bwb3Np dGUgdG8gd2hhdCB0aGUgdXNlciBpcyBhY3R1YWxseSBzZWxlY3RpbmcuIFRoaXMgd2FzIG5vdAor ICAgICAgICB3b3JraW5nIHByb3Blcmx5IGZyb20gcjEzOTE5NyB0byByMTU1MDU4LCBzbyBhZGRp bmcgYSBMYXlvdXQgVGVzdCB0bworICAgICAgICBwcmV2ZW50IGZ1dHVyZSBicmVha3MuIEl0IGlz IGEgcmVmdGVzdCBjb21wYXJpbmcgcmVnaW9ucyBhbmQgYWJzb2x1dGUKKyAgICAgICAgcG9zaXRp b25zIGJlaGF2aW9yLgorCisgICAgICAgICogZmFzdC9yZWdpb25zL3NlbGVjdGlvbi1kaXJlY3Rp b24tZXhwZWN0ZWQuaHRtbDogQWRkZWQuCisgICAgICAgICogZmFzdC9yZWdpb25zL3NlbGVjdGlv bi1kaXJlY3Rpb24uaHRtbDogQWRkZWQuCisKIDIwMTMtMDktMTYgIENocmlzIEZsZWl6YWNoICA8 Y2ZsZWl6YWNoQGFwcGxlLmNvbT4KIAogICAgICAgICBBWDogQVJJQSB0YWJsaXN0IGlzIGRpc2Fi bGVkLCBidXQgVm9pY2VPdmVyIGRvZXMgbm90IHNwZWFrIHRoZSB0YWJzIGFzIGRpbW1lZApkaWZm IC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9yZWdpb25zL3NlbGVjdGlvbi1kaXJlY3Rpb24tZXhw ZWN0ZWQuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvcmVnaW9ucy9zZWxlY3Rpb24tZGlyZWN0aW9u LWV4cGVjdGVkLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uMGJmMzUyZTQ1YTk5MmRjYmVhNTMzNTZiNTIyY2Q0 NzFmMzM1OWQyMAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvcmVnaW9ucy9z ZWxlY3Rpb24tZGlyZWN0aW9uLWV4cGVjdGVkLmh0bWwKQEAgLTAsMCArMSw0OCBAQAorPGh0bWw+ Cis8aGVhZD4KKyAgICA8c3R5bGU+CisgICAgICAgICNyZWdpb24geworICAgICAgICAgICAgaGVp Z2h0OiAxMDBweDsKKyAgICAgICAgICAgIHdpZHRoOiAyMDBweDsKKyAgICAgICAgICAgIHBvc2l0 aW9uOiBhYnNvbHV0ZTsKKyAgICAgICAgICAgIHRvcDogMTAwcHg7CisgICAgICAgIH0KKworICAg ICAgICAjb3V0c2lkZSB7CisgICAgICAgICAgICBoZWlnaHQ6IDEwMHB4OworICAgICAgICAgICAg d2lkdGg6IDIwMHB4OworICAgICAgICAgICAgcG9zaXRpb246IGFic29sdXRlOworICAgICAgICAg ICAgdG9wOiAwcHg7CisgICAgICAgIH0KKworICAgICAgICBib2R5IHsKKyAgICAgICAgICAgIG1h cmdpbi10b3A6IDA7CisgICAgICAgIH0KKworICAgICAgICAjZGVzY3JpcHRpb24geworICAgICAg ICAgICAgd2lkdGg6IDYwMHB4OworICAgICAgICAgICAgcG9zaXRpb246IGFic29sdXRlOworICAg ICAgICAgICAgdG9wOiAyMDBweDsKKyAgICAgICAgfQorICAgIDwvc3R5bGU+CisgICAgPHNjcmlw dD4KKyAgICAgICAgZnVuY3Rpb24gc2VsZWN0VGV4dCgpIHsKKyAgICAgICAgICAgIGlmICh3aW5k b3cudGVzdFJ1bm5lcikgeworICAgICAgICAgICAgICAgIGV2ZW50U2VuZGVyLm1vdXNlTW92ZVRv KDEwMCwgMTApOworICAgICAgICAgICAgICAgIGV2ZW50U2VuZGVyLm1vdXNlRG93bigpOworCisg ICAgICAgICAgICAgICAgZXZlbnRTZW5kZXIubW91c2VNb3ZlVG8oMTAwLCAxMTApOworICAgICAg ICAgICAgICAgIGV2ZW50U2VuZGVyLm1vdXNlVXAoKTsKKyAgICAgICAgICAgIH0KKyAgICAgICAg fQorICAgIDwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHkgb25sb2FkPSJzZWxlY3RUZXh0KCk7Ij4K KyAgICA8ZGl2IGlkPSJyZWdpb24iPmluc2lkZSByZWdpb24gaW5zaWRlIHJlZ2lvbiBpbnNpZGUg cmVnaW9uIGluc2lkZSByZWdpb248L2Rpdj4KKyAgICA8ZGl2IGlkPSJvdXRzaWRlIj5vdXRzaWRl IHJlZ2lvbiBvdXRzaWRlIHJlZ2lvbiBvdXRzaWRlIHJlZ2lvbiBvdXRzaWRlIHJlZ2lvbjwvZGl2 PgorICAgIDxkaXYgaWQ9ImRlc2NyaXB0aW9uIj4KKyAgICAgICAgPGgxPjxhIGhyZWY9Imh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjE1MDEiPkJ1ZyAjMTIxNTAxIC0g W0NTUyBSZWdpb25zXSBMYXlvdXQgVGVzdCBmb3Igc2VsZWN0aW9uIGRpcmVjdGlvbjwvYT48L2gx PgorICAgICAgICA8cD5TZWxlY3Rpb24gaXMgYmFzZWQgaW4gRE9NIHRyZWUsIHNvIGlmIHlvdSBz ZWxlY3QgdGV4dCBmcm9tICJvdXRpc2UgcmVnaW9uIiB0byAiaW5zaWRlIHJlZ2lvbiIgdGhlIGhp Z2hsaWdodGVkIGFyZWEgaXMgZXhhY3RseSB0aGUgb3Bwb3NpdGUgdG8gd2hhdCB0aGUgdXNlciBp cyBhY3R1YWxseSBzZWxlY3RpbmcuPC9wPgorICAgIDwvZGl2PgorPC9ib2R5PgorPC9odG1sPgpk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9yZWdpb25zL3NlbGVjdGlvbi1kaXJlY3Rpb24u aHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvcmVnaW9ucy9zZWxlY3Rpb24tZGlyZWN0aW9uLmh0bWwK bmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMC4uODVlN2IyMWM4ODQ4MDlhMTc2ZDM3MjFlNDBhOTUwYzJiOTBhNzg3NAotLS0g L2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvcmVnaW9ucy9zZWxlY3Rpb24tZGlyZWN0 aW9uLmh0bWwKQEAgLTAsMCArMSw0OCBAQAorPGh0bWw+Cis8aGVhZD4KKyAgICA8c3R5bGU+Cisg ICAgICAgICNzb3VyY2UgeworICAgICAgICAgICAgLXdlYmtpdC1mbG93LWludG86IGNvbnRlbnQ7 CisgICAgICAgIH0KKworICAgICAgICAjcmVnaW9uIHsKKyAgICAgICAgICAgIC13ZWJraXQtZmxv dy1mcm9tOiBjb250ZW50OworICAgICAgICAgICAgaGVpZ2h0OiAxMDBweDsKKyAgICAgICAgICAg IHdpZHRoOiAyMDBweDsKKyAgICAgICAgfQorCisgICAgICAgICNvdXRzaWRlIHsKKyAgICAgICAg ICAgIGhlaWdodDogMTAwcHg7CisgICAgICAgICAgICB3aWR0aDogMjAwcHg7CisgICAgICAgIH0K KworICAgICAgICBib2R5IHsKKyAgICAgICAgICAgIG1hcmdpbi10b3A6IDA7CisgICAgICAgIH0K KworICAgICAgICAjZGVzY3JpcHRpb24geworICAgICAgICAgICAgd2lkdGg6IDYwMHB4OworICAg ICAgICB9CisgICAgPC9zdHlsZT4KKyAgICA8c2NyaXB0PgorICAgICAgICBmdW5jdGlvbiBzZWxl Y3RUZXh0KCkgeworICAgICAgICAgICAgaWYgKHdpbmRvdy50ZXN0UnVubmVyKSB7CisgICAgICAg ICAgICAgICAgZXZlbnRTZW5kZXIubW91c2VNb3ZlVG8oMTAwLCAxMCk7CisgICAgICAgICAgICAg ICAgZXZlbnRTZW5kZXIubW91c2VEb3duKCk7CisKKyAgICAgICAgICAgICAgICBldmVudFNlbmRl ci5tb3VzZU1vdmVUbygxMDAsIDExMCk7CisgICAgICAgICAgICAgICAgZXZlbnRTZW5kZXIubW91 c2VVcCgpOworICAgICAgICAgICAgfQorICAgICAgICB9CisgICAgPC9zY3JpcHQ+Cis8L2hlYWQ+ Cis8Ym9keSBvbmxvYWQ9InNlbGVjdFRleHQoKTsiPgorICAgIDxkaXYgaWQ9InNvdXJjZSI+aW5z aWRlIHJlZ2lvbiBpbnNpZGUgcmVnaW9uIGluc2lkZSByZWdpb24gaW5zaWRlIHJlZ2lvbjwvZGl2 PgorICAgIDxkaXYgaWQ9Im91dHNpZGUiPm91dHNpZGUgcmVnaW9uIG91dHNpZGUgcmVnaW9uIG91 dHNpZGUgcmVnaW9uIG91dHNpZGUgcmVnaW9uPC9kaXY+CisgICAgPGRpdiBpZD0icmVnaW9uIj48 L2Rpdj4KKyAgICA8ZGl2IGlkPSJkZXNjcmlwdGlvbiI+CisgICAgICAgIDxoMT48YSBocmVmPSJo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIxNTAxIj5CdWcgIzEyMTUw MSAtIFtDU1MgUmVnaW9uc10gTGF5b3V0IFRlc3QgZm9yIHNlbGVjdGlvbiBkaXJlY3Rpb248L2E+ PC9oMT4KKyAgICAgICAgPHA+U2VsZWN0aW9uIGlzIGJhc2VkIGluIERPTSB0cmVlLCBzbyBpZiB5 b3Ugc2VsZWN0IHRleHQgZnJvbSAib3V0aXNlIHJlZ2lvbiIgdG8gImluc2lkZSByZWdpb24iIHRo ZSBoaWdobGlnaHRlZCBhcmVhIGlzIGV4YWN0bHkgdGhlIG9wcG9zaXRlIHRvIHdoYXQgdGhlIHVz ZXIgaXMgYWN0dWFsbHkgc2VsZWN0aW5nLjwvcD4KKyAgICA8L2Rpdj4KKzwvYm9keT4KKzwvaHRt bD4K