121498 2013-09-17 09:41:06 -0700 Make SVGTransform::valueAsString use StringBuilder 2013-09-18 18:28:33 -0700 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 darin darin benjamin cmarcelo commit-queue d-r fmalita pdr schenney zimmermann oldest_to_newest 930264 0 darin 2013-09-17 09:41:06 -0700 Make SVGTransform::valueAsString use StringBuilder 930265 1 211915 darin 2013-09-17 09:43:15 -0700 Created attachment 211915 Patch 930284 2 darin 2013-09-17 10:08:14 -0700 Committed r155968: <http://trac.webkit.org/changeset/155968> 930339 3 ap 2013-09-17 12:06:50 -0700 This broke a regression test, fixed in <http://trac.webkit.org/r155982>. Mac EWS was doing a pretty good job on this, it had failing results soon after the patch landed. 930805 4 darin 2013-09-18 18:28:33 -0700 Thanks Alexey. Really sorry I didn’t notice it on EWS. 211915 2013-09-17 09:43:15 -0700 2013-09-17 09:52:33 -0700 Patch bug-121498-20130917094314.patch text/plain 7268 darin U3VidmVyc2lvbiBSZXZpc2lvbjogMTU1OTYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDc5NzQ5YTQ4NGNjZDYwMzRiYjcxNzAw ZTA5MWUxYmFkYmY0NWUzZWQuLmUzNzk4ZmIyYmQ1ZjhiMDFkMGFmYmMxODY0NmQwNmVmZGEyZjFh MjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTMtMDktMTcgIERhcmluIEFkbGVyICA8ZGFyaW5A YXBwbGUuY29tPgorCisgICAgICAgIE1ha2UgU1ZHVHJhbnNmb3JtOjp2YWx1ZUFzU3RyaW5nIHVz ZSBTdHJpbmdCdWlsZGVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMjE0OTgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIHd0Zi90ZXh0L1N0cmluZ0J1aWxkZXIuY3BwOiBBZGRlZCBhcHBlbmROdW1iZXIg ZnVuY3Rpb25zIGNvcnJlc3BvbmRpbmcgdG8gYWxsIHJlbWFpbmluZworICAgICAgICBTdHJpbmc6 Om51bWJlciBmdW5jdGlvbnMuIElmIHdlIGZpbmQgd2UgZG9uJ3QgbmVlZCBhbGwgb2YgdGhlc2Ug d2UgY2FuIGRlbGV0ZSB0aGVtIGxhdGVyLAorICAgICAgICBidXQgSSBkb24ndCB3YW50IHRvIGdp dmUgY2xpZW50cyBhIHJlYXNvbiB0byBwcmVmZXIgbGVzcy1lZmZpY2llbnQgQVBJIHRvIFN0cmlu Z0J1aWxkZXIuCisgICAgICAgICogd3RmL3RleHQvU3RyaW5nQnVpbGRlci5oOiBEaXR0by4KKwog MjAxMy0wOS0xNiAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCiAgICAg ICAgIEhhc2hNYXAgc2hvdWxkIHdvcmsgd2l0aCBtb3ZlLW9ubHkga2V5cwpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4 IDMwMzBkNzJkNTVkNTI5ZmNhZDBhMTBjMTc0ODUyZDI1MTU2MmU2NjAuLjc3NGU3ODAyNmNhOGZj MzI3YTAyMmI5ZmJjZmFkODU5ZGVhNjIwNmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAor MjAxMy0wOS0xNyAgRGFyaW4gQWRsZXIgIDxkYXJpbkBhcHBsZS5jb20+CisKKyAgICAgICAgTWFr ZSBTVkdUcmFuc2Zvcm06OnZhbHVlQXNTdHJpbmcgdXNlIFN0cmluZ0J1aWxkZXIKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMTQ5OAorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogc3ZnL1NWR1RyYW5zZm9y bS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTVkdUcmFuc2Zvcm06OnZhbHVlQXNTdHJpbmcpOiBV c2UgU3RyaW5nQnVpbGRlciBjb25zdGVudGx5IHRvCisgICAgICAgIGF2b2lkIGNyZWF0aW5nIHRl bXBvcmFyeSBTdHJpbmcgb2JqZWN0cyB0aGF0IGNhdXNlIGFkZGl0aW9uYWwsIHNsb3cKKyAgICAg ICAgbWVtb3J5IGFsbG9jYXRpb24uCisKIDIwMTMtMDktMTYgIEFuZGVycyBDYXJsc3NvbiAgPGFu ZGVyc2NhQGFwcGxlLmNvbT4KIAogICAgICAgICBIYXNoTWFwIHNob3VsZCB3b3JrIHdpdGggbW92 ZS1vbmx5IGtleXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL3RleHQvU3RyaW5nQnVpbGRl ci5jcHAgYi9Tb3VyY2UvV1RGL3d0Zi90ZXh0L1N0cmluZ0J1aWxkZXIuY3BwCmluZGV4IDc0NWJj YTZlM2E5MmI0NzU5MjQ3MDg4NTk0NTM2MmIzNjFjOWI0YzcuLmI2NzIxNDkyZTYyZTNmMTI0MTNk N2FlNmRhZTcyNDQzMTQwYjc4NmQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL3RleHQvU3Ry aW5nQnVpbGRlci5jcHAKKysrIGIvU291cmNlL1dURi93dGYvdGV4dC9TdHJpbmdCdWlsZGVyLmNw cApAQCAtMjksNiArMjksNyBAQAogCiAjaW5jbHVkZSAiSW50ZWdlclRvU3RyaW5nQ29udmVyc2lv bi5oIgogI2luY2x1ZGUgIldURlN0cmluZy5oIgorI2luY2x1ZGUgPHd0Zi9kdG9hLmg+CiAKIG5h bWVzcGFjZSBXVEYgewogCkBAIC0zMjgsNiArMzI5LDI0IEBAIHZvaWQgU3RyaW5nQnVpbGRlcjo6 YXBwZW5kTnVtYmVyKHVuc2lnbmVkIGxvbmcgbG9uZyBudW1iZXIpCiAgICAgbnVtYmVyVG9TdHJp bmdVbnNpZ25lZDxTdHJpbmdCdWlsZGVyPihudW1iZXIsIHRoaXMpOwogfQogCit2b2lkIFN0cmlu Z0J1aWxkZXI6OmFwcGVuZE51bWJlcihkb3VibGUgbnVtYmVyLCB1bnNpZ25lZCBwcmVjaXNpb24s IFRyYWlsaW5nWmVyb3NUcnVuY2F0aW5nUG9saWN5IHRyYWlsaW5nWmVyb3NUcnVuY2F0aW5nUG9s aWN5KQoreworICAgIE51bWJlclRvU3RyaW5nQnVmZmVyIGJ1ZmZlcjsKKyAgICBhcHBlbmQobnVt YmVyVG9GaXhlZFByZWNpc2lvblN0cmluZyhudW1iZXIsIHByZWNpc2lvbiwgYnVmZmVyLCB0cmFp bGluZ1plcm9zVHJ1bmNhdGluZ1BvbGljeSA9PSBUcnVuY2F0ZVRyYWlsaW5nWmVyb3MpKTsKK30K Kwordm9pZCBTdHJpbmdCdWlsZGVyOjphcHBlbmRFQ01BU2NyaXB0TnVtYmVyKGRvdWJsZSBudW1i ZXIpCit7CisgICAgTnVtYmVyVG9TdHJpbmdCdWZmZXIgYnVmZmVyOworICAgIGFwcGVuZChudW1i ZXJUb1N0cmluZyhudW1iZXIsIGJ1ZmZlcikpOworfQorCit2b2lkIFN0cmluZ0J1aWxkZXI6OmFw cGVuZEZpeGVkV2lkdGhOdW1iZXIoZG91YmxlIG51bWJlciwgdW5zaWduZWQgZGVjaW1hbFBsYWNl cykKK3sKKyAgICBOdW1iZXJUb1N0cmluZ0J1ZmZlciBidWZmZXI7CisgICAgYXBwZW5kKG51bWJl clRvRml4ZWRXaWR0aFN0cmluZyhudW1iZXIsIGRlY2ltYWxQbGFjZXMsIGJ1ZmZlcikpOworfQor CiBib29sIFN0cmluZ0J1aWxkZXI6OmNhblNocmluaygpIGNvbnN0CiB7CiAgICAgLy8gT25seSBz aHJpbmsgdGhlIGJ1ZmZlciBpZiBpdCdzIGxlc3MgdGhhbiA4MCUgZnVsbC4gTmVlZCB0byB0dW5l IHRoaXMgaGV1cmlzdGljIQpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvdGV4dC9TdHJpbmdC dWlsZGVyLmggYi9Tb3VyY2UvV1RGL3d0Zi90ZXh0L1N0cmluZ0J1aWxkZXIuaAppbmRleCBjZjc3 ZDYxZDA1N2VlYzUzNzlhNWI3NTYwYzAyZjI0Y2MxZGVjZDc5Li5mNTM0NGNiOWRiNjdjMWRiYmNj MjdmYTg5YmFiMDNhNmMyYjIyNDlkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi90ZXh0L1N0 cmluZ0J1aWxkZXIuaAorKysgYi9Tb3VyY2UvV1RGL3d0Zi90ZXh0L1N0cmluZ0J1aWxkZXIuaApA QCAtMTYwLDYgKzE2MCw5IEBAIHB1YmxpYzoKICAgICBXVEZfRVhQT1JUX1BSSVZBVEUgdm9pZCBh cHBlbmROdW1iZXIodW5zaWduZWQgbG9uZyk7CiAgICAgV1RGX0VYUE9SVF9QUklWQVRFIHZvaWQg YXBwZW5kTnVtYmVyKGxvbmcgbG9uZyk7CiAgICAgV1RGX0VYUE9SVF9QUklWQVRFIHZvaWQgYXBw ZW5kTnVtYmVyKHVuc2lnbmVkIGxvbmcgbG9uZyk7CisgICAgV1RGX0VYUE9SVF9QUklWQVRFIHZv aWQgYXBwZW5kTnVtYmVyKGRvdWJsZSwgdW5zaWduZWQgcHJlY2lzaW9uID0gNiwgVHJhaWxpbmda ZXJvc1RydW5jYXRpbmdQb2xpY3kgPSBUcnVuY2F0ZVRyYWlsaW5nWmVyb3MpOworICAgIFdURl9F WFBPUlRfUFJJVkFURSB2b2lkIGFwcGVuZEVDTUFTY3JpcHROdW1iZXIoZG91YmxlKTsKKyAgICBX VEZfRVhQT1JUX1BSSVZBVEUgdm9pZCBhcHBlbmRGaXhlZFdpZHRoTnVtYmVyKGRvdWJsZSwgdW5z aWduZWQgZGVjaW1hbFBsYWNlcyk7CiAKICAgICBTdHJpbmcgdG9TdHJpbmcoKQogICAgIHsKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3N2Zy9TVkdUcmFuc2Zvcm0uY3BwIGIvU291cmNlL1dl YkNvcmUvc3ZnL1NWR1RyYW5zZm9ybS5jcHAKaW5kZXggMjBkNmU4ODk0NGM1ZjJiMjk2OWJjYmFk MzkzMWYzODM1MDMwYjc4ZC4uMDkyMzhhNjFjZmIwY2ZlMDM3NzIzMTA4ZjFmOWY2MDBlODZiYzY1 MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvc3ZnL1NWR1RyYW5zZm9ybS5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvc3ZnL1NWR1RyYW5zZm9ybS5jcHAKQEAgLTE3NCwyOCArMTc0LDY1IEBA IFN0cmluZyBTVkdUcmFuc2Zvcm06OnZhbHVlQXNTdHJpbmcoKSBjb25zdAogICAgICAgICByZXR1 cm4gcHJlZml4OwogICAgIGNhc2UgU1ZHX1RSQU5TRk9STV9NQVRSSVg6IHsKICAgICAgICAgU3Ry aW5nQnVpbGRlciBidWlsZGVyOwotICAgICAgICBidWlsZGVyLmFwcGVuZChwcmVmaXggKyBTdHJp bmc6Om51bWJlcihtX21hdHJpeC5hKCkpICsgJyAnICsgU3RyaW5nOjpudW1iZXIobV9tYXRyaXgu YigpKSArICcgJyArIFN0cmluZzo6bnVtYmVyKG1fbWF0cml4LmMoKSkgKyAnICcgKwotICAgICAg ICAgICAgICAgICAgICAgICBTdHJpbmc6Om51bWJlcihtX21hdHJpeC5kKCkpICsgJyAnICsgU3Ry aW5nOjpudW1iZXIobV9tYXRyaXguZSgpKSArICcgJyArIFN0cmluZzo6bnVtYmVyKG1fbWF0cml4 LmYoKSkgKyAnKScpOworICAgICAgICBidWlsZGVyLmFwcGVuZChwcmVmaXgpOworICAgICAgICBi dWlsZGVyLmFwcGVuZE51bWJlcihtX21hdHJpeC5hKCkpOworICAgICAgICBidWlsZGVyLmFwcGVu ZCgnICcpOworICAgICAgICBidWlsZGVyLmFwcGVuZE51bWJlcihtX21hdHJpeC5iKCkpOworICAg ICAgICBidWlsZGVyLmFwcGVuZCgnICcpOworICAgICAgICBidWlsZGVyLmFwcGVuZE51bWJlciht X21hdHJpeC5jKCkpOworICAgICAgICBidWlsZGVyLmFwcGVuZCgnICcpOworICAgICAgICBidWls ZGVyLmFwcGVuZE51bWJlcihtX21hdHJpeC5kKCkpOworICAgICAgICBidWlsZGVyLmFwcGVuZCgn ICcpOworICAgICAgICBidWlsZGVyLmFwcGVuZE51bWJlcihtX21hdHJpeC5lKCkpOworICAgICAg ICBidWlsZGVyLmFwcGVuZCgnICcpOworICAgICAgICBidWlsZGVyLmFwcGVuZE51bWJlcihtX21h dHJpeC5lKCkpOworICAgICAgICBidWlsZGVyLmFwcGVuZCgnKScpOworICAgICAgICByZXR1cm4g YnVpbGRlci50b1N0cmluZygpOworICAgIH0KKyAgICBjYXNlIFNWR19UUkFOU0ZPUk1fVFJBTlNM QVRFOiB7CisgICAgICAgIFN0cmluZ0J1aWxkZXIgYnVpbGRlcjsKKyAgICAgICAgYnVpbGRlci5h cHBlbmQocHJlZml4KTsKKyAgICAgICAgYnVpbGRlci5hcHBlbmROdW1iZXIobV9tYXRyaXguZSgp KTsKKyAgICAgICAgYnVpbGRlci5hcHBlbmQoJyAnKTsKKyAgICAgICAgYnVpbGRlci5hcHBlbmRO dW1iZXIobV9tYXRyaXguZSgpKTsKKyAgICAgICAgYnVpbGRlci5hcHBlbmQoJyknKTsKKyAgICAg ICAgcmV0dXJuIGJ1aWxkZXIudG9TdHJpbmcoKTsKKyAgICB9CisgICAgY2FzZSBTVkdfVFJBTlNG T1JNX1NDQUxFOiB7CisgICAgICAgIFN0cmluZ0J1aWxkZXIgYnVpbGRlcjsKKyAgICAgICAgYnVp bGRlci5hcHBlbmQocHJlZml4KTsKKyAgICAgICAgYnVpbGRlci5hcHBlbmROdW1iZXIobV9tYXRy aXgueFNjYWxlKCkpOworICAgICAgICBidWlsZGVyLmFwcGVuZCgnICcpOworICAgICAgICBidWls ZGVyLmFwcGVuZE51bWJlcihtX21hdHJpeC55U2NhbGUoKSk7CisgICAgICAgIGJ1aWxkZXIuYXBw ZW5kKCcpJyk7CiAgICAgICAgIHJldHVybiBidWlsZGVyLnRvU3RyaW5nKCk7CiAgICAgfQotICAg IGNhc2UgU1ZHX1RSQU5TRk9STV9UUkFOU0xBVEU6Ci0gICAgICAgIHJldHVybiBwcmVmaXggKyBT dHJpbmc6Om51bWJlcihtX21hdHJpeC5lKCkpICsgJyAnICsgU3RyaW5nOjpudW1iZXIobV9tYXRy aXguZigpKSArICcpJzsKLSAgICBjYXNlIFNWR19UUkFOU0ZPUk1fU0NBTEU6Ci0gICAgICAgIHJl dHVybiBwcmVmaXggKyBTdHJpbmc6Om51bWJlcihtX21hdHJpeC54U2NhbGUoKSkgKyAnICcgKyBT dHJpbmc6Om51bWJlcihtX21hdHJpeC55U2NhbGUoKSkgKyAnKSc7CiAgICAgY2FzZSBTVkdfVFJB TlNGT1JNX1JPVEFURTogewogICAgICAgICBkb3VibGUgYW5nbGVJblJhZCA9IGRlZzJyYWQobV9h bmdsZSk7CiAgICAgICAgIGRvdWJsZSBjb3NBbmdsZSA9IGNvcyhhbmdsZUluUmFkKTsKICAgICAg ICAgZG91YmxlIHNpbkFuZ2xlID0gc2luKGFuZ2xlSW5SYWQpOwogICAgICAgICBmbG9hdCBjeCA9 IG5hcnJvd1ByZWNpc2lvblRvRmxvYXQoY29zQW5nbGUgIT0gMSA/IChtX21hdHJpeC5lKCkgKiAo MSAtIGNvc0FuZ2xlKSAtIG1fbWF0cml4LmYoKSAqIHNpbkFuZ2xlKSAvICgxIC0gY29zQW5nbGUp IC8gMiA6IDApOwogICAgICAgICBmbG9hdCBjeSA9IG5hcnJvd1ByZWNpc2lvblRvRmxvYXQoY29z QW5nbGUgIT0gMSA/IChtX21hdHJpeC5lKCkgKiBzaW5BbmdsZSAvICgxIC0gY29zQW5nbGUpICsg bV9tYXRyaXguZigpKSAvIDIgOiAwKTsKLSAgICAgICAgaWYgKGN4IHx8IGN5KQotICAgICAgICAg ICAgcmV0dXJuIHByZWZpeCArIFN0cmluZzo6bnVtYmVyKG1fYW5nbGUpICsgJyAnICsgU3RyaW5n OjpudW1iZXIoY3gpICsgJyAnICsgU3RyaW5nOjpudW1iZXIoY3kpICsgJyknOwotICAgICAgICBy ZXR1cm4gcHJlZml4ICsgU3RyaW5nOjpudW1iZXIobV9hbmdsZSkgKyAnKSc7CisgICAgICAgIFN0 cmluZ0J1aWxkZXIgYnVpbGRlcjsKKyAgICAgICAgYnVpbGRlci5hcHBlbmQocHJlZml4KTsKKyAg ICAgICAgYnVpbGRlci5hcHBlbmROdW1iZXIobV9hbmdsZSk7CisgICAgICAgIGlmIChjeCB8fCBj eSkgeworICAgICAgICAgICAgYnVpbGRlci5hcHBlbmQoJyAnKTsKKyAgICAgICAgICAgIGJ1aWxk ZXIuYXBwZW5kTnVtYmVyKGN4KTsKKyAgICAgICAgICAgIGJ1aWxkZXIuYXBwZW5kKCcgJyk7Cisg ICAgICAgICAgICBidWlsZGVyLmFwcGVuZE51bWJlcihjeSk7CisgICAgICAgIH0KKyAgICAgICAg YnVpbGRlci5hcHBlbmQoJyknKTsKKyAgICAgICAgcmV0dXJuIGJ1aWxkZXIudG9TdHJpbmcoKTsK ICAgICB9CiAgICAgY2FzZSBTVkdfVFJBTlNGT1JNX1NLRVdYOgotICAgICAgICByZXR1cm4gcHJl Zml4ICsgU3RyaW5nOjpudW1iZXIobV9hbmdsZSkgKyAnKSc7Ci0gICAgY2FzZSBTVkdfVFJBTlNG T1JNX1NLRVdZOgotICAgICAgICByZXR1cm4gcHJlZml4ICsgU3RyaW5nOjpudW1iZXIobV9hbmds ZSkgKyAnKSc7CisgICAgY2FzZSBTVkdfVFJBTlNGT1JNX1NLRVdZOiB7CisgICAgICAgIFN0cmlu Z0J1aWxkZXIgYnVpbGRlcjsKKyAgICAgICAgYnVpbGRlci5hcHBlbmQocHJlZml4KTsKKyAgICAg ICAgYnVpbGRlci5hcHBlbmROdW1iZXIobV9hbmdsZSk7CisgICAgICAgIGJ1aWxkZXIuYXBwZW5k KCcpJyk7CisgICAgICAgIHJldHVybiBidWlsZGVyLnRvU3RyaW5nKCk7CisgICAgfQogICAgIH0K IAogICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOwo=