121494 2013-09-17 08:23:50 -0700 Add RenderObject bit for isBR() 2013-09-17 08:59:42 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 koivisto webkit-unassigned commit-queue esprehn+autocc glenn hyatt kling kondapallykalyan oldest_to_newest 930228 0 koivisto 2013-09-17 08:23:50 -0700 It is no longer piggybacking on isText() flag and is now hot in inline layout. 930236 1 211909 koivisto 2013-09-17 08:34:12 -0700 Created attachment 211909 patch 930252 2 koivisto 2013-09-17 08:59:42 -0700 https://trac.webkit.org/r155962 211909 2013-09-17 08:34:12 -0700 2013-09-17 08:35:16 -0700 patch renderbr-bit.patch text/plain 4509 koivisto SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1NTk1OSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDEzLTA5LTE3ICBBbnR0aSBL b2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBBZGQgUmVuZGVyT2JqZWN0IGJp dCBmb3IgaXNCUigpLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTIxNDk0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgSXQgaXMgbm8gbG9uZ2VyIHBpZ2d5YmFja2luZyBvbiBpc1RleHQoKSBmbGFnIGFuZCBp cyBub3cgaG90IGluIGlubGluZSBsYXlvdXQuCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVy QlIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyQlI6OlJlbmRlckJSKToKKyAgICAgICAg KiByZW5kZXJpbmcvUmVuZGVyQlIuaDoKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyT2JqZWN0 Lmg6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJPYmplY3Q6OmlzQlIpOgorICAgICAgICAoV2Vi Q29yZTo6UmVuZGVyT2JqZWN0OjpzZXRJc0JSKToKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlck9i amVjdDo6UmVuZGVyT2JqZWN0Qml0ZmllbGRzOjpSZW5kZXJPYmplY3RCaXRmaWVsZHMpOgorCiAy MDEzLTA5LTE3ICBDaHJpc3RvcGhlIER1bWV6ICA8Y2guZHVtZXpAc2lzYS5zYW1zdW5nLmNvbT4K IAogICAgICAgICBTZXQgTWVzc2FnZUV2ZW50LnNvdXJjZSB0byB0aGUgbmV3bHkgY3JlYXRlZCBw b3J0IGZvciBzaGFyZWQgd29ya2VycycgY29ubmVjdCBldmVudHMKSW5kZXg6IFNvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9SZW5kZXJCUi5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlckJSLmNwcAkocmV2aXNpb24gMTU1OTU3KQorKysgU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL1JlbmRlckJSLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzYsNiArMzYsNyBA QCBSZW5kZXJCUjo6UmVuZGVyQlIoRWxlbWVudCogZWxlbWVudCkKICAgICAsIG1faW5saW5lQm94 V3JhcHBlcihudWxscHRyKQogICAgICwgbV9jYWNoZWRMaW5lSGVpZ2h0KGludmFsaWRMaW5lSGVp Z2h0KQogeworICAgIHNldElzQlIoKTsKIH0KIAogUmVuZGVyQlI6On5SZW5kZXJCUigpCkluZGV4 OiBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQlIuaAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQlIuaAkocmV2aXNpb24gMTU1OTU3KQorKysgU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJSLmgJKHdvcmtpbmcgY29weSkKQEAgLTUwLDgg KzUwLDYgQEAgcHVibGljOgogICAgIHZpcnR1YWwgdm9pZCBhYnNvbHV0ZVF1YWRzKFZlY3RvcjxG bG9hdFF1YWQ+JiwgYm9vbCogd2FzRml4ZWQpIGNvbnN0IE9WRVJSSURFOwogCiBwcml2YXRlOgot ICAgIHZpcnR1YWwgYm9vbCBpc0JSKCkgY29uc3QgT1ZFUlJJREUgeyByZXR1cm4gdHJ1ZTsgfQot CiAgICAgdmlydHVhbCBWaXNpYmxlUG9zaXRpb24gcG9zaXRpb25Gb3JQb2ludChjb25zdCBMYXlv dXRQb2ludCYpIE9WRVJSSURFOwogICAgIHZpcnR1YWwgaW50IGNhcmV0TWluT2Zmc2V0KCkgY29u c3QgT1ZFUlJJREU7CiAgICAgdmlydHVhbCBpbnQgY2FyZXRNYXhPZmZzZXQoKSBjb25zdCBPVkVS UklERTsKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJPYmplY3QuaAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyT2JqZWN0LmgJKHJldmlz aW9uIDE1NTk1NykKKysrIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJPYmplY3QuaAko d29ya2luZyBjb3B5KQpAQCAtMzQzLDcgKzM0Myw2IEBAIHB1YmxpYzoKIAogICAgIGJvb2wgaXNQ c2V1ZG9FbGVtZW50KCkgY29uc3QgeyByZXR1cm4gbm9kZSgpICYmIG5vZGUoKS0+aXNQc2V1ZG9F bGVtZW50KCk7IH0KIAotICAgIHZpcnR1YWwgYm9vbCBpc0JSKCkgY29uc3QgeyByZXR1cm4gZmFs c2U7IH0KICAgICB2aXJ0dWFsIGJvb2wgaXNCb3hNb2RlbE9iamVjdCgpIGNvbnN0IHsgcmV0dXJu IGZhbHNlOyB9CiAgICAgdmlydHVhbCBib29sIGlzQ291bnRlcigpIGNvbnN0IHsgcmV0dXJuIGZh bHNlOyB9CiAgICAgdmlydHVhbCBib29sIGlzUXVvdGUoKSBjb25zdCB7IHJldHVybiBmYWxzZTsg fQpAQCAtNTY4LDYgKzU2Nyw3IEBAIHB1YmxpYzoKICAgICBib29sIGlzUG9zaXRpb25lZCgpIGNv bnN0IHsgcmV0dXJuIG1fYml0ZmllbGRzLmlzUG9zaXRpb25lZCgpOyB9CiAKICAgICBib29sIGlz VGV4dCgpIGNvbnN0ICB7IHJldHVybiAhbV9iaXRmaWVsZHMuaXNCb3goKSAmJiBtX2JpdGZpZWxk cy5pc1RleHRPclJlbmRlclZpZXcoKTsgfQorICAgIGJvb2wgaXNCUigpIGNvbnN0IHsgcmV0dXJu IG1fYml0ZmllbGRzLmlzQlIoKTsgfQogICAgIGJvb2wgaXNCb3goKSBjb25zdCB7IHJldHVybiBt X2JpdGZpZWxkcy5pc0JveCgpOyB9CiAgICAgYm9vbCBpc1JlbmRlclZpZXcoKSBjb25zdCAgeyBy ZXR1cm4gbV9iaXRmaWVsZHMuaXNCb3goKSAmJiBtX2JpdGZpZWxkcy5pc1RleHRPclJlbmRlclZp ZXcoKTsgfQogICAgIGJvb2wgaXNJbmxpbmUoKSBjb25zdCB7IHJldHVybiBtX2JpdGZpZWxkcy5p c0lubGluZSgpOyB9IC8vIGlubGluZSBvYmplY3QKQEAgLTcwMCw2ICs3MDAsNyBAQCBwdWJsaWM6 CiAgICAgdmlydHVhbCBib29sIGNvbXB1dGVCYWNrZ3JvdW5kSXNLbm93blRvQmVPYnNjdXJlZCgp IHsgcmV0dXJuIGZhbHNlOyB9CiAKICAgICB2b2lkIHNldElzVGV4dCgpIHsgQVNTRVJUKCFpc0Jv eCgpKTsgbV9iaXRmaWVsZHMuc2V0SXNUZXh0T3JSZW5kZXJWaWV3KHRydWUpOyB9CisgICAgdm9p ZCBzZXRJc0JSKCkgeyBtX2JpdGZpZWxkcy5zZXRJc0JSKHRydWUpOyB9CiAgICAgdm9pZCBzZXRJ c0JveCgpIHsgbV9iaXRmaWVsZHMuc2V0SXNCb3godHJ1ZSk7IH0KICAgICB2b2lkIHNldElzUmVu ZGVyVmlldygpIHsgQVNTRVJUKGlzQm94KCkpOyBtX2JpdGZpZWxkcy5zZXRJc1RleHRPclJlbmRl clZpZXcodHJ1ZSk7IH0KICAgICB2b2lkIHNldFJlcGxhY2VkKGJvb2wgYiA9IHRydWUpIHsgbV9i aXRmaWVsZHMuc2V0SXNSZXBsYWNlZChiKTsgfQpAQCAtMTA5OSw2ICsxMTAwLDcgQEAgcHJpdmF0 ZToKICAgICAgICAgICAgICwgbV9pc0JveChmYWxzZSkKICAgICAgICAgICAgICwgbV9pc0lubGlu ZSh0cnVlKQogICAgICAgICAgICAgLCBtX2lzUmVwbGFjZWQoZmFsc2UpCisgICAgICAgICAgICAs IG1faXNCUihmYWxzZSkKICAgICAgICAgICAgICwgbV9ob3Jpem9udGFsV3JpdGluZ01vZGUodHJ1 ZSkKICAgICAgICAgICAgICwgbV9pc0RyYWdnaW5nKGZhbHNlKQogICAgICAgICAgICAgLCBtX2hh c0xheWVyKGZhbHNlKQpAQCAtMTExNiw3ICsxMTE4LDcgQEAgcHJpdmF0ZToKICAgICAgICAgewog ICAgICAgICB9CiAgICAgICAgIAotICAgICAgICAvLyAzMSBiaXRzIGhhdmUgYmVlbiB1c2VkIGhl cmUuIFRoZXJlIGlzIG9uZSBiaXQgYXZhaWxhYmxlLgorICAgICAgICAvLyAzMiBiaXRzIGhhdmUg YmVlbiB1c2VkIGhlcmUuIFRoZXJlIGFyZSBubyBiaXRzIGF2YWlsYWJsZS4KICAgICAgICAgQURE X0JPT0xFQU5fQklURklFTEQobmVlZHNMYXlvdXQsIE5lZWRzTGF5b3V0KTsKICAgICAgICAgQURE X0JPT0xFQU5fQklURklFTEQobmVlZHNQb3NpdGlvbmVkTW92ZW1lbnRMYXlvdXQsIE5lZWRzUG9z aXRpb25lZE1vdmVtZW50TGF5b3V0KTsKICAgICAgICAgQUREX0JPT0xFQU5fQklURklFTEQobm9y bWFsQ2hpbGROZWVkc0xheW91dCwgTm9ybWFsQ2hpbGROZWVkc0xheW91dCk7CkBAIC0xMTMwLDYg KzExMzIsNyBAQCBwcml2YXRlOgogICAgICAgICBBRERfQk9PTEVBTl9CSVRGSUVMRChpc0JveCwg SXNCb3gpOwogICAgICAgICBBRERfQk9PTEVBTl9CSVRGSUVMRChpc0lubGluZSwgSXNJbmxpbmUp OwogICAgICAgICBBRERfQk9PTEVBTl9CSVRGSUVMRChpc1JlcGxhY2VkLCBJc1JlcGxhY2VkKTsK KyAgICAgICAgQUREX0JPT0xFQU5fQklURklFTEQoaXNCUiwgSXNCUik7CiAgICAgICAgIEFERF9C T09MRUFOX0JJVEZJRUxEKGhvcml6b250YWxXcml0aW5nTW9kZSwgSG9yaXpvbnRhbFdyaXRpbmdN b2RlKTsKICAgICAgICAgQUREX0JPT0xFQU5fQklURklFTEQoaXNEcmFnZ2luZywgSXNEcmFnZ2lu Zyk7CiAK