121485 2013-09-17 05:44:21 -0700 [Win] TestWebKitAPI does not compile. 2013-09-18 09:32:16 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Unspecified RESOLVED FIXED P2 Normal --- 0 peavo webkit-unassigned bfulgham commit-queue oldest_to_newest 930176 0 peavo 2013-09-17 05:44:21 -0700 There is currently a few compile errors in BitmapImageEmptyFrameTest in TestWebKitAPI, because it is no longer allowed to inherit from WebCore::BitmapImage, which the test relies on. 930185 1 211895 peavo 2013-09-17 06:20:30 -0700 Created attachment 211895 Patch 930488 2 211895 bfulgham 2013-09-17 19:31:22 -0700 Comment on attachment 211895 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=211895&action=review I have a few questions, but I think this looks good. I'll r+ it and trust that you'll adjust things if you need to :-) > Tools/TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:44 > + auto hbmp = ::CreateDIBSection(0, &bitmapInfo, DIB_RGB_COLORS, 0, 0, 0); Does this need to be cleaned up somewhere? I can't tell (with a few seconds checking) whether we need to delete this GDI object. Otherwise looks good to me. > Tools/TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:48 > + if (bitmapImageTest) { I would prefer an early exit, but this is fine. > Tools/TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:53 > + HBITMAP hBitmap = CreateBitmap(sz.width(), sz.height(), 1, 32, bits); Does this bitmap need to be destroyed to be correct in our GDI/memory handling? 930582 3 211985 peavo 2013-09-18 04:51:58 -0700 Created attachment 211985 Patch 930583 4 peavo 2013-09-18 05:04:43 -0700 Thanks for reviewing, all valid points, updated patch :) 930648 5 211985 bfulgham 2013-09-18 09:09:46 -0700 Comment on attachment 211985 Patch r=me 930651 6 211985 commit-queue 2013-09-18 09:32:14 -0700 Comment on attachment 211985 Patch Clearing flags on attachment: 211985 Committed r156045: <http://trac.webkit.org/changeset/156045> 930652 7 commit-queue 2013-09-18 09:32:16 -0700 All reviewed patches have been landed. Closing bug. 211895 2013-09-17 06:20:30 -0700 2013-09-18 04:51:51 -0700 Patch bug-121485-20130917152023.patch text/plain 4691 peavo SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAxNTU5NTApCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDEzLTA5LTE3ICBwZWF2b0BvdXRs b29rLmNvbSAgPHBlYXZvQG91dGxvb2suY29tPgorCisgICAgICAgIFtXaW5dIFRlc3RXZWJLaXRB UEkgZG9lcyBub3QgY29tcGlsZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTEyMTQ4NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogV2ViS2l0LnZjeHByb2ovV2ViS2l0RXhwb3J0R2VuZXJhdG9yL1dlYktp dEV4cG9ydHMuZGVmLmluOiBFeHBvcnQgbmVlZGVkIHN5bWJvbHMuCisKIDIwMTMtMDktMTcgIEFu ZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgogCiAgICAgICAgIFNvbWUgYnVpbGQganVp Y2UgZm9yIFdpbmRvd3MuCkluZGV4OiBTb3VyY2UvV2ViS2l0L1dlYktpdC52Y3hwcm9qL1dlYktp dEV4cG9ydEdlbmVyYXRvci9XZWJLaXRFeHBvcnRzLmRlZi5pbgo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV2ViS2l0L1dlYktpdC52Y3hwcm9qL1dlYktpdEV4cG9ydEdlbmVyYXRvci9XZWJLaXRFeHBv cnRzLmRlZi5pbgkocmV2aXNpb24gMTU1OTQ4KQorKysgU291cmNlL1dlYktpdC9XZWJLaXQudmN4 cHJvai9XZWJLaXRFeHBvcnRHZW5lcmF0b3IvV2ViS2l0RXhwb3J0cy5kZWYuaW4JKHdvcmtpbmcg Y29weSkKQEAgLTM4Miw2ICszODIsOCBAQCBFWFBPUlRTCiAjZW5kaWYKICAgICAgICAgc3ltYm9s V2l0aFBvaW50ZXIoP2dldEhCSVRNQVBAQml0bWFwSW1hZ2VAV2ViQ29yZUBAVUFFX05QQVVIQklU TUFQX19AQEBaLCA/Z2V0SEJJVE1BUEBCaXRtYXBJbWFnZUBXZWJDb3JlQEBVRUFBX05QRUFVSEJJ VE1BUF9fQEBAWikKICAgICAgICAgP2dldEhCSVRNQVBPZlNpemVAQml0bWFwSW1hZ2VAV2ViQ29y ZUBAVUFFX05QQVVIQklUTUFQX19AQFBCVkludFNpemVAMkBAWgorICAgICAgICA/Y3JlYXRlQEJp dG1hcEltYWdlQFdlYkNvcmVAQFNBP0FWPyRQYXNzUmVmUHRyQFZCaXRtYXBJbWFnZUBXZWJDb3Jl QEBAV1RGQEBQQVVIQklUTUFQX19AQEBaCisgICAgICAgID9jcmVhdGVAQml0bWFwSW5mb0BXZWJD b3JlQEBTQT9BVTEyQEFCVkludFNpemVAMkBXNEJpdENvdW50QDEyQEBaCiAgICAgICAgIHN5bWJv bFdpdGhQb2ludGVyKD9kcmF3UGF0dGVybkBJbWFnZUBXZWJDb3JlQEBVQUVYUEFWR3JhcGhpY3ND b250ZXh0QDJAQUJWRmxvYXRSZWN0QDJAQUJWQWZmaW5lVHJhbnNmb3JtQDJAQUJWRmxvYXRQb2lu dEAyQFc0Q29sb3JTcGFjZUAyQFc0Q29tcG9zaXRlT3BlcmF0b3JAMkAxVzRCbGVuZE1vZGVAMkBA WiwgP2RyYXdQYXR0ZXJuQEltYWdlQFdlYkNvcmVAQFVFQUFYUEVBVkdyYXBoaWNzQ29udGV4dEAy QEFFQlZGbG9hdFJlY3RAMkBBRUJWQWZmaW5lVHJhbnNmb3JtQDJAQUVCVkZsb2F0UG9pbnRAMkBX NENvbG9yU3BhY2VAMkBXNENvbXBvc2l0ZU9wZXJhdG9yQDJAMVc0QmxlbmRNb2RlQDJAQFopCiAg ICAgICAgIHN5bWJvbFdpdGhQb2ludGVyKD9kcmF3RnJhbWVNYXRjaGluZ1NvdXJjZVNpemVAQml0 bWFwSW1hZ2VAV2ViQ29yZUBATUFFWFBBVkdyYXBoaWNzQ29udGV4dEAyQEFCVkZsb2F0UmVjdEAy QEFCVkludFNpemVAMkBXNENvbG9yU3BhY2VAMkBXNENvbXBvc2l0ZU9wZXJhdG9yQDJAQFosID9k cmF3RnJhbWVNYXRjaGluZ1NvdXJjZVNpemVAQml0bWFwSW1hZ2VAV2ViQ29yZUBATUVBQVhQRUFW R3JhcGhpY3NDb250ZXh0QDJAQUVCVkZsb2F0UmVjdEAyQEFFQlZJbnRTaXplQDJAVzRDb2xvclNw YWNlQDJAVzRDb21wb3NpdGVPcGVyYXRvckAyQEBaKQogICAgICAgICBzeW1ib2xXaXRoUG9pbnRl cig/bWF5RmlsbFdpdGhTb2xpZENvbG9yQEJpdG1hcEltYWdlQFdlYkNvcmVAQE1BRV9OWFosID9t YXlGaWxsV2l0aFNvbGlkQ29sb3JAQml0bWFwSW1hZ2VAV2ViQ29yZUBATUVBQV9OWFopCkluZGV4 OiBUb29scy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQ2hhbmdlTG9nCShyZXZpc2lv biAxNTU5NTApCisrKyBUb29scy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwx NyBAQAorMjAxMy0wOS0xNyAgcGVhdm9Ab3V0bG9vay5jb20gIDxwZWF2b0BvdXRsb29rLmNvbT4K KworICAgICAgICBbV2luXSBUZXN0V2ViS2l0QVBJIGRvZXMgbm90IGNvbXBpbGUuCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjE0ODUKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJdCBpcyBubyBsb25nZXIg cG9zc2libGUgdG8gaW5oZXJpdCBmcm9tIFdlYkNvcmU6OkJpdG1hcEltYWdlLCB3aGljaCB0aGUg dGVzdCByZWxpZXMgb24uCisgICAgICAgIEluc3RlYWQsIGxvYWQgYSBiaXRtYXAsIHRoZW4gZGVz dHJveSB0aGUgZGVjb2RlZCBkYXRhLCB3aGljaCB3aWxsIGNhdXNlIFdlYkNvcmU6OmZyYW1lQXRJ bmRleCgpCisgICAgICAgIHRvIHJldHVybiBudWxsLCB3aGljaCBpcyB0aGUgY2FzZSB3ZSB3YW50 IHRvIHRlc3QuCisKKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYkNvcmUvd2luL0Jp dG1hcEltYWdlLmNwcDoKKyAgICAgICAgKFRlc3RXZWJLaXRBUEk6OlRFU1QpOgorCiAyMDEzLTA5 LTE3ICBZdVRlaCBTaGVuICA8c2hlbnl1dGVAaG90bWFpbC5jb20+CiAKICAgICAgICAgQnJvd3Nl ck1hcnNoYWwuaCBidWlsZCBmYWlsCkluZGV4OiBUb29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dl YkNvcmUvd2luL0JpdG1hcEltYWdlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9UZXN0V2ViS2l0 QVBJL1Rlc3RzL1dlYkNvcmUvd2luL0JpdG1hcEltYWdlLmNwcAkocmV2aXNpb24gMTU1OTM3KQor KysgVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJDb3JlL3dpbi9CaXRtYXBJbWFnZS5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTI2LDYgKzI2LDcgQEAKIAogI2luY2x1ZGUgImNvbmZpZy5oIgog I2luY2x1ZGUgPFdlYkNvcmUvQml0bWFwSW1hZ2UuaD4KKyNpbmNsdWRlIDxXZWJDb3JlL0JpdG1h cEluZm8uaD4KIAogdXNpbmcgbmFtZXNwYWNlIFdlYkNvcmU7CiAKQEAgLTM0LDI2ICszNSwyNSBA QCBuYW1lc3BhY2UgVGVzdFdlYktpdEFQSSB7CiAvLyBUZXN0IHRoYXQgdGhlcmUgaXMgbm8gY3Jh c2ggd2hlbiBCaXRtYXBJbWFnZTo6Z2V0SEJJVE1BUE9mU2l6ZSgpIGlzIGNhbGxlZAogLy8gZm9y IGFuIGltYWdlIHdpdGggZW1wdHkgZnJhbWVzIChCaXRtYXBJbWFnZTo6ZnJhbWVBdEluZGV4KGkp IHJldHVybiBudWxsKSwgV2ViS2l0IEJ1ZyAxMDI2ODkuCiAKLWNsYXNzIEJpdG1hcEltYWdlVGVz dCA6IHB1YmxpYyBXZWJDb3JlOjpCaXRtYXBJbWFnZSB7Ci1wdWJsaWM6Ci0gICAgQml0bWFwSW1h Z2VUZXN0KCkKLSAgICB7Ci0gICAgICAgIG1fZnJhbWVzLmdyb3coMSk7Ci0gICAgfQotCi0gICAg dmlydHVhbCBzaXplX3QgZnJhbWVDb3VudCgpCi0gICAgewotICAgICAgICByZXR1cm4gMTsKLSAg ICB9Ci19OwotCiBURVNUKFdlYkNvcmUsIEJpdG1hcEltYWdlRW1wdHlGcmFtZVRlc3QpCiB7CiAg ICAgSW50U2l6ZSBzeigxNiwgMTYpOwotICAgIFJlZlB0cjxCaXRtYXBJbWFnZVRlc3Q+IGJpdG1h cEltYWdlVGVzdCA9IGFkb3B0UmVmKG5ldyBCaXRtYXBJbWFnZVRlc3QpOwotICAgIGludCBiaXRz WzI1Nl07Ci0gICAgSEJJVE1BUCBoQml0bWFwID0gQ3JlYXRlQml0bWFwKHN6LndpZHRoKCksIHN6 LmhlaWdodCgpLCAxLCAzMiwgYml0cyk7Ci0gICAgYml0bWFwSW1hZ2VUZXN0LT5nZXRIQklUTUFQ T2ZTaXplKGhCaXRtYXAsICZzeik7CisKKyAgICBCaXRtYXBJbmZvIGJpdG1hcEluZm8gPSBCaXRt YXBJbmZvOjpjcmVhdGUoc3opOworCisgICAgYXV0byBoYm1wID0gOjpDcmVhdGVESUJTZWN0aW9u KDAsICZiaXRtYXBJbmZvLCBESUJfUkdCX0NPTE9SUywgMCwgMCwgMCk7CisKKyAgICBSZWZQdHI8 SW1hZ2U+IGJpdG1hcEltYWdlVGVzdCA9IEJpdG1hcEltYWdlOjpjcmVhdGUoaGJtcCk7CisKKyAg ICBpZiAoYml0bWFwSW1hZ2VUZXN0KSB7CisgICAgICAgIC8vIERlc3Ryb3lpbmcgZGVjb2RlZCBk YXRhIHdpbGwgY2F1c2UgZnJhbWVBdEluZGV4KGkpIHRvIHJldHVybiBudWxsLgorICAgICAgICBi aXRtYXBJbWFnZVRlc3QtPmRlc3Ryb3lEZWNvZGVkRGF0YSgpOworCisgICAgICAgIGludCBiaXRz WzI1Nl07CisgICAgICAgIEhCSVRNQVAgaEJpdG1hcCA9IENyZWF0ZUJpdG1hcChzei53aWR0aCgp LCBzei5oZWlnaHQoKSwgMSwgMzIsIGJpdHMpOworCisgICAgICAgIGJpdG1hcEltYWdlVGVzdC0+ Z2V0SEJJVE1BUE9mU2l6ZShoQml0bWFwLCAmc3opOworICAgIH0KIH0KIAogfSAvLyBuYW1lc3Bh Y2UgVGVzdFdlYktpdEFQSQo= 211985 2013-09-18 04:51:58 -0700 2013-09-18 09:32:14 -0700 Patch bug-121485-20130918135147.patch text/plain 4751 peavo SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAxNTYwMzIpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDEzLTA5LTE4ICBwZWF2b0BvdXRs b29rLmNvbSAgPHBlYXZvQG91dGxvb2suY29tPgorCisgICAgICAgIFtXaW5dIFRlc3RXZWJLaXRB UEkgZG9lcyBub3QgY29tcGlsZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTEyMTQ4NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogV2ViS2l0LnZjeHByb2ovV2ViS2l0RXhwb3J0R2VuZXJhdG9yL1dlYktp dEV4cG9ydHMuZGVmLmluOiBFeHBvcnQgbmVlZGVkIHN5bWJvbHMuCisKIDIwMTMtMDktMTcgIEFu ZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgogCiAgICAgICAgIFNvbWUgYnVpbGQganVp Y2UgZm9yIFdpbmRvd3MuCkluZGV4OiBTb3VyY2UvV2ViS2l0L1dlYktpdC52Y3hwcm9qL1dlYktp dEV4cG9ydEdlbmVyYXRvci9XZWJLaXRFeHBvcnRzLmRlZi5pbgo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV2ViS2l0L1dlYktpdC52Y3hwcm9qL1dlYktpdEV4cG9ydEdlbmVyYXRvci9XZWJLaXRFeHBv cnRzLmRlZi5pbgkocmV2aXNpb24gMTU2MDMyKQorKysgU291cmNlL1dlYktpdC9XZWJLaXQudmN4 cHJvai9XZWJLaXRFeHBvcnRHZW5lcmF0b3IvV2ViS2l0RXhwb3J0cy5kZWYuaW4JKHdvcmtpbmcg Y29weSkKQEAgLTM4Miw2ICszODIsOCBAQCBFWFBPUlRTCiAjZW5kaWYKICAgICAgICAgc3ltYm9s V2l0aFBvaW50ZXIoP2dldEhCSVRNQVBAQml0bWFwSW1hZ2VAV2ViQ29yZUBAVUFFX05QQVVIQklU TUFQX19AQEBaLCA/Z2V0SEJJVE1BUEBCaXRtYXBJbWFnZUBXZWJDb3JlQEBVRUFBX05QRUFVSEJJ VE1BUF9fQEBAWikKICAgICAgICAgP2dldEhCSVRNQVBPZlNpemVAQml0bWFwSW1hZ2VAV2ViQ29y ZUBAVUFFX05QQVVIQklUTUFQX19AQFBCVkludFNpemVAMkBAWgorICAgICAgICA/Y3JlYXRlQEJp dG1hcEltYWdlQFdlYkNvcmVAQFNBP0FWPyRQYXNzUmVmUHRyQFZCaXRtYXBJbWFnZUBXZWJDb3Jl QEBAV1RGQEBQQVVIQklUTUFQX19AQEBaCisgICAgICAgID9jcmVhdGVAQml0bWFwSW5mb0BXZWJD b3JlQEBTQT9BVTEyQEFCVkludFNpemVAMkBXNEJpdENvdW50QDEyQEBaCiAgICAgICAgIHN5bWJv bFdpdGhQb2ludGVyKD9kcmF3UGF0dGVybkBJbWFnZUBXZWJDb3JlQEBVQUVYUEFWR3JhcGhpY3ND b250ZXh0QDJAQUJWRmxvYXRSZWN0QDJAQUJWQWZmaW5lVHJhbnNmb3JtQDJAQUJWRmxvYXRQb2lu dEAyQFc0Q29sb3JTcGFjZUAyQFc0Q29tcG9zaXRlT3BlcmF0b3JAMkAxVzRCbGVuZE1vZGVAMkBA WiwgP2RyYXdQYXR0ZXJuQEltYWdlQFdlYkNvcmVAQFVFQUFYUEVBVkdyYXBoaWNzQ29udGV4dEAy QEFFQlZGbG9hdFJlY3RAMkBBRUJWQWZmaW5lVHJhbnNmb3JtQDJAQUVCVkZsb2F0UG9pbnRAMkBX NENvbG9yU3BhY2VAMkBXNENvbXBvc2l0ZU9wZXJhdG9yQDJAMVc0QmxlbmRNb2RlQDJAQFopCiAg ICAgICAgIHN5bWJvbFdpdGhQb2ludGVyKD9kcmF3RnJhbWVNYXRjaGluZ1NvdXJjZVNpemVAQml0 bWFwSW1hZ2VAV2ViQ29yZUBATUFFWFBBVkdyYXBoaWNzQ29udGV4dEAyQEFCVkZsb2F0UmVjdEAy QEFCVkludFNpemVAMkBXNENvbG9yU3BhY2VAMkBXNENvbXBvc2l0ZU9wZXJhdG9yQDJAQFosID9k cmF3RnJhbWVNYXRjaGluZ1NvdXJjZVNpemVAQml0bWFwSW1hZ2VAV2ViQ29yZUBATUVBQVhQRUFW R3JhcGhpY3NDb250ZXh0QDJAQUVCVkZsb2F0UmVjdEAyQEFFQlZJbnRTaXplQDJAVzRDb2xvclNw YWNlQDJAVzRDb21wb3NpdGVPcGVyYXRvckAyQEBaKQogICAgICAgICBzeW1ib2xXaXRoUG9pbnRl cig/bWF5RmlsbFdpdGhTb2xpZENvbG9yQEJpdG1hcEltYWdlQFdlYkNvcmVAQE1BRV9OWFosID9t YXlGaWxsV2l0aFNvbGlkQ29sb3JAQml0bWFwSW1hZ2VAV2ViQ29yZUBATUVBQV9OWFopCkluZGV4 OiBUb29scy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQ2hhbmdlTG9nCShyZXZpc2lv biAxNTYwMzIpCisrKyBUb29scy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwx NyBAQAorMjAxMy0wOS0xOCAgcGVhdm9Ab3V0bG9vay5jb20gIDxwZWF2b0BvdXRsb29rLmNvbT4K KworICAgICAgICBbV2luXSBUZXN0V2ViS2l0QVBJIGRvZXMgbm90IGNvbXBpbGUuCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjE0ODUKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJdCBpcyBubyBsb25nZXIg cG9zc2libGUgdG8gaW5oZXJpdCBmcm9tIFdlYkNvcmU6OkJpdG1hcEltYWdlLCB3aGljaCB0aGUg dGVzdCByZWxpZXMgb24uCisgICAgICAgIEluc3RlYWQsIGxvYWQgYSBiaXRtYXAsIHRoZW4gZGVz dHJveSB0aGUgZGVjb2RlZCBkYXRhLCB3aGljaCB3aWxsIGNhdXNlIFdlYkNvcmU6OmZyYW1lQXRJ bmRleCgpCisgICAgICAgIHRvIHJldHVybiBudWxsLCB3aGljaCBpcyB0aGUgY2FzZSB3ZSB3YW50 IHRvIHRlc3QuCisKKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYkNvcmUvd2luL0Jp dG1hcEltYWdlLmNwcDoKKyAgICAgICAgKFRlc3RXZWJLaXRBUEk6OlRFU1QpOgorCiAyMDEzLTA5 LTE4ICBDb21taXQgUXVldWUgIDxjb21taXQtcXVldWVAd2Via2l0Lm9yZz4KIAogICAgICAgICBV bnJldmlld2VkLCByb2xsaW5nIG91dCByMTU2MDE5IGFuZCByMTU2MDIwLgpJbmRleDogVG9vbHMv VGVzdFdlYktpdEFQSS9UZXN0cy9XZWJDb3JlL3dpbi9CaXRtYXBJbWFnZS5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJDb3JlL3dpbi9CaXRtYXBJbWFnZS5j cHAJKHJldmlzaW9uIDE1NjAzMikKKysrIFRvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViQ29y ZS93aW4vQml0bWFwSW1hZ2UuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yNiw2ICsyNiw4IEBACiAK ICNpbmNsdWRlICJjb25maWcuaCIKICNpbmNsdWRlIDxXZWJDb3JlL0JpdG1hcEltYWdlLmg+Cisj aW5jbHVkZSA8V2ViQ29yZS9CaXRtYXBJbmZvLmg+CisjaW5jbHVkZSA8d3RmL3dpbi9HRElPYmpl Y3QuaD4KIAogdXNpbmcgbmFtZXNwYWNlIFdlYkNvcmU7CiAKQEAgLTM0LDI2ICszNiwyNiBAQCBu YW1lc3BhY2UgVGVzdFdlYktpdEFQSSB7CiAvLyBUZXN0IHRoYXQgdGhlcmUgaXMgbm8gY3Jhc2gg d2hlbiBCaXRtYXBJbWFnZTo6Z2V0SEJJVE1BUE9mU2l6ZSgpIGlzIGNhbGxlZAogLy8gZm9yIGFu IGltYWdlIHdpdGggZW1wdHkgZnJhbWVzIChCaXRtYXBJbWFnZTo6ZnJhbWVBdEluZGV4KGkpIHJl dHVybiBudWxsKSwgV2ViS2l0IEJ1ZyAxMDI2ODkuCiAKLWNsYXNzIEJpdG1hcEltYWdlVGVzdCA6 IHB1YmxpYyBXZWJDb3JlOjpCaXRtYXBJbWFnZSB7Ci1wdWJsaWM6Ci0gICAgQml0bWFwSW1hZ2VU ZXN0KCkKLSAgICB7Ci0gICAgICAgIG1fZnJhbWVzLmdyb3coMSk7Ci0gICAgfQotCi0gICAgdmly dHVhbCBzaXplX3QgZnJhbWVDb3VudCgpCi0gICAgewotICAgICAgICByZXR1cm4gMTsKLSAgICB9 Ci19OwotCiBURVNUKFdlYkNvcmUsIEJpdG1hcEltYWdlRW1wdHlGcmFtZVRlc3QpCiB7CiAgICAg SW50U2l6ZSBzeigxNiwgMTYpOwotICAgIFJlZlB0cjxCaXRtYXBJbWFnZVRlc3Q+IGJpdG1hcElt YWdlVGVzdCA9IGFkb3B0UmVmKG5ldyBCaXRtYXBJbWFnZVRlc3QpOworCisgICAgQml0bWFwSW5m byBiaXRtYXBJbmZvID0gQml0bWFwSW5mbzo6Y3JlYXRlKHN6KTsKKworICAgIGF1dG8gYm1wID0g YWRvcHRHRElPYmplY3QoQ3JlYXRlRElCU2VjdGlvbigwLCAmYml0bWFwSW5mbywgRElCX1JHQl9D T0xPUlMsIDAsIDAsIDApKTsKKworICAgIFJlZlB0cjxJbWFnZT4gYml0bWFwSW1hZ2VUZXN0ID0g Qml0bWFwSW1hZ2U6OmNyZWF0ZShibXAuZ2V0KCkpOworCisgICAgaWYgKCFiaXRtYXBJbWFnZVRl c3QpCisgICAgICAgIHJldHVybjsKKworICAgIC8vIERlc3Ryb3lpbmcgZGVjb2RlZCBkYXRhIHdp bGwgY2F1c2UgZnJhbWVBdEluZGV4KGkpIHRvIHJldHVybiBudWxsLgorICAgIGJpdG1hcEltYWdl VGVzdC0+ZGVzdHJveURlY29kZWREYXRhKCk7CisKICAgICBpbnQgYml0c1syNTZdOwotICAgIEhC SVRNQVAgaEJpdG1hcCA9IENyZWF0ZUJpdG1hcChzei53aWR0aCgpLCBzei5oZWlnaHQoKSwgMSwg MzIsIGJpdHMpOwotICAgIGJpdG1hcEltYWdlVGVzdC0+Z2V0SEJJVE1BUE9mU2l6ZShoQml0bWFw LCAmc3opOworICAgIGF1dG8gYml0bWFwID0gYWRvcHRHRElPYmplY3QoQ3JlYXRlQml0bWFwKHN6 LndpZHRoKCksIHN6LmhlaWdodCgpLCAxLCAzMiwgYml0cykpOworCisgICAgYml0bWFwSW1hZ2VU ZXN0LT5nZXRIQklUTUFQT2ZTaXplKGJpdG1hcC5nZXQoKSwgJnN6KTsKIH0KIAogfSAvLyBuYW1l c3BhY2UgVGVzdFdlYktpdEFQSQo=