121484 2013-09-17 05:09:45 -0700 [GTK] Don't make the GObject DOM bindings API break test fatal 2013-09-17 05:16:03 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 berto berto cdumez cgarcia commit-queue oldest_to_newest 930162 0 berto 2013-09-17 05:09:45 -0700 This test may easily give false positives, because the API can vary depending on the compilation options. For example, if you run configure with the default options, video track support will be disabled, which will produce this error: API incompatibility detected in GObject DOM bindings @@ -14,7 +14,6 @@ WebKitDOMAttr* webkit_dom_element_set_attribute_node_ns(WebKitDOMElement*, WebKitDOMAttr*, GError**) WebKitDOMAudioTrack* webkit_dom_audio_track_list_get_track_by_id(WebKitDOMAudioTrackList*, const gchar*) WebKitDOMAudioTrack* webkit_dom_audio_track_list_item(WebKitDOMAudioTrackList*, gulong) -WebKitDOMAudioTrackList* webkit_dom_html_media_element_get_audio_tracks(WebKitDOMHTMLMediaElement*) WebKitDOMBarProp* webkit_dom_dom_window_get_locationbar(WebKitDOMDOMWindow*) WebKitDOMBarProp* webkit_dom_dom_window_get_menubar(WebKitDOMDOMWindow*) WebKitDOMBarProp* webkit_dom_dom_window_get_personalbar(WebKitDOMDOMWindow*) [...] Until we don't figure out a way to handle this (see bug 121481) this check shouldn't be made fatal. 930163 1 211889 berto 2013-09-17 05:11:29 -0700 Created attachment 211889 Patch 930164 2 211889 cgarcia 2013-09-17 05:12:51 -0700 Comment on attachment 211889 Patch Excellent, thanks! 930166 3 berto 2013-09-17 05:16:03 -0700 Committed r155948: <http://trac.webkit.org/changeset/155948> 211889 2013-09-17 05:11:29 -0700 2013-09-17 05:12:51 -0700 Patch 121484.diff text/plain 1748 berto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBlZTI5MjdlLi5mOWRjOTQ2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTMtMDktMTcgIEFsYmVydG8gR2FyY2lhICA8YmVydG9AaWdhbGlhLmNvbT4KKworICAg ICAgICBbR1RLXSBEb24ndCBtYWtlIHRoZSBHT2JqZWN0IERPTSBiaW5kaW5ncyBBUEkgYnJlYWsg dGVzdCBmYXRhbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTIxNDg0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgVGhlIEFQSSB2YXJpZXMgZGVwZW5kaW5nIG9uIHRoZSBjb21waWxhdGlvbiBvcHRpb25zLCBz byB0aGlzIGNhbgorICAgICAgICBlYXNpbHkgcHJvZHVjZSBmYWxzZSBwb3NpdGl2ZXMuCisKKyAg ICAgICAgVW50aWwgd2UgZmlndXJlIG91dCBhIHdheSB0byBoYW5kbGUgdGhpcyBzaXR1YXRpb24g d2Ugc2hvdWxkbid0CisgICAgICAgIG1ha2UgdGhpcyB0ZXN0IGZhdGFsLgorCisgICAgICAgICog YmluZGluZ3Mvc2NyaXB0cy9nb2JqZWN0LXJ1bi1hcGktYnJlYWstdGVzdDoKKyAgICAgICAgKGNo ZWNrX2FwaSk6CisKIDIwMTMtMDktMTcgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29t PgogCiAgICAgICAgIENUVEU6IFBhc3MgUmVuZGVyQXJlbmEgYXJvdW5kIGJ5IHJlZmVyZW5jZS4K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvZ29iamVjdC1ydW4t YXBpLWJyZWFrLXRlc3QgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL2dvYmplY3Qt cnVuLWFwaS1icmVhay10ZXN0CmluZGV4IGI0MmZjMGMuLjMyMDhlNjMgMTAwNzU1Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvZ29iamVjdC1ydW4tYXBpLWJyZWFrLXRlc3QK KysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9nb2JqZWN0LXJ1bi1hcGktYnJl YWstdGVzdApAQCAtNDMsNyArNDMsMTEgQEAgZGVmIGNoZWNrX2FwaShvcHRpb25zLCBmcm9tX2Zp bGUsIHRvX2ZpbGUpOgogICAgICAgICBpZiBmYWlsZWQ6CiAgICAgICAgICAgICBzeXMuc3RkZXJy LndyaXRlKCJBUEkgaW5jb21wYXRpYmlsaXR5IGRldGVjdGVkIGluIEdPYmplY3QgRE9NIGJpbmRp bmdzXG4iKQogICAgICAgICAgICAgc3lzLnN0ZGVyci53cml0ZShkaWZmX291dCkKLSAgICAgICAg ICAgIHJldHVybiAxCisgICAgICAgICAgICAjIFRoaXMgdGVzdCBjYW4gZ2l2ZSBmYWxzZSBwb3Np dGl2ZXMgYmVjYXVzZSB0aGUgR09iamVjdAorICAgICAgICAgICAgIyBET00gYmluZGluZ3MgQVBJ IHZhcmllcyBkZXBlbmRpbmcgb24gdGhlIGNvbXBpbGF0aW9uIG9wdGlvbnMuCisgICAgICAgICAg ICAjIFNvIHRoaXMgc2hvdWxkbid0IGJlIG1hZGUgZmF0YWwgdW50aWwgd2UgZmlndXJlIG91dCBh IHdheSB0byBoYW5kbGUgaXQuCisgICAgICAgICAgICAjIFNlZSBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIxNDgxCisgICAgICAgICAgICByZXR1cm4gMAogCiAgICAg ICAgIGlmIG9wdGlvbnMucmVzZXRfcmVzdWx0czoKICAgICAgICAgICAgIHN5cy5zdGRvdXQud3Jp dGUoIlJlc2V0IHJlc3VsdHM6ICVzXG4iICUgZnJvbV9maWxlKQo=