121482 2013-09-17 05:03:15 -0700 REGRESSION(r155910): WebKit nightly builds don't load any page 2013-09-17 10:20:10 -0700 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mihnea webkit-unassigned ap benjamin cmarcelo commit-queue mrowe oldest_to_newest 930156 0 mihnea 2013-09-17 05:03:15 -0700 C++ style comments in wtf/Platform.h are not processed correctly, we have to replace them with C style comments. 930160 1 211888 mihnea 2013-09-17 05:05:59 -0700 Created attachment 211888 Patch 930174 2 211888 commit-queue 2013-09-17 05:39:35 -0700 Comment on attachment 211888 Patch Clearing flags on attachment: 211888 Committed r155950: <http://trac.webkit.org/changeset/155950> 930175 3 commit-queue 2013-09-17 05:39:37 -0700 All reviewed patches have been landed. Closing bug. 930279 4 ap 2013-09-17 10:03:18 -0700 That's a very late failure. I'm not even sure how this is possible. Is there a way to make it so that wrong comment style would cause a build failure instead of runtime failure, so that this wouldn't happen in the future? 930287 5 mihnea 2013-09-17 10:14:28 -0700 (In reply to comment #4) > That's a very late failure. I'm not even sure how this is possible. > > Is there a way to make it so that wrong comment style would cause a build failure instead of runtime failure, so that this wouldn't happen in the future? That would be great because it already happened in https://bugs.webkit.org/show_bug.cgi?id=114752. 930292 6 ap 2013-09-17 10:20:10 -0700 I see, so it's sandbox profile generation. 211888 2013-09-17 05:05:59 -0700 2013-09-17 05:39:35 -0700 Patch 121482.patch text/plain 1479 mihnea ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFuZ2VMb2cK aW5kZXggOTExYTNlNWUuLmUzMDM0OGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTMtMDktMTcg IE1paG5lYSBPdmlkZW5pZSAgPG1paG5lYUBhZG9iZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lP TihyMTU1OTEwKTogV2ViS2l0IG5pZ2h0bHkgYnVpbGRzIGRvbid0IGxvYWQgYW55IHBhZ2UKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMTQ4MgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlcGxhY2VkIEMr KyBzdHlsZSBjb21tZW50cyB3aXRoIEMgc3R5bGUgY29tbWVudHMuCisKKyAgICAgICAgKiB3dGYv UGxhdGZvcm0uaDoKKwogMjAxMy0wOS0xNiAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBw bGUuY29tPgogCiAgICAgICAgIFVTRShXRUJfVEhSRUFEKTogTW9yZSBleHBsaWNpdCBXZWJUaHJl YWQgaW5pdGlhbGl6YXRpb24KZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL1BsYXRmb3JtLmgg Yi9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybS5oCmluZGV4IDlmOTJlYjEuLjU1Y2NmOTggMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL1BsYXRmb3JtLmgKKysrIGIvU291cmNlL1dURi93dGYvUGxh dGZvcm0uaApAQCAtNTI5LDkgKzUyOSw5IEBACiAjZGVmaW5lIFdURl9VU0VfQVBQS0lUIDEKICNk ZWZpbmUgV1RGX1VTRV9TRUNVUklUWV9GUkFNRVdPUksgMQogCi0vLyBPUyBYIGRlZmluZXMgYSBz ZXJpZXMgb2YgcGxhdGZvcm0gbWFjcm9zIGZvciBkZWJ1Z2dpbmcuCi0vLyBTb21lIG9mIHRoZW0g YXJlIHJlYWxseSBhbm5veWluZyBiZWNhdXNlIHRoZXkgdXNlIGNvbW1vbiBuYW1lcyAoZS5nLiBj aGVjaygpKS4KLS8vIERpc2FibGUgdGhvc2UgbWFjcm9zIHNvIHRoYXQgd2UgYXJlIG5vdCBsaW1p dGVkIGluIGhvdyB3ZSBuYW1lIG1ldGhvZHMgYW5kIGZ1bmN0aW9ucy4KKy8qIE9TIFggZGVmaW5l cyBhIHNlcmllcyBvZiBwbGF0Zm9ybSBtYWNyb3MgZm9yIGRlYnVnZ2luZy4gKi8KKy8qIFNvbWUg b2YgdGhlbSBhcmUgcmVhbGx5IGFubm95aW5nIGJlY2F1c2UgdGhleSB1c2UgY29tbW9uIG5hbWVz IChlLmcuIGNoZWNrKCkpLiAqLworLyogRGlzYWJsZSB0aG9zZSBtYWNyb3Mgc28gdGhhdCB3ZSBh cmUgbm90IGxpbWl0ZWQgaW4gaG93IHdlIG5hbWUgbWV0aG9kcyBhbmQgZnVuY3Rpb25zLiAqLwog I3VuZGVmIF9fQVNTRVJUX01BQ1JPU19ERUZJTkVfVkVSU0lPTlNfV0lUSE9VVF9VTkRFUlNDT1JF UwogI2RlZmluZSBfX0FTU0VSVF9NQUNST1NfREVGSU5FX1ZFUlNJT05TX1dJVEhPVVRfVU5ERVJT Q09SRVMgMAogI2VuZGlmIC8qIFBMQVRGT1JNKE1BQykgJiYgIVBMQVRGT1JNKElPUykgKi8K