121471 2013-09-17 00:51:17 -0700 Fix Qt WK2 build after r155888 2013-09-17 01:38:10 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 abrhm webkit-unassigned abecsi cmarcelo commit-queue kadam menard ossy zarvai oldest_to_newest 930081 0 abrhm 2013-09-17 00:51:17 -0700 Fix Qt WK2 build after r155888 930083 1 211869 abrhm 2013-09-17 00:56:09 -0700 Created attachment 211869 proposed fix 930092 2 211869 ossy 2013-09-17 01:14:05 -0700 Comment on attachment 211869 proposed fix LGTM. The fix touches only Qt specific files and it fixes the build, so review from an owner isn't necessary now. r=me. 930102 3 211869 ossy 2013-09-17 01:38:04 -0700 Comment on attachment 211869 proposed fix Clearing flags on attachment: 211869 Committed r155935: <http://trac.webkit.org/changeset/155935> 930103 4 ossy 2013-09-17 01:38:10 -0700 All reviewed patches have been landed. Closing bug. 211869 2013-09-17 00:56:09 -0700 2013-09-17 01:38:04 -0700 proposed fix patch49.patch text/plain 5340 abrhm ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAxNmJhOTRmLi5jZDI1MDU3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAg QEAKKzIwMTMtMDktMTcgIEdhYm9yIEFicmFoYW0gIDxhYnJobUBpbmYudS1zemVnZWQuaHU+CisK KyAgICAgICAgRml4IFF0IFdLMiBidWlsZCBhZnRlciByMTU1ODg4CisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjE0NzEKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvcXQvcXF1aWNr d2Vidmlldy5jcHA6CisgICAgICAgIChRUXVpY2tXZWJWaWV3UHJpdmF0ZTo6Y3JlYXRlRHJhd2lu Z0FyZWFQcm94eSk6CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9xdC9xcXVpY2t3ZWJ2aWV3X3Bf cC5oOgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvcXQvcmF3L3FyYXd3ZWJ2aWV3LmNwcDoKKyAg ICAgICAgKFFSYXdXZWJWaWV3UHJpdmF0ZTo6Y3JlYXRlRHJhd2luZ0FyZWFQcm94eSk6CisgICAg ICAgICogVUlQcm9jZXNzL0FQSS9xdC9yYXcvcXJhd3dlYnZpZXdfcF9wLmg6CisgICAgICAgICog VUlQcm9jZXNzL3F0L1F0UGFnZUNsaWVudC5jcHA6CisgICAgICAgIChXZWJLaXQ6OlF0UGFnZUNs aWVudDo6Y3JlYXRlRHJhd2luZ0FyZWFQcm94eSk6CisgICAgICAgICogVUlQcm9jZXNzL3F0L1F0 UGFnZUNsaWVudC5oOgorCiAyMDEzLTA5LTE2ICBNYW51ZWwgUmVnbyBDYXNhc25vdmFzICA8cmVn b0BpZ2FsaWEuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIGZpeGluZyB0aGUgR1RLIFdLMiBk ZWJ1ZyBidWlsZCBhZnRlciByMTU1OTExLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL0FQSS9xdC9xcXVpY2t3ZWJ2aWV3LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9BUEkvcXQvcXF1aWNrd2Vidmlldy5jcHAKaW5kZXggYWIzMDQ1OC4uYjhjYTAwMiAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xcXVpY2t3ZWJ2aWV3LmNwcAor KysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3FxdWlja3dlYnZpZXcuY3BwCkBA IC02MzUsOSArNjM1LDkgQEAgdm9pZCBRUXVpY2tXZWJWaWV3UHJpdmF0ZTo6cHJvY2Vzc0RpZEJl Y29tZVJlc3BvbnNpdmUoV0tQYWdlUmVmLCBjb25zdCB2b2lkKiBjbGkKICAgICBlbWl0IHEtPmV4 cGVyaW1lbnRhbCgpLT5wcm9jZXNzRGlkQmVjb21lUmVzcG9uc2l2ZSgpOwogfQogCi1QYXNzT3du UHRyPERyYXdpbmdBcmVhUHJveHk+IFFRdWlja1dlYlZpZXdQcml2YXRlOjpjcmVhdGVEcmF3aW5n QXJlYVByb3h5KCkKK093blB0cjxEcmF3aW5nQXJlYVByb3h5PiBRUXVpY2tXZWJWaWV3UHJpdmF0 ZTo6Y3JlYXRlRHJhd2luZ0FyZWFQcm94eSgpCiB7Ci0gICAgcmV0dXJuIERyYXdpbmdBcmVhUHJv eHlJbXBsOjpjcmVhdGUod2ViUGFnZVByb3h5LmdldCgpKTsKKyAgICByZXR1cm4gY3JlYXRlT3du ZWQ8V2ViS2l0OjpEcmF3aW5nQXJlYVByb3h5SW1wbD4od2ViUGFnZVByb3h5LmdldCgpKTsKIH0K IAogdm9pZCBRUXVpY2tXZWJWaWV3UHJpdmF0ZTo6aGFuZGxlRG93bmxvYWRSZXF1ZXN0KERvd25s b2FkUHJveHkqIGRvd25sb2FkKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L0FQSS9xdC9xcXVpY2t3ZWJ2aWV3X3BfcC5oIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQ SS9xdC9xcXVpY2t3ZWJ2aWV3X3BfcC5oCmluZGV4IGYxY2UxNzEuLjFjZDc1MmQgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXF1aWNrd2Vidmlld19wX3AuaAor KysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3FxdWlja3dlYnZpZXdfcF9wLmgK QEAgLTEzMyw3ICsxMzMsNyBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCB2b2lkIHBhZ2VEaWRSZXF1 ZXN0U2Nyb2xsKGNvbnN0IFFQb2ludCYgcG9zKSB7IH0KICAgICB2b2lkIHByb2Nlc3NEaWRDcmFz aCgpOwogICAgIHZvaWQgZGlkUmVsYXVuY2hQcm9jZXNzKCk7Ci0gICAgUGFzc093blB0cjxXZWJL aXQ6OkRyYXdpbmdBcmVhUHJveHk+IGNyZWF0ZURyYXdpbmdBcmVhUHJveHkoKTsKKyAgICBPd25Q dHI8V2ViS2l0OjpEcmF3aW5nQXJlYVByb3h5PiBjcmVhdGVEcmF3aW5nQXJlYVByb3h5KCk7CiAg ICAgdm9pZCBoYW5kbGVEb3dubG9hZFJlcXVlc3QoV2ViS2l0OjpEb3dubG9hZFByb3h5Kik7CiAK ICAgICB2b2lkIGRpZFJlY2VpdmVNZXNzYWdlRnJvbU5hdmlnYXRvclF0T2JqZWN0KFdLU3RyaW5n UmVmIG1lc3NhZ2UpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9x dC9yYXcvcXJhd3dlYnZpZXcuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9y YXcvcXJhd3dlYnZpZXcuY3BwCmluZGV4IDg5ZjcyOTcuLmNjMDE5NzMgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcmF3L3FyYXd3ZWJ2aWV3LmNwcAorKysgYi9T b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3Jhdy9xcmF3d2Vidmlldy5jcHAKQEAgLTIz OSw5ICsyMzksOSBAQCB2b2lkIFFSYXdXZWJWaWV3UHJpdmF0ZTo6ZG9uZVdpdGhLZXlFdmVudChj b25zdCBXZWJLaXQ6Ok5hdGl2ZVdlYktleWJvYXJkRXZlbnQmCiAgICAgbV9jbGllbnQtPmRvbmVX aXRoS2V5RXZlbnQoZXZlbnQubmF0aXZlRXZlbnQoKSwgd2FzRXZlbnRIYW5kbGVkKTsKIH0KIAot UGFzc093blB0cjxXZWJLaXQ6OkRyYXdpbmdBcmVhUHJveHk+IFFSYXdXZWJWaWV3UHJpdmF0ZTo6 Y3JlYXRlRHJhd2luZ0FyZWFQcm94eSgpCitPd25QdHI8V2ViS2l0OjpEcmF3aW5nQXJlYVByb3h5 PiBRUmF3V2ViVmlld1ByaXZhdGU6OmNyZWF0ZURyYXdpbmdBcmVhUHJveHkoKQogewotICAgIHJl dHVybiBXZWJLaXQ6OkRyYXdpbmdBcmVhUHJveHlJbXBsOjpjcmVhdGUobV93ZWJQYWdlUHJveHku Z2V0KCkpOworICAgIHJldHVybiBjcmVhdGVPd25lZDxXZWJLaXQ6OkRyYXdpbmdBcmVhUHJveHlJ bXBsPihtX3dlYlBhZ2VQcm94eS5nZXQoKSk7CiB9CiAKIFFSYXdXZWJWaWV3UHJpdmF0ZTo6UVJh d1dlYlZpZXdQcml2YXRlKFdlYktpdDo6V2ViQ29udGV4dCogY29udGV4dCwgV2ViS2l0OjpXZWJQ YWdlR3JvdXAqIHBhZ2VHcm91cCwgUVJhd1dlYlZpZXdDbGllbnQqIGNsaWVudCkKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcmF3L3FyYXd3ZWJ2aWV3X3BfcC5o IGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9yYXcvcXJhd3dlYnZpZXdfcF9wLmgK aW5kZXggNThkNmIxMy4uNzcxNGU4ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL0FQSS9xdC9yYXcvcXJhd3dlYnZpZXdfcF9wLmgKKysrIGIvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL0FQSS9xdC9yYXcvcXJhd3dlYnZpZXdfcF9wLmgKQEAgLTk0LDcgKzk0LDcgQEAgcHVi bGljOgogCiAgICAgLy8gUGFnZUNsaWVudAogCi0gICAgdmlydHVhbCBQYXNzT3duUHRyPFdlYktp dDo6RHJhd2luZ0FyZWFQcm94eT4gY3JlYXRlRHJhd2luZ0FyZWFQcm94eSgpOworICAgIHZpcnR1 YWwgT3duUHRyPFdlYktpdDo6RHJhd2luZ0FyZWFQcm94eT4gY3JlYXRlRHJhd2luZ0FyZWFQcm94 eSgpOwogCiAgICAgdmlydHVhbCB2b2lkIHBhZ2VEaWRSZXF1ZXN0U2Nyb2xsKGNvbnN0IFdlYkNv cmU6OkludFBvaW50JiBwb3MpOwogICAgIHZpcnR1YWwgdm9pZCBwcm9jZXNzRGlkQ3Jhc2goKTsK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9RdFBhZ2VDbGllbnQuY3Bw IGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL3F0L1F0UGFnZUNsaWVudC5jcHAKaW5kZXggMmYy NDJjNi4uODg3YzRmOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL3F0L1F0 UGFnZUNsaWVudC5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL3F0L1F0UGFnZUNs aWVudC5jcHAKQEAgLTYzLDcgKzYzLDcgQEAgdm9pZCBRdFBhZ2VDbGllbnQ6OmluaXRpYWxpemUo UVF1aWNrV2ViVmlldyogd2ViVmlldywgUXRXZWJQYWdlRXZlbnRIYW5kbGVyKiBldmUKICAgICBt X3VuZG9Db250cm9sbGVyID0gdW5kb0NvbnRyb2xsZXI7CiB9CiAKLVBhc3NPd25QdHI8RHJhd2lu Z0FyZWFQcm94eT4gUXRQYWdlQ2xpZW50OjpjcmVhdGVEcmF3aW5nQXJlYVByb3h5KCkKK093blB0 cjxEcmF3aW5nQXJlYVByb3h5PiBRdFBhZ2VDbGllbnQ6OmNyZWF0ZURyYXdpbmdBcmVhUHJveHko KQogewogICAgIHJldHVybiBRUXVpY2tXZWJWaWV3UHJpdmF0ZTo6Z2V0KG1fd2ViVmlldyktPmNy ZWF0ZURyYXdpbmdBcmVhUHJveHkoKTsKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9xdC9RdFBhZ2VDbGllbnQuaCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9R dFBhZ2VDbGllbnQuaAppbmRleCBlNmQ5ZGIzLi5iMDZhY2M4IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvcXQvUXRQYWdlQ2xpZW50LmgKKysrIGIvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL3F0L1F0UGFnZUNsaWVudC5oCkBAIC01Miw3ICs1Miw3IEBAIHB1YmxpYzoKICAg ICB2aXJ0dWFsIHZvaWQgZGlkQ2hhbmdlVmlld3BvcnRQcm9wZXJ0aWVzKGNvbnN0IFdlYkNvcmU6 OlZpZXdwb3J0QXR0cmlidXRlcyYpOwogICAgIHZpcnR1YWwgdm9pZCBwcm9jZXNzRGlkQ3Jhc2go KTsKICAgICB2aXJ0dWFsIHZvaWQgZGlkUmVsYXVuY2hQcm9jZXNzKCk7Ci0gICAgdmlydHVhbCBQ YXNzT3duUHRyPERyYXdpbmdBcmVhUHJveHk+IGNyZWF0ZURyYXdpbmdBcmVhUHJveHkoKTsKKyAg ICB2aXJ0dWFsIE93blB0cjxEcmF3aW5nQXJlYVByb3h5PiBjcmVhdGVEcmF3aW5nQXJlYVByb3h5 KCk7CiAgICAgdmlydHVhbCB2b2lkIGhhbmRsZURvd25sb2FkUmVxdWVzdChEb3dubG9hZFByb3h5 Kik7CiAgICAgdmlydHVhbCB2b2lkIGhhbmRsZUFwcGxpY2F0aW9uU2NoZW1lUmVxdWVzdChQYXNz UmVmUHRyPFF0UmVmQ291bnRlZE5ldHdvcmtSZXF1ZXN0RGF0YT4pOwogICAgIHZpcnR1YWwgdm9p ZCBoYW5kbGVBdXRoZW50aWNhdGlvblJlcXVpcmVkUmVxdWVzdChjb25zdCBTdHJpbmcmIGhvc3Ru YW1lLCBjb25zdCBTdHJpbmcmIHJlYWxtLCBjb25zdCBTdHJpbmcmIHByZWZpbGxlZFVzZXJuYW1l LCBTdHJpbmcmIHVzZXJuYW1lLCBTdHJpbmcmIHBhc3N3b3JkKTsK