12147 2007-01-06 21:02:37 -0800 Linked favicons no longer render in address bar 2007-12-11 18:45:26 -0800 1 1 1 Unclassified WebKit New Bugs 420+ Mac OS X 10.4 RESOLVED FIXED http://www.informationgift.com/ud/faviconic/testfavicon_yeslink.html InRadar, Regression P2 Normal --- 1 lewis beidson beidson ddkilzer mrowe oldest_to_newest 36634 0 lewis 2007-01-06 21:02:37 -0800 Using a link tag to specify a favicon different from /favicon.ico fails to render in the address bar. At least, it does so for a multi-icon set (containing 1, 4, 8, and 32-bit icons). Safari favors the 4-bit icon in the multi-res set. Ideally, Webkit would favor the 32-bit icon. Bug present in latest nightly as of this report. 36290 1 beidson 2007-01-08 10:30:33 -0800 I think the bug here isn't that we fail to respect the linked icon, or that we "prefer the 4-bit version" - I believe the bug here is that we grab frame 0 from the image - or the first indexed icon from the icon set - and its the wrong one! I think we have a radar for this but it's been low priority as we haven't seen this reported in the wild yet. Lemme see if I can find the radar and/or file one. 36293 2 beidson 2007-01-08 10:37:52 -0800 <rdar://problem/4680377> I will bump this up a notch on the priority list. But a warning! The algorithm won't be "choose the deepest icon" - it will be "choose the deepest icon of the correct size or, if none is found, choose the deepest icon of the incorrect size" as that is what we did in the previous WebIconDatabase 36240 3 beidson 2007-01-08 10:38:13 -0800 <rdar://problem/4680377> I will bump this up a notch on the priority list. But a warning! The algorithm won't be "choose the deepest icon" - it will be "choose the deepest icon of the correct size or, if none is found, choose the deepest icon of the incorrect size" as that is what we did in the previous WebIconDatabase 36241 4 beidson 2007-01-08 10:38:51 -0800 Sorry bout the double post - no clue how that happened... lame! 36245 5 ddkilzer 2007-01-08 10:46:19 -0800 *** Bug 12002 has been marked as a duplicate of this bug. *** 36246 6 ddkilzer 2007-01-08 10:51:46 -0800 (In reply to comment #5) > *** Bug 12002 has been marked as a duplicate of this bug. *** Interesting note from Bug 12002 Comment #0: Code in WebKit/DOM/WebDOMOperations.m for DOMHTMLLinkElement leads me to believe that this icon is expected to be loaded (or was loaded at one time) since saving a WebArchive uses this code path and will try to save the icon to the WebArchive file (and fail). It's too bad Bug 11882 hasn't landed yet, or you could write a webarchive test for this. 63977 7 lewis 2007-12-11 17:51:44 -0800 Both of the issues in this report (sorry about that) appear to be resolved; work as expected for me in both Safari 3 and today's Webkit on Leopard. 63981 8 ddkilzer 2007-12-11 18:45:26 -0800 Marking as RESOLVED/FIXED per Comment #7 and Radar.