121469 2013-09-17 00:45:17 -0700 [CSSRegions] Replace generatingNode() with generatingElement() for RenderRegion 2013-09-17 05:01:10 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mihnea webkit-unassigned commit-queue esprehn+autocc glenn kondapallykalyan WebkitBugTracker oldest_to_newest 930078 0 mihnea 2013-09-17 00:45:17 -0700 The fix fox https://bugs.webkit.org/show_bug.cgi?id=120397 replaced node() with generatingElement() for regions, but i forgot about replacing generatingNode() with generatingElement() in RenderNamedFlowThread::compareRenderRegions. This is needed in preparation for https://bugs.webkit.org/show_bug.cgi?id=119135. 930082 1 211868 mihnea 2013-09-17 00:52:17 -0700 Created attachment 211868 Patch 930154 2 211868 commit-queue 2013-09-17 05:01:07 -0700 Comment on attachment 211868 Patch Clearing flags on attachment: 211868 Committed r155946: <http://trac.webkit.org/changeset/155946> 930155 3 commit-queue 2013-09-17 05:01:10 -0700 All reviewed patches have been landed. Closing bug. 211868 2013-09-17 00:52:17 -0700 2013-09-17 05:01:07 -0700 Patch 121469.patch text/plain 2344 mihnea ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBiZjJkNjEyLi5jMzFhOTRlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTMtMDktMTcgIE1paG5lYSBPdmlkZW5pZSAgPG1paG5lYUBhZG9iZS5jb20+CisKKyAg ICAgICAgW0NTU1JlZ2lvbnNdIFJlcGxhY2UgZ2VuZXJhdGluZ05vZGUoKSB3aXRoIGdlbmVyYXRp bmdFbGVtZW50KCkgZm9yIFJlbmRlclJlZ2lvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIxNDY5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgVGhlIGZpeCBmb3IgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTEyMDM5NyByZXBsYWNlZCBub2RlKCkgd2l0aCBnZW5lcmF0aW5nRWxl bWVudCgpIGZvciByZWdpb25zLCBidXQgaSBmb3Jnb3QgYWJvdXQgcmVwbGFjaW5nIGdlbmVyYXRp bmdOb2RlKCkgd2l0aCBnZW5lcmF0aW5nRWxlbWVudCgpIGluIFJlbmRlck5hbWVkRmxvd1RocmVh ZDo6Y29tcGFyZVJlbmRlclJlZ2lvbnMuIFRoaXMgaXMgbmVlZGVkIGluIHByZXBhcmF0aW9uIGZv ciByZWdpb25zIGFzIGFub255bW91cyBibG9ja3MgcmVmYWN0b3JpbmcgaW4gaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExOTEzNS4KKworICAgICAgICBObyBuZXcgZnVu Y3Rpb25hbGl0eSBpbnRyb2R1Y2VkLCB0aGVyZWZvcmUgbm8gbmV3IHRlc3RzLgorCisgICAgICAg ICogcmVuZGVyaW5nL1JlbmRlck5hbWVkRmxvd1RocmVhZC5jcHA6CisgICAgICAgIChXZWJDb3Jl Ojpjb21wYXJlUmVuZGVyUmVnaW9ucyk6CisKIDIwMTMtMDktMTYgIFNhbSBXZWluaWcgIDxzYW1A d2Via2l0Lm9yZz4KIAogICAgICAgICBDVFRFOiBJbnB1dFR5cGUgc2hvdWxkIHN0b3JlIGl0cyBI VE1MSW5wdXRFbGVtZW50IGJhY2sgcG9pbnRlciBhcyBhIHJlZmVyZW5jZQpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck5hbWVkRmxvd1RocmVhZC5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTmFtZWRGbG93VGhyZWFkLmNwcAppbmRleCBjMWRk MGZmLi5lNWNjNzc2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy TmFtZWRGbG93VGhyZWFkLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy TmFtZWRGbG93VGhyZWFkLmNwcApAQCAtMTkzLDEyICsxOTMsMTIgQEAgc3RhdGljIGJvb2wgY29t cGFyZVJlbmRlclJlZ2lvbnMoY29uc3QgUmVuZGVyUmVnaW9uKiBmaXJzdFJlZ2lvbiwgY29uc3Qg UmVuZGVyUmUKICAgICBBU1NFUlQoZmlyc3RSZWdpb24pOwogICAgIEFTU0VSVChzZWNvbmRSZWdp b24pOwogCi0gICAgQVNTRVJUKGZpcnN0UmVnaW9uLT5nZW5lcmF0aW5nTm9kZSgpKTsKLSAgICBB U1NFUlQoc2Vjb25kUmVnaW9uLT5nZW5lcmF0aW5nTm9kZSgpKTsKKyAgICBBU1NFUlQoZmlyc3RS ZWdpb24tPmdlbmVyYXRpbmdFbGVtZW50KCkpOworICAgIEFTU0VSVChzZWNvbmRSZWdpb24tPmdl bmVyYXRpbmdFbGVtZW50KCkpOwogCiAgICAgLy8gSWYgdGhlIHJlZ2lvbnMgYmVsb25nIHRvIGRp ZmZlcmVudCBub2RlcywgY29tcGFyZSB0aGVpciBwb3NpdGlvbiBpbiB0aGUgRE9NLgotICAgIGlm IChmaXJzdFJlZ2lvbi0+Z2VuZXJhdGluZ05vZGUoKSAhPSBzZWNvbmRSZWdpb24tPmdlbmVyYXRp bmdOb2RlKCkpIHsKLSAgICAgICAgdW5zaWduZWQgc2hvcnQgcG9zaXRpb24gPSBmaXJzdFJlZ2lv bi0+Z2VuZXJhdGluZ05vZGUoKS0+Y29tcGFyZURvY3VtZW50UG9zaXRpb24oc2Vjb25kUmVnaW9u LT5nZW5lcmF0aW5nTm9kZSgpKTsKKyAgICBpZiAoZmlyc3RSZWdpb24tPmdlbmVyYXRpbmdFbGVt ZW50KCkgIT0gc2Vjb25kUmVnaW9uLT5nZW5lcmF0aW5nRWxlbWVudCgpKSB7CisgICAgICAgIHVu c2lnbmVkIHNob3J0IHBvc2l0aW9uID0gZmlyc3RSZWdpb24tPmdlbmVyYXRpbmdFbGVtZW50KCkt PmNvbXBhcmVEb2N1bWVudFBvc2l0aW9uKHNlY29uZFJlZ2lvbi0+Z2VuZXJhdGluZ0VsZW1lbnQo KSk7CiAKICAgICAgICAgLy8gSWYgdGhlIHNlY29uZCByZWdpb24gaXMgY29udGFpbmVkIGluIHRo ZSBmaXJzdCBvbmUsIHRoZSBmaXJzdCByZWdpb24gaXMgImxlc3MiIGlmIGl0J3MgOmJlZm9yZS4K ICAgICAgICAgaWYgKHBvc2l0aW9uICYgTm9kZTo6RE9DVU1FTlRfUE9TSVRJT05fQ09OVEFJTkVE X0JZKSB7Cg==