121460 2013-09-16 16:21:46 -0700 Disable OS X's unprefixed debug macro 2013-09-16 16:48:42 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin cmarcelo commit-queue oldest_to_newest 929965 0 benjamin 2013-09-16 16:21:46 -0700 Disable OS X's unprefixed debug macro 929966 1 211841 benjamin 2013-09-16 16:22:24 -0700 Created attachment 211841 Patch 929967 2 211841 andersca 2013-09-16 16:23:33 -0700 Comment on attachment 211841 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=211841&action=review > Source/WTF/wtf/Platform.h:531 > +#define __ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORES 0 I think you should add the same comment in the change log above this #define as well. 929968 3 benjamin 2013-09-16 16:29:31 -0700 Committed r155910: <http://trac.webkit.org/changeset/155910> 929972 4 benjamin 2013-09-16 16:38:10 -0700 Committed r155912: <http://trac.webkit.org/changeset/155912> 929976 5 211841 darin 2013-09-16 16:48:42 -0700 Comment on attachment 211841 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=211841&action=review > Source/WTF/ChangeLog:8 > + * wtf/Platform.h: OS X defines a serie of platform macros for debugging. Missing trailing s in "series". 211841 2013-09-16 16:22:24 -0700 2013-09-16 16:48:42 -0700 Patch bug-121460-20130916162224.patch text/plain 1182 benjamin SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAxNTU5MDkpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEzLTA5LTE2ICBCZW5qYW1pbiBQb3VsYWluICA8 YmVuamFtaW5Ad2Via2l0Lm9yZz4KKworICAgICAgICBEaXNhYmxlIE9TIFgncyB1bnByZWZpeGVk IGRlYnVnIG1hY3JvCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMjE0NjAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIHd0Zi9QbGF0Zm9ybS5oOiBPUyBYIGRlZmluZXMgYSBzZXJpZSBvZiBwbGF0Zm9ybSBt YWNyb3MgZm9yIGRlYnVnZ2luZy4KKyAgICAgICAgU29tZSBvZiB0aGVtIGFyZSByZWFsbHkgYW5u b3lpbmcgYmVjYXVzZSB0aGV5IHVzZSBjb21tb24gbmFtZXMgKGUuZy4gY2hlY2soKSkuCisKKyAg ICAgICAgRGlzYWJsZSB0aG9zZSBtYWNyb3Mgc28gdGhhdCB3ZSBhcmUgbm90IGxpbWl0ZWQgaG93 IHdlIG5hbWUgbWV0aG9kcyBhbmQgZnVuY3Rpb25zLgorCiAyMDEzLTA5LTE2ICBBbmRlcnMgQ2Fy bHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKICAgICAgICAgTWVzc2FnZVF1ZXVlIHNob3Vs ZCB1c2UgYSBEZXF1ZSBvZiBPd25QdHJzCkluZGV4OiBTb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybS5o Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvd3RmL1BsYXRmb3JtLmgJKHJldmlzaW9uIDE1NTkw OSkKKysrIFNvdXJjZS9XVEYvd3RmL1BsYXRmb3JtLmgJKHdvcmtpbmcgY29weSkKQEAgLTUyOCw2 ICs1MjgsNyBAQAogI2VuZGlmCiAjZGVmaW5lIFdURl9VU0VfQVBQS0lUIDEKICNkZWZpbmUgV1RG X1VTRV9TRUNVUklUWV9GUkFNRVdPUksgMQorI2RlZmluZSBfX0FTU0VSVF9NQUNST1NfREVGSU5F X1ZFUlNJT05TX1dJVEhPVVRfVU5ERVJTQ09SRVMgMAogI2VuZGlmIC8qIFBMQVRGT1JNKE1BQykg JiYgIVBMQVRGT1JNKElPUykgKi8KIAogI2lmIFBMQVRGT1JNKElPUykK